Is it nestable? (Can you put one of these spanners inside of another?)
--- Christopher Heckman
https://codereview.appspot.com/571180043/
LGTM
https://codereview.appspot.com/577110043/
Carl Sorensen writes:
> On 11/16/19, 2:14 PM, "David Kastrup" wrote:
>
> Carl Sorensen writes:
>
> > On 11/16/19, 1:52 PM, "David Kastrup" wrote:
> >
> > Carl Sorensen writes:
> >
> > > Dear Team,
> > >
> > > It seems to me like we
On 11/16/19, 2:14 PM, "David Kastrup" wrote:
Carl Sorensen writes:
> On 11/16/19, 1:52 PM, "David Kastrup" wrote:
>
> Carl Sorensen writes:
>
> > Dear Team,
> >
> > It seems to me like we are pretty much in shape such that we should
David Kastrup writes:
> Carl Sorensen writes:
>
>> On 11/16/19, 1:52 PM, "David Kastrup" wrote:
>>
>> Carl Sorensen writes:
>>
>> > Dear Team,
>> >
>> > It seems to me like we are pretty much in shape such that we should
>> > release 2.20. I'd be fine if we called
Carl Sorensen writes:
> On 11/16/19, 1:52 PM, "David Kastrup" wrote:
>
> Carl Sorensen writes:
>
> > Dear Team,
> >
> > It seems to me like we are pretty much in shape such that we should
> > release 2.20. I'd be fine if we called 2.19.83-1 the 2.20 release,
> >
On 11/16/19, 1:52 PM, "David Kastrup" wrote:
Carl Sorensen writes:
> Dear Team,
>
> It seems to me like we are pretty much in shape such that we should
> release 2.20. I'd be fine if we called 2.19.83-1 the 2.20 release,
> even if there are some critical
Carl Sorensen writes:
> Dear Team,
>
> It seems to me like we are pretty much in shape such that we should
> release 2.20. I'd be fine if we called 2.19.83-1 the 2.20 release,
> even if there are some critical regressions. 2.19.83 is SO much
> better than 2.18.2.
>
> IIUC, the only thing 2.20
Dear Team,
It seems to me like we are pretty much in shape such that we should release
2.20. I'd be fine if we called 2.19.83-1 the 2.20 release, even if there are
some critical regressions. 2.19.83 is SO much better than 2.18.2.
IIUC, the only thing 2.20 is waiting on is for David K. to
LGTM.
Thanks for working on these annoying details!
Carl
https://codereview.appspot.com/559260043/
On 11/16/19, 7:49 AM, "Kieren MacMillan" wrote:
>> I'd vote for MeasureSpanner.
> +1
+1
Kieren.
MeasureSpanner works for me.
Carl
Hello,
Here is the current patch countdown list. The next countdown will be on
November 18th.
A quick synopsis of all patches currently in the review process can be
found here:
http://philholmes.net/lilypond/allura/
Push:
5593 Optionally use "tidy" to check generated HTML - Dan
Thanks for working on it !!
Some other nits:
https://codereview.appspot.com/571180043/diff/565230043/lily/measure-attached-spanner.cc
File lily/measure-attached-spanner.cc (right):
https://codereview.appspot.com/571180043/diff/565230043/lily/measure-attached-spanner.cc#newcode93
Hi Jaap
I've added de-wolff to Sourceforge with Developer permissions. You may
now update and create Issues as well as reading them.
Next step is to initiate discussion about your patch under Issue 665 at
Sourceforge, and upload a patch as a proposal to Rietveld for a code
review.
I haven't reviewed the ly or scm.
https://codereview.appspot.com/571180043/diff/565230043/lily/include/measure-attached-spanner.hh
File lily/include/measure-attached-spanner.hh (right):
https://codereview.appspot.com/571180043/diff/565230043/lily/include/measure-attached-spanner.hh#newcode4
My sourceforge account name is: de-wolff
> -Original Message-
> From: Trevor
> Sent: Saturday, November 16, 2019 3:44 PM
> To: lilyp...@de-wolff.org; lilypond-devel@gnu.org
> Subject: Re: Working on issue 665, how to proceed?
>
> lilyp...@de-wolff.org wrote 15/11/2019 23:31:33
>
>> I'd vote for MeasureSpanner.
> +1
+1
Kieren.
-- Original Message --
From: thomasmorle...@gmail.com
To: david.nales...@gmail.com; lemzw...@googlemail.com;
carl.d.soren...@gmail.com; nine.fierce.ball...@gmail.com
Cc: re...@codereview-hr.appspotmail.com; lilypond-devel@gnu.org
Sent: 16/11/2019 14:30:43
Subject: Re: Implement
lilyp...@de-wolff.org wrote 15/11/2019 23:31:33
Subject: Working on issue 665, how to proceed?
Hi Jaap
You wrote
In the last weeks I did write a start of a lilypond -> musicxml solution.
As this is an (old) issue, there is need to put this in lilypond, but how?
What level of quality is
https://codereview.appspot.com/571180043/diff/565230043/ly/spanners-init.ly
File ly/spanners-init.ly (right):
https://codereview.appspot.com/571180043/diff/565230043/ly/spanners-init.ly#newcode25
ly/spanners-init.ly:25:
"View side-by-side diff with in-line comments" is broken for this file.
On 2019/11/16 14:27:25, Dan Eble wrote:
On 2019/11/15 19:21:09, Carl wrote:
> I think the name should be changed from MeasureAttachedSpanner to
> BarAttachedSpanner.
Calling it just MeasureSpanner would also address the specific problem
you
raised. Is it more important for the name to
On 2019/11/15 19:21:09, Carl wrote:
I think the name should be changed from MeasureAttachedSpanner to
BarAttachedSpanner.
Calling it just MeasureSpanner would also address the specific problem
you raised. Is it more important for the name to state where it is
attached or what it spans?
Thanks, James!
On Sat, Nov 16, 2019 at 4:07 AM James wrote:
>
> David,
>
> On 15/11/2019 13:31, David Nalesnik wrote:
> > On Fri, Nov 15, 2019 at 4:31 AM James Lowe wrote:
> >> David et al.
> >>
> >> On Fri, 15 Nov 2019 07:33:01 +0100, Urs Liska
> >> wrote:
> >>
> >>> Hi David,
> >>>
> >>> I
LGTM
https://codereview.appspot.com/577100046/
David,
On 15/11/2019 13:31, David Nalesnik wrote:
On Fri, Nov 15, 2019 at 4:31 AM James Lowe wrote:
David et al.
On Fri, 15 Nov 2019 07:33:01 +0100, Urs Liska wrote:
Hi David,
I feel responsible for this because I know where this is coming from ;-)
You can send me the patch. However,
25 matches
Mail list logo
