Re: freetype.cc: solve algebra puzzle for converting quadratics to cubics (issue 252810043 by d...@gnu.org)

2015-07-02 Thread tisimst . lilypond
The math checks out. LGTM2. https://codereview.appspot.com/252810043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add usage of OpenType font feature to the documents (issue 328140043 by truer...@gmail.com)

2017-07-31 Thread tisimst . lilypond
On 2017/07/27 13:47:01, trueroad wrote: Thank you for your reviewing. https://codereview.appspot.com/328140043/diff/1/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/328140043/diff/1/Documentation/changes.tely#newcode1037

Re: Add usage of OpenType font feature to the documents (issue 328140043 by truer...@gmail.com)

2017-07-31 Thread tisimst . lilypond
On 2017/07/31 17:48:10, lemzwerg wrote: > If Pango really is agnostic of the features, that is really exciting and a bit > mysterious ;-). Why? It's not Pango but HarfBuzz that processes (i.e., applies) the OpenType features to a run of glyphs. Ah, I see! Thanks for clarifying that. I

Re: Add usage of OpenType font feature to the documents (issue 328140043 by truer...@gmail.com)

2017-07-31 Thread tisimst . lilypond
On 2017/07/31 16:58:40, lemzwerg wrote: In general, Pango is agnostic of the features themselves, AFAIK. It simply forwards the selected stuff to the font in question. If Pango really is agnostic of the features, that is really exciting and a bit mysterious ;-). However, the user has

Re: Add usage of OpenType font feature to the documents (issue 328140043 by truer...@gmail.com)

2017-07-26 Thread tisimst . lilypond
https://codereview.appspot.com/328140043/diff/1/Documentation/notation/text.itely File Documentation/notation/text.itely (right): https://codereview.appspot.com/328140043/diff/1/Documentation/notation/text.itely#newcode1464 Documentation/notation/text.itely:1464: On 2017/07/26 15:38:12, pkx166h

Re: Add usage of OpenType font feature to the documents (issue 328140043 by truer...@gmail.com)

2017-08-01 Thread tisimst . lilypond
On 2017/08/01 15:08:11, trueroad wrote: On 2017/08/01 15:05:46, trueroad wrote: > Add notes and identification way If I understand correctly, I've found a current limitation. I could not find a way to specify OpenType font scripts and languages. So I've added it to the document. Also I've

Re: Add usage of OpenType font feature to the documents (issue 328140043 by truer...@gmail.com)

2017-08-01 Thread tisimst . lilypond
On 2017/07/31 17:55:29, tisimst wrote: On 2017/07/31 17:48:10, lemzwerg wrote: > It's not Pango but HarfBuzz that processes (i.e., applies) the OpenType > features to a run of glyphs. Ah, I see! Thanks for clarifying that. I didn't realize Harfbuzz was part of the picture. Guess I haven't

Re: Add usage of OpenType font feature to the documents (issue 328140043 by truer...@gmail.com)

2017-08-01 Thread tisimst . lilypond
On 2017/08/01 17:49:47, lemzwerg wrote: > I looked into the latest Harfbuzz internals, and it looks like > the list of supported OpenType features is manually maintained. Nope. > Not all the features listed on the Microsoft feature registry > are supported, but many are. HarfBuzz is

Re: Doc: Add how to change the notation fonts (issue 330040043 by truer...@gmail.com)

2017-08-17 Thread tisimst . lilypond
https://codereview.appspot.com/330040043/diff/1/Documentation/notation/text.itely File Documentation/notation/text.itely (right): https://codereview.appspot.com/330040043/diff/1/Documentation/notation/text.itely#newcode1627 Documentation/notation/text.itely:1627: #:factor (/ staff-height pt 20)

Re: Doc: Add how to change the notation fonts (issue 330040043 by truer...@gmail.com)

2017-08-23 Thread tisimst . lilypond
I like the changes. Just a few more comments for clarification. https://codereview.appspot.com/330040043/diff/20001/Documentation/notation/input.itely File Documentation/notation/input.itely (right):

Re: Doc: Add how to change the notation fonts (issue 330040043 by truer...@gmail.com)

2017-08-24 Thread tisimst . lilypond
LGTM https://codereview.appspot.com/330040043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Doc: Add how to change the notation fonts (issue 330040043 by truer...@gmail.com)

2017-08-17 Thread tisimst . lilypond
https://codereview.appspot.com/330040043/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/330040043/diff/1/Documentation/notation/input.itely#newcode2845 Documentation/notation/input.itely:2845: @end example I think it