Re: New markup commands: \left-brace \right-brace.

Hi everybody, I've tidied up a few details based on Carl's comments, and I'm confident the patch is ready for committing. Please take a look at the latest patchset here: http://codereview.appspot.com/8874/show Thanks, Neil ___ lilypond-devel mailing

Re: New markup commands: \left-brace \right-brace.

On Wed, Jul 29, 2009 at 2:11 PM, Neil Puttockn.putt...@gmail.com wrote: Hi everybody, I've tidied up a few details based on Carl's comments, and I'm confident the patch is ready for committing. Please take a look at the latest patchset here: http://codereview.appspot.com/8874/show LGTM.

Re: New markup commands: \left-brace \right-brace.

On 2009/07/17 01:40:04, Carl wrote: Code looks good to me. Thanks for taking a look. http://codereview.appspot.com/8874/diff/5202/4204#newcode2623 Line 2623: (ly:font-get-glyph font (string-append brace (number-string n) Do we want to keep line length to 80 chars? Definitely. I've

Re: New markup commands: \left-brace \right-brace.

wasn't too happy with the hard-coded value, so this will be a nice refinement. Brace yourself for a new patch set. :) Description: New markup commands: \left-brace \right-brace. Please review this at http://codereview.appspot.com/8874 Affected files: A input/regression/markup-braces.ly M scm

Re: New markup commands: \left-brace \right-brace.

Add exported function ly:otf-glyph-count. * use this function to remove hard-coded value in binary search and brace lookup. * normalize type assertion messages * fix potential null dereference in ly:otf-font-glyph-info * tidy formatting http://codereview.appspot.com/8874

Re: New markup commands: \left-brace \right-brace.

Code looks good to me. I have a couple of optional minor nitpicks. Thanks, Carl http://codereview.appspot.com/8874/diff/5202/4204 File scm/define-markup-commands.scm (right): http://codereview.appspot.com/8874/diff/5202/4204#newcode2623 Line 2623: (ly:font-get-glyph font (string-append

New markup commands: \left-brace \right-brace.

http://codereview.appspot.com/8874/diff/2201/3202 File scm/define-markup-commands.scm (right): http://codereview.appspot.com/8874/diff/2201/3202#newcode2625 Line 2625: (find-brace (binary-search 0 575 get-y-from-brace scaled-size)) Would Open_type_font::count () return the value 575 you need

Re: New markup commands: \left-brace \right-brace.

On Wed, Jul 15, 2009 at 8:40 PM, pnor...@gmail.com wrote: http://codereview.appspot.com/8874/diff/2201/3202 File scm/define-markup-commands.scm (right): http://codereview.appspot.com/8874/diff/2201/3202#newcode2625 Line 2625: (find-brace (binary-search 0 575 get-y-from-brace scaled-size))