Issue 3128: add Haydn-style turns to Feta (issue 340660043 by lilyp...@maltemeyn.de)

2018-04-08 Thread lemzwerg
Very nice! LGTM. https://codereview.appspot.com/340660043/diff/1/mf/feta-scripts.mf File mf/feta-scripts.mf (right): https://codereview.appspot.com/340660043/diff/1/mf/feta-scripts.mf#newcode757 mf/feta-scripts.mf:757: set_char_box (wd# / 2, wd# / 2, ht# / 2 * height_factor, ht# / 2 *

Re: Issue 3128: add Haydn-style turns to Feta (issue 340660043 by lilyp...@maltemeyn.de)

2018-04-08 Thread lilypond
On 2018/04/08 17:08:42, Dan Eble wrote: Is there a performance difference between these two scripts? I read quickly through the thread referenced in the ticket, but I couldn't find the answer. I don’t know; I’m not even sure whether \haydnturn should be played as \mordent or as \turn. The

Re: Issue 3128: add Haydn-style turns to Feta (issue 340660043 by lilyp...@maltemeyn.de)

2018-04-08 Thread nine . fierce . ballads
On 2018/04/08 17:43:36, simon.albrecht wrote: I’m not sure what exactly the difference in performing is, but that’s not for us to consider; it’s important for scholarly editing (of mid-to-late 18th century music, especially Haydn) to have this symbol available. Having two symbols available

Re: Issue 3128: add Haydn-style turns to Feta (issue 340660043 by lilyp...@maltemeyn.de)

2018-04-08 Thread Simon Albrecht
On 08.04.2018 19:08, nine.fierce.ball...@gmail.com wrote: Is there a performance difference between these two scripts?  I read quickly through the thread referenced in the ticket, but I couldn't find the answer. I’m not sure what exactly the difference in performing is, but that’s not for us

Re: Issue 3128: add Haydn-style turns to Feta (issue 340660043 by lilyp...@maltemeyn.de)

2018-04-08 Thread nine . fierce . ballads
Is there a performance difference between these two scripts? I read quickly through the thread referenced in the ticket, but I couldn't find the answer. https://codereview.appspot.com/340660043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Issue 5301: Refactor mark events ... (issue 340650043 by nine.fierce.ball...@gmail.com)

2018-04-08 Thread thomasmorley65
Hi Dan, some remarks/questions: https://codereview.appspot.com/340650043/diff/1/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/340650043/diff/1/ly/music-functions-init.ly#newcode833 ly/music-functions-init.ly:833: #(define-music-function