Re: [lm-sensors] Could the k8temp driver be interfering with ACPI?

2007-02-22 Thread Hans de Goede
Jean Delvare wrote: On Wed, 21 Feb 2007 15:19:44 -0500, Dave Jones wrote: Ah, Fedora has this horror in its initscripts (which explains why I missed it in my grep).. # Initialize ACPI bits if [ -d /proc/acpi ]; then for module in /lib/modules/$unamer/kernel/drivers/acpi/* ; do

Re: [lm-sensors] Conversion of ACPI fan+thermal to hwmon sysfs

2007-03-08 Thread Hans de Goede
Zhang Rui wrote: On Fri, 2007-03-02 at 12:13 +0100, Jean Delvare wrote: My original idea was to simply add a read-only hwmon-like interface to the acpi fan and thermal modules. I didn't plan to replace the current interfaces offered by these modules, at least not directly. There must be many

Re: [lm-sensors] The new thermal management sysfs class, and hwmon

2008-02-22 Thread Hans de Goede
Zhang, Rui wrote: Hi, Hans, On Fri, 2008-02-22 at 16:00 +0800, Hans de Goede wrote: I think all that is really needed and asked for is for the new thermal ACPI code to: 1) provide temp readings in the same format as hwmon (so milli degrees celcius, not degrees celcius Agree. 2) provide

Re: The new thermal management sysfs class, and hwmon

2008-02-25 Thread Hans de Goede
Zhang, Rui wrote: On Sat, 2008-02-23 at 16:29 +0800, Jean Delvare wrote: On Fri, 22 Feb 2008 11:54:06 +0100, Hans de Goede wrote: Zhang, Rui wrote: Hi, Hans, On Fri, 2008-02-22 at 16:00 +0800, Hans de Goede wrote: I think all that is really needed and asked for is for the new thermal

Re: [PATCH 1/2] thermal: add hwmon sys I/F for thermal device

2008-02-26 Thread Hans de Goede
Zhang, Rui wrote: Add hwmon sys I/F for the generic thermal device. Great! But I have several remarks: 1) Looking at the new code, you only add temp1_input, so I'm guessing that you are registering a seperate hwmon class entry per zone? Please don't do that, please register one hwmon class