Re: [PATCH V6] UBI: Extend UBI layer debug/messaging capabilities

2014-11-11 Thread Richard Weinberger
Am 10.11.2014 um 18:37 schrieb Richard Weinberger: Am 03.11.2014 um 14:58 schrieb Tanya Brokhman: If there is more then one UBI device mounted, there is no way to distinguish between messages from different UBI devices. Add device number to all ubi layer message types. The R/O block driver

Re: [PATCH v4 2/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-11-11 Thread Ivan T. Ivanov
Hi Hartmut, On Mon, 2014-11-10 at 22:11 +0100, Hartmut Knaack wrote: Ivan T. Ivanov schrieb am 03.11.2014 16:24: From: Stanimir Varbanov svarba...@mm-sol.com The voltage ADC is peripheral of Qualcomm SPMI PMIC chips. It has 15 bits resolution and register space inside PMIC accessible

Re: [PATCH V6] UBI: Extend UBI layer debug/messaging capabilities

2014-11-11 Thread Tanya Brokhman
On 11/10/2014 7:57 PM, Joe Perches wrote: On Mon, 2014-11-10 at 18:37 +0100, Richard Weinberger wrote: Am 03.11.2014 um 14:58 schrieb Tanya Brokhman: If there is more then one UBI device mounted, there is no way to distinguish between messages from different UBI devices. Add device number to

Re: [PATCH V6] UBI: Extend UBI layer debug/messaging capabilities

2014-11-11 Thread Joe Perches
On Tue, 2014-11-11 at 10:24 +0200, Tanya Brokhman wrote: On 11/10/2014 7:57 PM, Joe Perches wrote: On Mon, 2014-11-10 at 18:37 +0100, Richard Weinberger wrote: Am 03.11.2014 um 14:58 schrieb Tanya Brokhman: If there is more then one UBI device mounted, there is no way to distinguish

Re: [PATCH V6] UBI: Extend UBI layer debug/messaging capabilities

2014-11-11 Thread Richard Weinberger
Am 11.11.2014 um 09:34 schrieb Joe Perches: On Tue, 2014-11-11 at 10:24 +0200, Tanya Brokhman wrote: On 11/10/2014 7:57 PM, Joe Perches wrote: On Mon, 2014-11-10 at 18:37 +0100, Richard Weinberger wrote: Am 03.11.2014 um 14:58 schrieb Tanya Brokhman: If there is more then one UBI device

Re: [RFC 2/2] regulator: qcom-rpm: Implement RPM assisted disable

2014-11-11 Thread Andreas Färber
Hi, Am 10.11.2014 um 23:52 schrieb Bjorn Andersson: diff --git a/Documentation/devicetree/bindings/mfd/qcom-rpm.txt b/Documentation/devicetree/bindings/mfd/qcom-rpm.txt index 4264021..4671eef 100644 --- a/Documentation/devicetree/bindings/mfd/qcom-rpm.txt +++

Re: [PATCH V6] UBI: Extend UBI layer debug/messaging capabilities

2014-11-11 Thread Artem Bityutskiy
On Mon, 2014-11-10 at 09:57 -0800, Joe Perches wrote: On Mon, 2014-11-10 at 18:37 +0100, Richard Weinberger wrote: Am 03.11.2014 um 14:58 schrieb Tanya Brokhman: If there is more then one UBI device mounted, there is no way to distinguish between messages from different UBI devices.

Re: [RFC 2/2] regulator: qcom-rpm: Implement RPM assisted disable

2014-11-11 Thread Lee Jones
On Mon, 10 Nov 2014, Bjorn Andersson wrote: Some regulators are used to power e.g. PLLs that clocks the core we're running on, so we can't turn them off directly; but we do want them off when the core is powered down. To handle this the Qualcomm SoC provides a means to specify a sleep state

Re: [RFC 1/2] mfd: qcom-rpm: Expose sleep state resources to clients

2014-11-11 Thread Lee Jones
On Mon, 10 Nov 2014, Bjorn Andersson wrote: Resources exposed from the RPM have an active state that is used during normal operations and a sleep state that is used for HW assisted sleep modes. Expose this in the api to let client drivers set the sleep state as well. I assume you have users

Re: [PATCH V6] UBI: Extend UBI layer debug/messaging capabilities

2014-11-11 Thread Artem Bityutskiy
On Tue, 2014-11-11 at 09:15 +0100, Richard Weinberger wrote: Do we really want the function name in every log message? IMHO this is not wise except for pure debug logs. BTW: Why UBI-X? This looks odd. Either use UBIX or ubiX. How about something like this (untested): From: Artem

Re: [PATCH V6] UBI: Extend UBI layer debug/messaging capabilities

2014-11-11 Thread Richard Weinberger
Am 11.11.2014 um 13:03 schrieb Artem Bityutskiy: On Tue, 2014-11-11 at 09:15 +0100, Richard Weinberger wrote: Do we really want the function name in every log message? IMHO this is not wise except for pure debug logs. BTW: Why UBI-X? This looks odd. Either use UBIX or ubiX. How about

Re: [PATCH V6] UBI: Extend UBI layer debug/messaging capabilities

2014-11-11 Thread Artem Bityutskiy
On Tue, 2014-11-11 at 13:25 +0100, Richard Weinberger wrote: Am 11.11.2014 um 13:03 schrieb Artem Bityutskiy: On Tue, 2014-11-11 at 09:15 +0100, Richard Weinberger wrote: Do we really want the function name in every log message? IMHO this is not wise except for pure debug logs. BTW: Why

Re: [PATCH] UBI: Extend UBI layer debug/messaging capabilities - cosmetics

2014-11-11 Thread Artem Bityutskiy
On Sun, 2014-11-09 at 13:06 +0200, Tanya Brokhman wrote: Some cosmetic fixes to the patch UBI: Extend UBI layer debug/messaging capabilities. Signed-off-by: Tanya Brokhman tlin...@codeaurora.org --- Pushed this patch, but without the hunk which changes the printing helpers. Thanks! -- To

Re: [RFC 2/2] regulator: qcom-rpm: Implement RPM assisted disable

2014-11-11 Thread Javier Martinez Canillas
Hello Bjorn, On Mon, Nov 10, 2014 at 11:52 PM, Bjorn Andersson bjorn.anders...@sonymobile.com wrote: Some regulators are used to power e.g. PLLs that clocks the core we're running on, so we can't turn them off directly; but we do want them off when the core is powered down. To handle this the

Re: [PATCH] tty: serial: msm_serial: Use DT aliases

2014-11-11 Thread Kevin Hilman
Stephen Boyd sb...@codeaurora.org writes: On 11/10/2014 10:54 AM, Kevin Hilman wrote: On Wed, Oct 22, 2014 at 5:33 PM, Stephen Boyd sb...@codeaurora.org wrote: We rely on probe order of this driver to determine the line number for the uart port. This makes it impossible to know the line

Re: [RFC 1/2] mfd: qcom-rpm: Expose sleep state resources to clients

2014-11-11 Thread Bjorn Andersson
On Tue 11 Nov 04:04 PST 2014, Lee Jones wrote: On Mon, 10 Nov 2014, Bjorn Andersson wrote: Resources exposed from the RPM have an active state that is used during normal operations and a sleep state that is used for HW assisted sleep modes. Expose this in the api to let client drivers

Re: [RFC 2/2] regulator: qcom-rpm: Implement RPM assisted disable

2014-11-11 Thread Bjorn Andersson
On Tue 11 Nov 01:11 PST 2014, Andreas F?rber wrote: Hi, Am 10.11.2014 um 23:52 schrieb Bjorn Andersson: diff --git a/Documentation/devicetree/bindings/mfd/qcom-rpm.txt b/Documentation/devicetree/bindings/mfd/qcom-rpm.txt index 4264021..4671eef 100644 ---

Re: [RFC 2/2] regulator: qcom-rpm: Implement RPM assisted disable

2014-11-11 Thread Bjorn Andersson
On Tue 11 Nov 03:59 PST 2014, Lee Jones wrote: On Mon, 10 Nov 2014, Bjorn Andersson wrote: Some regulators are used to power e.g. PLLs that clocks the core we're running on, so we can't turn them off directly; but we do want them off when the core is powered down. To handle this the

Re: [RFC 2/2] regulator: qcom-rpm: Implement RPM assisted disable

2014-11-11 Thread Bjorn Andersson
On Tue 11 Nov 06:21 PST 2014, Javier Martinez Canillas wrote: Hello Bjorn, Hi Javier, On Mon, Nov 10, 2014 at 11:52 PM, Bjorn Andersson bjorn.anders...@sonymobile.com wrote: Some regulators are used to power e.g. PLLs that clocks the core we're running on, so we can't turn them off

Re: [PATCH V6] UBI: Extend UBI layer debug/messaging capabilities

2014-11-11 Thread Richard Weinberger
Am 11.11.2014 um 14:27 schrieb Artem Bityutskiy: On Tue, 2014-11-11 at 13:25 +0100, Richard Weinberger wrote: Am 11.11.2014 um 13:03 schrieb Artem Bityutskiy: On Tue, 2014-11-11 at 09:15 +0100, Richard Weinberger wrote: Do we really want the function name in every log message? IMHO this is

Re: [PATCH] mfd: qcom-spmi-pmic: Add support for more chips versions

2014-11-11 Thread Courtney Cavin
On Fri, Nov 07, 2014 at 04:40:52PM +0100, Ivan T. Ivanov wrote: On Fri, 2014-11-07 at 17:33 +0200, Ivan T. Ivanov wrote: On Thu, 2014-11-06 at 08:55 -0800, Bjorn Andersson wrote: On Wed, Nov 5, 2014 at 11:54 PM, Ivan T. Ivanov iiva...@mm-sol.com wrote: On Wed, 2014-11-05 at 17:36

Re: [RFC/PATCH 0/5 v2] mtd:ubi: Read disturb and Data retention handling

2014-11-11 Thread Tanya Brokhman
Hi Artem, Hope I didn't drop any ccs this time... Sorry about that. Not on purpose. On 11/7/2014 10:58 AM, Artem Bityutskiy wrote: On Thu, 2014-11-06 at 14:16 +0200, Tanya Brokhman wrote: What I'm trying to say - it may be too late and you may lose data here. preferred to prevent rather than

Re: [RFC/PATCH 0/5 v2] mtd:ubi: Read disturb and Data retention handling

2014-11-11 Thread Richard Weinberger
Tanya, Am 11.11.2014 um 21:36 schrieb Tanya Brokhman: Hi Artem, Hope I didn't drop any ccs this time... Sorry about that. Not on purpose. On 11/7/2014 10:58 AM, Artem Bityutskiy wrote: On Thu, 2014-11-06 at 14:16 +0200, Tanya Brokhman wrote: What I'm trying to say - it may be too late

Re: [PATCH v4 2/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-11-11 Thread Hartmut Knaack
Ivan T. Ivanov schrieb am 11.11.2014 09:21: Hi Hartmut, On Mon, 2014-11-10 at 22:11 +0100, Hartmut Knaack wrote: Ivan T. Ivanov schrieb am 03.11.2014 16:24: From: Stanimir Varbanov svarba...@mm-sol.com The voltage ADC is peripheral of Qualcomm SPMI PMIC chips. It has 15 bits resolution