index 000..b6bf5bc
> --- /dev/null
> +++ b/include/dt-bindings/mfd/qcom,ssbi.h
> @@ -0,0 +1,19 @@
> +/* Copyright (c) 2015, The Linux Foundation. All rights reserved.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the
gt;dev.of_node, "default-brightness", &val);
> +
> memset(&props, 0, sizeof(struct backlight_properties));
> props.type = BACKLIGHT_RAW;
> + props.brightness = val;
> props.max_brightness = PM8941_WLED_REG_VAL_MAX;
> bl = devm_backlight_device_register(
acklight_device *bl;
> struct pm8941_wled *wled;
> struct regmap *regmap;
> int rc;
> @@ -403,13 +395,14 @@ static int pm8941_wled_probe(struct platform_device
> *pdev)
> if (rc)
> return rc;
>
> - wled->cdev.brightness_set
_irq_flags calls. Some
> users also modify IRQ_NOPROBE and this has been maintained although it
> is not clear that is really needed. There appears to be a great deal of
> blind copy and paste of this code.
>
> Signed-off-by: Rob Herring
> Cc: Samuel Ortiz
> Acked-by: Lee Jon
On Mon, 27 Jul 2015, Mark Brown wrote:
> On Mon, Jul 27, 2015 at 08:29:18AM +0100, Lee Jones wrote:
> > On Fri, 24 Jul 2015, Mark Brown wrote:
> > > On Fri, Jul 24, 2015 at 11:24:34AM +0100, Mark Brown wrote:
>
> > From here:
>
> > > >
On Fri, 24 Jul 2015, Mark Brown wrote:
> On Fri, Jul 24, 2015 at 11:24:34AM +0100, Mark Brown wrote:
> > On Fri, Jul 24, 2015 at 10:58:47AM +0100, Lee Jones wrote:
> > > On Thu, 23 Jul 2015, Mark Brown wrote:
>
> > > > I have no idea what's going on he
On Thu, 23 Jul 2015, Bjorn Andersson wrote:
> On Thu 23 Jul 06:22 PDT 2015, Lee Jones wrote:
>
> > On Mon, 13 Jul 2015, Bjorn Andersson wrote:
> >
> > > On Tue 07 Jul 05:37 PDT 2015, Lee Jones wrote:
> > >
> > > > On Fri, 26 Jun 2015, bj.
no idea what's going on here, sorry. I've not been reading this
> thread.
All of the information you need is in the email you replied to.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blo
props.brightness = val;
> props.max_brightness = PM8941_WLED_REG_VAL_MAX;
> bl = devm_backlight_device_register(&pdev->dev, wled->name,
> &pdev->dev, wled,
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Lina
_unlock(&chip->pm_irq_lock);
> +
> + return rc;
> +}
> +
> static struct irq_chip pm8xxx_irq_chip = {
> .name = "pm8xxx",
> .irq_mask_ack = pm8xxx_irq_mask_ack,
> .irq_unmask = pm8xxx_irq_unmask,
> .irq_set_type =
On Mon, 13 Jul 2015, Bjorn Andersson wrote:
> On Tue 07 Jul 05:16 PDT 2015, Lee Jones wrote:
>
> > FAO Mark and DT chaps,
> >
> > > From: Bjorn Andersson
> > >
> > > Add binding documentation for the Qualcomm Resource Power Manager (RPM)
> >
On Mon, 13 Jul 2015, Bjorn Andersson wrote:
> On Tue 07 Jul 05:37 PDT 2015, Lee Jones wrote:
>
> > On Fri, 26 Jun 2015, bj...@kryo.se wrote:
> >
> > > From: Bjorn Andersson
> [..]
>
> > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
&
o.
Please read: Sections 12 and 13 of Documentation/SubmittingPatches.
Granted, Acked-bys are used by Maintainers when reviewing changes in
subsystems they are responsible for. However, that's not the sole use
of them. Anyone can provide an Ack for code they have reviewed, but
are not an
={ 211, 126, 83, 1 },
> [QCOM_RPM_DDR_DMM] ={ 212, 127, 84, 2 },
> + [QCOM_RPM_QDSS_CLK] = { 214, ~0, 7, 1 },
> [QCOM_RPM_VDDMIN_GPIO] ={ 215, 131, 89, 1 },
> };
>
--
Lee Jones
Linaro STMicroelectronics Landing Te
ICENSE("GPL v2");
> diff --git a/include/linux/mfd/qcom-smd-rpm.h
> b/include/linux/mfd/qcom-smd-rpm.h
> new file mode 100644
> index 000..2a53dca
> --- /dev/null
> +++ b/include/linux/mfd/qcom-smd-rpm.h
> @@ -0,0 +1,35 @@
> +#ifndef __QCOM_SMD_RPM_H__
> +#define __Q
ine QCOM_SMD_RPM_BUS_CLK 0x316b6c63
> +#define QCOM_SMD_RPM_BUS_MASTER 0x73616d62
> +#define QCOM_SMD_RPM_BUS_SLAVE 0x766c7362
> +#define QCOM_SMD_RPM_CLK_BUF_A 0x616B6C63
> +#define QCOM_SMD_RPM_LDOA0x616f646c
> +#define QCOM_SMD_RPM_LDOB0x626F646C
> +#define Q
set_irq_flags calls. Some
> users also set IRQ_NOPROBE and this has been maintained although it is not
> clear that is really needed. There appears to be a great deal of blind
> copy and paste of this code.
>
> Signed-off-by: Rob Herring
> Cc: Samuel Ortiz
> Cc: Lee Jones
> Cc:
2 +-
> drivers/mfd/htc-egpio.c|2 +-
> drivers/mfd/jz4740-adc.c |2 +-
> drivers/mfd/pm8921-core.c |2 +-
> drivers/mfd/t7l66xb.c |2 +-
> drivers/mfd/tc6393xb.c |2 +-
> drivers/mfd/ucb1x00-core.c |4 ++--
> 8 files changed, 9 insertions
mes = "ack", "err", "wakeup";
>
> - #address-cells = <1>;
> - #size-cells = <0>;
> + regulators {
> + compatible = "qcom,rpm-pm8921-regulators";
> + vdd_l1_l2_l12_l1
ddress-cells = <1>;
> - #size-cells = <0>;
> + regulators {
> + compatible = "qcom,rpm-pm8921-regulators";
> + vdd_l1_l2_l12_l18-supply = <&pm8921_s4>;
> +
> + s1 {
> +
+
> + if (subtype == PM8110_SUBTYPE)
> + minor = rev2;
> +
> + dev_dbg(dev, "%x: %s v%d.%d\n", subtype, name, major, minor);
> +}
> +
> static const struct regmap_config spmi_regmap_config = {
> .reg_bits = 16,
> .val_bits
ompatible = "qcom,rpm-msm8660", .data = &msm8660_template },
> { .compatible = "qcom,rpm-msm8960", .data = &msm8960_template },
> + { .compatible = "qcom,rpm-ipq8064", .data = &ipq806x_template },
> { }
> };
> MODULE_DEVICE_TABLE(of, qcom_rpm_o
137
> +#define QCOM_RPM_SMB208_S2a 138
> +#define QCOM_RPM_SMB208_S2b 139
>
> /*
> * Constants used to select force mode for regulators.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source soft
On Thu, 19 Mar 2015, Lee Jones wrote:
> On Thu, 20 Nov 2014, Josh Cartwright wrote:
>
> > The IPQ8064 also includes an RPM following the same message structure as
> > other chips. In addition, it supports a few new resource types to
> > support the NSS fabric cloc
YPE) &&
> + major < 0x02)
> + major++;
> +
> + if (subtype == PM8110_SUBTYPE)
> + minor = rev2;
> +
> + dev_dbg(dev, "%x: %s v%d.%d\n", subtype, name, major, minor);
> +}
> +
> static const struct regmap_co
132
> #define QCOM_RPM_VDDMIN_GPIO 133
> +#define QCOM_RPM_NSS_FABRIC_0_CLK134
> +#define QCOM_RPM_NSS_FABRIC_1_CLK135
> +#define QCOM_RPM_SMB208_S1a 136
> +#define QCOM_RPM_SMB208_S1b 137
> +#define QCOM_RPM_SMB208_S2a
E(ipq806x_rpm_resource_table),
> +};
> +
> static const struct of_device_id qcom_rpm_of_match[] = {
> { .compatible = "qcom,rpm-apq8064", .data = &apq8064_template },
> { .compatible = "qcom,rpm-msm8660", .data = &msm8660_template },
> { .compa
fine QCOM_RPM_VDDMIN_GPIO 133
> +#define QCOM_RPM_NSS_FABRIC_0_CLK134
> +#define QCOM_RPM_NSS_FABRIC_1_CLK135
> +#define QCOM_RPM_SMB208_S1a 136
> +#define QCOM_RPM_SMB208_S1b 137
> +#define QCOM_RPM_SMB208_S2a
ck and forth we've concluded that we should be
> > future compatible with these bindings, so let's make an attempt to make
> > it possible to use the Qualcomm family A regulators.
> >
>
> ping?
Pings don't work. If I haven't replied, there is a reason.
I&
On Tue, 10 Feb 2015, Lee Jones wrote:
> On Mon, 09 Feb 2015, Bjorn Andersson wrote:
>
> > On Thu, Jan 29, 2015 at 5:51 PM, Bjorn Andersson
> > wrote:
> > > Add the regulator subnodes to the Qualcomm RPM MFD device tree bindings.
> > >
> > > Signed-o
122
> +#define QCOM_RPM_PXO_CLK 123
> +#define QCOM_RPM_QDSS_CLK 124
> +#define QCOM_RPM_SFPB_CLK125
> +#define QCOM_RPM_SMI_CLK 126
> +#define QCOM_RPM_SYS_FABRIC_ARB
QCOM_RPM_ACTIVE_STATE,
> vreg->resource,
> vreg->val,
> vreg->parts->request_len);
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro:
return ret;
> + }
> +
> + ret = irq_set_irq_wake(irq_ack, 1);
> + if (ret)
> + dev_warn(&pdev->dev, "failed to mark ack irq as wakeup\n");
> +
> + ret = devm_request_irq(&pdev->dev,
> +irq_err,
QCOM_RPM_ACTIVE_STATE,
> vreg->resource,
> vreg->val,
> vreg->parts->request_len);
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Li
>
> Signed-off-by: Josh Cartwright
> ---
> drivers/mfd/qcom_rpm.c | 41 +
> 1 file changed, 41 insertions(+)
For my own reference:
Acked-by: Lee Jones
> diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c
> index 0dd7a6f
d/qcom-rpm.txt | 6 +-
> include/dt-bindings/mfd/qcom-rpm.h | 6 ++
> 2 files changed, 11 insertions(+), 1 deletion(-)
For my own reference:
Acked-by: Lee Jones
> diff --git a/Documentation/devicetree/bindings/mfd/qcom-rpm.txt
> b/Documentation/devicetree/bindings/mf
QCOM_RPM_NSS_FABRIC_1_CLK135
> +#define QCOM_RPM_SMB208_S1a 136
> +#define QCOM_RPM_SMB208_S1b 137
> +#define QCOM_RPM_SMB208_S2a 138
> +#define QCOM_RPM_SMB208_S2b 139
>
> /*
> * Constants used to select force mo
On Tue, 11 Nov 2014, Bjorn Andersson wrote:
> On Tue 11 Nov 04:04 PST 2014, Lee Jones wrote:
>
> > On Mon, 10 Nov 2014, Bjorn Andersson wrote:
> >
> > > Resources exposed from the RPM have an "active state" that is used during
> > > normal oper
com_rpm.h
> +++ b/include/linux/mfd/qcom_rpm.h
> @@ -5,6 +5,9 @@
>
> struct qcom_rpm;
>
> -int qcom_rpm_write(struct qcom_rpm *rpm, int resource, u32 *buf, size_t
> count);
> +#define RPM_ACTIVE_STATE 0
> +#define RPM_SLEEP_STATE 1
> +
> +int
optional
> + Value type:
> + Definition: select that the regulator is supplying the active CPU(s)
> + and can only be disabled with the assistans from the RPM
> + after going to sleep
> +
There must be a better way to document this.
> =
On Fri, 17 Oct 2014, Bjorn Andersson wrote:
> On Wed 08 Oct 01:40 PDT 2014, Lee Jones wrote:
[...]
> > > +static struct qcom_smd_driver qcom_smd_rpm_driver = {
> > > + .probe = qcom_smd_rpm_probe,
> > > + .remove = qcom_smd_rpm_remove,
> > > + .callback =
.remove = qcom_smd_rpm_remove,
> + .callback = qcom_smd_rpm_callback,
> + .driver = {
> + .name = "qcom_smd_rpm",
> + .owner = THIS_MODULE,
> + .of_match_table = qcom_smd_rpm_of_match,
> + },
> +};
> +
> +module_qc
On Wed, 24 Sep 2014, Bjorn Andersson wrote:
> On Wed 24 Sep 01:22 PDT 2014, Lee Jones wrote:
>
> > On Mon, 22 Sep 2014, Bjorn Andersson wrote:
> >
> > > Add binding for the Qualcomm Resource Power Manager (RPM) found in 8660,
> > > 8960 and 8064 based devi
7 +1283,7 @@ config RTC_DRV_LPC32XX
> >>
> >> config RTC_DRV_PM8XXX
> >>tristate "Qualcomm PMIC8XXX RTC"
> >> - depends on MFD_PM8XXX
> >> + depends on MFD_PM8XXX || MFD_SPMI_PMIC
> >
> > There's currently no Kconfig symbo
> > +
> > + rtc {
> > + compatible = "qcom,rtc";
> > + interrupts = <0x0 0x61 0x1
> > IRQ_TYPE_EDGE_RISING>;
> > + interrupt-names = "alarm";
> &g
r children devices described in
> device tree.
>
> Signed-off-by: Josh Cartwright
> Signed-off-by: Stanimir Varbanov
> Acked-by: Lee Jones
> ---
> drivers/mfd/Kconfig | 15 +
> drivers/mfd/Makefile |
> Signed-off-by: Bjorn Andersson
> ---
>
> No functional changes since v6.
Then you should have applied my:
Acked-by: Lee Jones
> drivers/mfd/Kconfig | 14 +
> drivers/mfd/Makefile |1 +
> drivers/mfd/qcom_rpm.c | 580
>
21
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/qcom-rpm.txt
This requires a DT Ack.
[...]
> +++ b/include/dt-bindings/mfd/qcom-rpm.h
Please split this into a separate patch.
When you do, for this file only, please apply my:
Acked-by: Lee Jones
> @@ -0,0 +1,154
On Wed, 24 Sep 2014, Lee Jones wrote:
> On Tue, 23 Sep 2014, Bjorn Andersson wrote:
>
> > On Tue 23 Sep 01:17 PDT 2014, Srinivas Kandagatla wrote:
> >
> > > Hi Bjorn,
> > >
> > > Thankyou for the new patchset.
> > >
> > > I got fe
they will pull the parts individually.
> However
> both of the patches depend on the header file created in patch 1, someone
> needs
> to take both for it to work out?
Once reviewed I can take the whole set with Mark's Ack.
--
Lee Jones
Linaro STMicroelectronics Landing Team
On Wed, 17 Sep 2014, Lee Jones wrote:
> On Wed, 17 Sep 2014, Srinivas Kandagatla wrote:
>
> > On 17 Sep 2014 09:03, "Lee Jones" wrote:
> > >
> > > On Wed, 17 Sep 2014, Srinivas Kandagatla wrote:
> > >
> > > > This patch promtes the d
On Wed, 17 Sep 2014, Srinivas Kandagatla wrote:
> On 17 Sep 2014 09:03, "Lee Jones" wrote:
> >
> > On Wed, 17 Sep 2014, Srinivas Kandagatla wrote:
> >
> > > This patch promtes the driver to be at subsystem level as this driver
> > > will be used
On Tue, 26 Aug 2014, Lee Jones wrote:
> On Mon, 25 Aug 2014, Bjorn Andersson wrote:
>
> > Add binding for the Qualcomm Resource Power Manager (RPM) found in 8660,
> > 8960 and 8064 based devices. The binding currently describes the rpm
> > itself and the regulator subno
s_initcall(ssbi_init);
>
> MODULE_LICENSE("GPL v2");
> MODULE_VERSION("1.0");
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the li
ns(+)
> create mode 100644 drivers/mfd/qcom_rpm.c
> create mode 100644 include/linux/mfd/qcom_rpm.h
I'd like to take this in with the other MFD patch.
Is the regulator one okay to go in on it's own?
Acked-by: Lee Jones
--
Lee Jones
Linaro STMicroelectronics Landing Team Lea
4 include/dt-bindings/mfd/qcom,rpm.h
Please use the same filename formatting as the existing files.
[...]
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the lin
On Thu, 21 Aug 2014, Bjorn Andersson wrote:
> On Thu 21 Aug 06:22 PDT 2014, Lee Jones wrote:
> > > +struct qcom_rpm *dev_get_qcom_rpm(struct device *dev)
> > > +{
> > > + return dev_get_drvdata(dev);
> > > +}
> > > +EXPORT_SYMBOL(dev_get_q
+ platform_device_unregister(to_platform_device(dev));
> + return 0;
> +}
> +
> +static int qcom_rpm_remove(struct platform_device *pdev)
> +{
> + device_for_each_child(&pdev->dev, NULL, qcom_rpm_remove_child);
of_platform_depopulate()?
> + return 0;
>
ee.
> >>>
> >>> Signed-off-by: Josh Cartwright
> >>> Signed-off-by: Stanimir Varbanov
> >>> Acked-by: Lee Jones
> >>> ---
> >>> drivers/mfd/Kconfig | 16 +++
> >>> drivers/mfd/Makefile
On Tue, 22 Jul 2014, Stanimir Varbanov wrote:
> On 07/22/2014 01:32 PM, Lee Jones wrote:
> > On Thu, 17 Jul 2014, Stanimir Varbanov wrote:
> >
> >> The pm8921-core driver presently supports pm8921 and pm8058
> >> Qualcomm PMICs. To avoid confusion with new g
> +#include
> +#include
[...]
> +MODULE_DESCRIPTION("PM8XXX SPMI PMIC driver");
> +MODULE_ALIAS("platform:" KBUILD_MODNAME);
> +MODULE_AUTHOR("The Linux Foundation");
The Linux Foundation did not write this patch.
> +MODULE_LICENSE("GPL v2");
Ap
+++-
> 3 files changed, 27 insertions(+), 27 deletions(-)
> rename drivers/mfd/{pm8921-core.c => pm8xxx-ssbi.c} (92%)
Patch looks fine to me.
Acked-by: Lee Jones
I'm assuming we want to wait for the others in the set to be ready
before applying?
[...]
--
uot;);
> > +MODULE_ALIAS("platform:pm8xxx-ssbi");
> >How about adding the module author as svarba...@mm-sol.com/qcom?
> MODULE_AUTHOR("SVARBANOV");
Module author has the same standards as Git author.
MODULE_AUTHOR("Stanimir Varbanov ");
--
Lee Jon
On Mon, 14 Jul 2014, Stanimir Varbanov wrote:
> On 07/11/2014 12:07 PM, Lee Jones wrote:
> > On Thu, 10 Jul 2014, Stanimir Varbanov wrote:
> >>>>>> The Qualcomm QPNP PMIC chips are components used with the
> >>>>>> Snapdragon 800 series SoC fam
>>>> +{
> >>>> +struct device_node *root = sdev->dev.of_node;
> >>>> +struct device_node *child;
> >>>> +struct regmap *regmap;
> >>>> +
> >>>> +regmap = devm_regmap_init_spmi_ext(sdev,
On Wed, 09 Jul 2014, Stanimir Varbanov wrote:
> Hi Lee,
>
> Thanks for the comments.
>
> On 07/09/2014 05:34 PM, Lee Jones wrote:
> > On Thu, 03 Jul 2014, Stanimir Varbanov wrote:
> >> From: Josh Cartwright
> >>
> >> The Qualcomm QPNP PMIC chips
t(sdev, &qpnp_regmap_config);
> + if (IS_ERR(regmap))
> + return PTR_ERR(regmap);
> +
> + for_each_available_child_of_node(root, child)
> + qpnp_add_device(sdev, child);
This entire driver looks like a re-write of of_platform_populate().
Why?
>
ov
> ---
> arch/arm/boot/dts/qcom-msm8974.dtsi | 45
> +++
> 1 files changed, 45 insertions(+), 0 deletions(-)
Subject should start with 'ARM: ' for all of your arch/arm patches.
Rest of the patch unreviewed by me.
--
Lee Jones
Linaro
config;
>
> block = pmirq / 8;
> - irq_bit = pmirq % 8;
>
> config = chip->config[pmirq];
> pm8xxx_config_irq(chip, block, config);
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Face
- Moved rpm driver to drivers/soc
> >>>
> >>> I'm not sure I follow the motivation for having this under drivers/soc?
> >>>
> >> Hi Kevin,
> >>
> >> I've made the argument that to me this is conceptually a black
3
[...]
> +#define QCOM_RPM_SYS_FABRIC_MODE 131
> +#define QCOM_RPM_USB_OTG_SWITCH 132
> +#define QCOM_RPM_VDDMIN_GPIO 133
Are you sure you don't want these in 0xXY format?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │
mode 100644 include/linux/mfd/pm8xxx/core.h
Sorry, this slipped through the gaps.
Diff looks great. Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: s
->dev);
> +}
> +
> +static const struct of_device_id pm8x41_id_table[] = {
> + { .compatible = "qcom,pm8841", },
> + { .compatible = "qcom,pm8941", },
> + {},
> +};
> +MODULE_DEVICE_TABLE(of, pm8x41_id_table);
> +
> +static struct spmi_driver pm8x41_drive
in Lee's tree pending for 3.15. It may be best to get yours
> and Rob's Ack and have Lee take it through his tree.
After discussing with Andrew, I think this is better to go through my
tree as you suggested, in order to mitigate any merge conflicts during
the merge window.
Patch
ng
> with the rtc_ops
>
> Signed-off-by: Josh Cartwright
> ---
> drivers/rtc/rtc-pm8xxx.c | 54
> +++---
> include/linux/mfd/pm8xxx/rtc.h | 25 ---
For the MFD changes@:
Acked-by: Lee Jones
--
Lee Jones
Lina
ertion(+), 2 deletions(-)
Applied thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message
> We don't need to implement a dummy irq_set_wake op if we just set
> IRQCHIP_SKIP_SET_WAKE.
>
> Suggested-by: Josh Cartwright
> Signed-off-by: Stephen Boyd
> ---
> drivers/mfd/pm8921-core.c | 8 +---
> 1 file changed, 1 insertion(+), 7 deletions(-)
Applied,
> This isn't necessary as we aren't setting the summary interrupt
> to wake up the system in the irq_wake() callback.
>
> Signed-off-by: Stephen Boyd
> ---
> drivers/mfd/pm8921-core.c | 3 ---
> 1 file changed, 3 deletions(-)
Applied, thanks.
--
Lee Jones
Li
m,pm8xxx.txt| 63
> ++
> 1 file changed, 63 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/qcom,pm8xxx.txt
This patch has been on the MLs for some time now and hasn't received
any feedback from the DT guys.
Patch looks good (despite the lack IRQ de
On Wed, 26 Feb 2014, Stephen Boyd wrote:
> Allow this driver to be compiled on all ARM builds as it doesn't
> rely on anything within arm/mach-msm.
>
> Signed-off-by: Stephen Boyd
> ---
> drivers/mfd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 1 file changed, 20 insertions(+)
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-
On Wed, 26 Feb 2014, Stephen Boyd wrote:
> Allow this driver to probe based on devicetree.
>
> Acked-by: Lee Jones
> Signed-off-by: Stephen Boyd
> ---
> drivers/mfd/pm8921-core.c | 8
> 1 file changed, 8 insertions(+)
Applied, thanks.
--
Lee Jones
Linaro STMic
s/mfd/pm8921-core.c | 66
> +++
> 2 files changed, 39 insertions(+), 28 deletions(-)
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To un
On Wed, 26 Feb 2014, Stephen Boyd wrote:
> Convert this driver to use irqdomains so that the PMIC's child
> devices can be converted to devicetree.
>
> Acked-by: Lee Jones
> Signed-off-by: Stephen Boyd
> ---
> drivers/mfd/Kconfig | 1 +
&g
for chained handlers) introduced the chained
> irq functions but this driver wasn't updated to use them. Fix
> these problems and remove the BROKEN marking on this driver.
>
> Acked-by: Lee Jones
> Signed-off-by: Stephen Boyd
> ---
> drivers/mfd/Kconfig | 1 -
21) so that it's always compiled when
> needed. In the future we can rename pm8921-core.c to something
> more generic.
>
> Acked-by: Lee Jones
> Signed-off-by: Stephen Boyd
> ---
> drivers/mfd/Kconfig| 10 --
> drivers/mfd/
h
>
> These match the #defines in that file. I'd like to be explicit
> about the numbers to prevent people from thinking they have to
> use #defines and to match what other irq controllers have done
> (gic, atmel-aic, etc.)
I believe people _do_ have to use the #defines? Is there
ells = <1>;
> + #size-cells = <0>;
> +
> + pwrkey {
> + compatible = "qcom,pm8921-pwrkey";
> + interrupt-parent = <&pmicintc>;
> + interrupts = <50 1>, <51 1>;
As above.
> +
m,pm8xxx.txt| 63
> ++
> 1 file changed, 63 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/qcom,pm8xxx.txt
Just waiting on the Ack for this one now.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
7;m still a little dubious over the lack of an irq_create_mapping()
call, but if you say you've tested it and it works I guess something
else must be going on in its place.
Acked-by: Lee Jones
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM
On Tue, 07 Jan 2014, Stephen Boyd wrote:
> On 01/07, Lee Jones wrote:
> > > >> + return of_platform_populate(pdev->dev.of_node, NULL, NULL,
> > > >> &pdev->dev);
> > > >> +}
> > > > Can't you use the MFD core instead
each different pm8xxx chip that comes along, meaning
> simpler code.
I'm inclined to agree, but playing Devil's advocate here, as a device
using the MFD subsystem it's often clearer to readers and other people
looking for examples if the MFD core functionality is used. For
instance
e.
> + chip = devm_kzalloc(&pdev->dev, sizeof(*chip) + sizeof(u8) * nirqs,
> + GFP_KERNEL);
What does the sizeof(u8) add here?
> + return of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev);
> +}
Can't you use the MFD co
| 348 ++
> drivers/mfd/pm8xxx-irq.c | 371
> -
> include/linux/mfd/pm8xxx/irq.h | 23 ---
> 4 files changed, 348 insertions(+), 404 deletions(-)
> delete mode 100644 drivers/mfd/pm8xxx-irq.c
A
> PM8921 and PM8058 are PMICs found paired with MSM8960 and MSM8660
> devices respectively. They contain subdevices such as keypads,
> RTC, regulators, clocks, etc.
>
> Cc:
Still waiting on these guys.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open
pm8921_driver = {
> .driver = {
> .name = "pm8921-core",
> .owner = THIS_MODULE,
> + .of_match_table = pm8921_id_table,
> },
> };
Patch fine:
Acked-by: Lee Jones
--
Lee Jones
Linaro STMicroelectronics Landing Team
&val, 1);
> > > +}
> > > +EXPORT_SYMBOL_GPL(ssbi_reg_write);
> >
> > Not a big deal but could these just be inlined in the headers?
>
> Sure, I can do that if I need to resend? The only benefit I see
> is two less symbols exported.
Yes please. After this
-
> 2 files changed, 39 insertions(+), 32 deletions(-)
As this is regmap related, don't forget to CC Mark Brown when you
resubmit this patchset.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
which I can't do until
patch 5 has been fixed. Please resubmit once it's been rectified.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "
so for now I'll just Ack
it. Please remember to apply my Ack when you resubmit, as it will act
as a reminder and I won't have to re-review.
Acked-by: Lee Jones
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Faceboo
1 - 100 of 109 matches
Mail list logo
