Re: [PATCH v7 6/8] scsi: ufs: make the UFS variant a platform device

Comments inline below: > This change turns the UFS variant (SCSI_UFS_QCOM) into a UFS > a platform device. > In order to do so a few additional changes are required: > 1. The ufshcd-pltfrm is no longer serves as a platform device. >Now it only serves as a group of platform APIs such as PM

Re: [PATCH v3 02/15] scsi: ufs: clear fields UTRD, UPIU req and rsp before new transfers

Looks good to me. Reviewed-by: Subhash Jadavani > Some of the data structures (like response UPIU) and/or its elements > (unused fields) should be cleared before sending out the respective > command to UFS device. > > This change clears the UPIU response data structure

Re: [PATCH v4] scsi: ufs: add ioctl interface for query request

Looks good to me. Reviewed-by: Subhash Jadavani > This patch exposes the ioctl interface for UFS driver via SCSI device > ioctl interface. As of now UFS driver would provide the ioctl for query > interface to connected UFS device. > > Signed-off-by: Dolev Raviv

Re: [PATCH v7 4/8] add ufshcd_get_variant ufshcd_set_variant

Looks good to me. Reviewed-by: Subhash Jadavani > Signed-off-by: Yaniv Gardi > > --- > drivers/scsi/ufs/ufs-qcom.c | 34 +- > drivers/scsi/ufs/ufshcd.h | 21 + > 2 files changed, 38

Re: [PATCH v7 8/8] scsi: ufs-qcom: add QUniPro hardware support and power optimizations

Looks good to me. Reviewed-by: Subhash Jadavani > New revisions of UFS host controller supports the new UniPro > hardware controller (referred as QUniPro). This patch adds > the support to enable this new UniPro controller hardware. > > This change also adds power

Re: [PATCH v7 6/8] scsi: ufs: make the UFS variant a platform device

On Thursday 22 October 2015 07:02:14 subha...@codeaurora.org wrote: > > > > Required properties: > > -- compatible: compatible list, contains "jedec,ufs-1.1" > > +- compatible: compatible list, contains "jedec,ufs-1.1" or > > + "qcom,msm8994-ufshc" or

Re: [PATCH v7 5/8] scsi: ufs: creates wrapper functions for vops

Looks good to me. Reviewed-by: Subhash Jadavani > In order to simplify the code a set of wrapper functions is created > to test and call each of the variant operations. > > Signed-off-by: Yaniv Gardi > > --- > drivers/scsi/ufs/ufs-qcom.c | 1 -

Re: [PATCH v7 3/8] scsi: ufs-qcom: update configuration option of SCSI_UFS_QCOM component

Looks good to me. Reviewed-by: Subhash Jadavani > This change is required in order to be able to build the component > as a module. > > Signed-off-by: Yaniv Gardi > > --- > drivers/scsi/ufs/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH v7 1/8] phy: qcom-ufs: fix build error when the component is built as a module

Looks good to me. Reviewed-by: Subhash Jadavani > Export the following functions in order to avoid build errors > when the component PHY_QCOM_UFS is compiled as a module: > > ERROR: "ufs_qcom_phy_disable_ref_clk" > [drivers/scsi/ufs/ufs-qcom.ko] undefined! > ERROR:

Re: [PATCH v7 2/8] scsi: ufs-qcom: fix compilation warning if compiled as a module

Looks good to me. Reviewed-by: Subhash Jadavani > This change fixes a compilation warning that happens if SCSI_UFS_QCOM > is compiled as a module. > Also this patch fixes an error happens when insmod the module: > "ufs_qcom: module license 'unspecified' taints kernel."

Re: [PATCH v3 04/15] scsi: ufs: clear outstanding_request bit in case query timeout

Looks good to me. Reviewed-by: Subhash Jadavani > When sending a query to the device returns with a timeout error, > we clear the corresponding bit in the DOORBELL register but > we don't clear the outstanding_request field as we should. > This patch fixes this bug. >

Re: [PATCH v3 03/15] scsi: ufs: verify command tag validity

Looks good to me. Reviewed-by: Subhash Jadavani > A race condition appear to exist between request completion when > scsi_done() is called to end the request and set the tag back to > -1 (at blk_queue_end_tag() scsi_end_request), and scsi layer error > handling which

Re: [PATCH/RESEND] ARM: Remove __ref on hotplug cpu die path

On Mon, Oct 19, 2015 at 01:05:33PM -0700, Stephen Boyd wrote: > Now that __cpuinit has been removed, the __ref markings on these > functions are useless. Remove them. This also reduces the size of > the multi_v7_defconfig image: > > $ size before after >textdata bss dec hex

Re: [GIT PULL] qcom defconfig for 4.4 *RESEND*

On Wed, Oct 14, 2015 at 05:13:44PM -0500, Andy Gross wrote: > The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f: > > Linux 4.3-rc1 (2015-09-12 16:35:56 -0700) > > are available in the git repository at: > > git://codeaurora.org/quic/kernel/agross-msm.git

[PATCH 0/4] Sony Xperia Z dts

This series starts by adding hwspinlock, smem, gsbi5 and cleans up the 8064 regulator definitions. Based on this it adds the necessary nodes for booting the Sony Xperia Z (APQ8064 based) to userspace, with UART, eMMC, uSD, USB gadget and hw buttons. Bjorn Andersson (4): ARM: dts: qcom:

[PATCH 3/4] ARM: dts: qcom: apq8064: Introduce gsbi5 and gsbi5 serial node

Signed-off-by: Bjorn Andersson --- arch/arm/boot/dts/qcom-apq8064.dtsi | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi index 1bc6c4039dea..fa3053c14532 100644

[PATCH 1/4] ARM: dts: qcom: apq8064: Add hwmutex and SMEM nodes

Signed-off-by: Bjorn Andersson --- arch/arm/boot/dts/qcom-apq8064.dtsi | 29 + 1 file changed, 29 insertions(+) diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi index a4c1762b53ea..1b64723bd8a0

[PATCH 4/4] ARM: dts: qcom: apq8064: Introduce Sony Xperia Z dts

This introduces initial support for the Sony Xperia Z smartphone, including support for UART, MMC, USB gadget and physical buttons. Signed-off-by: Bjorn Andersson --- arch/arm/boot/dts/Makefile | 1 +

[PATCH 2/4] ARM: dts: qcom: apq8064: Declare all pm8921 regulators

Consolidate all labeling of regulators into the core 8064 dtsi file to make them available from all other dts files. Signed-off-by: Bjorn Andersson --- arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts | 16 +- arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 20

Re: [PATCH 2/2] drm/panel: Add Sharp LS043T1LE01 MIPI DSI panel

On Tue, Jul 28, 2015 at 6:37 PM, Bjorn Andersson wrote: > From: Werner Johansson > > This adds support for the Sharp panel found on the Qualcomm > Snapdragon 800 Dragonboard (APQ8074) > > Signed-off-by: Werner Johansson

[pull] drm/msm: msm-next for 4.4

Hi Dave, A bit smaller pull this time. Few minor things, plus initial support for msm8996 (snapdragon 820).. Sorry, a bit latish, was hoping to get some 8960/8064 DSI stuff included. But still waiting on the v2 of the patchset (just pending some minor review comments). It would be nice to get

Re: [PATCH] soc: qcom: Introduce WCNSS_CTRL SMD client

Hi Bjorn, On 2015/9/22 1:52, Bjorn Andersson wrote: The WCNSS_CTRL SMD client is used for among other things upload nv firmware to a newly booted WCNSS chip. Signed-off-by: Bjorn Andersson --- This driver probes on the WCNSS_CTRL SMD channel as it comes up upon

Re: [PATCH v3 13/15] scsi: ufs: add missing memory barriers

2015-09-02 19:13 GMT+09:00 Yaniv Gardi : > Performing several writes to UFS host controller registers has > no gurrantee of ordering, so we must make sure register writes > to setup request list base address etc. are performed before the > run/stop register is enabled. > In

Re: [PATCH] serial: msm_serial: Make config tristate

[[PATCH] serial: msm_serial: Make config tristate] On 21/10/2015 (Wed 16:05) Stephen Boyd wrote: > This driver works as a module, so mark it as a tristate config > instead of a bool. > > Cc: Paul Gortmaker > Signed-off-by: Stephen Boyd > ---

Re: [PATCH] soc: qcom: Introduce WCNSS_CTRL SMD client

On Thu 22 Oct 03:25 PDT 2015, yfw wrote: > Hi Bjorn, > > On 2015/9/22 1:52, Bjorn Andersson wrote: [..] > > I have a question: Do you have plan to add the nob to trigger wcnss firmware > downloading which is also common for wifi and BT? > In caf the wcnss driver is actually two drivers

Re: [PATCH v3 12/15] scsi: ufs: reduce the interrupts for power mode change requests

2015-10-21 23:57 GMT+09:00 Akinobu Mita : > 2015-09-02 19:13 GMT+09:00 Yaniv Gardi : >> DME commands such as Hibern8 enter/exit and gear switch generate 2 >> completion interrupts, one for confirmation that command is received >> by local UniPro and