Re: [PATCH v1 01/11] ARM: amba: Add Qualcomm vendor ID.

2014-05-13 Thread Linus Walleij
On Tue, Apr 29, 2014 at 10:19 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org This patch adds Qualcomm amba vendor Id to the list. This ID is used in mmci driver. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org (...) +

Re: [PATCH v1 02/11] mmc: mmci: Add Qualcomm Id to amba id table

2014-05-13 Thread Linus Walleij
On Tue, Apr 29, 2014 at 10:19 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org This patch adds a fake Qualcomm ID 0x00051180 to the amba_ids, as Qualcomm SDCC controller is pl180, but amba id registers read 0x0's. The plan is to remove SDCC

Re: [PATCH v1 03/11] mmc: mmci: Add Qcom datactrl register variant

2014-05-13 Thread Linus Walleij
On Tue, Apr 29, 2014 at 10:19 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org Instance of this IP on Qualcomm's SOCs has bit different layout for datactrl register. Bit postion datactrl[16:4] hold the true block size instead of power of 2.

Re: [PATCH v1 05/11] mmc: mmci: use NSEC_PER_SEC macro

2014-05-13 Thread Linus Walleij
On Tue, Apr 29, 2014 at 10:20 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org This patch replaces a constant used in calculating timeout with a proper macro. This is make code more readable. Signed-off-by: Srinivas Kandagatla

Re: [PATCH v1 06/11] mmc: mmci: Qcomm: Add 3 clock cycle delay after register write

2014-05-13 Thread Linus Walleij
On Tue, Apr 29, 2014 at 10:20 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org Most of the Qcomm SD card controller registers must be updated to the MCLK domain so subsequent writes to registers will be ignored until 3 clock cycles have

Re: [PATCH v1 07/11] mmc: mmci: move ST specific register extensions access under condition.

2014-05-13 Thread Linus Walleij
On Tue, Apr 29, 2014 at 10:20 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org This patch moves some of the ST specific register extensions access under condition, so that other SOCs like Qualcomm or ARM would not a side effect of writing to

Re: [PATCH v1 08/11] mmc: mmci: Qcom fix MCICLK register settings.

2014-05-13 Thread Linus Walleij
On Tue, Apr 29, 2014 at 10:20 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org MCICLK register layout is bit different to the standard pl180 register layout. Qcom SDCC controller some setup in MCICLK register to get it going. So this patch

Re: [PATCH v1 09/11] mmc: mmci: Add clock support for Qualcomm.

2014-05-13 Thread Linus Walleij
On Tue, Apr 29, 2014 at 10:20 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org MCICLK going to card bus is directly driven by the clock controller, so the driver has to set the required rates depending on the state of the card. This bit of

Re: [PATCH v1 10/11] mmc: mmci: Add Qcom variations to MCICommand register.

2014-05-13 Thread Linus Walleij
On Tue, Apr 29, 2014 at 10:21 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org Some bits which control Command Path State Machine (CPSM) are new in Qcom integration, so this patch adds support to those bits. Signed-off-by: Srinivas

Re: [PATCH v1 11/11] mmc: mmci: Add Qcom specific pio_read function.

2014-05-13 Thread Linus Walleij
On Tue, Apr 29, 2014 at 10:21 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org MCIFIFOCNT register behaviour on Qcom chips is very different than the other pl180 integrations. MCIFIFOCNT register contains the number of words that are still

Re: [PATCH v1 02/11] mmc: mmci: Add Qualcomm Id to amba id table

2014-05-13 Thread Srinivas Kandagatla
Thanks Linus W. On 13/05/14 08:17, Linus Walleij wrote: On Tue, Apr 29, 2014 at 10:19 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org This patch adds a fake Qualcomm ID 0x00051180 to the amba_ids, as Qualcomm SDCC controller is pl180, but

Re: [PATCH v1 05/11] mmc: mmci: use NSEC_PER_SEC macro

2014-05-13 Thread Srinivas Kandagatla
On 13/05/14 08:20, Linus Walleij wrote: On Tue, Apr 29, 2014 at 10:20 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org This patch replaces a constant used in calculating timeout with a proper macro. This is make code more readable.

Re: [PATCH v1 06/11] mmc: mmci: Qcomm: Add 3 clock cycle delay after register write

2014-05-13 Thread Srinivas Kandagatla
Thanks Linus W for reviewing the patches. On 13/05/14 08:29, Linus Walleij wrote: On Tue, Apr 29, 2014 at 10:20 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org Most of the Qcomm SD card controller registers must be updated to the MCLK

Re: [PATCH v1 07/11] mmc: mmci: move ST specific register extensions access under condition.

2014-05-13 Thread Srinivas Kandagatla
On 13/05/14 09:08, Linus Walleij wrote: /* Keep ST Micro busy mode if enabled */ - datactrl |= host-datactrl_reg MCI_ST_DPSM_BUSYMODE; + if (host-hw_designer == AMBA_VENDOR_ST) + datactrl |= host-datactrl_reg MCI_ST_DPSM_BUSYMODE; Do not hard-check the

Re: [PATCH v1 09/11] mmc: mmci: Add clock support for Qualcomm.

2014-05-13 Thread Srinivas Kandagatla
Thanks Linus W, On 13/05/14 09:28, Linus Walleij wrote: code is conditioned on hw designer. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org (...) + if (host-hw_designer == AMBA_VENDOR_QCOM) { + host-cclk = host-mclk; + }

Re: [PATCH v1 01/11] ARM: amba: Add Qualcomm vendor ID.

2014-05-13 Thread Srinivas Kandagatla
Thanks Linus W, On 13/05/14 08:16, Linus Walleij wrote: On Tue, Apr 29, 2014 at 10:19 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org This patch adds Qualcomm amba vendor Id to the list. This ID is used in mmci driver. Signed-off-by:

Re: [PATCH v1 00/11] Add Qualcomm SD Card Controller support.

2014-05-13 Thread Ulf Hansson
On 29 April 2014 10:18, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org Hi Russell, This patch series adds Qualcomm SD Card Controller support in pl180 mmci driver. QCom SDCC is basically a pl180, but bit more customized, some of the register

Re: [PATCH v1 00/11] Add Qualcomm SD Card Controller support.

2014-05-13 Thread Srinivas Kandagatla
On 13/05/14 11:04, Ulf Hansson wrote: On 29 April 2014 10:18, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org Hi Russell, This patch series adds Qualcomm SD Card Controller support in pl180 mmci driver. QCom SDCC is basically a pl180, but bit

Re: [RFC PATCH v2 1/9] crypto: qce: Add core driver implementation

2014-05-13 Thread Herbert Xu
On Fri, May 09, 2014 at 12:57:39AM +0300, Stanimir Vabanov wrote: Hi Herbert, On 04/28/2014 11:59 AM, Herbert Xu wrote: On Mon, Apr 14, 2014 at 03:48:37PM +0300, Stanimir Varbanov wrote: +#define QCE_MAJOR_VERSION50x05 +#define QCE_QUEUE_LENGTH 50 What is the purpose of

[PATCH 2/4] spi: qup: Correct selection of FIFO/Block mode

2014-05-13 Thread Andy Gross
This patch fixes the calculation for determining whether to use FIFO or BLOCK mode. Signed-off-by: Andy Gross agr...@codeaurora.org --- drivers/spi/spi-qup.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c index

[PATCH 0/4] spi: qup: Fixes and new version support

2014-05-13 Thread Andy Gross
This set of patches provides a few fixes for the SPI QUP driver and support for an earlier version of the QUP. The first patch removes the use of the controller's own chip select functionality. The user should instead use GPIOs and make use of the SPI core's GPIO chip select feature. The second

[PATCH 1/4] spi: qup: Remove chip select function

2014-05-13 Thread Andy Gross
This patch removes the chip select function. Chip select should instead be supported using GPIOs, defining the DT entry cs-gpios, and letting the SPI core assert/deassert the chip select as it sees fit. Signed-off-by: Andy Gross agr...@codeaurora.org ---

[PATCH 3/4] spi: qup: Fix order of spi_register_master

2014-05-13 Thread Andy Gross
This patch moves the devm_spi_register_master below the initialization of the runtime_pm. If done in the wrong order, the spi_register_master fails if any probed slave devices issue SPI transactions. Signed-off-by: Andy Gross agr...@codeaurora.org --- drivers/spi/spi-qup.c | 11 +++ 1

[PATCH 4/4] spi: qup: Add support for v1.1.1

2014-05-13 Thread Andy Gross
This patch adds support for v1.1.1 of the SPI QUP controller. Signed-off-by: Andy Gross agr...@codeaurora.org --- drivers/spi/spi-qup.c | 32 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c index

Re: [PATCH 4/4] spi: qup: Add support for v1.1.1

2014-05-13 Thread Stephen Boyd
On 05/13, Andy Gross wrote: @@ -488,7 +491,7 @@ static int spi_qup_probe(struct platform_device *pdev) struct resource *res; struct device *dev; void __iomem *base; - u32 data, max_freq, iomode; + u32 data = 0, max_freq, iomode; It looks like data is unused? But

Re: [PATCH v1 01/11] ARM: amba: Add Qualcomm vendor ID.

2014-05-13 Thread Stephen Boyd
On 05/13, Srinivas Kandagatla wrote: Thanks Linus W, On 13/05/14 08:16, Linus Walleij wrote: On Tue, Apr 29, 2014 at 10:19 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org This patch adds Qualcomm amba vendor Id to the list. This ID is

Re: [PATCH 4/4] spi: qup: Add support for v1.1.1

2014-05-13 Thread Andy Gross
On Tue, May 13, 2014 at 03:08:45PM -0700, Stephen Boyd wrote: On 05/13, Andy Gross wrote: @@ -488,7 +491,7 @@ static int spi_qup_probe(struct platform_device *pdev) struct resource *res; struct device *dev; void __iomem *base; - u32 data, max_freq, iomode; + u32 data =

[PATCH] clocksource: qcom: Implement read_current_timer for udelay

2014-05-13 Thread Stephen Boyd
Setup the same timer used as the clocksource to be used as the read_current_timer implementation. This allows us to support a stable udelay implementation on MSMs where it's possible for the CPUs to scale speeds independently of one another. Signed-off-by: Stephen Boyd sb...@codeaurora.org ---