Hi Linus W,
On 26/05/14 11:07, Ulf Hansson wrote:
unsigned intfifosize;
unsigned intfifohalfsize;
@@ -116,6 +118,7 @@ static struct variant_data variant_u300 = {
.fifosize = 16 * 4,
.fifohalfsize = 8 * 4,
On Wed, May 28, 2014 at 9:27 AM, Srinivas Kandagatla
srinivas.kandaga...@linaro.org wrote:
Hi Linus W,
On 26/05/14 11:07, Ulf Hansson wrote:
unsigned intfifosize;
unsigned intfifohalfsize;
@@ -116,6 +118,7 @@ static struct variant_data variant_u300 =
On Tue, May 27, 2014 at 12:39 AM, Srinivas Kandagatla
srinivas.kandaga...@linaro.org wrote:
On 26/05/14 15:21, Ulf Hansson wrote:
On 23 May 2014 14:52, srinivas.kandaga...@linaro.org wrote:
+ boolexplicit_mclk_control;
+ boolcclk_is_mclk;
On Fri, May 23, 2014 at 2:53 PM, srinivas.kandaga...@linaro.org wrote:
+ if (unlikely(bytes)) {
+ unsigned char buf[4];
(...)
Please think twice about this.
http://lwn.net/Articles/70473/
http://lwn.net/Articles/420019/
http://lwn.net/Articles/182369/
Yours,
Linus Walleij
On 28/05/14 09:02, Linus Walleij wrote:
On Tue, May 27, 2014 at 12:39 AM, Srinivas Kandagatla
srinivas.kandaga...@linaro.org wrote:
On 26/05/14 15:21, Ulf Hansson wrote:
On 23 May 2014 14:52, srinivas.kandaga...@linaro.org wrote:
+ boolexplicit_mclk_control;
+
On 28/05/14 09:08, Linus Walleij wrote:
On Fri, May 23, 2014 at 2:53 PM, srinivas.kandaga...@linaro.org wrote:
+ if (unlikely(bytes)) {
+ unsigned char buf[4];
(...)
Please think twice about this.
http://lwn.net/Articles/70473/
http://lwn.net/Articles/420019/
On Tue, May 27, 2014 at 10:47 PM, Bjorn Andersson
bjorn.anders...@sonymobile.com wrote:
Signed-off-by: Bjorn Andersson bjorn.anders...@sonymobile.com
---
Thought I already sent you parts of this previously, sorry about that.
This should apply on your devel branch.
OK thanks, patch applied.
Hi Ulf,
On 26/05/14 22:38, Srinivas Kandagatla wrote:
2 files changed, 28 insertions(+)
diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c
index 17e7f6a..6434f5b1 100644
--- a/drivers/mmc/host/mmci.c
+++ b/drivers/mmc/host/mmci.c
@@ -185,6 +185,10 @@ static struct variant_data
On Tue, May 27, 2014 at 02:40:15PM -0700, Stephen Boyd wrote:
On 05/24/14 05:48, Mark Brown wrote:
That said it looks like this is intended to be a supply for an external
PHY rather than the device itself, but even so my original question
about it being able to operate without power still
On 28 May 2014 11:41, Srinivas Kandagatla
srinivas.kandaga...@linaro.org wrote:
Hi Ulf,
On 26/05/14 22:38, Srinivas Kandagatla wrote:
2 files changed, 28 insertions(+)
diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c
index 17e7f6a..6434f5b1 100644
---
On 28 May 2014 10:28, Srinivas Kandagatla
srinivas.kandaga...@linaro.org wrote:
On 28/05/14 09:02, Linus Walleij wrote:
On Tue, May 27, 2014 at 12:39 AM, Srinivas Kandagatla
srinivas.kandaga...@linaro.org wrote:
On 26/05/14 15:21, Ulf Hansson wrote:
On 23 May 2014 14:52,
From: Srinivas Kandagatla srinivas.kandaga...@linaro.org
Thankyou Linus W, Ulf H and everyone for reviewing RFC to v3 patches.
This patch series adds Qualcomm SD Card Controller support in pl180 mmci
driver. QCom SDCC is basically a pl180, but bit more customized, some of the
register layouts
From: Srinivas Kandagatla srinivas.kandaga...@linaro.org
This patch replaces a constant used in calculating timeout with a proper
macro. This is make code more readable.
Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org
Reviewed-by: Linus Walleij linus.wall...@linaro.org
---
From: Srinivas Kandagatla srinivas.kandaga...@linaro.org
Instance of this IP on Qualcomm's SOCs has bit different layout for datactrl
register. Bit position datactrl[16:4] hold the true block size instead of power
of 2.
Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org
From: Srinivas Kandagatla srinivas.kandaga...@linaro.org
On Controllers like Qcom SD card controller where cclk is mclk and mclk should
be directly controlled by the driver.
This patch adds support to control mclk directly in the driver, and also
adds explicit_mclk_control flag in variant
From: Srinivas Kandagatla srinivas.kandaga...@linaro.org
Some of the controller have maximum supported frequency, This patch adds
support in variant data structure to specify such restrictions. This
gives more flexibility in calculating the f_max before passing it to
mmc-core.
Signed-off-by:
From: Srinivas Kandagatla srinivas.kandaga...@linaro.org
This patch adds edge support for data and command out to variant structure
giving more flexibility to the driver to support more SOCs which have
different clock register layout.
Without this patch other new SOCs like Qcom will have to add
From: Srinivas Kandagatla srinivas.kandaga...@linaro.org
This patch adds specifics of clk and datactrl register on Qualcomm SD
Card controller. This patch also populates the Qcom variant data with
these new values specific to Qualcomm SD Card Controller.
Signed-off-by: Srinivas Kandagatla
From: Srinivas Kandagatla srinivas.kandaga...@linaro.org
On some SOCs like Qcom there are explicit bits in the command register
to specify if its a data transfer command or not. So this patch adds
support to such bits in variant data, giving more flexibility to the
driver.
Signed-off-by:
From: Srinivas Kandagatla srinivas.kandaga...@linaro.org
This patch adds 8bit bus enable to variant structure giving more flexibility
to the driver to support more SOCs which have different clock register layout.
Without this patch other new SOCs like Qcom will have to add more code
to special
From: Srinivas Kandagatla srinivas.kandaga...@linaro.org
This patch adds a fake Qualcomm ID 0x00051180 to the amba_ids, as Qualcomm
SDCC controller is pl180, but amba id registers read 0x0's.
The plan is to remove SDCC driver totally and use mmci as the main SD
controller driver for Qualcomm
From: Srinivas Kandagatla srinivas.kandaga...@linaro.org
This patch converts the register bits in the header file to use BIT(()
macro, which looks much neater.
No functional changes done.
Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org
---
drivers/mmc/host/mmci.h | 208
From: Srinivas Kandagatla srinivas.kandaga...@linaro.org
This patch adds ddrmode mask to variant structure giving more flexibility
to the driver to support more SOCs which have different datactrl register
layout.
Without this patch datactrl register is updated with wrong ddrmode mask on non
ST
From: Srinivas Kandagatla srinivas.kandaga...@linaro.org
On Qcom SD Card controller POWER, CLKCTRL, DATACTRL and COMMAND registers
should be updated in MCLK domain, and writes to these registers must be
separated by three MCLK cycles. This resitriction is not applicable for
other registers. Any
From: Srinivas Kandagatla srinivas.kandaga...@linaro.org
MCIFIFOCNT register behaviour on Qcom chips is very different than the other
pl180 integrations. MCIFIFOCNT register contains the number of
words that are still waiting to be transferred through the FIFO. It keeps
decrementing once the host
Sorry Stephen for late reply,
Some reason this mail was filtered in other folders.
On 24/05/14 00:28, Stephen Boyd wrote:
On 05/23/14 05:53, srinivas.kandaga...@linaro.org wrote:
@@ -1022,6 +1025,40 @@ mmci_cmd_irq(struct mmci_host *host, struct mmc_command
*cmd,
}
}
+static int
Hello Stephen,
On Tue, May 27, 2014 at 02:40:15PM -0700, Stephen Boyd wrote:
On 05/24/14 05:48, Mark Brown wrote:
On Fri, May 23, 2014 at 12:57:17PM -0700, Stephen Boyd wrote:
Optional properties:
-- vdd-supply: supply for Ethernet mac
+- vdd-supply: analog 3.3V supply for
Linus,
Just wondering were we stood on:
https://patchwork.kernel.org/patch/4144631/
https://patchwork.kernel.org/patch/4161061/
thanks
- k
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation
--
To
On Thu, May 22, 2014 at 4:00 PM, Stephen Boyd sb...@codeaurora.org wrote:
There's one existing use of 'micrel' in the documentation so use
'micrel' instead of the company's ticker symbol 'mcrl'.
Cc: devicet...@vger.kernel.org
Signed-off-by: Stephen Boyd sb...@codeaurora.org
Applied for 3.16.
On May 27, 2014, at 12:28 PM, Bjorn Andersson bjorn.anders...@sonymobile.com
wrote:
This series adds a regulator driver for the Resource Power Manager found in
Qualcomm 8660, 8960 and 8064 based devices.
The RPM driver exposes resources to its child devices, that can be accessed to
On May 27, 2014, at 12:28 PM, Bjorn Andersson bjorn.anders...@sonymobile.com
wrote:
Add binding for the Qualcomm Resource Power Manager (RPM) found in 8660, 8960
and 8064 based devices. The binding currently describes the rpm itself and the
regulator subnodes.
Signed-off-by: Bjorn
On Wed, May 28, 2014 at 10:16 AM, Uwe Kleine-König
u.kleine-koe...@pengutronix.de wrote:
Hello Stephen,
On Tue, May 27, 2014 at 02:40:15PM -0700, Stephen Boyd wrote:
On 05/24/14 05:48, Mark Brown wrote:
On Fri, May 23, 2014 at 12:57:17PM -0700, Stephen Boyd wrote:
Optional properties:
On Tue, May 27, 2014 at 10:28:41AM -0700, Bjorn Andersson wrote:
+static int rpm_reg_set_voltage(struct regulator_dev *rdev,
+int min_uV, int max_uV,
+unsigned *selector)
+{
+ struct qcom_rpm_reg *vreg = rdev_get_drvdata(rdev);
+
On Wed, May 28, 2014 at 9:23 AM, Kumar Gala ga...@codeaurora.org wrote:
On May 27, 2014, at 12:28 PM, Bjorn Andersson
bjorn.anders...@sonymobile.com wrote:
This series adds a regulator driver for the Resource Power Manager found in
Qualcomm 8660, 8960 and 8064 based devices.
The RPM
On May 28, 2014, at 11:59 AM, Bjorn Andersson bj...@kryo.se wrote:
On Wed, May 28, 2014 at 9:23 AM, Kumar Gala ga...@codeaurora.org wrote:
On May 27, 2014, at 12:28 PM, Bjorn Andersson
bjorn.anders...@sonymobile.com wrote:
This series adds a regulator driver for the Resource Power
On Wed, May 28, 2014 at 05:16:46PM +0200, Uwe Kleine-König wrote:
On Tue, May 27, 2014 at 02:40:15PM -0700, Stephen Boyd wrote:
On 05/24/14 05:48, Mark Brown wrote:
So, according to the datasheet I managed to find this device has a
supply VDD_IO (so normally written vdd-io-supply here),
Add basic APQ8064 SoC include device tree and support for basic booting on
the IFC6410 board. Also, keep dtb build list and qcom_dt_match in sorted
order.
Signed-off-by: Kumar Gala ga...@codeaurora.org
---
v3:
* Cleanup cpu node to have compatible enable-method per node and
not in the
* Move SoC peripherals into an SoC container node
* Move serial enabling into board file (qcom-apq8074-dragonboard.dts)
* Move spi pinctrl into board file
* Cleanup cpu node to match binding spec, enable-method and compatible
should be per cpu, not part of the container
* Drop interrupts
* Move SoC peripherals into an SoC container node
* Move serial enabling into board file (qcom-msm8660-surf.dts)
* Cleanup cpu node to match binding spec, enable-method and compatible
should be per cpu, not part of the container
Signed-off-by: Kumar Gala ga...@codeaurora.org
---
* Move SoC peripherals into an SoC container node
* Move serial enabling into board file (qcom-msm8960-cdp.dts)
* Cleanup cpu node to match binding spec, enable-method and compatible
should be per cpu, not part of the container
* Drop interrupts property from l2-cache node as its not part of the
* Move SoC peripherals into an SoC container node
* Move serial enabling into board file (qcom-apq8074-dragonboard.dts)
* Move spi pinctrl into board file
* Cleanup cpu node to match binding spec, enable-method and compatible
should be per cpu, not part of the container
* Drop interrupts
On Wed, May 28, 2014 at 6:18 PM, Kumar Gala ga...@codeaurora.org wrote:
Just wondering were we stood on:
https://patchwork.kernel.org/patch/4144631/
https://patchwork.kernel.org/patch/4161061/
I have never seen them before in my life :-D
I don't pick patches from linux-arm-msm as I'm not
On May 28, 2014, at 2:05 PM, Linus Walleij linus.wall...@linaro.org wrote:
On Wed, May 28, 2014 at 6:18 PM, Kumar Gala ga...@codeaurora.org wrote:
Just wondering were we stood on:
https://patchwork.kernel.org/patch/4144631/
https://patchwork.kernel.org/patch/4161061/
I have never seen
On 05/28/14 10:12, Mark Brown wrote:
On Wed, May 28, 2014 at 05:16:46PM +0200, Uwe Kleine-König wrote:
On Tue, May 27, 2014 at 02:40:15PM -0700, Stephen Boyd wrote:
On 05/24/14 05:48, Mark Brown wrote:
So, according to the datasheet I managed to find this device has a
supply VDD_IO (so
On Wed, May 28, 2014 at 12:44:35PM -0700, Stephen Boyd wrote:
On 05/28/14 10:12, Mark Brown wrote:
If the supply must always be physically present the bindings should be
specified as it being mandatory and the code written in that fashion; as
an extension Linux will put a dummy in but this
We shouldn't be using regulator_get_optional() here. These
regulators are always present as part of the physical design and
there isn't any way to use an internal regulator or change the
source of the reference voltage via software. Given that the only
users of this driver in the kernel are DT
On Wed, May 28, 2014 at 01:27:23PM -0500, Kumar Gala wrote:
* Move SoC peripherals into an SoC container node
* Move serial enabling into board file (qcom-msm8960-cdp.dts)
* Cleanup cpu node to match binding spec, enable-method and compatible
should be per cpu, not part of the container
*
On May 28, 2014, at 3:09 PM, Josh Cartwright jo...@codeaurora.org wrote:
On Wed, May 28, 2014 at 01:27:23PM -0500, Kumar Gala wrote:
* Move SoC peripherals into an SoC container node
* Move serial enabling into board file (qcom-msm8960-cdp.dts)
* Cleanup cpu node to match binding spec,
On Wed, May 28, 2014 at 01:11:12PM -0700, Stephen Boyd wrote:
We shouldn't be using regulator_get_optional() here. These
regulators are always present as part of the physical design and
there isn't any way to use an internal regulator or change the
source of the reference voltage via software.
49 matches
Mail list logo
