Re: [PATCH v4 3/5] PCI: qcom: Add Qualcomm PCIe controller driver

Hi Stan, On Tue, Dec 15, 2015 at 10:24:07AM +0200, Stanimir Varbanov wrote: > On 12/03/2015 03:35 PM, Stanimir Varbanov wrote: > > From: Stanimir Varbanov > > > > The PCIe driver reuse the Designware common code for host > > and MSI initialization, and also program the

Re: [2/2] ARM64: dts: qcom: Remove size elements from pmic reg properties

On Wed, Nov 25, 2015 at 02:27:37PM -0800, Stephen Boyd wrote: > The #size-cells for the pmics are 0, but we specify a size in the > reg property so that MPP and GPIO modules can figure out how many > pins there are. Now that we've done that by counting irqs, we can > remove the size elements in

Re: [PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

On Wed, Dec 16, 2015 at 05:27:48PM +0530, Archit Taneja wrote: > On 12/16/2015 02:45 PM, Boris Brezillon wrote: > >On Wed, 19 Aug 2015 10:19:03 +0530 > >Archit Taneja wrote: > >>+ return mtd_device_parse_register(mtd, NULL, , NULL, 0); > > > > return

Re: [v2,3/5] clk: qcom: Add MSM8996 Global Clock Control (GCC) driver

On Mon, Nov 30, 2015 at 05:31:40PM -0800, Stephen Boyd wrote: > Add support for the global clock controller found on MSM8996 > based devices. This should allow most non-multimedia device > drivers to probe and control their clocks. > > Signed-off-by: Stephen Boyd > > ---

Re: [PATCH] net: add Qualcomm IPC router

On Fri, Dec 11, 2015 at 09:41:59PM +0100, Bjorn Andersson wrote: > From: Courtney Cavin > > Add an implementation of Qualcomm's IPC router protocol, used to > communicate with service providing remote processors. > > Signed-off-by: Courtney Cavin

Re: [PATCH v4 3/5] PCI: qcom: Add Qualcomm PCIe controller driver

On Thu, Dec 03, 2015 at 03:35:22PM +0200, Stanimir Varbanov wrote: > From: Stanimir Varbanov > > The PCIe driver reuse the Designware common code for host > and MSI initialization, and also program the Qualcomm > application specific registers. > > Signed-off-by: Stanimir

Re: [PATCH] net: add Qualcomm IPC router

On Tue, Dec 15, 2015 at 10:01:14PM +0100, David Miller wrote: > From: Bjorn Andersson > Date: Fri, 11 Dec 2015 12:41:59 -0800 > > > +static unsigned int qrtr_local_nid = 1; > > +module_param_named(node_id, qrtr_local_nid, uint, S_IRUGO); > >

Re: [PATCH] net: add Qualcomm IPC router

From: Courtney Cavin Date: Wed, 16 Dec 2015 16:01:41 -0800 > We could hardcode the value in kconfig, but that seems like a worse > solution than a module parameter. > > I'm open to further suggestions. No module parameters, configure it via netlink or similar at

Re: [PATCH v2] mmc: sdhci-msm: Boost controller core clock

On 16 December 2015 at 12:44, Ivan T. Ivanov wrote: > >> On Dec 16, 2015, at 12:18 PM, Ulf Hansson wrote: >> >> [...] >> It seems like a reasonable assumption that the controller can't cope with a higher clock rate than 100 MHz as "input"

Re: [PATCH v2] mmc: sdhci-msm: Boost controller core clock

> On Dec 16, 2015, at 12:18 PM, Ulf Hansson wrote: > > [...] > >>> It seems like a reasonable assumption that the controller can't cope >>> with a higher clock rate than 100 MHz as "input" clock. That would >>> then mean that there are different versions of the

Re: [PATCH v4 1/3] dt-binding: power: Add otg regulator binding

On Wed, Dec 16, 2015 at 12:13:50AM +0100, Sebastian Reichel wrote: > On Tue, Dec 15, 2015 at 11:52:10AM -0800, Tim Bird wrote: > > Add a binding for the regulator which controls the OTG chargepath switch. > > The OTG switch gets its power from pm8941_5vs1, and that should be > > expressed as a

Re: [PATCH RFC 06/27] PM / Domains: add debugfs 'states' and 'timings' seq files

On 16/12/2015 13:48, Ulf Hansson wrote: [...] A general comment. Static functions in genpd shall start with one of the following prefix. genpd_* _genpd_* __genpd_* Please change accordingly. Many static routines were already prefixed like the exported functions with "pm_", shall I make a

Re: [PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

On Wed, 16 Dec 2015 17:27:48 +0530 Archit Taneja wrote: > >> +/* > >> + * NAND controller page layout info > >> + * > >> + * |---||-| > >> + * | xx...xx| | *xx...xx|

Re: [PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

Hi Boris, On 12/16/2015 02:45 PM, Boris Brezillon wrote: Hi Archit, Again, sorry for the late review. It's probably not exhaustive but points a few things that should be fixed. Thanks for the thorough review! Some comments below. On Wed, 19 Aug 2015 10:19:03 +0530 Archit Taneja

Re: [PATCH RFC 06/27] PM / Domains: add debugfs 'states' and 'timings' seq files

[...] >> >> A general comment. Static functions in genpd shall start with one of >> the following prefix. >> >> genpd_* >> _genpd_* >> __genpd_* >> >> Please change accordingly. > > > Many static routines were already prefixed like the exported functions with > "pm_", shall I make a separate

Re: [PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

Hi Archit, Again, sorry for the late review. It's probably not exhaustive but points a few things that should be fixed. On Wed, 19 Aug 2015 10:19:03 +0530 Archit Taneja wrote: > The Qualcomm NAND controller is found in SoCs like IPQ806x, MSM7xx, > MDM9x15 series. > >

Re: [PATCH v4 3/5] dt/bindings: qcom_nandc: Add DT bindings

Hi Boris, On 12/16/2015 12:03 PM, Boris Brezillon wrote: Hi Archit, Sorry for the late review, but there are a few things I think should be addressed. On Wed, 19 Aug 2015 10:19:04 +0530 Archit Taneja wrote: Add DT bindings document for the Qualcomm NAND controller

Re: [PATCH v2] mmc: sdhci-msm: Boost controller core clock

[...] >> It seems like a reasonable assumption that the controller can't cope >> with a higher clock rate than 100 MHz as "input" clock. That would >> then mean that there are different versions of the controller, as it >> seems like for some version it's fine with 200MHz and for some 100MHz. >>