Re: [PATCH] tty: serial: msm_serial.c: Cleaning up uninitialized variables

2014-06-02 Thread Daniel Thompson 
On 01/06/14 14:38, Rickard Strandqvist wrote:
 There is a risk that the variable will be used without being initialized.
 
 This was largely found by using a static code analysis program called 
 cppcheck.
 
 Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se
 ---
  drivers/tty/serial/msm_serial.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c
 index 053b98e..c67f5c5 100644
 --- a/drivers/tty/serial/msm_serial.c
 +++ b/drivers/tty/serial/msm_serial.c
 @@ -962,7 +962,7 @@ static int __init msm_console_setup(struct console *co, 
 char *options)
  {
   struct uart_port *port;
   struct msm_port *msm_port;
 - int baud, flow, bits, parity;
 + int baud = 0, flow, bits, parity;

This made me wonder my baud is special compared to the other three
variables. In fact I don't really think it is special so setting baud
from the else clause in the uninitialized branch makes more sense to me.




--
To unsubscribe from this list: send the line unsubscribe linux-arm-msm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] tty: serial: msm_serial.c: Cleaning up uninitialized variables

2014-06-02 Thread dwalker 
On Sun, Jun 01, 2014 at 03:38:24PM +0200, Rickard Strandqvist wrote:
 There is a risk that the variable will be used without being initialized.
 
 This was largely found by using a static code analysis program called 
 cppcheck.
 
 Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se
 ---
  drivers/tty/serial/msm_serial.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c
 index 053b98e..c67f5c5 100644
 --- a/drivers/tty/serial/msm_serial.c
 +++ b/drivers/tty/serial/msm_serial.c
 @@ -962,7 +962,7 @@ static int __init msm_console_setup(struct console *co, 
 char *options)
  {
   struct uart_port *port;
   struct msm_port *msm_port;
 - int baud, flow, bits, parity;
 + int baud = 0, flow, bits, parity;
  

It looks valid .. We might want to just set it to 115200 which is what your 
change eventually does later in
the code.

Daniel
--
To unsubscribe from this list: send the line unsubscribe linux-arm-msm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] tty: serial: msm_serial.c: Cleaning up uninitialized variables

2014-06-01 Thread Rickard Strandqvist 
There is a risk that the variable will be used without being initialized.

This was largely found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se
---
 drivers/tty/serial/msm_serial.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c
index 053b98e..c67f5c5 100644
--- a/drivers/tty/serial/msm_serial.c
+++ b/drivers/tty/serial/msm_serial.c
@@ -962,7 +962,7 @@ static int __init msm_console_setup(struct console *co, 
char *options)
 {
struct uart_port *port;
struct msm_port *msm_port;
-   int baud, flow, bits, parity;
+   int baud = 0, flow, bits, parity;
 
if (unlikely(co-index = UART_NR || co-index  0))
return -ENXIO;
-- 
1.7.10.4

--
To unsubscribe from this list: send the line unsubscribe linux-arm-msm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html