Re: [PATCH 3/5] drm/i2c: adv7511: Refactor encoder slave functions

2015-12-03 Thread Laurent Pinchart
Hi Rob, On Thursday 03 December 2015 10:55:12 Rob Clark wrote: > On Thu, Dec 3, 2015 at 10:28 AM, Laurent Pinchart wrote: > > On Thursday 03 December 2015 10:02:02 Rob Clark wrote: > >> On Mon, Jul 27, 2015 at 4:59 AM, Laurent Pinchart wrote: > >>> On Monday 27 July 2015 11:46:57 Archit Taneja

Re: [PATCH 3/5] drm/i2c: adv7511: Refactor encoder slave functions

2015-12-03 Thread Rob Clark
On Thu, Dec 3, 2015 at 10:28 AM, Laurent Pinchart wrote: > On Thursday 03 December 2015 10:02:02 Rob Clark wrote: >> On Mon, Jul 27, 2015 at 4:59 AM, Laurent Pinchart wrote: >> > On Monday 27 July 2015 11:46:57 Archit Taneja wrote: >> >> ADV7511 is represented

Re: [PATCH 3/5] drm/i2c: adv7511: Refactor encoder slave functions

2015-12-03 Thread Laurent Pinchart
On Thursday 03 December 2015 10:02:02 Rob Clark wrote: > On Mon, Jul 27, 2015 at 4:59 AM, Laurent Pinchart wrote: > > On Monday 27 July 2015 11:46:57 Archit Taneja wrote: > >> ADV7511 is represented as an i2c drm slave encoder device. ADV7533, on > >> the other hand, is going be a normal i2c

Re: [PATCH 3/5] drm/i2c: adv7511: Refactor encoder slave functions

2015-12-03 Thread Archit Taneja
On 12/3/2015 9:25 PM, Rob Clark wrote: On Thu, Dec 3, 2015 at 10:28 AM, Laurent Pinchart wrote: On Thursday 03 December 2015 10:02:02 Rob Clark wrote: On Mon, Jul 27, 2015 at 4:59 AM, Laurent Pinchart wrote: On Monday 27 July 2015 11:46:57 Archit Taneja

Re: [PATCH 3/5] drm/i2c: adv7511: Refactor encoder slave functions

2015-12-03 Thread Rob Clark
On Mon, Jul 27, 2015 at 4:59 AM, Laurent Pinchart wrote: > Hi Archit, > > (CC'ing Boris Brezillon) > > Thank you for the patch. > > On Monday 27 July 2015 11:46:57 Archit Taneja wrote: >> ADV7511 is represented as an i2c drm slave encoder device. ADV7533, on >>

Re: [PATCH 3/5] drm/i2c: adv7511: Refactor encoder slave functions

2015-09-02 Thread Archit Taneja
On 08/04/2015 05:54 PM, Rob Clark wrote: On Tue, Aug 4, 2015 at 1:16 AM, Andrzej Hajda wrote: On 08/03/2015 04:04 PM, Rob Clark wrote: On Mon, Aug 3, 2015 at 8:03 AM, Andrzej Hajda wrote: Hi, On 07/31/2015 04:48 PM, Rob Clark wrote: On Fri, Jul

Re: [PATCH 3/5] drm/i2c: adv7511: Refactor encoder slave functions

2015-08-04 Thread Rob Clark
On Tue, Aug 4, 2015 at 1:16 AM, Andrzej Hajda a.ha...@samsung.com wrote: On 08/03/2015 04:04 PM, Rob Clark wrote: On Mon, Aug 3, 2015 at 8:03 AM, Andrzej Hajda a.ha...@samsung.com wrote: Hi, On 07/31/2015 04:48 PM, Rob Clark wrote: On Fri, Jul 31, 2015 at 8:58 AM, Boris Brezillon

Re: [PATCH 3/5] drm/i2c: adv7511: Refactor encoder slave functions

2015-08-03 Thread Andrzej Hajda
On 08/03/2015 04:04 PM, Rob Clark wrote: On Mon, Aug 3, 2015 at 8:03 AM, Andrzej Hajda a.ha...@samsung.com wrote: Hi, On 07/31/2015 04:48 PM, Rob Clark wrote: On Fri, Jul 31, 2015 at 8:58 AM, Boris Brezillon boris.brezil...@free-electrons.com wrote: Hi Rob, On Fri, 31 Jul 2015 08:13:59

Re: [PATCH 3/5] drm/i2c: adv7511: Refactor encoder slave functions

2015-08-03 Thread Andrzej Hajda
Hi, On 07/31/2015 04:48 PM, Rob Clark wrote: On Fri, Jul 31, 2015 at 8:58 AM, Boris Brezillon boris.brezil...@free-electrons.com wrote: Hi Rob, On Fri, 31 Jul 2015 08:13:59 -0400 Rob Clark robdcl...@gmail.com wrote: (...) Another problem I've seen with some drm bridge drivers is that

Re: [PATCH 3/5] drm/i2c: adv7511: Refactor encoder slave functions

2015-08-03 Thread Rob Clark
On Mon, Aug 3, 2015 at 8:03 AM, Andrzej Hajda a.ha...@samsung.com wrote: Hi, On 07/31/2015 04:48 PM, Rob Clark wrote: On Fri, Jul 31, 2015 at 8:58 AM, Boris Brezillon boris.brezil...@free-electrons.com wrote: Hi Rob, On Fri, 31 Jul 2015 08:13:59 -0400 Rob Clark robdcl...@gmail.com wrote:

Re: [PATCH 3/5] drm/i2c: adv7511: Refactor encoder slave functions

2015-07-31 Thread Rob Clark
On Fri, Jul 31, 2015 at 8:58 AM, Boris Brezillon boris.brezil...@free-electrons.com wrote: Hi Rob, On Fri, 31 Jul 2015 08:13:59 -0400 Rob Clark robdcl...@gmail.com wrote: I went through the branch you shared. From what I understood, the encoder chain comprises of one 'real' encoder

Re: [PATCH 3/5] drm/i2c: adv7511: Refactor encoder slave functions

2015-07-31 Thread Rob Clark
On Fri, Jul 31, 2015 at 5:12 AM, Boris Brezillon boris.brezil...@free-electrons.com wrote: Hi Archit, On Fri, 31 Jul 2015 10:56:20 +0530 Archit Taneja arch...@codeaurora.org wrote: Hi Boris, Laurent, On 07/28/2015 08:08 PM, Boris Brezillon wrote: Archit, Laurent, On Tue, 28 Jul 2015

Re: [PATCH 3/5] drm/i2c: adv7511: Refactor encoder slave functions

2015-07-31 Thread Boris Brezillon
Hi Rob, On Fri, 31 Jul 2015 08:13:59 -0400 Rob Clark robdcl...@gmail.com wrote: I went through the branch you shared. From what I understood, the encoder chain comprises of one 'real' encoder object (drm_encoder) in the 'drm_encoder_chain' struct. This drm_encoder encapsulates all the

Re: [PATCH 3/5] drm/i2c: adv7511: Refactor encoder slave functions

2015-07-31 Thread Boris Brezillon
Hi Archit, On Fri, 31 Jul 2015 10:56:20 +0530 Archit Taneja arch...@codeaurora.org wrote: Hi Boris, Laurent, On 07/28/2015 08:08 PM, Boris Brezillon wrote: Archit, Laurent, On Tue, 28 Jul 2015 13:47:37 +0530 Archit Taneja arch...@codeaurora.org wrote: Hi, On 07/27/2015 02:29

Re: [PATCH 3/5] drm/i2c: adv7511: Refactor encoder slave functions

2015-07-31 Thread Archit Taneja
On 07/31/2015 02:42 PM, Boris Brezillon wrote: Hi Archit, On Fri, 31 Jul 2015 10:56:20 +0530 Archit Taneja arch...@codeaurora.org wrote: Hi Boris, Laurent, On 07/28/2015 08:08 PM, Boris Brezillon wrote: Archit, Laurent, On Tue, 28 Jul 2015 13:47:37 +0530 Archit Taneja

Re: [PATCH 3/5] drm/i2c: adv7511: Refactor encoder slave functions

2015-07-30 Thread Archit Taneja
Hi Boris, Laurent, On 07/28/2015 08:08 PM, Boris Brezillon wrote: Archit, Laurent, On Tue, 28 Jul 2015 13:47:37 +0530 Archit Taneja arch...@codeaurora.org wrote: Hi, On 07/27/2015 02:29 PM, Laurent Pinchart wrote: Hi Archit, (CC'ing Boris Brezillon) Thank you for the patch. On Monday 27

Re: [PATCH 3/5] drm/i2c: adv7511: Refactor encoder slave functions

2015-07-28 Thread Archit Taneja
Hi, On 07/27/2015 02:29 PM, Laurent Pinchart wrote: Hi Archit, (CC'ing Boris Brezillon) Thank you for the patch. On Monday 27 July 2015 11:46:57 Archit Taneja wrote: ADV7511 is represented as an i2c drm slave encoder device. ADV7533, on the other hand, is going be a normal i2c client device

Re: [PATCH 3/5] drm/i2c: adv7511: Refactor encoder slave functions

2015-07-28 Thread Boris Brezillon
Archit, Laurent, On Tue, 28 Jul 2015 13:47:37 +0530 Archit Taneja arch...@codeaurora.org wrote: Hi, On 07/27/2015 02:29 PM, Laurent Pinchart wrote: Hi Archit, (CC'ing Boris Brezillon) Thank you for the patch. On Monday 27 July 2015 11:46:57 Archit Taneja wrote: ADV7511 is

Re: [PATCH 3/5] drm/i2c: adv7511: Refactor encoder slave functions

2015-07-27 Thread Laurent Pinchart
Hi Archit, (CC'ing Boris Brezillon) Thank you for the patch. On Monday 27 July 2015 11:46:57 Archit Taneja wrote: ADV7511 is represented as an i2c drm slave encoder device. ADV7533, on the other hand, is going be a normal i2c client device creating bridge and connector entities. Please, no.