Re: [PATCH v6 04/13] clk: qcom: gdsc: Manage clocks with !CONFIG_PM

2015-07-29 Thread Rajendra Nayak
On 07/29, Rajendra Nayak wrote: On 07/29/2015 06:34 AM, Stephen Boyd wrote: Sorry, I read the thread and I tried to understand what was going on but I'm still lost. Can you clarify further in the commit text somehow? So I can add this in the commit text, if it seems fine The use of

Re: [PATCH v6 04/13] clk: qcom: gdsc: Manage clocks with !CONFIG_PM

2015-07-29 Thread Stephen Boyd
On 07/29, Rajendra Nayak wrote: On 07/29/2015 06:34 AM, Stephen Boyd wrote: Sorry, I read the thread and I tried to understand what was going on but I'm still lost. Can you clarify further in the commit text somehow? So I can add this in the commit text, if it seems fine The use of

Re: [PATCH v6 04/13] clk: qcom: gdsc: Manage clocks with !CONFIG_PM

2015-07-28 Thread Stephen Boyd
On 07/23/2015 01:35 AM, Rajendra Nayak wrote: [].. + +#ifndef CONFIG_PM +static void enable_clock(struct device *dev, const char *con_id) +{ +struct clk *clk; + +clk = clk_get(dev, con_id); +if (!IS_ERR(clk)) { +clk_prepare_enable(clk); +clk_put(clk); +} +} +

Re: [PATCH v6 04/13] clk: qcom: gdsc: Manage clocks with !CONFIG_PM

2015-07-28 Thread Rajendra Nayak
On 07/29/2015 06:34 AM, Stephen Boyd wrote: On 07/23/2015 01:35 AM, Rajendra Nayak wrote: [].. + +#ifndef CONFIG_PM +static void enable_clock(struct device *dev, const char *con_id) +{ +struct clk *clk; + +clk = clk_get(dev, con_id); +if (!IS_ERR(clk)) { +

Re: [PATCH v6 04/13] clk: qcom: gdsc: Manage clocks with !CONFIG_PM

2015-07-23 Thread Rajendra Nayak
[].. + +#ifndef CONFIG_PM +static void enable_clock(struct device *dev, const char *con_id) +{ +struct clk *clk; + +clk = clk_get(dev, con_id); +if (!IS_ERR(clk)) { +clk_prepare_enable(clk); +clk_put(clk); +} +} + +static void disable_clock(struct device *dev,

Re: [PATCH v6 04/13] clk: qcom: gdsc: Manage clocks with !CONFIG_PM

2015-07-22 Thread Stephen Boyd
On 07/22/2015 12:11 AM, Rajendra Nayak wrote: With CONFIG_PM disabled, turn the devices clocks on during driver binding to the device, and turn them off when the driver is unbound from the device. Signed-off-by: Rajendra Nayak rna...@codeaurora.org --- drivers/clk/qcom/gdsc.c | 59