[PATCH] block: Remove leading whitespace and trailing newline in elevator switch error message

2017-05-05 Thread mar...@trippelsdorf.de
Trying to switch to a non-existing elevator currently results in garbled dmesg output, e.g.: # echo " foo" > /sys/block/sda/queue/scheduler elevator: type foo not found elevator: switch to foo failed (note the leading whitespace and unintended line break.) Fix by removing the leading w

Re: [PATCH v2 cosmetic] Remove trailing newline in elevator switch error message

2017-05-05 Thread mar...@trippelsdorf.de
On 2017.05.05 at 20:05 +, Bart Van Assche wrote: > On Mon, 2017-05-01 at 18:29 +0200, mar...@trippelsdorf.de wrote: > > + strlcpy(elevator_name, name, sizeof(elevator_name)); > > + strstrip(elevator_name); > > + ret = __elevator_change(q, elevator_name); > > > Are you aware that the cur

[GIT PULL] Block changes for 4.12-rc1

2017-05-05 Thread Jens Axboe
Hi Linus, Some fixes and followup features/changes that should go in, in this merge window. This pull request contains: - Two fixes for lightnvm from Javier, fixing problems in the new code merge previously in this merge window. - A fix from Jan for the backing device changes, fixing an issue

RE: [PATCH v2] x86, uaccess: introduce copy_from_iter_wt for pmem / writethrough operations

2017-05-05 Thread Kani, Toshimitsu
> On Fri, May 5, 2017 at 3:44 PM, Kani, Toshimitsu > wrote: > > On Fri, 2017-05-05 at 15:25 -0700, Dan Williams wrote: > >> On Fri, May 5, 2017 at 1:39 PM, Kani, Toshimitsu > >> wrote: > > : > >> > > --- > >> > > Changes since the initial RFC: > >> > > * s/writethru/wt/ since we already have ior

[PATCH] nbd: ignore non-nbd ioctl's

2017-05-05 Thread Josef Bacik
In testing we noticed that nbd would spew if you ran a fio job against the raw device itself. This is because fio calls a block device specific ioctl, however the block layer will first pass this back to the driver ioctl handler in case the driver wants to do something special. Since the device wa

Re: [PATCH v2] x86, uaccess: introduce copy_from_iter_wt for pmem / writethrough operations

2017-05-05 Thread Dan Williams
On Fri, May 5, 2017 at 3:44 PM, Kani, Toshimitsu wrote: > On Fri, 2017-05-05 at 15:25 -0700, Dan Williams wrote: >> On Fri, May 5, 2017 at 1:39 PM, Kani, Toshimitsu >> wrote: > : >> > > --- >> > > Changes since the initial RFC: >> > > * s/writethru/wt/ since we already have ioremap_wt(), >> > >

[RFC PATCH] blk-mq: release sched tag just after getting driver tag

2017-05-05 Thread Ming Lei
In theory sched tag is used just for scheduling, and its lifetime should have been over just after rq is transfered to dispatch queue. Unfortunately the rq itself is allocated from tag set of .sched_tags, so we can't do that simply. In this way, scheduler will have a independent queue depth, and d

Re: [PATCH 1/4] blk-mq: introduce BLK_MQ_F_SCHED_USE_HW_TAG

2017-05-05 Thread Ming Lei
On Sat, May 06, 2017 at 06:54:09AM +0800, Ming Lei wrote: > On Thu, May 04, 2017 at 08:06:15AM -0600, Jens Axboe wrote: > > On 05/03/2017 08:51 PM, Ming Lei wrote: > > > On Wed, May 03, 2017 at 08:13:03PM -0600, Jens Axboe wrote: > > >> On 05/03/2017 08:01 PM, Ming Lei wrote: > > >>> On Thu, May 4,

Re: [PATCH 1/4] blk-mq: introduce BLK_MQ_F_SCHED_USE_HW_TAG

2017-05-05 Thread Ming Lei
On Thu, May 04, 2017 at 08:06:15AM -0600, Jens Axboe wrote: > On 05/03/2017 08:51 PM, Ming Lei wrote: > > On Wed, May 03, 2017 at 08:13:03PM -0600, Jens Axboe wrote: > >> On 05/03/2017 08:01 PM, Ming Lei wrote: > >>> On Thu, May 4, 2017 at 5:40 AM, Omar Sandoval wrote: > On Thu, May 04, 2017

Re: [PATCH v2] x86, uaccess: introduce copy_from_iter_wt for pmem / writethrough operations

2017-05-05 Thread Kani, Toshimitsu
On Fri, 2017-05-05 at 15:25 -0700, Dan Williams wrote: > On Fri, May 5, 2017 at 1:39 PM, Kani, Toshimitsu > wrote: : > > > --- > > > Changes since the initial RFC: > > > * s/writethru/wt/ since we already have ioremap_wt(), > > > set_memory_wt(), etc. (Ingo) > > > > Sorry I should have said earl

Re: [PATCH v2] x86, uaccess: introduce copy_from_iter_wt for pmem / writethrough operations

2017-05-05 Thread Dan Williams
On Fri, May 5, 2017 at 1:39 PM, Kani, Toshimitsu wrote: > On Fri, 2017-04-28 at 12:39 -0700, Dan Williams wrote: >> The pmem driver has a need to transfer data with a persistent memory >> destination and be able to rely on the fact that the destination >> writes are not cached. It is sufficient fo

[GIT PULL] libnvdimm for 4.12

2017-05-05 Thread Williams, Dan J
Hi Linus, please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm tags/libnvdimm-for-4.12 ...to receive the libnvdimm update for 4.12. The bulk of this has been in multiple -next releases. There were a few late breaking fixes and small features that got added in the last

Re: [PATCH v2] x86, uaccess: introduce copy_from_iter_wt for pmem / writethrough operations

2017-05-05 Thread Kani, Toshimitsu
On Fri, 2017-04-28 at 12:39 -0700, Dan Williams wrote: > The pmem driver has a need to transfer data with a persistent memory > destination and be able to rely on the fact that the destination > writes are not cached. It is sufficient for the writes to be flushed > to a cpu-store-buffer (non-tempor

Re: [PATCH v2 cosmetic] Remove trailing newline in elevator switch error message

2017-05-05 Thread Bart Van Assche
On Mon, 2017-05-01 at 18:29 +0200, mar...@trippelsdorf.de wrote: > + strlcpy(elevator_name, name, sizeof(elevator_name)); > + strstrip(elevator_name); > + ret = __elevator_change(q, elevator_name); Hello Markus, Are you aware that the current implementation of __elevator_change() stri

Re: [PATCH] block-mq: set both block queue and hardware queue restart bit for restart

2017-05-05 Thread Bart Van Assche
On Fri, 2017-05-05 at 08:58 +, Long Li wrote: > > > From: Bart Van Assche [mailto:bart.vanass...@sandisk.com] > > > > > > Can you repeat your test with kernel v4.11-rc6? > > > The patches that went into the block layer for v4.11-rc6 should be > > > sufficient to fix this: [ ... ] > > Testing

Re: [PATCH v2] x86, uaccess: introduce copy_from_iter_wt for pmem / writethrough operations

2017-05-05 Thread Dan Williams
On Thu, May 4, 2017 at 11:54 PM, Ingo Molnar wrote: > > * Dan Williams wrote: > >> The pmem driver has a need to transfer data with a persistent memory >> destination and be able to rely on the fact that the destination writes >> are not cached. It is sufficient for the writes to be flushed to a

Re: [linux-next][bock] WARNING: CPU: 22 PID: 0 at block/blk-core.c:2655 .blk_update_request+0x4f8/0x500

2017-05-05 Thread Jens Axboe
On 05/05/2017 12:25 AM, Abdul Haleem wrote: > Hi, > > 4.11.0 Linus mainline booted with Warnings on PowerPC. > > We did not see this on next-20170407 but on next-20170410 and later. Have you tried current Linus -git? Both of the -next versions you list are rather old. -- Jens Axboe

RE: [PATCH] block-mq: set both block queue and hardware queue restart bit for restart

2017-05-05 Thread Long Li
> -Original Message- > From: linux-block-ow...@vger.kernel.org [mailto:linux-block- > ow...@vger.kernel.org] On Behalf Of Long Li > Sent: Friday, April 14, 2017 1:12 AM > To: Bart Van Assche ; linux- > ker...@vger.kernel.org; linux-block@vger.kernel.org; KY Srinivasan > ; ax...@kernel.dk

Re: remove REQ_OP_WRITE_SAME

2017-05-05 Thread Christoph Hellwig
On Thu, Apr 13, 2017 at 10:23:10PM -0400, Martin K. Petersen wrote: > The other thing that keeps me a bit on the fence is that a bunch of the > plumbing to handle a bio with a payload different from bi_size is needed > for the copy offload token. I'm hoping to have those patches ready for > 4.13. R