On Wed, May 31, 2017 at 08:45:23AM -0400, Jeff Layton wrote:
> v5: don't retrofit old API over the new infrastructure
> add fstype flag to indicate how wb errors are tracked within that fs
> add more function variants that take a errseq_t "since" value
> add second errseq_t to struct fi
On Thu, Jun 01, 2017 at 08:55:12AM -0700, Bart Van Assche wrote:
> Requests that got stuck in a block driver are neither on
> blk_mq_ctx.rq_list nor on any hw dispatch queue. Make these
> visible in debugfs through the "busy" attribute.
>
> Signed-off-by: Bart Van Assche
> Cc: Christoph Hellwig
On Thu, Jun 01, 2017 at 11:19:11PM +, Bart Van Assche wrote:
> On Thu, 2017-06-01 at 10:21 +0800, Ming Lei wrote:
> > On Wed, May 31, 2017 at 03:37:30PM +, Bart Van Assche wrote:
> > > On Wed, 2017-05-31 at 20:37 +0800, Ming Lei wrote:
> > > >
> > > > + /* wait until queue is unquies
On Thu, Jun 01, 2017 at 11:09:00PM +, Bart Van Assche wrote:
> On Thu, 2017-06-01 at 08:54 +0800, Ming Lei wrote:
> > On Wed, May 31, 2017 at 03:21:41PM +, Bart Van Assche wrote:
> > > On Wed, 2017-05-31 at 20:37 +0800, Ming Lei wrote:
> > > > diff --git a/drivers/scsi/scsi_lib.c b/drivers/
On Thu, 2017-06-01 at 10:21 +0800, Ming Lei wrote:
> On Wed, May 31, 2017 at 03:37:30PM +, Bart Van Assche wrote:
> > On Wed, 2017-05-31 at 20:37 +0800, Ming Lei wrote:
> > >
> > > + /* wait until queue is unquiesced */
> > > + wait_event_cmd(q->quiesce_wq, !blk_queue_quiesced(q),
> > > +
On Thu, 2017-06-01 at 08:54 +0800, Ming Lei wrote:
> On Wed, May 31, 2017 at 03:21:41PM +, Bart Van Assche wrote:
> > On Wed, 2017-05-31 at 20:37 +0800, Ming Lei wrote:
> > > diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> > > index 99e16ac479e3..ffcf05765e2b 100644
> > > --- a
On 06/01/2017 12:17 PM, Bart Van Assche wrote:
> On Thu, 2017-06-01 at 12:06 -0700, Jens Axboe wrote:
>> On 06/01/2017 06:11 AM, Bart Van Assche wrote:
>>> On Thu, 2017-06-01 at 08:08 +0200, Christoph Hellwig wrote:
On Wed, May 31, 2017 at 03:52:46PM -0700, Bart Van Assche wrote:
> Commit
On Thu, 2017-06-01 at 12:06 -0700, Jens Axboe wrote:
> On 06/01/2017 06:11 AM, Bart Van Assche wrote:
> > On Thu, 2017-06-01 at 08:08 +0200, Christoph Hellwig wrote:
> > > On Wed, May 31, 2017 at 03:52:46PM -0700, Bart Van Assche wrote:
> > > > Commit 6d247d7f71d1 ("block: allow specifying size for
On Thu, Jun 01, 2017 at 01:02:40PM +0800, Joseph Qi wrote:
> From: Joseph Qi
>
> If error occurs, we have to free the allocated callback in
> blk_mq_init_allocated_queue to avoid memory leaking.
Nak. If blk_mq_init_allocated_queue() fails, we call blk_cleanup_queue()
which will do this.
On 05/31/2017 02:43 PM, Bart Van Assche wrote:
> Hello Jens,
>
> The patches in this series are a sequel of Christoph's "Split scsi passthrough
> fields out of struct request" patch series. The changes compared to v1 of this
> patch series are:
> - Renamed QUEUE_FLAG_SCSI_PDU into QUEUE_FLAG_SCSI_
On 05/31/2017 02:43 PM, Bart Van Assche wrote:
> Since the introduction of .init_rq_fn() and .exit_rq_fn() it is
> essential that the memory allocated for struct request_queue
> stays around until all blk_exit_rl() calls have finished. Hence
> make blk_init_rl() take a reference on struct request_q
On 06/01/2017 06:11 AM, Bart Van Assche wrote:
> On Thu, 2017-06-01 at 08:08 +0200, Christoph Hellwig wrote:
>> On Wed, May 31, 2017 at 03:52:46PM -0700, Bart Van Assche wrote:
>>> Commit 6d247d7f71d1 ("block: allow specifying size for extra command
>>> data") added support for .cmd_size to blk-sq.
On 05/31/2017 11:08 PM, Christoph Hellwig wrote:
> On Wed, May 31, 2017 at 03:52:46PM -0700, Bart Van Assche wrote:
>> Commit 6d247d7f71d1 ("block: allow specifying size for extra command
>> data") added support for .cmd_size to blk-sq. Due to that patch the
>> blk_mq_rq_{to,from}_pdu() functions a
On 06/01/2017 08:55 AM, Bart Van Assche wrote:
> Hello Jens,
>
> This series contains four patches that add new features to the blk-mq-debugfs
> code. Please consider these patches for kernel v4.13.
>
> Thanks,
>
> Bart.
>
> Changes between v2 and v3:
> - Renamed a function in the patch that sh
On Thu, Jun 01, 2017 at 08:55:09AM -0700, Bart Van Assche wrote:
> Hello Jens,
>
> This series contains four patches that add new features to the blk-mq-debugfs
> code. Please consider these patches for kernel v4.13.
>
> Thanks,
>
> Bart.
>
> Changes between v2 and v3:
> - Renamed a function in
When analyzing e.g. queue lockups it is important to know whether
or not a request has already been started. Hence also show the
atomic request flags.
Signed-off-by: Bart Van Assche
Reviewed-by: Hannes Reinecke
Reviewed-by: Ming Lei
Cc: Omar Sandoval
Cc: Christoph Hellwig
---
block/blk-mq-de
Requests that got stuck in a block driver are neither on
blk_mq_ctx.rq_list nor on any hw dispatch queue. Make these
visible in debugfs through the "busy" attribute.
Signed-off-by: Bart Van Assche
Cc: Christoph Hellwig
Cc: Hannes Reinecke
Cc: Omar Sandoval
Cc: Ming Lei
Cc: Eduardo Valentin
-
Hello Jens,
This series contains four patches that add new features to the blk-mq-debugfs
code. Please consider these patches for kernel v4.13.
Thanks,
Bart.
Changes between v2 and v3:
- Renamed a function in the patch that shows busy requests. In the same patch,
added a comment as requested
Running a queue causes the block layer to examine the per-CPU and
hw queues but not the requeue list. Hence add a 'kick' operation
that also examines the requeue list.
Signed-off-by: Bart Van Assche
Reviewed-by: Ming Lei
Cc: Christoph Hellwig
Cc: Hannes Reinecke
Cc: Omar Sandoval
---
block/b
When verifying whether or not a blk-mq driver forgot to kick the
requeue list after having requeued a request it is important to
be able to verify the contents of the requeue list. Hence export
that list through debugfs.
Signed-off-by: Bart Van Assche
Reviewed-by: Hannes Reinecke
Reviewed-by: Mi
On Thu, Jun 01, 2017 at 02:08:04PM +, Bart Van Assche wrote:
> The first eight patches in this series do not depend on any block layer
> changes.
> Do you want me to repost this patches or can you perhaps queue these without a
> repost?
It would be great if you could repost them, also for the
On Wed, 2017-05-24 at 22:04 -0400, Martin K. Petersen wrote:
> > This patch series consists of the bug fixes I came up with during the
> > past two months. Please consider these patches for kernel v4.13.
>
> No major objections from me. Although you may have to slice and dice the
> series differen
Feel free to add
Acked-by: J. Bruce Fields
if you need it.--b.
On Wed, May 31, 2017 at 02:43:50PM -0700, Bart Van Assche wrote:
> Since using scsi_req() is only allowed against request queues for
> which struct scsi_request is the first member of their private
> request data, refuse to
On Thu, 2017-06-01 at 08:08 +0200, Christoph Hellwig wrote:
> On Wed, May 31, 2017 at 03:52:46PM -0700, Bart Van Assche wrote:
> > Commit 6d247d7f71d1 ("block: allow specifying size for extra command
> > data") added support for .cmd_size to blk-sq. Due to that patch the
> > blk_mq_rq_{to,from}_pdu
24 matches
Mail list logo