ts to blk-mq for SCSI. For 4.14
> we'll plan to try again with these fixes.
>
> This reverts commit 5c279bd9e40624f4ab6e688671026d6005b066fa.
>
> Signed-off-by: Christoph Hellwig <h...@lst.de>Reviewed-by: Hannes Reinecke
> <h...@suse.com>
Cheers,
Hannes
--
Dr. Hanne
On 08/09/2017 04:10 PM, Christoph Hellwig wrote:
> On Mon, Aug 07, 2017 at 08:09:11AM +0200, Hannes Reinecke wrote:
>> On 08/05/2017 01:39 PM, Christoph Hellwig wrote:
>>> Can you use normal linux style for the code instead of copy and
>>> pasting the weird nam
On 08/09/2017 04:23 PM, Christoph Hellwig wrote:
> On Wed, Aug 02, 2017 at 04:13:24PM +0200, Hannes Reinecke wrote:
>> Hi all,
>>
>> as we're trying to get rid of the remaining request_fn drivers here's
>> a patchset to move the DAC960 driver to the SCSI stack.
>>
rmed on
> initiator side (and vice-versa). I confess I couldn't find such sync
> idea in NVMe over fabrics spec, though.
> Also, reading NVMe spec 1.3, we do have the optional feature
> "reservations", but seems it doesn't mention target (only multiple hosts).
>
See above.
Neve
roject. I made some changes, all errors are mine.
> You
> are more than welcomed to test and add new features!
>
Ah. But then why isn't he mentioned in the From: or Signed-off: lines?
Shouldn't he be getting some more credits than just 'William'?
(Unless William is in fact an alias for K
n a bit.
>
THX.
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
Not a real RAID level, but some HBAs support JBOD in addition to
the 'classical' RAID levels.
Signed-off-by: Hannes Reinecke <h...@suse.com>
---
drivers/scsi/raid_class.c | 1 +
include/linux/raid_class.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/scsi/raid_class.c b/d
Firmware) and Mylex AcceleRAID 170
(for V2 Firmware).
As usual, comments and reviews are welcome.
Hannes Reinecke (4):
raid_class: Add 'JBOD' RAID level
scsi: Add VENDOR_SPECIFIC sense code definitions
scsi: add Mylex RAID controller
block: Drop obsolete DAC960 driver
Documentation
Some older devices will return vendor specific sense codes, so
we should be adding a definition for it.
Signed-off-by: Hannes Reinecke <h...@suse.com>
---
include/scsi/scsi_proto.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/scsi/scsi_proto.h b/include/scsi/scsi_proto.h
for that, he talked about
> that back at LSFMM earlier this year. Hannes?
>
Oh, I do.
hpsa is working happily on SLES for _all_ SmartArray controllers.
You need to enable 'hpsa_allow_any=1', though.
But I'm perfectly happy with making that the default and drop cciss
completely.
Cheers,
Hanne
unmapped hardware queue.
>
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Reviewed-by: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Omar Sandoval <osan...@fb.com>
> Cc: Ming Lei <ming@redhat.com>
art Van Assche <bart.vanass...@sandisk.com>
> Reviewed-by: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Omar Sandoval <osan...@fb.com>
> Cc: Ming Lei <ming@redhat.com>
> ---
> block/blk-mq-sched.c | 2 ++
> block/blk-mq.c
ewed-by: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Omar Sandoval <osan...@fb.com>
> Cc: Ming Lei <ming@redhat.com>
> ---
> block/blk-core.c | 33 +++++
> block/blk.h | 2 ++
>
gt; Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Reviewed-by: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Omar Sandoval <osan...@fb.com>
> Cc: Ming Lei <ming@redhat.com>
> ---
> block/blk-core.c
ed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Omar Sandoval <osan...@fb.com>
> Cc: Ming Lei <ming@redhat.com>
> ---
> block/blk-mq.c | 3 ++-
> 1 file chang
ass...@sandisk.com>
> Reviewed-by: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Omar Sandoval <osan...@fb.com>
> Cc: Ming Lei <ming@redhat.com>
> ---
> include/linux/blkdev.h | 7 +++
> 1 file changed, 7 insertion
db499b8 ("block: split scsi_request out of struct
> request")
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Omar Sandoval <osan...@fb.com>
> Cc:
Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Omar Sandoval <osan...@fb.com>
> ---
> block/blk-core.c | 17 +
> include/linux/blk-mq.h | 2 ++
> include/linux/blkdev.h | 4
> 3 files changed, 19 i
ned int. Also because of
> consistency, rename that second argument from 'rw' into 'op'.
> This patch does not change any functionality.
>
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Reviewed-by: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke
unmapped hardware queue.
>
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Reviewed-by: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Omar Sandoval <osan...@fb.com>
> Cc: Ming Lei <ming@redhat.com>
On 06/20/2017 12:08 AM, Bart Van Assche wrote:
> From: Bart Van Assche <bart.vanass...@sandisk.com>
>
> The variable 'disk_type' is never modified so constify it.
>
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Reviewed-by: Christoph Hellwig <h
art Van Assche <bart.vanass...@sandisk.com>
> Reviewed-by: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Omar Sandoval <osan...@fb.com>
> Cc: Ming Lei <ming@redhat.com>
> ---
> block/blk-mq-sched.c | 2 ++
> block/blk-
ewed-by: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Omar Sandoval <osan...@fb.com>
> Cc: Ming Lei <ming@redhat.com>
> ---
> block/blk-core.c | 33 +
> block/blk.h | 2 ++
>
gt; Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Reviewed-by: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Omar Sandoval <osan...@fb.com>
> Cc: Ming Lei <ming@redhat.com>
> ---
> block/blk-core.c
ass...@sandisk.com>
> Reviewed-by: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Omar Sandoval <osan...@fb.com>
> Cc: Ming Lei <ming@redhat.com>
> ---
> include/linux/blkdev.h | 7 +++
> 1 file changed, 7 insertion
ed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Omar Sandoval <osan...@fb.com>
> Cc: Ming Lei <ming@redhat.com>
> ---
> block/blk-mq.c | 2 +-
> 1 file change
...@sandisk.com>
> Reviewed-by: Christoph Hellwig <h...@lst.de>
> Reviewed-by: Hannes Reinecke <h...@suse.com>
> Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com>
> ---
> block/scsi_ioctl.c| 10 +++---
> drivers/ide/ide-atapi.c
db499b8 ("block: split scsi_request out of struct
> request")
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Reviewed-by: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Omar Sandoval <
ons(+), 2 deletions(-)
>
Thanks for doing so. I had been missing this functionality for a long
time; now I can finally go ahead and convert the dasd driver :-)
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage
ng@redhat.com>
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Reviewed-by: Christoph Hellwig <h...@lst.de>
> Reviewed-by: Ming Lei <ming@redhat.com>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Omar Sandoval <osan...@fb.com>
>
tty massive change which
> cannot be added in an incremental fashion).
>
> Thoughts?
I very much prefer this solution, ie rejecting all commands if the queue
state is not 'LIVE', and make the 'connect' command the only one being
accepted in that state.
(Actually, we would need a state
blocksize.
Signed-off-by: Hannes Reinecke <h...@suse.com>
---
drivers/block/loop.c | 43 +--
drivers/block/loop.h | 1 +
include/uapi/linux/loop.h | 3 +++
3 files changed, 41 insertions(+), 6 deletions(-)
diff --git a/drivers/block/lo
Signed-off-by: Hannes Reinecke <h...@suse.de>
Reviewed-by: Christoph Hellwig <h...@lst.de>
---
drivers/block/loop.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 28d9329..fc706ad 100644
--- a/drivers/block/
review from Ming Lei
Changes to v7:
- Reset logical blocksize on loop_set_fd()
Hannes Reinecke (2):
loop: Remove unused 'bdev' argument from loop_set_capacity
loop: support 4k physical blocksize
drivers/block/loop.c | 47 +++
drivers/block/loop.h
through libata.
>
> Signed-off-by: Christoph Hellwig <h...@lst.de>
> ---
> drivers/scsi/sd.c | 44
> drivers/scsi/sd.h | 2 ++
> 2 files changed, 46 insertions(+)
>
Reviewed-by: Hannes Reinecke <h...@suse.
s/ata/libata-scsi.c | 76
> +++
> include/linux/ata.h | 1 +
> include/linux/libata.h| 1 +
> 4 files changed, 110 insertions(+)
> Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke
On 06/04/2017 02:42 PM, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <h...@lst.de>
> ---
> drivers/ata/libata-core.c | 59
> +--
> 1 file changed, 32 insertions(+), 27 deletions(-)
>
Reviewed-by: Hannes Reinecke
On 06/04/2017 02:42 PM, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <h...@lst.de>
> ---
> drivers/ata/libata-core.c | 10 +-
> include/linux/ata.h | 10 +++---
> 2 files changed, 12 insertions(+), 8 deletions(-)
>
Reviewed-by: Hannes
On 06/04/2017 02:42 PM, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <h...@lst.de>
> ---
> drivers/ata/libata-core.c | 59
> +--
> 1 file changed, 16 insertions(+), 43 deletions(-)
>
Reviewed-by: Hannes Reinecke
vers/ata/libata-eh.c | 64
> ---
> drivers/ata/libata.h | 4 +--
> 3 files changed, 66 insertions(+), 66 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke
gt;
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Omar Sandoval <osan...@fb.com>
> Cc: linux-block@vger.kernel.org
> ---
> drivers/cdrom/cdrom.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --gi
@sandisk.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Omar Sandoval <osan...@fb.com>
> Cc: Ming Lei <ming@redhat.com>
> ---
> block/blk-mq-debugfs.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
.vanass...@sandisk.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Omar Sandoval <osan...@fb.com>
> Cc: Ming Lei <ming@redhat.com>
> ---
> block/blk-mq-debugfs.c | 26 ++++++
> 1 file changed, 26 in
.vanass...@sandisk.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Omar Sandoval <osan...@fb.com>
> Cc: Ming Lei <ming@redhat.com>
> ---
> block/blk-mq-debugfs.c | 25 +
> 1 file changed, 25 ins
;
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Omar Sandoval <osan...@fb.com>
> Cc: Ming Lei <ming@redhat.com>
> ---
> block/blk-mq-debugfs.c | 32
Cc: Omar Sandoval <osan...@fb.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Ming Lei <ming@redhat.com>
> ---
> block/blk-mq-debugfs.c | 10 ++++++
> 1 file changed, 10 insertions(+)
>
Reviewed-by: Han
mq: untangle debugfs and sysfs")
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Cc: Omar Sandoval <osan...@fb.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Ming Lei <ming@redhat.com>
>
/scsi/xen-scsifront.c
> @@ -534,7 +534,6 @@ static int scsifront_queuecommand(struct Scsi_Host *shost,
> int err;
>
> sc->result = 0;
> - memset(shadow, 0, sizeof(*shadow));
>
> shadow->sc = sc;
> shadow->act = VSCSIIF_ACT_SCSI_CDB;
&
ar Baddela <sebad...@cisco.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> ---
> drivers/scsi/snic/snic_scsi.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/snic/snic_scsi.c b/drivers/scsi/snic/snic_
only assigns a tag to a request after
> a request has been started.
>
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Reviewed-by: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> ---
> drivers/scsi/scsi_error.c | 1
On 05/24/2017 02:34 AM, Bart Van Assche wrote:
> The only functional change is that this patch causes scsi_setup_fs_cmnd()
> to clear scsi_request.sense_len.
>
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Reviewed-by: Christoph Hellwig <h...@lst.de&g
if a request is requeued.
>
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> ---
> drivers/scsi/scsi_lib.c | 12 +---
> 1 file changed, 1 insertion(+), 11 deletions(-)
ig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> ---
> drivers/scsi/scsi_lib.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index 10c6adb208dc..4b24c45fa113 100644
> ---
ed-by: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> ---
> drivers/scsi/scsi_lib.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke
rep callback functions and not from
> scsi_ioctl_reset().
>
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Reviewed-by: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> ---
> drivers/scsi/scsi_error.c | 1 -
> dri
ss...@sandisk.com>
> Reviewed-by: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.de>
> ---
> drivers/scsi/scsi_lib.c | 17 -----
> 1 file changed, 8 insertions(+), 9 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Chee
ueue command initialization code.
>
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Reviewed-by: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> ---
> drivers/scsi/scsi.c
On 05/24/2017 02:34 AM, Bart Van Assche wrote:
> Since scsi_req_init() works on a struct scsi_request, change the
> argument type into struct scsi_request *.
>
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Reviewed-by: Christoph Hellwig <h...@lst.de&g
t;ax...@fb.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Omar Sandoval <osan...@fb.com>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: linux-block@vger.kernel.org
> ---
> block/bsg.c| 1 -
> block/scsi_ioctl.c |
be repeated after every
> blk_get_request() call by adding a new callback function to struct
> request_queue.
>
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Cc: Jens Axboe <ax...@fb.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Omar
the private data.
>
> References: commit 82ed4db499b8 ("block: split scsi_request out of struct
> request")
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Cc: Jens Axboe <ax...@fb.com>
> Cc: Christoph Hellwig <h...@lst.de>
>
boe <ax...@fb.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Omar Sandoval <osan...@fb.com>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: linux-...@vger.kernel.org
> Cc: linux-block@vger.kernel.org
> ---
> fs/nfsd/blocklayout.c | 3 +++
> 1 file
ommit 82ed4db499b8 ("block: split scsi_request out of struct
> request")
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Cc: Jens Axboe <ax...@fb.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Omar Sandoval <osan...@fb.com>
>
uce the flag QUEUE_FLAG_SCSI_SUP.
>
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Cc: Jens Axboe <ax...@fb.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Omar Sandoval <osan...@fb.com>
> Cc: Hannes Reinecke <h...@suse.com>
> ---
>
Fixes: e9c787e65c0c ("scsi: allocate scsi_cmnd structures as part of struct
> request")
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Cc: Scott Bauer <scott.ba...@intel.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Jan Kara <
t; Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Cc: Jens Axboe <ax...@fb.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Tejun Heo <t...@kernel.org>
> Cc: Jan Kara <j...@suse.cz>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: <
. Hence convert these
> two assignment statements into warning statements.
>
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Johannes Thumshirn <jthumsh...@suse
hin <isra...@mellanox.com>
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Cc: James Bottomley <james.bottom...@hansenpartnership.com>
> Cc: Israel Rukshin <isra...@mellanox.com>
> Cc: Max Gurtovoy <m...@mellanox.com>
> Cc: Hannes
On 05/24/2017 02:33 AM, Bart Van Assche wrote:
> This patch does not change any functionality.
>
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Cc: Israel Rukshin <isra...@mellanox.com>
> Cc: Max Gurtovoy <m...@mellanox.com>
> Cc: Hannes Re
igned-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Johannes Thumshirn <jthumsh...@suse.de>
> ---
> drivers/scsi/scsi_error.c | 8 +++-
> drivers/scsi/scsi
On 05/24/2017 02:33 AM, Bart Van Assche wrote:
> This will make it easier to serialize SCSI device state changes
> through a mutex.
>
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@s
h a mutex.
>
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Johannes Thumshirn <jthumsh...@suse.de>
> Cc: Sreekanth Reddy <sreekanth.re...@broadcom.com>
long for most applications.
Signed-off-by: Hannes Reinecke <h...@suse.com>
---
block/scsi_ioctl.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c
index 4a294a5..53b95ea 100644
--- a/block/scsi_ioctl.c
+++ b/block/scsi_ioctl.c
@@
| 24 ++--
> include/linux/blk-mq.h | 1 +
> include/linux/blkdev.h | 1 +
> include/linux/elevator.h | 7 +
> 6 files changed, 124 insertions(+), 17 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. H
ot sure if that's a real issue, but personally I liked the mapping.
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
1 +
> block/blk-mq-debugfs.h | 29 +
> block/blk-mq-sysfs.c | 1 +
> block/blk-mq.h | 28
> block/blk-sysfs.c | 1 +
> 6 files changed, 33 insertions(+), 28 deletions(-)
> create mode 100644 block/blk-mq-debugfs.h
&
>
> ---
> block/blk-mq-debugfs.c | 464
> +++--
> 1 file changed, 136 insertions(+), 328 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de
->queue_num);
> + snprintf(name, sizeof(name), "hctx%u", hctx->queue_num);
> hctx_dir = debugfs_create_dir(name, q->mq_debugfs_dir);
> if (!hctx_dir)
> return -ENOMEM;
>
Hmm. The number actually corresponds to /sys/block/XX/mq/
With thi
hanged, 4 insertions(+), 5 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F.
off-by: Omar Sandoval <osan...@fb.com>
> ---
> block/blk-mq-debugfs.c | 201
> ++---
> 1 file changed, 108 insertions(+), 93 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke
On 05/04/2017 09:31 AM, Omar Sandoval wrote:
> From: Omar Sandoval <osan...@fb.com>
>
> This reads more naturally than spaces.
>
> Signed-off-by: Omar Sandoval <osan...@fb.com>
> ---
> block/blk-mq-debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletio
> dd->tags.driver_data = dd;
> dd->tags.timeout = MTIP_NCQ_CMD_TIMEOUT_MS;
>
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49
we might
> - * have driver dependencies on the value of the internal tag.
> - */
> - if (e && !(data->flags & BLK_MQ_REQ_RESERVED)) {
> + if (e) {
> data->flags |= BLK_MQ_REQ_INTERNAL;
>
> /*
>
Reviewed-by: Hannes Rei
--
> 1 file changed, 76 insertions(+), 30 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5
acle.com>
> Cc: James Bottomley <james.bottom...@hansenpartnership.com>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: <linux-s...@vger.kernel.org>
> ---
> drivers/scsi/Makefile | 1 +
> drivers/scsi/scsi_debugfs.c | 13 +
> drivers/scsi/scsi_debugfs
On 04/26/2017 10:47 PM, Bart Van Assche wrote:
> This new callback function will be used in the next patch to show
> more information about SCSI requests.
>
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Reviewed-by: Omar Sandoval <osan...@fb.com&g
On 04/24/2017 11:51 PM, Bart Van Assche wrote:
> On Mon, 2017-04-24 at 09:32 +0200, Hannes Reinecke wrote:
>> On 04/22/2017 01:40 AM, Bart Van Assche wrote:
>>> --- a/include/linux/blk-mq.h
>>> +++ b/include/linux/blk-mq.h
>>> @@ -121,6 +121,12 @@ struct
rtin.peter...@oracle.com>
> Cc: James Bottomley <james.bottom...@hansenpartnership.com>
> Cc: Omar Sandoval <osan...@fb.com>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: <linux-s...@vger.kernel.org>
> ---
> drivers/scsi/scsi_lib.c | 11 +++
> 1 fi
On 04/22/2017 01:40 AM, Bart Van Assche wrote:
> This new callback function will be used in the next patch to show
> more information about SCSI requests.
>
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Reviewed-by: Omar Sandoval <osan...@fb.com&g
-by: Omar Sandoval <osan...@fb.com>
> Cc: Hannes Reinecke <h...@suse.com>
> ---
> block/blk-mq-debugfs.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke
On 04/22/2017 01:40 AM, Bart Van Assche wrote:
> Move the "state" attribute from the top level to the "mq" directory
> as requested by Omar.
>
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Reviewed-by: Omar Sandoval <osan...@
aches the "dead" state.
>
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Cc: Omar Sandoval <osan...@fb.com>
> Cc: Hannes Reinecke <h...@suse.com>
> ---
> block/blk-core.c | 5 +
> 1 file changed, 5 insertions(+)
>
Reviewed-by
Cc: Omar Sandoval <osan...@fb.com>
> Cc: Hannes Reinecke <h...@suse.com>
> ---
> block/blk-mq-sysfs.c | 23 +--
> 1 file changed, 17 insertions(+), 6 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hanne
s...@sandisk.com>
> Cc: Omar Sandoval <osan...@fb.com>
> Cc: Hannes Reinecke <h...@suse.com>
> ---
> block/blk-mq-debugfs.c | 8
> block/blk-mq-sysfs.c | 6 +++---
> block/blk-mq.h | 8
> 3 files changed, 11 insertions(+), 11 dele
up the queue name.
>
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Cc: Omar Sandoval <osan...@fb.com>
> Cc: Hannes Reinecke <h...@suse.com>
> ---
> block/blk-mq-debugfs.c | 5 +++--
> block/blk-mq-sysfs.c | 2 +-
> block/blk-mq.h
alled. To avoid lock inversion,
> protect sysfs / debugfs registration with the queue sysfs_lock
> instead of the global mutex all_q_mutex.
>
> Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
> Cc: Omar Sandoval <osan...@fb.com>
> Cc: Hannes Reinecke <h
vers/md/dm-zoned-io.c
> create mode 100644 drivers/md/dm-zoned-metadata.c
> create mode 100644 drivers/md/dm-zoned-reclaim.c
> create mode 100644 drivers/md/dm-zoned.h
>
Very nice.
You can add my
Reviewed-by: Hannes Reinecke <h...@suse.com>
to the whole series.
Cheers,
Hann
>> include/linux/mg_disk.h | 45 --
>> 5 files changed, 1257 deletions(-)
>> delete mode 100644 Documentation/blockdev/mflash.txt
>> delete mode 100644 drivers/block/mg_disk.c
>> delete mode 100644 include/linux/mg_disk.h
blocksize.
Signed-off-by: Hannes Reinecke <h...@suse.com>
---
drivers/block/loop.c | 40 +++-
drivers/block/loop.h | 1 +
include/uapi/linux/loop.h | 3 +++
3 files changed, 39 insertions(+), 5 deletions(-)
diff --git a/drivers/block/lo
Signed-off-by: Hannes Reinecke <h...@suse.de>
Reviewed-by: Christoph Hellwig <h...@lst.de>
Reviewed-by: Ming Lei <ming@redhat.com>
---
drivers/block/loop.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/loop.c b/drivers/block/lo
301 - 400 of 561 matches
Mail list logo
