Re: [PATCH 01/33] block: add a lower-level bio_add_page interface

2018-05-16 Thread Ritesh Harjani
On 5/16/2018 11:35 PM, Christoph Hellwig wrote: On Wed, May 16, 2018 at 10:36:14AM +0530, Ritesh Harjani wrote: 1. if bio_full is true that means no space in bio->bio_io_vec[] no? Than how come we are still proceeding ahead with only warning? While originally in bio_add_page we used to ret

Re: [PATCH 01/33] block: add a lower-level bio_add_page interface

2018-05-15 Thread Ritesh Harjani
On 5/9/2018 1:17 PM, Christoph Hellwig wrote: For the upcoming removal of buffer heads in XFS we need to keep track of the number of outstanding writeback requests per page. For this we need to know if bio_add_page merged a region with the previous bvec or not. Instead of adding additional arg

Re: [RFC PATCH] cfq: Give a chance for arming slice idle timer in case of group_idle

2017-08-11 Thread Ritesh Harjani
On 8/11/2017 8:30 PM, Jens Axboe wrote: On 08/10/2017 11:15 PM, Ritesh Harjani wrote: Hi Jens, Could you please take a look at below patch and the issue it is trying to solve. Please let us know your thoughts on the below problem and the patch. It looks reasonable to me. I'll queue

Re: [RFC PATCH] cfq: Give a chance for arming slice idle timer in case of group_idle

2017-08-10 Thread Ritesh Harjani
Hi Jens, Could you please take a look at below patch and the issue it is trying to solve. Please let us know your thoughts on the below problem and the patch. Regards Ritesh On 8/9/2017 6:28 PM, Ritesh Harjani wrote: In below scenario blkio cgroup does not work as per their assigned

[RFC PATCH] cfq: Give a chance for arming slice idle timer in case of group_idle

2017-08-09 Thread Ritesh Harjani
pid=691: Thu Jan 1 00:06:08 1970 write: IOPS=1043, BW=32.6MiB/s (34.2MB/s)(1024MiB/31401msec) <..> // In this processes BW is as per their respective cgroups weight. Signed-off-by: Ritesh Harjani --- block/cfq-iosched.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --gi

Re: [PATCH v2] RFD: switch MMC/SD to use blk-mq multiqueueing

2016-12-27 Thread Ritesh Harjani
Hi Linus, Thanks for getting back on this. On 12/27/2016 5:51 PM, Linus Walleij wrote: On Wed, Dec 21, 2016 at 6:22 PM, Ritesh Harjani wrote: I may have some silly queries here. Please bear with my little understanding on blk-mq. It's OK we need to build consensus. On 12/20/2016 7:

Re: [PATCH v2] RFD: switch MMC/SD to use blk-mq multiqueueing

2016-12-21 Thread Ritesh Harjani
Hi, I may have some silly queries here. Please bear with my little understanding on blk-mq. On 12/20/2016 7:31 PM, Linus Walleij wrote: HACK ALERT: DO NOT MERGE THIS! IT IS A FYI PATCH FOR DISCUSSION ONLY. This hack switches the MMC/SD subsystem from using the legacy blk layer to using blk-m

Re: [PATCH] block: Remove unused member (busy) from struct blk_queue_tag

2016-12-16 Thread Ritesh Harjani
On 12/16/2016 3:57 PM, Bart Van Assche wrote: On 12/16/2016 05:41 AM, Ritesh Harjani wrote: Signed-off-by: Ritesh Harjani --- include/linux/blkdev.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 286b2a2..8369564 100644 --- a/include

[PATCH] block: Remove unused member (busy) from struct blk_queue_tag

2016-12-15 Thread Ritesh Harjani
Signed-off-by: Ritesh Harjani --- include/linux/blkdev.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 286b2a2..8369564 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -288,7 +288,6 @@ enum blk_queue_state { struct

Re: [PATCH 2/7] blk-mq: abstract out blk_mq_dispatch_rq_list() helper

2016-12-13 Thread Ritesh Harjani
Minor comments. On 12/9/2016 1:43 AM, Jens Axboe wrote: Takes a list of requests, and dispatches it. Moves any residual requests to the dispatch list. Signed-off-by: Jens Axboe --- block/blk-mq.c | 85 -- block/blk-mq.h | 1 + 2 files c

Re: [PATCH] block: Factor out req_set_nomerge

2016-12-01 Thread Ritesh Harjani
On 12/1/2016 9:08 PM, Jens Axboe wrote: On 12/01/2016 03:27 AM, Ritesh Harjani wrote: Factor out common code for setting REQ_NOMERGE flag which is being used out at certain places and make it a helper instead (req_set_nomerge). I applied this, but I got rid of the inline. Let the compiler

[PATCH] block: Factor out req_set_nomerge

2016-12-01 Thread Ritesh Harjani
Factor out common code for setting REQ_NOMERGE flag which is being used out at certain places and make it a helper instead (req_set_nomerge). Signed-off-by: Ritesh Harjani --- block/blk-merge.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/block/blk