Re: [PATCH] blk-mq-debugfs: Also show requests that have not yet been started

2018-10-08 Thread Johannes Thumshirn
On Fri, Oct 05, 2018 at 07:13:32PM -0600, Jens Axboe wrote: > On 10/5/18 4:37 PM, Omar Sandoval wrote: > > On Fri, Oct 05, 2018 at 08:18:00AM -0600, Jens Axboe wrote: > >> On 10/4/18 11:35 AM, Bart Van Assche wrote: > >>> When debugging e.g. the SCSI timeout handler it is important that > >>>

Re: [PATCH] blk-mq-debugfs: Also show requests that have not yet been started

2018-10-05 Thread Jens Axboe
On 10/5/18 4:37 PM, Omar Sandoval wrote: > On Fri, Oct 05, 2018 at 08:18:00AM -0600, Jens Axboe wrote: >> On 10/4/18 11:35 AM, Bart Van Assche wrote: >>> When debugging e.g. the SCSI timeout handler it is important that >>> requests that have not yet been started or that already have >>> completed

Re: [PATCH] blk-mq-debugfs: Also show requests that have not yet been started

2018-10-05 Thread Omar Sandoval
On Fri, Oct 05, 2018 at 08:18:00AM -0600, Jens Axboe wrote: > On 10/4/18 11:35 AM, Bart Van Assche wrote: > > When debugging e.g. the SCSI timeout handler it is important that > > requests that have not yet been started or that already have > > completed are also reported through debugfs. > >

Re: [PATCH] blk-mq-debugfs: Also show requests that have not yet been started

2018-10-05 Thread Jens Axboe
On 10/4/18 11:35 AM, Bart Van Assche wrote: > When debugging e.g. the SCSI timeout handler it is important that > requests that have not yet been started or that already have > completed are also reported through debugfs. Thanks, I like this better - applied. BTW, what's up with the reverse

Re: [PATCH] blk-mq-debugfs: Also show requests that have not yet been started

2018-10-05 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH] blk-mq-debugfs: Also show requests that have not yet been started

2018-10-04 Thread Hannes Reinecke
On 10/4/18 7:35 PM, Bart Van Assche wrote: When debugging e.g. the SCSI timeout handler it is important that requests that have not yet been started or that already have completed are also reported through debugfs. Signed-off-by: Bart Van Assche Cc: Christoph Hellwig Cc: Ming Lei Cc: Hannes

[PATCH] blk-mq-debugfs: Also show requests that have not yet been started

2018-10-04 Thread Bart Van Assche
When debugging e.g. the SCSI timeout handler it is important that requests that have not yet been started or that already have completed are also reported through debugfs. Signed-off-by: Bart Van Assche Cc: Christoph Hellwig Cc: Ming Lei Cc: Hannes Reinecke Cc: Johannes Thumshirn Cc: Martin

Re: [PATCH] blk-mq-debugfs: Also show requests that have not yet been started

2018-10-03 Thread Jens Axboe
On 10/3/18 4:51 PM, Bart Van Assche wrote: > On Wed, 2018-10-03 at 16:12 -0600, Jens Axboe wrote: >> On 10/3/18 3:42 PM, Bart Van Assche wrote: >>> On Fri, 2018-01-12 at 22:11 +, Bart Van Assche wrote: /* + * Show "busy" requests - these are the requests owned by the block

Re: [PATCH] blk-mq-debugfs: Also show requests that have not yet been started

2018-10-03 Thread Bart Van Assche
On Wed, 2018-10-03 at 16:12 -0600, Jens Axboe wrote: > On 10/3/18 3:42 PM, Bart Van Assche wrote: > > On Fri, 2018-01-12 at 22:11 +, Bart Van Assche wrote: > > > /* > > > + * Show "busy" requests - these are the requests owned by the block > > > driver. > > > + * The test

Re: [PATCH] blk-mq-debugfs: Also show requests that have not yet been started

2018-10-03 Thread Jens Axboe
On 10/3/18 3:42 PM, Bart Van Assche wrote: > On Fri, 2018-01-12 at 22:11 +, Bart Van Assche wrote: >> On Fri, 2018-01-12 at 15:05 -0700, Jens Axboe wrote: >>> On 1/12/18 3:00 PM, Bart Van Assche wrote: On Fri, 2018-01-12 at 14:55 -0700, Jens Axboe wrote: > On 1/12/18 2:52 PM, Bart Van

Re: [PATCH] blk-mq-debugfs: Also show requests that have not yet been started

2018-10-03 Thread Bart Van Assche
On Fri, 2018-01-12 at 22:11 +, Bart Van Assche wrote: > On Fri, 2018-01-12 at 15:05 -0700, Jens Axboe wrote: > > On 1/12/18 3:00 PM, Bart Van Assche wrote: > > > On Fri, 2018-01-12 at 14:55 -0700, Jens Axboe wrote: > > > > On 1/12/18 2:52 PM, Bart Van Assche wrote: > > > > > When debugging

[PATCH] blk-mq-debugfs: Also show requests that have not yet been started

2018-02-12 Thread Bart Van Assche
When debugging e.g. the SCSI timeout handler it is important that requests that have not yet been started or that already have completed are also reported through debugfs. This patch depends on a patch that went upstream in kernel v4.15, namely commit 14e3062fb185 ("scsi: core: Fix a

Re: [PATCH] blk-mq-debugfs: Also show requests that have not yet been started

2018-01-12 Thread Bart Van Assche
On Fri, 2018-01-12 at 15:05 -0700, Jens Axboe wrote: > On 1/12/18 3:00 PM, Bart Van Assche wrote: > > On Fri, 2018-01-12 at 14:55 -0700, Jens Axboe wrote: > > > On 1/12/18 2:52 PM, Bart Van Assche wrote: > > > > When debugging e.g. the SCSI timeout handler it is important that > > > > requests

Re: [PATCH] blk-mq-debugfs: Also show requests that have not yet been started

2018-01-12 Thread Jens Axboe
On 1/12/18 3:00 PM, Bart Van Assche wrote: > On Fri, 2018-01-12 at 14:55 -0700, Jens Axboe wrote: >> On 1/12/18 2:52 PM, Bart Van Assche wrote: >>> When debugging e.g. the SCSI timeout handler it is important that >>> requests that have not yet been started or that already have >>> completed are

Re: [PATCH] blk-mq-debugfs: Also show requests that have not yet been started

2018-01-12 Thread Jens Axboe
On 1/12/18 2:52 PM, Bart Van Assche wrote: > When debugging e.g. the SCSI timeout handler it is important that > requests that have not yet been started or that already have > completed are also reported through debugfs. > > This patch depends on a patch that went upstream recently, namely >

[PATCH] blk-mq-debugfs: Also show requests that have not yet been started

2018-01-12 Thread Bart Van Assche
When debugging e.g. the SCSI timeout handler it is important that requests that have not yet been started or that already have completed are also reported through debugfs. This patch depends on a patch that went upstream recently, namely commit 14e3062fb185 ("scsi: core: Fix a scsi_show_rq() NULL