Re: [PATCH v10 3/8] block: Split blk_pm_add_request() and blk_pm_put_request()

2018-09-26 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig But one very minor nitpick below: > #ifdef CONFIG_PM > +static inline void blk_pm_request_resume(struct request_queue *q) > +{ > + if (q->dev && (q->rpm_status == RPM_SUSPENDED || > +q->rpm_status == RPM_SUSPENDING)) I usually

[PATCH v10 3/8] block: Split blk_pm_add_request() and blk_pm_put_request()

2018-09-21 Thread Bart Van Assche
Move the pm_request_resume() and pm_runtime_mark_last_busy() calls into two new functions and thereby separate legacy block layer code from code that works for both the legacy block layer and blk-mq. A later patch will add calls to the new functions in the blk-mq code. Signed-off-by: Bart Van Assc