Re: [PATCH v2] bcache: move closure debug file into debug direcotry

2018-03-07 Thread Michael Lyle
On 03/06/2018 07:23 PM, Chengguang Xu wrote: > In current code closure debug file is outside of debug directory > and when unloading module there is lack of removing operation > for closure debug file, so it will cause creating error when trying > to reload module. > > This patch move closure

Re: [PATCH v2] bcache: move closure debug file into debug direcotry

2018-03-06 Thread Chengguang Xu
To: "Chengguang Xu" <cgxu...@gmx.com>, tang.jun...@zte.com.cn, > kent.overstr...@gmail.com > Cc: linux-bca...@vger.kernel.org, linux-block@vger.kernel.org > Subject: Re: [PATCH v2] bcache: move closure debug file into debug direcotry > > Sorry- I had to pull/unapply this ac

[PATCH v2] bcache: move closure debug file into debug direcotry

2018-03-06 Thread Chengguang Xu
In current code closure debug file is outside of debug directory and when unloading module there is lack of removing operation for closure debug file, so it will cause creating error when trying to reload module. This patch move closure debug file into "bcache" debug direcory so that the file

Re: [PATCH v2] bcache: move closure debug file into debug direcotry

2018-03-06 Thread Michael Lyle
Sorry- I had to pull/unapply this actually. On 03/04/2018 11:40 PM, Chengguang Xu wrote: > -static struct dentry *debug > +struct dentry *debug; This conflicts with other symbols called "debug" and doesn't compile. Please be sure that your patch set compiles before submitting. Mike > >

[PATCH v2] bcache: move closure debug file into debug direcotry

2018-03-05 Thread tang . junhui
LGTM. Reviewed-by: Tang Junhui > In current code closure debug file is outside of debug directory > and when unloading module there is lack of removing operation > for closure debug file, so it will cause creating error when trying > to reload module. > > This patch

[PATCH v2] bcache: move closure debug file into debug direcotry

2018-03-04 Thread Chengguang Xu
In current code closure debug file is outside of debug directory and when unloading module there is lack of removing operation for closure debug file, so it will cause creating error when trying to reload module. This patch move closure debug file into "bcache" debug direcory so that the file