[PATCH 02/11] block: Use the queue_flag_*() functions instead of open-coding these

Except for changing the atomic queue flag manipulations that are protected by the queue lock into non-atomic manipulations, this patch does not change any functionality. Signed-off-by: Bart Van Assche Cc: Christoph Hellwig Cc: Hannes Reinecke

[PATCH 09/11] block: Use blk_queue_flag_*() in drivers instead of queue_flag_*()

This patch has been generated as follows: for verb in set_unlocked clear_unlocked set clear; do replace-in-files queue_flag_${verb} blk_queue_flag_${verb%_unlocked} \ $(git grep -lw queue_flag_${verb} drivers block/bsg*) done Except for protecting all queue flag changes with the queue lock

[PATCH 03/11] block: Introduce blk_queue_flag_{set,clear,test_and_{set,clear}}()

Introduce functions that modify the queue flags and that protect these modifications with the request queue lock. Except for moving one wake_up_all() call from inside to outside a critical section, this patch does not change any functionality. Signed-off-by: Bart Van Assche

[PATCH 05/11] mtip32xx: Use the blk_queue_flag_*() functions

Use the blk_queue_flag_*() functions instead of open-coding these. Signed-off-by: Bart Van Assche Cc: Christoph Hellwig Cc: Hannes Reinecke Cc: Johannes Thumshirn Cc: Ming Lei ---

[PATCH 00/11] Make all concurrent queue flag manipulations safe

Hello Jens, As you probably know there is considerable confusion in the block layer core and in block drivers about how to protect queue flag changes against concurrent modifications. Some code protects these changes with the queue lock, other code uses atomic operations and some code does not

[PATCH 07/11] iscsi: Use blk_queue_flag_set()

Use blk_queue_flag_set() instead of open-coding this function. Signed-off-by: Bart Van Assche Cc: Martin K. Petersen Cc: Christoph Hellwig Cc: Hannes Reinecke Cc: Johannes Thumshirn Cc: Ming

[PATCH 08/11] target/tcm_loop: Use blk_queue_flag_set()

Use blk_queue_flag_set() instead of open-coding this function. Signed-off-by: Bart Van Assche Cc: Nicholas A. Bellinger Cc: Christoph Hellwig Cc: Hannes Reinecke Cc: Johannes Thumshirn Cc: Ming Lei

[PATCH 11/11] block: Move the queue_flag_*() functions from a public into a private header file

This patch helps to avoid that new code gets introduced in block drivers that manipulates queue flags without holding the queue lock when that lock should be held. Signed-off-by: Bart Van Assche Cc: Christoph Hellwig Cc: Hannes Reinecke Cc:

[PATCH 06/11] bcache: Use the blk_queue_flag_{set,clear}() functions

Use the blk_queue_flag_{set,clear}() functions instead of open-coding these. Signed-off-by: Bart Van Assche Cc: Michael Lyle Cc: Kent Overstreet Cc: Christoph Hellwig Cc: Hannes Reinecke Cc:

[PATCH 10/11] block: Complain if queue_flag_(set|clear)_unlocked() is abused

Since it is not safe to use queue_flag_(set|clear)_unlocked() without holding the queue lock after the sysfs entries for a queue have been created, complain if this happens. Signed-off-by: Bart Van Assche Cc: Mike Snitzer Cc: Christoph Hellwig

[PATCH 04/11] block: Protect queue flag changes with the queue lock

Since the queue flags may be changed concurrently from multiple contexts after a queue becomes visible in sysfs, make these changes safe by protecting these with the queue lock. Signed-off-by: Bart Van Assche Cc: Christoph Hellwig Cc: Hannes Reinecke

[PATCH 01/11] block: Reorder the queue flag manipulaton function definitions

Move the definition of queue_flag_clear_unlocked() up and move the definition of queue_in_flight() down such that all queue flag manipulation function definitions become contiguous. This patch does not change any functionality. Signed-off-by: Bart Van Assche Cc:

[PATCH v5 5/6] block: Fix a race between the cgroup code and request queue initialization

Initialize the request queue lock earlier such that the following race can no longer occur: blk_init_queue_node() blkcg_print_blkgs() blk_alloc_queue_node (1) q->queue_lock = >__queue_lock (2) blkcg_init_queue(q) (3)

[PATCH v5 6/6] block: Fix a race between request queue removal and the block cgroup controller

Avoid that the following race can occur: blk_cleanup_queue() blkcg_print_blkgs() spin_lock_irq(lock) (1) spin_lock_irq(blkg->q->queue_lock) (2,5) q->queue_lock = >__queue_lock (3) spin_unlock_irq(lock) (4)

[PATCH v5 1/6] block/loop: Delete gendisk before cleaning up the request queue

Remove the disk, partition and bdi sysfs attributes before cleaning up the request queue associated with the disk. Signed-off-by: Bart Van Assche Reviewed-by: Johannes Thumshirn Reviewed-by: Joseph Qi Cc: Josef Bacik

[PATCH v5 2/6] md: Delete gendisk before cleaning up the request queue

Remove the disk, partition and bdi sysfs attributes before cleaning up the request queue associated with the disk. Signed-off-by: Bart Van Assche Reviewed-by: Johannes Thumshirn Reviewed-by: Joseph Qi Cc: Shaohua Li

[PATCH v5 3/6] zram: Delete gendisk before cleaning up the request queue

Remove the disk, partition and bdi sysfs attributes before cleaning up the request queue associated with the disk. Signed-off-by: Bart Van Assche Reviewed-by: Johannes Thumshirn Reviewed-by: Joseph Qi Cc: Minchan Kim

Re: [PATCH v5 0/6] Fix races between blkcg code and request queue initialization and cleanup

On Wed, 2018-02-28 at 11:19 -0700, Jens Axboe wrote: > Didn't Ming ack the first three? Hello Jens, This morning I did what I usually do before I repost a patch series, namely to look at the replies to individual patches for reviewed-by tags. That's how I overlooked the following (see also

[PATCH v5 0/6] Fix races between blkcg code and request queue initialization and cleanup

Hello Jens, Recently Joseph Qi identified races between the block cgroup code and request queue initialization and cleanup. This patch series address these races. This patch series is structured as follows: - Patches 3..6 fix the aforementioned races. - Patches 1..3 ensure that all maintained

Re: [PATCH 06/11] bcache: Use the blk_queue_flag_{set,clear}() functions

LGTM On Wed, Feb 28, 2018 at 11:28 AM, Bart Van Assche wrote: > Use the blk_queue_flag_{set,clear}() functions instead of open-coding > these. > > Signed-off-by: Bart Van Assche > Cc: Michael Lyle > Cc: Kent Overstreet

[PATCH v5 4/6] block: Add 'lock' as third argument to blk_alloc_queue_node()

This patch does not change any functionality. Signed-off-by: Bart Van Assche Reviewed-by: Joseph Qi Cc: Christoph Hellwig Cc: Philipp Reisner Cc: Ulf Hansson Cc: Kees Cook

Re: [PATCH v5 0/6] Fix races between blkcg code and request queue initialization and cleanup

On Wed, Feb 28 2018, Bart Van Assche wrote: > On Wed, 2018-02-28 at 11:19 -0700, Jens Axboe wrote: > > Didn't Ming ack the first three? > > Hello Jens, > > This morning I did what I usually do before I repost a patch series, namely to > look at the replies to individual patches for reviewed-by

Re: [PATCH v5 0/6] Fix races between blkcg code and request queue initialization and cleanup

On 2/28/18 11:15 AM, Bart Van Assche wrote: > Hello Jens, > > Recently Joseph Qi identified races between the block cgroup code and request > queue initialization and cleanup. This patch series address these races. > > This patch series is structured as follows: > - Patches 3..6 fix the

[PATCH v2 09/10] nvme-pci: Add a quirk for a pseudo CMB

Introduce a quirk to use CMB-like memory on older devices that have an exposed BAR but do not advertise support for using CMBLOC and CMBSIZE. We'd like to use some of these older cards to test P2P memory. Signed-off-by: Logan Gunthorpe --- drivers/nvme/host/nvme.h | 7

[PATCH v2 07/10] nvme-pci: Use PCI p2pmem subsystem to manage the CMB

Register the CMB buffer as p2pmem and use the appropriate allocation functions to create and destroy the IO SQ. If the CMB supports WDS and RDS, publish it for use as p2p memory by other devices. Signed-off-by: Logan Gunthorpe --- drivers/nvme/host/pci.c | 75

[PATCH v2 02/10] PCI/P2PDMA: Add sysfs group to display p2pmem stats

Attributes display the total amount of P2P memory, the amount available and whether it is published or not. Signed-off-by: Logan Gunthorpe --- Documentation/ABI/testing/sysfs-bus-pci | 25 + drivers/pci/p2pdma.c| 50

[PATCH v2 06/10] IB/core: Add optional PCI P2P flag to rdma_rw_ctx_[init|destroy]()

In order to use PCI P2P memory pci_p2pmem_[un]map_sg() functions must be called to map the correct DMA address. To do this, we add a flags variable and the RDMA_RW_CTX_FLAG_PCI_P2P flag. When the flag is specified use the appropriate map function. Signed-off-by: Logan Gunthorpe

[PATCH v2 01/10] PCI/P2PDMA: Support peer to peer memory

Some PCI devices may have memory mapped in a BAR space that's intended for use in Peer-to-Peer transactions. In order to enable such transactions the memory must be registered with ZONE_DEVICE pages so it can be used by DMA interfaces in existing drivers. A kernel interface is provided so that

[PATCH v2 05/10] block: Introduce PCI P2P flags for request and request queue

QUEUE_FLAG_PCI_P2P is introduced meaning a driver's request queue supports targeting P2P memory. REQ_PCI_P2P is introduced to indicate a particular bio request is directed to/from PCI P2P memory. A request with this flag is not accepted unless the corresponding queues have the QUEUE_FLAG_PCI_P2P

[PATCH v2 00/10] Copy Offload in NVMe Fabrics with P2P PCI Memory

Hi Everyone, Here's v2 of our series to introduce P2P based copy offload to NVMe fabrics. This version has been rebased onto v4.16-rc3 which already includes Christoph's devpagemap work the previous version was based off as well as a couple of the cleanup patches that were in v1. Additionally,

[PATCH v2 10/10] nvmet: Optionally use PCI P2P memory

We create a configfs attribute in each nvme-fabrics target port to enable p2p memory use. When enabled, the port will only then use the p2p memory if a p2p memory device can be found which is behind the same switch as the RDMA port and all the block devices in use. If the user enabled it an no

[PATCH v2 03/10] PCI/P2PDMA: Add PCI p2pmem dma mappings to adjust the bus offset

The DMA address used when mapping PCI P2P memory must be the PCI bus address. Thus, introduce pci_p2pmem_[un]map_sg() to map the correct addresses when using P2P memory. For this, we assume that an SGL passed to these functions contain all p2p memory or no p2p memory. Signed-off-by: Logan

[PATCH v2 04/10] PCI/P2PDMA: Clear ACS P2P flags for all devices behind switches

For peer-to-peer transactions to work the downstream ports in each switch must not have the ACS flags set. At this time there is no way to dynamically change the flags and update the corresponding IOMMU groups so this is done at enumeration time before the the groups are assigned. This

Re: [PATCH 5/5] nvme: pci: pass max vectors as num_possible_cpus() to pci_alloc_irq_vectors

Looks fine, and we should pick this up for 4.16 independent of the rest, which I might need a little more review time for. Reviewed-by: Christoph Hellwig

RE: [PATCH V3 8/8] scsi: megaraid: improve scsi_mq performance via .host_tagset

> -Original Message- > From: Laurence Oberman [mailto:lober...@redhat.com] > Sent: Wednesday, February 28, 2018 9:52 PM > To: Ming Lei; Kashyap Desai > Cc: Jens Axboe; linux-block@vger.kernel.org; Christoph Hellwig; Mike > Snitzer; > linux-s...@vger.kernel.org; Hannes Reinecke; Arun Easi;

Re: [PATCH 2/4] block: bio_check_eod() needs to consider partition

Hi Christoph, thanks for your quick reply. On 2018/3/1 上午1:48, Christoph Hellwig wrote: > Hmm. I'd rather just kill off bio_check_eod and move the check > to blk_partition_remap so that we only have to check once. > I think the check should be done twice if the bi_partno is not zero, one for

Re: [PATCH] mq-deadline: Make sure to always unlock zones

On Wed, Feb 28, 2018 at 09:35:29AM -0800, Bart Van Assche wrote: > From: Damien Le Moal > > In case of a failed write request (all retries failed) and when using > libata, the SCSI error handler calls scsi_finish_command(). In the > case of blk-mq this means that

Re: [PATCH v2 00/10] Copy Offload in NVMe Fabrics with P2P PCI Memory

On Wed, 2018-02-28 at 16:39 -0700, Logan Gunthorpe wrote: > Hi Everyone, So Oliver (CC) was having issues getting any of that to work for us. The problem is that acccording to him (I didn't double check the latest patches) you effectively hotplug the PCIe memory into the system when creating

Re: [PATCH v2 00/10] Copy Offload in NVMe Fabrics with P2P PCI Memory

On Thu, 2018-03-01 at 14:54 +1100, Benjamin Herrenschmidt wrote: > On Wed, 2018-02-28 at 16:39 -0700, Logan Gunthorpe wrote: > > Hi Everyone, > > > So Oliver (CC) was having issues getting any of that to work for us. > > The problem is that acccording to him (I didn't double check the latest >

Re: v4.16-rc1 + dm-mpath + BFQ

On Fri, 2018-02-16 at 08:39 +0100, Paolo Valente wrote: > after enabling the listing options in your list, and a few other > related options, such iblock support, I get this: > > $ sudo ./run_tests -c -d -r 10 -t 02-mq -e bfq > Unloaded the ib_srpt kernel module > Unloaded the rdma_rxe kernel

Re: [PATCH V3 8/8] scsi: megaraid: improve scsi_mq performance via .host_tagset

On Thu, Mar 01, 2018 at 10:54:17AM +0530, Kashyap Desai wrote: > > -Original Message- > > From: Laurence Oberman [mailto:lober...@redhat.com] > > Sent: Wednesday, February 28, 2018 9:52 PM > > To: Ming Lei; Kashyap Desai > > Cc: Jens Axboe; linux-block@vger.kernel.org; Christoph Hellwig;

Re: [PATCH] null_blk: add 'requeue' fault attribute

On 2/28/18 1:51 AM, Omar Sandoval wrote: > On Tue, Feb 27, 2018 at 03:34:53PM -0700, Jens Axboe wrote: >> Similarly to the support we have for testing/faking timeouts for >> null_blk, this adds support for triggering a requeue condition. >> Considering the issues around restart we've been seeing,

RE: [PATCH V3 8/8] scsi: megaraid: improve scsi_mq performance via .host_tagset

Ming - Quick testing on my setup - Performance slightly degraded (4-5% drop)for megaraid_sas driver with this patch. (From 1610K IOPS it goes to 1544K) I confirm that after applying this patch, we have #queue = #numa node. ls -l

Re: [PATCH 0/2] block: sbitmap tweaks

On 2/27/18 5:56 PM, Omar Sandoval wrote: > From: Omar Sandoval > > Two fixlets inspired by Tejun's patch > (https://patchwork.kernel.org/patch/10226749/). Patch 2 is what we > discussed on that patch, patch 1 is a small preparation. Unless I hear complaints, I'm going to queue

Re: [PATCH V3 8/8] scsi: megaraid: improve scsi_mq performance via .host_tagset

On Wed, Feb 28, 2018 at 08:28:48PM +0530, Kashyap Desai wrote: > Ming - > > Quick testing on my setup - Performance slightly degraded (4-5% drop)for > megaraid_sas driver with this patch. (From 1610K IOPS it goes to 1544K) > I confirm that after applying this patch, we have #queue = #numa node.

[PATCH 10/15] lightnvm: pblk: check for supported version

At this point, only 1.2 spec is supported, thus check for it. Also, since device-side L2P is only supported in the 1.2 spec, make sure to only check its value under 1.2. Signed-off-by: Javier González --- drivers/lightnvm/pblk-init.c | 10 -- 1 file changed, 8

[PATCH 04/15] lightnvm: add shorten OCSSD version in geo

Create a shorten version to use in the generic geometry. Signed-off-by: Javier González --- drivers/nvme/host/lightnvm.c | 6 ++ include/linux/lightnvm.h | 8 2 files changed, 14 insertions(+) diff --git a/drivers/nvme/host/lightnvm.c

Re: [PATCH 0/2] Make the zone locking information available in debugfs

On 2/27/18 5:32 PM, Bart Van Assche wrote: > Hello Jens, > > While analyzing the mq-deadline behavior for ZBC drives together with Damien > we noticed the following: > - That the request queue attribute methods are not contiguous in > blk-mq-debugfs.c. > - That the information about which zones

Re: [PATCH] null_blk: add 'requeue' fault attribute

On Tue, Feb 27, 2018 at 03:34:53PM -0700, Jens Axboe wrote: > Similarly to the support we have for testing/faking timeouts for > null_blk, this adds support for triggering a requeue condition. > Considering the issues around restart we've been seeing, this should be > a useful addition to the

[PATCH] nbd: do not update block size if file system is mounted

If a file system is mounted on the nbd during a disconnect, resetting the size to 0, might change the block size and destroy the buffer_head mappings. This will cause a infinite loop when the file system looks for the buffer_heads for flushing. Only set the file size to 0, if we are the only

Re: [PATCH 3/4] block: display the correct diskname for bio

Looks fine, Reviewed-by: Christoph Hellwig

Re: [PATCH 4/4] block: fix a typo

Looks fine, Reviewed-by: Christoph Hellwig

[PATCH 14/15] lightnvm: pblk: refactor init/exit sequences

Refactor init and exit sequences to improve readability. In the way, fix bad free ordering on the init error path. Signed-off-by: Javier González --- drivers/lightnvm/pblk-init.c | 533 +-- 1 file changed, 266 insertions(+), 267

[PATCH 12/15] lightnvn: pblk: use generic address format

Use the generic address format on common address manipulations. Signed-off-by: Javier González --- drivers/lightnvm/pblk-core.c | 10 +- drivers/lightnvm/pblk-map.c | 4 ++-- drivers/lightnvm/pblk-sysfs.c | 4 ++-- drivers/lightnvm/pblk.h | 4 ++-- 4

[PATCH 11/15] lightnvm: pblk: rename ppaf* to addrf*

In preparation for 2.0 support in pblk, rename variables referring to the address format to addrf and reserve ppaf for the 1.2 path. Signed-off-by: Javier González --- drivers/lightnvm/pblk-init.c | 8 drivers/lightnvm/pblk-sysfs.c | 4 ++--

[PATCH 13/15] lightnvm: pblk: implement get log report chunk

In preparation of pblk supporting 2.0, implement the get log report chunk in pblk. Also, define the chunk states as given in the 2.0 spec. Signed-off-by: Javier González --- drivers/lightnvm/pblk-core.c | 139 +++ drivers/lightnvm/pblk-init.c | 223

[PATCH 09/15] lightnvm: implement get log report chunk helpers

The 2.0 spec provides a report chunk log page that can be retrieved using the stangard nvme get log page. This replaces the dedicated get/put bad block table in 1.2. This patch implements the helper functions to allow targets retrieve the chunk metadata using get log page. It makes

[PATCH 05/15] lightnvm: complete geo structure with maxoc*

Complete the generic geometry structure with the maxoc and maxocpu felds, present in the 2.0 spec. Also, expose them through sysfs. Signed-off-by: Javier González --- drivers/nvme/host/lightnvm.c | 17 + include/linux/lightnvm.h | 2 ++ 2 files changed,

[PATCH 07/15] lightnvm: add support for 2.0 address format

Add support for 2.0 address format. Also, align address bits for 1.2 and 2.0 to be able to operate on channel and luns without requiring a format conversion. Use a generic address format for this purpose. Signed-off-by: Javier González --- drivers/lightnvm/core.c | 20

[PATCH 08/15] lightnvm: make address conversions depend on generic device

On address conversions, use the generic device, instead of the target device. This allows to use conversions outside of the target's realm. Signed-off-by: Javier González --- drivers/lightnvm/core.c | 4 ++-- include/linux/lightnvm.h | 8 2 files changed, 6

[PATCH 06/15] lightnvm: normalize geometry nomenclature

Normalize nomenclature for naming channels, luns, chunks, planes and sectors as well as derivations in order to improve readability. Signed-off-by: Javier González --- drivers/lightnvm/core.c | 89 +--

[PATCH 03/15] lightnvm: add minor version to generic geometry

Separate the version between major and minor on the generic geometry and represent it through sysfs in the 2.0 path. The 1.2 path only shows the major version to preserve the existing user space interface. Signed-off-by: Javier González --- drivers/lightnvm/core.c | 4

[PATCH 01/15] lightnvm: simplify geometry structure.

Currently, the device geometry is stored redundantly in the nvm_id and nvm_geo structures at a device level. Moreover, when instantiating targets on a specific number of LUNs, these structures are replicated and manually modified to fit the instance channel and LUN partitioning. Instead, create a

[PATCH V4 00/15] lightnvm: pblk: implement 2.0 support

# Changes since V4 - Rebase on top of Matias' for-4.17/core - Fix pblk's write buffer size when using mw_cuints - Remove chunk information from pblk's sysfs. We intend to clean up sysfs, as it is messy as it is now, and use trace points instead. So, avoid an extra refactoring in the near

[PATCH 02/15] lightnvm: add controller capabilities to 2.0

Assign missing mccap value on 2.0 path Signed-off-by: Javier González --- drivers/nvme/host/lightnvm.c | 4 +++- include/linux/lightnvm.h | 8 +--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/nvme/host/lightnvm.c

Re: [PATCH V3 8/8] scsi: megaraid: improve scsi_mq performance via .host_tagset

On Wed, 2018-02-28 at 23:21 +0800, Ming Lei wrote: > On Wed, Feb 28, 2018 at 08:28:48PM +0530, Kashyap Desai wrote: > > Ming - > > > > Quick testing on my setup -  Performance slightly degraded (4-5% > > drop)for > > megaraid_sas driver with this patch. (From 1610K IOPS it goes to > > 1544K) > >

[PATCH V2] lightnvm: pblk: remove unused variable

# Changes since V1: - Rebase on top of latest 2.0 changes Javier González (1): lightnvm: pblk: remove unused variable drivers/lightnvm/pblk-core.c | 3 --- 1 file changed, 3 deletions(-) -- 2.7.4

[PATCH] lightnvm: pblk: remove unused variable

Remove unused variable after a previous cleanup (a8112b631adb) Signed-off-by: Javier González --- drivers/lightnvm/pblk-core.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c index cd663855ee88..b85cdedb5f48

Re: [PATCH] null_blk: add 'requeue' fault attribute

On 2/28/18 9:14 AM, Omar Sandoval wrote: > On Wed, Feb 28, 2018 at 08:28:25AM -0700, Jens Axboe wrote: >> On 2/28/18 1:51 AM, Omar Sandoval wrote: >>> On Tue, Feb 27, 2018 at 03:34:53PM -0700, Jens Axboe wrote: Similarly to the support we have for testing/faking timeouts for null_blk,

Re: [PATCH] null_blk: add 'requeue' fault attribute

On Wed, Feb 28, 2018 at 09:15:37AM -0700, Jens Axboe wrote: > On 2/28/18 9:14 AM, Omar Sandoval wrote: > > On Wed, Feb 28, 2018 at 08:28:25AM -0700, Jens Axboe wrote: > >> On 2/28/18 1:51 AM, Omar Sandoval wrote: > >>> On Tue, Feb 27, 2018 at 03:34:53PM -0700, Jens Axboe wrote: > Similarly to

Re: [PATCH] null_blk: add 'requeue' fault attribute

On Wed, Feb 28, 2018 at 08:28:25AM -0700, Jens Axboe wrote: > On 2/28/18 1:51 AM, Omar Sandoval wrote: > > On Tue, Feb 27, 2018 at 03:34:53PM -0700, Jens Axboe wrote: > >> Similarly to the support we have for testing/faking timeouts for > >> null_blk, this adds support for triggering a requeue

Re: [PATCH 0/2] block: sbitmap tweaks

On Tue, Feb 27, 2018 at 04:56:41PM -0800, Omar Sandoval wrote: > From: Omar Sandoval > > Two fixlets inspired by Tejun's patch > (https://patchwork.kernel.org/patch/10226749/). Patch 2 is what we > discussed on that patch, patch 1 is a small preparation. > > Omar Sandoval (2): >

[PATCH] mq-deadline: Make sure to always unlock zones

From: Damien Le Moal In case of a failed write request (all retries failed) and when using libata, the SCSI error handler calls scsi_finish_command(). In the case of blk-mq this means that scsi_mq_done() does not get called, that blk_mq_complete_request() does not get

Re: [PATCH] Use bio_endio instead of bio_put in error path of blk_rq_append_bio

On 27/02/18 16:44, Jiri Palecek wrote: <> >> These are BIDI commands that travel as a couple of chained requests. They are >> sent as BLOCK_PC command and complete or fail as one hole unit. The system >> is not >> allowed (And does not know how) to split them or complete them partially. >> This

Re: [PATCH] Use bio_endio instead of bio_put in error path of blk_rq_append_bio

On 28/02/18 19:38, Boaz Harrosh wrote: <> > Based on v4.15 code feel free to add to your patchset > where needed > Sorry is what happens when you work on so many Linux versions at the same time. This one is based on v4.15 > > Don't leak the request if blk_rq_append_bio fails > >