[PATCH] xen-blkfront: Fix handling of non-supported operations

2017-07-21 Thread Bart Van Assche
This patch fixes the following sparse warnings: drivers/block/xen-blkfront.c:916:45: warning: incorrect type in argument 2 (different base types) drivers/block/xen-blkfront.c:916:45:expected restricted blk_status_t [usertype] error drivers/block/xen-blkfront.c:916:45:got int [signed]

Re: [Xen-users] File-based domU - Slow storage write since xen 4.8

2017-07-21 Thread Roger Pau Monné
On Fri, Jul 21, 2017 at 11:53:33AM -0400, Keith Busch wrote: > On Fri, Jul 21, 2017 at 12:19:39PM +0200, Benoit Depail wrote: > > On 07/20/17 19:36, Keith Busch wrote: > > > > > > As a test, could you throttle the xvdb queue's max_sectors_kb? If I > > > followed xen-blkfront correctly, the

Re: [Xen-users] File-based domU - Slow storage write since xen 4.8

2017-07-21 Thread Keith Busch
On Fri, Jul 21, 2017 at 12:19:39PM +0200, Benoit Depail wrote: > On 07/20/17 19:36, Keith Busch wrote: > > > > As a test, could you throttle the xvdb queue's max_sectors_kb? If I > > followed xen-blkfront correctly, the default should have it set to 44. > > Try setting it to 40. > > > > echo

[GIT PULL] Block fixes for 4.13-rc2

2017-07-21 Thread Jens Axboe
Hi Linus, Small set of fixes for -rc2 - two fixes for BFQ, documentation and code, and a removal of an unused variable in nbd. Outside of that, a small collection of fixes from the usual crew on the nvme side. Please pull! git://git.kernel.dk/linux-block.git for-linus

[PATCH 1/3] nbd: allow multiple disconnects to be sent

2017-07-21 Thread josef
From: Josef Bacik There's no reason to limit ourselves to one disconnect message per socket. Sometimes networks do strange things, might as well let sysadmins hit the panic button as much as they want. Signed-off-by: Josef Bacik --- drivers/block/nbd.c | 5 ++---

[PATCH 3/3] nbd: only set sndtimeo if we have a timeout set

2017-07-21 Thread josef
From: Josef Bacik A user reported that he was getting immediate disconnects with my sndtimeo patch applied. This is because by default the OSS nbd client doesn't set a timeout, so we end up setting the sndtimeo to 0, which of course means we have send errors a lot. Instead only

[PATCH 2/3] nbd: take tx_lock before disconnecting

2017-07-21 Thread josef
From: Josef Bacik We need to take the tx_lock so we don't interleave our disconnect request between real data going down the wire. Signed-off-by: Josef Bacik --- drivers/block/nbd.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/block/nbd.c

Re: nbd drops connection on most writes

2017-07-21 Thread Adam Borowski
On Fri, Jul 21, 2017 at 12:22:51PM +, Josef Bacik wrote: > Oh shit the default timeout is 0 if you don't set it in the client. Use > the timeout option with nbd client and it should fix it for you. I'll > send something up to make this a sane default. Confirmed, adding a timeout=XXX

Re: nbd drops connection on most writes

2017-07-21 Thread Josef Bacik
Oh shit the default timeout is 0 if you don't set it in the client. Use the timeout option with nbd client and it should fix it for you. I'll send something up to make this a sane default. Thanks, Josef Sent from my iPhone > On Jul 21, 2017, at 8:15 AM, Adam Borowski

nbd drops connection on most writes

2017-07-21 Thread Adam Borowski
Hi! I'm afraid that 4.13-rc1 nbd aborts connection on writes for me: [ 251.938384] block nbd0: Send data failed (result -11) [ 251.943484] block nbd0: Request send failed trying another connection [ 251.950034] block nbd0: Receive control failed (result -32) [ 251.955676] block nbd0:

[PATCH for-4.13] block: disable runtime-pm for blk-mq

2017-07-21 Thread Christoph Hellwig
The blk-mq code lacks support for looking at the rpm_status field, tracking active requests and the RQF_PM flag. Due to the default switch to blk-mq for scsi people start to run into suspend / resume issue due to this fact, so make sure we disable the runtime PM functionality until it is properly

Re: [Xen-users] File-based domU - Slow storage write since xen 4.8

2017-07-21 Thread Benoit Depail
On 07/20/17 19:36, Keith Busch wrote: > On Thu, Jul 20, 2017 at 05:12:33PM +0200, Benoit Depail wrote: >> # Dom0 with a kernel >= 4.4.2, or a custom 4.4.1 including commit >> d2081cfe624b5decaaf68088ca256ed1b140672c >> >> On the dom0: >> # dd if=/dev/zero of=/mnt/d-anb-nab2.img bs=4M

[PATCH] block: use bio_io_error directly

2017-07-21 Thread Guoqing Jiang
bio_io_error is capable of replacing the two lines. Cc: Christoph Hellwig Cc: Philipp Reisner Cc: Lars Ellenberg Cc: Mike Snitzer Cc: Sagi Grimberg Cc: Alexander Viro