Re: [PATCH 0/5] blk-mq/scsi-mq: support global tags & introduce force_blk_mq

2018-02-09 Thread Ming Lei
Hi Kashyap, On Fri, Feb 09, 2018 at 02:12:16PM +0530, Kashyap Desai wrote: > > -Original Message- > > From: Ming Lei [mailto:ming@redhat.com] > > Sent: Friday, February 9, 2018 11:01 AM > > To: Kashyap Desai > > Cc: Hannes Reinecke; Jens Axboe; linux-block@vger.kernel.org; Christoph >

[PATCH V2] block: pass inclusive 'lend' parameter to truncate_inode_pages_range

2018-02-09 Thread Ming Lei
The 'lend' parameter of truncate_inode_pages_range is required to be inclusive, so follow the rule. This patch fixes one memory corruption triggered by discard. Cc: Cc: Dmitry Monakhov Fixes: 351499a172c0 ("block: Invalidate cache on discard v2") Signed-off-by: Ming Lei --- V2: - Cc st

Re: [LSF/MM ATTEND] State of blk-mq I/O scheduling and next steps

2018-02-09 Thread Ming Lei
On Fri, Feb 9, 2018 at 5:47 AM, Omar Sandoval wrote: > Hi, > > I'd like to attend LSF/MM to talk about the state of I/O scheduling in > blk-mq. I can present some results about mq-deadline and Kyber on our > production workloads. I'd also like to talk about what's next, in > particular, improvemen

Re: v4.16-rc1 + dm-mpath + BFQ

2018-02-09 Thread Jens Axboe
On 2/9/18 12:14 PM, Bart Van Assche wrote: > On 02/09/18 10:58, Jens Axboe wrote: >> On 2/9/18 11:54 AM, Bart Van Assche wrote: >>> Hello Paolo, >>> >>> If I enable the BFQ scheduler for a dm-mpath device then a kernel oops >>> appears (see also below). This happens systematically with Linus' tree

Re: v4.16-rc1 + dm-mpath + BFQ

2018-02-09 Thread Bart Van Assche
On 02/09/18 10:58, Jens Axboe wrote: On 2/9/18 11:54 AM, Bart Van Assche wrote: Hello Paolo, If I enable the BFQ scheduler for a dm-mpath device then a kernel oops appears (see also below). This happens systematically with Linus' tree from this morning (commit 54ce685cae30) merged with Jens' fo

Re: v4.16-rc1 + dm-mpath + BFQ

2018-02-09 Thread Jens Axboe
On 2/9/18 11:54 AM, Bart Van Assche wrote: > Hello Paolo, > > If I enable the BFQ scheduler for a dm-mpath device then a kernel oops > appears (see also below). This happens systematically with Linus' tree from > this morning (commit 54ce685cae30) merged with Jens' for-linus branch (commit > a7877

v4.16-rc1 + dm-mpath + BFQ

2018-02-09 Thread Bart Van Assche
Hello Paolo, If I enable the BFQ scheduler for a dm-mpath device then a kernel oops appears (see also below). This happens systematically with Linus' tree from this morning (commit 54ce685cae30) merged with Jens' for-linus branch (commit a78773906147 ("block, bfq: add requeue-request hook")) and f

[PATCH v3 2/3] block: Fix a race between the cgroup code and request queue initialization

2018-02-09 Thread Bart Van Assche
Initialize the request queue lock earlier such that the following race can no longer occur: blk_init_queue_node() blkcg_print_blkgs() blk_alloc_queue_node (1) q->queue_lock = &q->__queue_lock (2) blkcg_init_queue(q) (3) spin_lock_irq(blkg->

[PATCH v3 1/3] block: Add a third argument to blk_alloc_queue_node()

2018-02-09 Thread Bart Van Assche
This patch does not change any functionality. Signed-off-by: Bart Van Assche Cc: Christoph Hellwig Cc: Joseph Qi Cc: Philipp Reisner Cc: Ulf Hansson Cc: Kees Cook --- block/blk-core.c | 7 --- block/blk-mq.c| 2 +- drivers/block/null_blk.c | 3 ++- driv

[PATCH v3 0/3] Fix races between blkcg code and request queue initialization and cleanup

2018-02-09 Thread Bart Van Assche
Hello Jens, Recently Joseph Qi identified races between the block cgroup code and request queue initialization and cleanup. This patch series address these races. Please consider these patches for kernel v4.17. Thanks, Bart. Changes between v2 and v3: - Added a third patch that fixes a race bet

[PATCH v3 3/3] block: Fix a race between request queue removal and the block cgroup controller

2018-02-09 Thread Bart Van Assche
Avoid that the following race can occur: blk_cleanup_queue() blkcg_print_blkgs() spin_lock_irq(lock) (1) spin_lock_irq(blkg->q->queue_lock) (2,5) q->queue_lock = &q->__queue_lock (3) spin_unlock_irq(lock) (4) spin_unlock_irq(blkg-

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

2018-02-09 Thread Mike Galbraith
On Fri, 2018-02-09 at 14:21 +0100, Oleksandr Natalenko wrote: > > In addition to this I think it should be worth considering CC'ing Greg > to pull this fix into 4.15 stable tree. This isn't one he can cherry-pick, some munging required, in which case he usually wants a properly tested backport.

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

2018-02-09 Thread Jens Axboe
On 2/9/18 6:21 AM, Oleksandr Natalenko wrote: > Hi. > > 08.02.2018 08:16, Paolo Valente wrote: >>> Il giorno 07 feb 2018, alle ore 23:18, Jens Axboe ha >>> scritto: >>> >>> On 2/7/18 2:19 PM, Paolo Valente wrote: Commit 'a6a252e64914 ("blk-mq-sched: decide how to handle flush rq via >

Re: [PATCH] block: pass inclusive 'lend' parameter to truncate_inode_pages_range

2018-02-09 Thread Bart Van Assche
On Fri, 2018-02-09 at 22:15 +0800, Ming Lei wrote: > The 'lend' parameter of truncate_inode_pages_range is required to be > inclusive, so follow the rule. > > This patch fixes one memory corruption triggered by discard. > > Fixes: 351499a172c0 ("block: Invalidate cache on discard v2") Since this

[PATCH] block: pass inclusive 'lend' parameter to truncate_inode_pages_range

2018-02-09 Thread Ming Lei
The 'lend' parameter of truncate_inode_pages_range is required to be inclusive, so follow the rule. This patch fixes one memory corruption triggered by discard. Fixes: 351499a172c0 ("block: Invalidate cache on discard v2") Signed-off-by: Ming Lei --- block/ioctl.c | 2 +- 1 file changed, 1 inse

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

2018-02-09 Thread Oleksandr Natalenko
Hi. 08.02.2018 08:16, Paolo Valente wrote: Il giorno 07 feb 2018, alle ore 23:18, Jens Axboe ha scritto: On 2/7/18 2:19 PM, Paolo Valente wrote: Commit 'a6a252e64914 ("blk-mq-sched: decide how to handle flush rq via RQF_FLUSH_SEQ")' makes all non-flush re-prepared requests for a device be

[PATCH v2] blk: optimization for classic polling

2018-02-09 Thread Nitesh Shetty
From: Nitesh Shetty This removes the dependency on interrupts to wake up task. Set task state as TASK_RUNNING, if need_resched() returns true, while polling for IO completion. Earlier, polling task used to sleep, relying on interrupt to wake it up. This made some IO take very long when interrupt-

[PATCH V2 1/4] lightnvm: make 1.2 data structures explicit

2018-02-09 Thread Matias Bjørling
Make the 1.2 data structures explicit, so it will be easy to identify the 2.0 data structures. Also fix the order of which the nvme_nvm_* are declared, such that they follow the nvme_nvm_command order. Signed-off-by: Matias Bjørling --- drivers/nvme/host/lightnvm.c | 82 ++---

[PATCH V2 2/4] lightnvm: flatten nvm_id_group into nvm_id

2018-02-09 Thread Matias Bjørling
There are no groups in the 2.0 specification, make sure that the nvm_id structure is flattened before 2.0 data structures are added. Signed-off-by: Matias Bjørling --- drivers/lightnvm/core.c | 25 ++- drivers/nvme/host/lightnvm.c | 100 +--

[PATCH V2 0/4] lightnvm: base 2.0 implementation

2018-02-09 Thread Matias Bjørling
A couple of patches for 2.0 support for the lightnvm subsystem. They form the basis for integrating 2.0 support. For the rest of the support, Javier has code that implements report chunk and sets up the LBA format data structure. He also has a bunch of patches that brings pblk up to speed. The fi

[PATCH V2 4/4] nvme: lightnvm: add late setup of block size and metadata

2018-02-09 Thread Matias Bjørling
The nvme driver sets up the size of the nvme namespace in two steps. First it initializes the device with standard logical block and metadata sizes, and then sets the correct logical block and metadata size. Due to the OCSSD 2.0 specification relies on the namespace to expose these sizes for correc

[PATCH V2 3/4] lightnvm: add 2.0 geometry identification

2018-02-09 Thread Matias Bjørling
Implement the geometry data structures for 2.0 and enable a drive to be identified as one, including exposing the appropriate 2.0 sysfs entries. Signed-off-by: Matias Bjørling --- drivers/lightnvm/core.c | 8 +- drivers/nvme/host/lightnvm.c | 334 +-

RE: [PATCH 0/5] blk-mq/scsi-mq: support global tags & introduce force_blk_mq

2018-02-09 Thread Kashyap Desai
> -Original Message- > From: Ming Lei [mailto:ming@redhat.com] > Sent: Friday, February 9, 2018 11:01 AM > To: Kashyap Desai > Cc: Hannes Reinecke; Jens Axboe; linux-block@vger.kernel.org; Christoph > Hellwig; Mike Snitzer; linux-s...@vger.kernel.org; Arun Easi; Omar Sandoval; > Martin