Current bcache Kconfig uses '---help---' as header of help information,
for now 'help' is prefered. This patch fixes this style by replacing
'---help---' by 'help' in bcache Kconfig file.
Signed-off-by: Coly Li
Cc: Shenghui Wang
---
drivers/md/bcac
'%pF' and '%pf' are deprecated vsprintf pointer extensions, this patch
replace them by '%pS', which is suggested by checkpatch.pl.
Signed-off-by: Coly Li
Cc: Shenghui Wang
---
drivers/md/bcache/closure.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Symbolic permission names are used in bcache, for now octal permission
numbers are encouraged to use for readability. This patch replaces
all symbolic permissions by octal permission numbers.
Signed-off-by: Coly Li
Cc: Shenghui Wang
---
drivers/md/bcache/bcache.h | 4 ++--
drivers/md/bcache
This patch fixes typo 'succesfully' to correct 'successfully', which is
suggested by checkpatch.pl.
Signed-off-by: Coly Li
Cc: Shenghui Wang
---
drivers/md/bcache/io.c | 2 +-
drivers/md/bcache/request.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
dif
This patch declares char * array with const prefix in sysfs.c,
which is suggested by checkpatch.pl.
Signed-off-by: Coly Li
Cc: Shenghui Wang
---
drivers/md/bcache/sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c
This patch fixes 3 style issues warned by checkpatch.pl,
- Comment lines are not aligned
- Comments use "/*" on subsequent lines
- Comment lines use a trailing "*/"
Signed-off-by: Coly Li
Cc: Shenghui Wang
---
drivers/md/bcache/bset.c | 9 ++---
drivers/md/bca
This is warned by checkpatch.pl, this patch removes the extra space.
Signed-off-by: Coly Li
Cc: Shenghui Wang
---
drivers/md/bcache/bcache.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/md/bcache/bcache.h b/drivers/md/bcache/bcache.h
index 66e6d5639b38
This is not a preferred style to place open brace '{' at the end of
function definition, checkpatch.pl reports error for such coding
style. This patch moves them into the start of the next new line.
Signed-off-by: Coly Li
Cc: Shenghui Wang
---
drivers/md/bcache/super.c | 9 ++-
The SPDX header is missing fro closure.c, super.c and util.c, this
patch adds SPDX header for GPL-2.0 into these files.
Signed-off-by: Coly Li
Cc: Shenghui Wang
---
drivers/md/bcache/closure.c | 1 +
drivers/md/bcache/super.c | 1 +
drivers/md/bcache/util.c| 1 +
3 files changed, 3
Checkpatch.pl warns there are 2 locations of smp_mb() and smp_wmb()
without code comment. This patch adds the missing code comments for
these memory barrier calls.
Signed-off-by: Coly Li
Cc: Shenghui Wang
---
drivers/md/bcache/closure.h | 4 +++-
drivers/md/bcache/super.c | 2 +-
2 files
On 2018/8/10 4:26 PM, shenghui wrote:
>
>
> On 08/10/2018 03:23 PM, Coly Li wrote:
>> There are many function definitions do not have identifier argument names,
>> scripts/checkpatch.pl complains warnings like this,
>>
>> WARNING: function definition argumen
ert the input buffer into a long int type result.
Fixes: Commit ea8c5356d390 ("bcache: set max writeback rate when I/O request is
idle")
Signed-off-by: Coly Li
Cc: sta...@vger.kernel.org #4.16+
Cc: Kai Krakow
Cc: Stefan Priebe
---
drivers/md/bcache/sysfs.c | 13 ++---
1 f
limit.
Thanks in advance for any comment or review.
Changelog:
v3: Fix coments from Shenghui Wang.
v2: Fix comments from Shenghui Wang.
v1: Initial version
Coly Li
---
Coly Li (17):
bcache: style fix to replace 'unsigned' by 'unsigned int'
bcache: style fix to add a blan
dirty_init(struct bcache_device *);
This patch adds identifier argument names to all bcache function
definitions to fix such warnings.
Signed-off-by: Coly Li
Cc: Shenghui Wang
---
drivers/md/bcache/bcache.h| 112 +++---
drivers/md/bcache/bset.h
This patch fixes warning reported by checkpatch.pl by replacing 'unsigned'
with 'unsigned int'.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/alloc.c | 36 ++-
drivers/md/bcache/bcache.h| 107 +++
driv
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/alloc.c | 3 +++
drivers/md/bcache/bcache.h| 1 +
drivers/md/bcache/bset.c | 5 -
drivers/md/bcache/btree.c | 7 +++
drivers/md/bcache/closure.c | 1 +
drivers/md/bcache/debug.c | 4
There are still many places in bcache use printk to display kernel
message, which are suggested to be preplaced by pr_*() routines like
pr_err(), pr_info(), or pr_notice().
This patch replaces all printk() with a proper pr_*() routine for
bcache code.
Signed-off-by: Coly Li
Reviewed-by
Symbolic permission names are used in bcache, for now octal permission
numbers are encouraged to use for readability. This patch replaces
all symbolic permissions by octal permission numbers.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/bcache.h | 4 ++--
drivers/md
This patch fixes the lines over 80 characters into more lines, to minimize
warnings by checkpatch.pl. There are still some lines exceed 80 characters,
but it is better to be a single line and I don't change them.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/bca
bch_btree_insert_check_key() has unaligned indent, or indent by blank
characters. This patch makes the indent aligned and replace blank by
tabs.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/btree.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
'%pF' and '%pf' are deprecated vsprintf pointer extensions, this patch
replace them by '%pS', which is suggested by checkpatch.pl.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/closure.c | 4 ++--
1 file changed, 2 insertions(+), 2 dele
This patch fixes typo 'succesfully' to correct 'successfully', which is
suggested by checkpatch.pl.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/io.c | 2 +-
drivers/md/bcache/request.c | 2 +-
2 files changed, 2 insertions(+), 2 deleti
Current bcache Kconfig uses '---help---' as header of help information,
for now 'help' is prefered. This patch fixes this style by replacing
'---help---' by 'help' in bcache Kconfig file.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/b
This patch fixes 3 style issues warned by checkpatch.pl,
- Comment lines are not aligned
- Comments use "/*" on subsequent lines
- Comment lines use a trailing "*/"
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/bset.c | 9 ++---
drive
kmem_cache_destroy() is safe for NULL pointer as input, the NULL pointer
checking is unncessary. This patch just removes the NULL pointer checking
to make code simpler.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/request.c | 3 +--
1 file changed, 1 insertion(+), 2
Checkpatch.pl warns there are 2 locations of smp_mb() and smp_wmb()
without code comment. This patch adds the missing code comments for
these memory barrier calls.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/closure.h | 4 +++-
drivers/md/bcache/super.c | 2 +-
2
This is not a preferred style to place open brace '{' at the end of
function definition, checkpatch.pl reports error for such coding
style. This patch moves them into the start of the next new line.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/s
This patch declares char * array with const prefix in sysfs.c,
which is suggested by checkpatch.pl.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache
The SPDX header is missing fro closure.c, super.c and util.c, this
patch adds SPDX header for GPL-2.0 into these files.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/closure.c | 1 +
drivers/md/bcache/super.c | 1 +
drivers/md/bcache/util.c| 1 +
3 files changed
This is warned by checkpatch.pl, this patch removes the extra space.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/bcache.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/md/bcache/bcache.h b/drivers/md/bcache/bcache.h
index
set by sysfs
interface, because sysfs_strtoul_clamp() directly returns. This patch
fixes this and allows writeback_rate can be manually set again.
Coly Li
>
> Am 10.08.2018 um 17:45 schrieb Coly Li:
>> Commit ea8c5356d390 ("bcache: set max writeback rate when I/O request
>
On 2018/8/11 2:19 AM, Jens Axboe wrote:
> On 8/10/18 9:45 AM, Coly Li wrote:
>> Commit ea8c5356d390 ("bcache: set max writeback rate when I/O request
>> is idle") changes struct bch_ratelimit member rate from uint32_t to
>> atomic_long_t and uses atomic_long_set
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/alloc.c | 3 +++
drivers/md/bcache/bcache.h| 1 +
drivers/md/bcache/bset.c | 5 -
drivers/md/bcache/btree.c | 7 +++
drivers/md/bcache/closure.c | 1 +
drivers/md/bcache/debug.c | 4
line limit.
Thanks in advance for any comment or review.
Changelog:
v3: Fix coments from Shenghui Wang.
v2: Fix comments from Shenghui Wang.
v1: Initial version
Coly Li
---
Coly Li (17):
bcache: style fix to replace 'unsigned' by 'unsigned int'
bcache: style fix
There are still many places in bcache use printk to display kernel
message, which are suggested to be preplaced by pr_*() routines like
pr_err(), pr_info(), or pr_notice().
This patch replaces all printk() with a proper pr_*() routine for
bcache code.
Signed-off-by: Coly Li
Reviewed-by
dirty_init(struct bcache_device *);
This patch adds identifier argument names to all bcache function
definitions to fix such warnings.
Signed-off-by: Coly Li
Reviewed: Shenghui Wang
---
drivers/md/bcache/bcache.h| 112 +++---
drivers/md/bcache/bset.h
This patch fixes warning reported by checkpatch.pl by replacing 'unsigned'
with 'unsigned int'.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/alloc.c | 36 ++-
drivers/md/bcache/bcache.h| 107 +++
driv
Symbolic permission names are used in bcache, for now octal permission
numbers are encouraged to use for readability. This patch replaces
all symbolic permissions by octal permission numbers.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/bcache.h | 4 ++--
drivers/md
This patch fixes the lines over 80 characters into more lines, to minimize
warnings by checkpatch.pl. There are still some lines exceed 80 characters,
but it is better to be a single line and I don't change them.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/bca
bch_btree_insert_check_key() has unaligned indent, or indent by blank
characters. This patch makes the indent aligned and replace blank by
tabs.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/btree.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Checkpatch.pl warns there are 2 locations of smp_mb() and smp_wmb()
without code comment. This patch adds the missing code comments for
these memory barrier calls.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/closure.h | 4 +++-
drivers/md/bcache/super.c | 2 +-
2
This patch declares char * array with const prefix in sysfs.c,
which is suggested by checkpatch.pl.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache
'%pF' and '%pf' are deprecated vsprintf pointer extensions, this patch
replace them by '%pS', which is suggested by checkpatch.pl.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/closure.c | 4 ++--
1 file changed, 2 insertions(+), 2 dele
This patch fixes typo 'succesfully' to correct 'successfully', which is
suggested by checkpatch.pl.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/io.c | 2 +-
drivers/md/bcache/request.c | 2 +-
2 files changed, 2 insertions(+), 2 deleti
This patch fixes 3 style issues warned by checkpatch.pl,
- Comment lines are not aligned
- Comments use "/*" on subsequent lines
- Comment lines use a trailing "*/"
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/bset.c | 9 ++---
drive
Current bcache Kconfig uses '---help---' as header of help information,
for now 'help' is prefered. This patch fixes this style by replacing
'---help---' by 'help' in bcache Kconfig file.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/b
This is warned by checkpatch.pl, this patch removes the extra space.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/bcache.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/md/bcache/bcache.h b/drivers/md/bcache/bcache.h
index
This is not a preferred style to place open brace '{' at the end of
function definition, checkpatch.pl reports error for such coding
style. This patch moves them into the start of the next new line.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/s
The SPDX header is missing fro closure.c, super.c and util.c, this
patch adds SPDX header for GPL-2.0 into these files.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/closure.c | 1 +
drivers/md/bcache/super.c | 1 +
drivers/md/bcache/util.c| 1 +
3 files changed
kmem_cache_destroy() is safe for NULL pointer as input, the NULL pointer
checking is unncessary. This patch just removes the NULL pointer checking
to make code simpler.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/request.c | 3 +--
1 file changed, 1 insertion(+), 2
On 2018/8/11 1:19 PM, Coly Li wrote:
> Hi Jens,
>
> This series contains several minor fixes and code cleanup reported by
> scripts/checkpatch.pl. After this series, there are still a few warning
> from checkpatch.pl, but I think they are necessary to be the way they
> are and
On 2018/8/12 5:42 AM, Jens Axboe wrote:
> On 8/10/18 11:19 PM, Coly Li wrote:
>> Hi Jens,
>>
>> This series contains several minor fixes and code cleanup reported by
>> scripts/checkpatch.pl. After this series, there are still a few warning
>> from checkpatch.pl,
On 2018/8/12 11:10 PM, Jens Axboe wrote:
> On 8/10/18 10:49 PM, Coly Li wrote:
>> On 2018/8/11 2:19 AM, Jens Axboe wrote:
>>> On 8/10/18 9:45 AM, Coly Li wrote:
>>>> Commit ea8c5356d390 ("bcache: set max writeback rate when I/O request
>>>> is idle&
quot; when I apply this patch.
>
> Signed-off-by: Shan Hai
Nice catch!
This one should go to stable trees since 4.17 as well. I will CC stable
maintainers when I submit this one for 4.19.
Thank you for the fix.
Coly Li
> ---
> drivers/md/bcache/writeback.c | 4 +++-
> 1 file chang
From: Shan Hai
The writeback thread would exit with a lock held when the cache device is
detached via sysfs interface, fix it by releasing the held lock before exiting
the while-loop.
Signed-off-by: Shan Hai
Signed-off-by: Coly Li
Tested-by: Shenghui Wang
Cc: sta...@vger.kernel.org #4.17
han Hai
Signed-off-by: Coly Li
Tested-by: Shenghui Wang
Cc: sta...@vger.kernel.org #4.17+
---
Changelog:
v2: add Fixes tag by Coly Li.
v1: initial patch from Shan Hai.
drivers/md/bcache/writeback.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/md/bcache/writeback.
On 2018/8/23 2:02 AM, Coly Li wrote:
> From: Shan Hai
>
> The writeback thread would exit with a lock held when the cache device is
> detached via sysfs interface, fix it by releasing the held lock before exiting
> the while-loop.
>
> Fixes: fadd94e05c02 (bcache: quit dc-&
file system code.
This patch replaces REQ_META with correct flag REQ_PRIO.
CC Adam Manzanares because he explains to me what REQ_PRIO is for.
Signed-off-by: Coly Li
Cc: Adam Manzanares
---
drivers/md/bcache/request.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
On 9/26/18 12:32 AM, Adam Manzanares wrote:
On 9/25/18 9:12 AM, Coly Li wrote:
In cached_dev_cache_miss() and check_should_bypass(), REQ_META is used
to check whether a bio is for metadata request. REQ_META is used for
blktrace, the correct REQ_ flag should be REQ_PRIO. This flag means the
cool to have it in this run.
Thanks.
Coly Li
guoju (1):
bcache: add separate workqueue for journal_write to avoid deadlock
drivers/md/bcache/bcache.h | 1 +
drivers/md/bcache/journal.c | 6 +++---
drivers/md/bcache/super.c | 8
3 files changed, 12 insertions(+), 3 deletions
org
Signed-off-by: Coly Li
---
drivers/md/bcache/bcache.h | 1 +
drivers/md/bcache/journal.c | 6 +++---
drivers/md/bcache/super.c | 8
3 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/md/bcache/bcache.h b/drivers/md/bcache/bcache.h
index 83504dd8100a..954dad29e
ave it in my for-next. Thanks.
Coly Li
---
drivers/md/bcache/request.c | 3 +++
drivers/md/bcache/super.c | 4
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
index 7dbe8b6..bafc85e 100644
--- a/drivers/md/bca
replay, so we need to count these dirty keys even
device in clean status, otherwise after writeback, the amount
of dirty data would be incorrect.
Signed-off-by: Tang Junhui
---
Nice catch. Added to my for-next, and CC sta...@vger.kernel.org.
Thanks.
Coly Li
drivers/md/bcache/super.c | 3
From: Tang Junhui
Missed reading IOs are identified by s->cache_missed, not the
s->cache_miss, so in trace_bcache_read() using trace_bcache_read
to identify whether the IO is missed or not.
Signed-off-by: Tang Junhui
Cc: sta...@vger.kernel.org
Signed-off-by: Coly Li
---
drivers/md/
file system code.
This patch replaces REQ_META with correct flag REQ_PRIO.
CC Adam Manzanares because he explains to me what REQ_PRIO is for.
Signed-off-by: Coly Li
Cc: Adam Manzanares
---
drivers/md/bcache/request.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
e change.
After the change, the value is bigger about 1 bucket size.
Signed-off-by: Shenghui Wang
Reviewed-by: Tang Junhui
Signed-off-by: Coly Li
---
drivers/md/bcache/super.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super
The code comments of closure_return_with_destructor() in closure.h makrs
function name as closure_return(). This patch fixes this type with the
correct name - closure_return_with_destructor.
Signed-off-by: Coly Li
---
drivers/md/bcache/closure.h | 3 ++-
1 file changed, 2 insertions(+), 1
xes: 0f0709e6bfc3c ("bcache: stop bcache device when backing device is
offline")
Signed-off-by: Tang Junhui
Cc: sta...@vger.kernel.org
Signed-off-by: Coly Li
---
drivers/md/bcache/request.c | 3 +++
drivers/md/bcache/super.c | 4
2 files changed, 3 insertions(+), 4 deletions(-)
c for too small cache set size, with other code
cleanup changes. Shenghui and me have several code cleanup and minor
fixes, and Junhui again contributes helpful fixes for several real bugs.
Please pull them for 4.20 merge window. Thanks in advance.
Coly Li
---
Ben Peddell (1):
bcache: Pop
-off-by: Coly Li
---
drivers/md/bcache/super.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index a99af19d2f91..4989c7d4d4d0 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -1152,11 +1152,12
ck_rate_minimum attribute was dropped.
Re-add the missing sysfs writeback_rate_minimum attribute mapping to
"allow the user to specify a minimum rate at which dirty blocks are
retired."
Fixes: 1d316e6 bcache: implement PI controller for writeback rate
Signed-off-by: Ben Peddell
Signed-off-
From: Shenghui Wang
Recal cached_dev_sectors on cached_dev detached, as recal done on
cached_dev attached.
Update the cached_dev_sectors before bcache_device_detach called
as bcache_device_detach will set bcache_device->c to NULL.
Signed-off-by: Shenghui Wang
Signed-off-by: Coly
From: Dongbo Cao
Parameter "struct kobject *kobj" in bch_debug_init() is useless,
remove it in this patch.
Signed-off-by: Dongbo Cao
Signed-off-by: Coly Li
---
drivers/md/bcache/bcache.h | 2 +-
drivers/md/bcache/debug.c | 2 +-
drivers/md/bcache/super.c | 2 +-
3 files
From: Shenghui Wang
struct kmem_cache *bch_passthrough_cache is not used in
bcache code. Remove it.
Signed-off-by: Shenghui Wang
Signed-off-by: Coly Li
---
drivers/md/bcache/request.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/bcache/request.h b/drivers/md
ey buffer.
Signed-off-by: Tang Junhui
Cc: sta...@vger.kernel.org
Signed-off-by: Coly Li
---
drivers/md/bcache/btree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
index e7d4817681f2..3f4211b5cd33 100644
--- a/drivers/md/bcach
In extents.c:bch_extent_bad(), number 96 is used as parameter to call
btree_bug_on(). The purpose is to check whether stale gen value exceeds
BUCKET_GC_GEN_MAX, so it is better to use macro BUCKET_GC_GEN_MAX to
make the code more understandable.
Signed-off-by: Coly Li
---
drivers/md/bcache
ned-off-by: Shenghui Wang
Signed-off-by: Coly Li
---
drivers/md/bcache/alloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/bcache/alloc.c b/drivers/md/bcache/alloc.c
index 7a28232d868b..5002838ea476 100644
--- a/drivers/md/bcache/alloc.c
+++ b/drivers/md/bcache/alloc.c
From: Dongbo Cao
Split the combined '||' statements in if() check, to make the code easier
for debug.
Signed-off-by: Dongbo Cao
Signed-off-by: Coly Li
---
drivers/md/bcache/super.c | 90 +--
1 file changed, 76 insertions(+), 14 deletions(-)
di
From: Dongbo Cao
when the nbuckets of cache device is smaller than 1024, making cache
device will trigger BUG_ON in kernel, add a condition to avoid this.
Reported-by: nitroxis
Signed-off-by: Dongbo Cao
Signed-off-by: Coly Li
---
drivers/md/bcache/super.c | 8
1 file changed, 8
On 2018/10/8 下午10:19, Jens Axboe wrote:
> On 10/8/18 6:41 AM, Coly Li wrote:
>> From: Ben Peddell
>>
>> Forgot to include the maintainers with my first email.
>>
>> Somewhere between Michael Lyle's original
>> "bcache: PI controller for writebac
, which may be helpful for future writing requests.
If you are not sure whether this is helpful for your own workload, please
leave it as disabled by default.
Signed-off-by: Coly Li
---
drivers/md/bcache/bcache.h| 14 ++
drivers/md/bcache/sysfs.c | 9 +
drivers/md
sets c->sectors_to_gc to a positive value before gc_should_run().
This routine can be called where the gc thread is woken up and
required to run in force.
Signed-off-by: Coly Li
---
drivers/md/bcache/btree.h | 18 ++
drivers/md/bcache/sysfs.c | 17 ++---
2 files ch
: set writeback_percent in a flexible range
If anyone is also interested on writeback performance tuning with these
tunnable options, I do appreciate if you find a better performance
number with the non-default option values, and share them with us.
Thanks in advance.
Coly Li
---
Coly Li (5):
bcache: intr
This patch moves MODULE_AUTHOR and MODULE_LICENSE to end of super.c, and
add MODULE_DESCRIPTION("Bcache: a Linux block layer cache").
This is preparation for adding module parameters.
Signed-off-by: Coly Li
---
drivers/md/bcache/super.c | 7 ---
1 file changed, 4 insertions(+), 3
of users for most of
workloads. Anyway, if people wants to take their own risk to do research
on new writeback cutoff tuning for their own workload, now they can
make it.
Signed-off-by: Coly Li
---
drivers/md/bcache/super.c | 40
drivers/md/bcache/sysf
workloads. But for people who want to do research on bcache
writeback perforamnce tuning, they may have chance to specify more
flexible writeback_percent in range [0, 70].
Signed-off-by: Coly Li
---
drivers/md/bcache/sysfs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a
t; (first use in this function); did you mean ‘REQ_DISCARD’?
>>
>>
>> How should we proceed with this patch?
>
> The patch seems reasonably easy to backport. Compile-tested only, and
> only against v4.4.171.
I don't have idea whether stable kernels accept rebased patches, for
SUSE kernel I will do back port for all necessary kernel versions.
--
Coly Li
o_wait(&c->bucket_wait, &wait,
> + TASK_UNINTERRUPTIBLE);
> + if (!fifo_empty(&ca->free_inc))
> + break;
> + mutex_unlock(&c->bucket_lock);
> + schedule();
> + mutex_lock(&c->bucket_lock);
> + }
> +
> + finish_wait(&c->bucket_wait, &wait);
> bch_prio_write(ca);
> + }
> mutex_unlock(&c->bucket_lock);
>
> err = "cannot allocate new UUID bucket";
>
Hi Junhui,
It seems your patch losts all indent format. Could you please to handle
it and resend the peroper format again ?
Thanks.
--
Coly Li
th metadata and
high priority I/O requests will be handled properly.
Reported-by: Nix
Signed-off-by: Coly Li
Reviewed-by: Andre Noll
Cc: sta...@vger.kernel.org
Cc: Dave Chinner
Cc: Christoph Hellwig
---
drivers/md/bcache/request.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
dif
h replaces 'sizeof(unsigned long) * 7' by more generic
'sizeof(struct cache_stats))', to avoid potential error if new
member added into struct cache_stats.
Signed-off-by: Coly Li
---
drivers/md/bcache/stats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drive
metadata issue for XFS.
Please take them in your for-next.
Thanks in advance.
Coly Li
---
Colin Ian King (1):
bcache: fix indentation issue, remove tabs on a hunk of code
Coly Li (16):
bcache: not use hard coded memset size in bch_cache_accounting_clear()
bcache: export backing_dev_name via
of debugging:
https://www.spinics.net/lists/linux-bcache/msg06996.html
Previous reports:
- https://bugzilla.kernel.org/show_bug.cgi?id=201051
- https://bugzilla.kernel.org/show_bug.cgi?id=196103
- https://www.spinics.net/lists/linux-bcache/msg06885.html
(Coly Li: minor modification to follow maxi
een bcache device and backing device.
Signed-off-by: Coly Li
---
drivers/md/bcache/sysfs.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c
index 557a8a3270a1..b9166ee027fa 100644
--- a/drivers/md/bcache/sysfs.c
+++ b/drivers/md/bca
-show, but
directly exporting backing_dev_uuid by sysfs file
/sys/block/bcache/bcache/backing_dev_uuid is a much simpler method.
With backing_dev_uuid, and partition uuids from /dev/disk/by-partuuid/,
now we can identify each bcache device and its partitions conveniently.
Signed-off-by: Coly Li
From: Colin Ian King
There is a hunk of code that is indented one level too deep, fix this
by removing the extra tabs.
Signed-off-by: Colin Ian King
Signed-off-by: Coly Li
---
drivers/md/bcache/super.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions
lue indeed set is 1410065407, which is not expected
behavior.
This patch replaces sysfs_strtoul() by sysfs_strtoul_clamp() when
convert input string to unsigned int value, and set value range in
[0, UINT_MAX], to avoid the above integer overflow errors.
Signed-off-by: Coly Li
---
drivers/md/bcac
dc->disk.c, &w->key, 0));
B) It could be worse when reads hits stale dirty keys, it would
read old incorrect data.
This patch tolerate the existence of these stale && dirty keys,
and treat them as bad key in bch_extent_bad().
(Coly Li: fix indent which was modified by sender
etting a bool value like expensive_debug_checks.
Signed-off-by: Coly Li
---
drivers/md/bcache/sysfs.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c
index 96b64893f2cb..57395e23747a 100644
--- a/drivers/md/bcache/sysfs.c
this method, if bit
width of var is less than unsigned long, integer overflow won't happen
before min and max are checking.
Now sysfs_strtoul_clamp() can properly handle smaller data type like
unsigned int, of cause min and max should be defined in range of
unsigned int too.
Signed-off-by
dc->writeback_delay.
This patch uses sysfs_strtoul_clamp() to convert the input string and
set the result value range in [0, UINT_MAX] to avoid such unsigned
integer overflow.
Signed-off-by: Coly Li
---
drivers/md/bcache/sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/driv
101 - 200 of 854 matches
Mail list logo
