Re: [PATCH 2/3] blktests: add python scripts for parsing fio json output

penSUSE:Leap:15.0 Name : jq Version: 1.5-lp150.1.10 Arch : x86_64 Vendor : openSUSE Installed Size : 93.4 KiB Installed : Yes [...] -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SU

Re: [PATCH] block: update documentation

On 28/11/2018 02:25, Damien Le Moal wrote: > Jens Axboe , February 2009 I guess that address of Jens' doesn't work anymore either. -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX G

Re: [PATCH 04/20] block: wire up block device iopoll method

Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH 03/20] fs: add an iopoll method to struct file_operations

Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH 02/20] aio: clear IOCB_HIPRI

Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH 01/20] aio: fix failure to put the file pointer

Reivewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH 5/7] aio: Fix fallback I/O priority value

Looks good, Reiewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 4/7] block: Introduce get_current_ioprio()

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 1/7] aio: Comment use of IOCB_FLAG_IOPRIO aio flag

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 2/7] block: Remove bio->bi_ioc

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 3/7] scsi: push blk_status_t up into scsi_setup_{fs,scsi}_cmnd

Look good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH] block: Clear kernel memory before copying to user

blktests? This would be very useful for downstream distributions. Thanks a lot, Johannes -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imen

Re: [PATCH v2] block: BFQ default for single queue devices

policy = "mq-deadline"; Which chooses mq-deadline on a zoned device. So nothing to worry about here now. All this only given Linus' patch actually gets merged. Byte, Johannes -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de

Re: [PATCH 2/2] loop/007: Add test for oops during backing file verification

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 1/2] loop/006: Add test for setting partscan flag

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 6/6] mtip32xx: fully switch to the generic DMA API

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 0/15 v2] loop: Fix oops and possible deadlocks

Any opinions? Personally I think a test that has varying outcomes depending on how often you run it (just to hit the race) isn't really suitable for a suite like blktests. But that's my personal opinion only, Omar what's your opinion here? -- Johannes Thumshirn

Re: [PATCH] blk-mq: provider helper for setting up an SQ queue and tag set

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 17/17] null_blk: remove legacy IO path

h. Unless legacy path is not used any longer, why not keep it in the > code > as a tutorial? But when there is no tutorial on how to write drivers for the legacy path no one will write drivers for the legacy path and will be upset when we remove it. Johan

Re: [PATCH 0/15 v2] loop: Fix oops and possible deadlocks

On Wed, Oct 10, 2018 at 02:28:09PM +0200, Jan Kara wrote: > On Wed 10-10-18 13:42:27, Johannes Thumshirn wrote: > > On Wed, Oct 10, 2018 at 07:19:00PM +0900, Tetsuo Handa wrote: > > > On 2018/10/10 19:04, Jan Kara wrote: > > > > Hi, > > > > > &g

Re: [PATCH 0/15 v2] loop: Fix oops and possible deadlocks

category and I think it could also be worthwhile to add the C reproducer from syzkaller to blktests. Byte, Johannes -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N

Re: [PATCH] blk-mq-debugfs: Also show requests that have not yet been started

>> > >>> Signed-off-by: Bart Van Assche > >>> Cc: Christoph Hellwig > >>> Cc: Ming Lei > >>> Cc: Hannes Reinecke > >>> Cc: Johannes Thumshirn > >>> Cc: Martin K. Petersen > >> > >> For some reas

Re: [PATCH] blk-mq-debugfs: Also show requests that have not yet been started

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v10 7/8] block: Make blk_get_request() block for non-PM requests while suspended

On Wed, Sep 26, 2018 at 11:24:55AM -0700, Bart Van Assche wrote: > On Wed, 2018-09-26 at 17:06 +0200, Johannes Thumshirn wrote: > > On Wed, Sep 26, 2018 at 04:57:32PM +0200, Christoph Hellwig wrote: > > > I don't think this actually works given that rpm_status only exists > &g

Re: [PATCH v10 7/8] block: Make blk_get_request() block for non-PM requests while suspended

attern. Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC3

Re: [PATCH v10 7/8] block: Make blk_get_request() block for non-PM requests while suspended

; +*/ > > + WARN_ON_ONCE(q->rpm_status == RPM_SUSPENDED); > > +#endif > > I hate this ifdef, but it probably isnt worth adding a helper for this > assert, so I guess we'll have to live with it.. How about: if (IS_ENABLED

Re: [PATCH] block: fix deadline elevator drain for zoned block devices

On Wed, Sep 26, 2018 at 04:23:16PM +0900, Damien Le Moal wrote: > When the deadline scheduler is used with a zoned block device, writes > to a zone will be dispatched one a a time. This causes the warning at a time? ^ Otherwise, Reviewed-by: Johannes Thu

Re: [PATCH v9 1/8] blk-mq: Document the functions that iterate over requests

bool reserved) Otherwise: Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graha

Re: [PATCH blktests 0/3] Add NVMeOF multipath tests

I have to admit. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnber

Re: [PATCH blktests 0/3] Add NVMeOF multipath tests

itory. Hi Bart, is there a special reason this isn't in the nvme category? I don't really see a blocker here. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90

Re: [PATCH] block: Remove two superfluous #include directives

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v4 2/2] block: Ensure that a request queue is dissociated from the cgroup controller

>From my limited insight into this: Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, J

Re: [PATCH v4 1/2] block: Introduce blk_exit_queue()

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH] block: copy ioprio in __bio_clone_fast()

Good catch, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH for v4.18] blk-mq: Rename BLK_EH_DONE into BLK_EH_DONT_RESET_TIMER

I'm OK with the rename in general but not sure about doing it this late in the cycle. Anyways, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr

Re: Silent data corruption in blkdev_direct_IO()

nks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9

Re: [PATCH 1/3] block: Fix a comment in a header file

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 2/2] blktests: add test for ANA state transition

On Tue, Jul 17, 2018 at 03:31:18PM +0200, Hannes Reinecke wrote: > +requires() { > + _have_program nvme && _have_module nvme-loop && _have_module loop && \ > + _have_configfs && _have_fio > +} this needs '_have_module_param nvme-core

Re: [PATCH blktests v3 1/6] dir-locals.el: Add c-mode settings

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH blktests v2] dir-locals.el: fix indenation with Emacs

On Fri, Jul 06, 2018 at 02:17:44PM -0700, Omar Sandoval wrote: > On Fri, Jul 06, 2018 at 10:21:28AM +0200, Johannes Thumshirn wrote: > > A recent update of Emacs broke .dir-locals.el's shell indentation > > setting. > > > > Also set 'sh-indendation

Re: [PATCH blktests] dir-locals: fix indenation with Emacs

On Thu, Jul 05, 2018 at 11:13:48AM -0700, Bart Van Assche wrote: > On 07/04/18 04:59, Johannes Thumshirn wrote: > > A recent update of Emacs broke .dir-locals.el's shell indendation > > setting. > > Please fix the spelling of "indentation" in the subject and in the

[PATCH blktests v2] dir-locals.el: fix indenation with Emacs

A recent update of Emacs broke .dir-locals.el's shell indentation setting. Also set 'sh-indendation' not just 'sh-basic-offset' for this. Signed-off-by: Johannes Thumshirn Reviewed-by: Bart Van Assche --- Changes to v1: - Fix spelling and subject prefix - Add Bart's R-b --- .dir-locals.el

[PATCH blktests] dir-locals: fix indenation with Emacs

A recent update of Emacs broke .dir-locals.el's shell indendation setting. Also set 'sh-indendation' not just 'sh-basic-offset' for this. Signed-off-by: Johannes Thumshirn --- .dir-locals.el | 1 + 1 file changed, 1 insertion(+) diff --git a/.dir-locals.el b/.dir-locals.el index f64c48202910

Re: [PATCH V2] blk-mq: code clean-up by adding an API to clear set->mq_map

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH] blk-mq: code clean-up by adding an API to clear set->mq_map

gling too much things in parallel currently. Sorry for that. Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithar

Re: [PATCH] blk-mq: code clean-up by adding an API to clear set->mq_map

lk_mq_clear_mq_map(struct blk_mq_tag_set *set) +{ + int cpu; + + for_each_possible_cpu(cpu) + set->mq_map[cpu] = 0; +} + static inline u16 blk_mq_unique_tag_to_hwq(u32 unique_tag) { return unique_tag >> BLK_MQ_UNIQUE_TAG_BITS; -- Johannes Thumshirn

Re: [PATCH] blk-mq: code clean-up by adding an API to clear set->mq_map

uld still evaluate if it isn't worth to make it: +static void blk_mq_clear_mq_map(struct blk_mq_tag_set *set) +{ + int cpu; + + for_each_possible_cpu(cpu) + set->mq_map[cpu] = 0; +} and put it into 'include/linux/blk-mq.h'. Johannes -

Re: [PATCH] blk-mq: code clean-up by adding an API to clear set->mq_map

n API to clear set->mq_map to make it clear. Is there a follow up patch to this which justifies the change? With no 2nd consumer of the function I fear this will be disregarded as useless code churn. Byte, Johannes -- Johannes Thumshirn Stora

Re: [PATCH 1/3] blk-mq: use list_splice_tail() to insert requests

racing is enabled? Not sure if this is possible though. Maybe Steven (Cced) can help here. Byte, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg

Re: [PATCH blktests v2 2/3] Add the discontiguous-io test program

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH blktests v2 1/3] src/Makefile: Rename $(TARGETS) into $(C_TARGETS)

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH blktests 00/15] Add SRP initiator driver tests

each test. No actually there is. There is a group_requires() in the test/XXX/group file (check for instance tests/group/nvme which has group_requires() calling _have_root and a group_device_requires() calling _test_dev_is_nvme). Byte, Johannes -- Johannes

Re: [PATCH blktests 15/15] Add tests for the SRP initiator and target drivers

On Fri, Jun 22, 2018 at 03:19:46PM -0700, Bart Van Assche wrote: > tests/srp/functions | 1288 +++ Can you please move these into common/srp? Thanks, Johannes -- Johannes Thumshirn Storage jthu

Re: [PATCH blktests 00/15] Add SRP initiator driver tests

IO configuration data if e.g. blktests is run accidentally > on a production server. I think that wiping LIO configuration data should > be a manual step. I think this should be handled in requires(). I.e. check if LIO is already configured and then skip the test if it

Re: [PATCH blktests] check: add command line switch to test device drivers only

Thanks :-) -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38

Re: [PATCH blktests] check: add command line switch to test device drivers only

Ping? -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB

Re: [PATCH 9/9] Makefile: Do not suppress useful shellcheck warnings

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 7/9] Avoid passing tests/block/002 arguments to _init_scsi_debug

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 8/9] check: Suppress a shellcheck warning about the DMESG_FILTER initialization

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 6/9] Multiple tests: remove unused and undefined variables

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 5/9] check: Avoid that shellcheck complains that $FULL appears unused

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 4/9] Suppress shellcheck complaints about global variables

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 3/9] check, tests/meta/012: Use array["index"] instead of array[index]

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 1/9] common/rc: Fix _have_tracepoint()

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 2/9] Annotate include statements in shell scripts where the source file is a variable

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

[PATCH blktests] check: add command line switch to test device drivers only

and not a test() function. Signed-off-by: Johannes Thumshirn --- check | 18 ++ 1 file changed, 18 insertions(+) diff --git a/check b/check index 4baa8dde2436..639fcc43f09d 100755 --- a/check +++ b/check @@ -395,6 +395,12 @@ _run_test() { . "tests/${TEST_NAME}"

Re: [PATCHv2] block: always set partition number to '0' in blk_partition_remap()

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH blktests 1/9] blktests: add hepler functions for new md tests

as from linux-block and linux-raid channels are welcome. :) Migrating them over would be the best thing since sliced bread. Having to run only one test suite for the linux block device space is our long term goal. Thanks, Johannes -- Johannes Thumshirn

Re: [PATCH blktests 1/9] blktests: add hepler functions for new md tests

On Wed, Jun 06, 2018 at 08:29:25AM -0600, Jens Axboe wrote: > Hopefully this can be the start of migrating over those tests! Yes this would be great. I just wanted to connect the submitter and the md developers and make them aware of possibly duplicated efforts ;-). -- Johannes Thumsh

Re: [PATCH blktests 1/9] blktests: add hepler functions for new md tests

ping > ./check md > > For someone who don't want to run md tests, they just keep RAID_DEVS > and RAID_SPARE_DEVS not assigned, all md tests will be skipped. While I'm very much in support for the idea, please be aware that md has an own test suite by itsel

Re: [PATCH 08/14] nvmet: implement the changed namespaces log

On Tue, May 29, 2018 at 10:17:12AM +0200, Christoph Hellwig wrote: > On Mon, May 28, 2018 at 08:53:42AM +0200, Johannes Thumshirn wrote: > > Reviewed-by: Johannes Thumshirn > > > > As a side note, what happens if more than 1024 Namespaces are changed > > (apart f

Re: [PATCH 04/14] nvme.h: add the changed namespace list log

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 07/14] nvmet: split log page implementation

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 08/14] nvmet: implement the changed namespaces log

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> As a side note, what happens if more than 1024 Namespaces are changed (apart from setting the 1st element to 0x and zeroing out the rest)? The Spec is pretty silent in this regard. -- Johannes Thu

Re: [PATCH 13/14] nvme: use the changed namespaces list log to clear ns data changed AENs

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 05/14] nvme.h: add AER configuration symbols

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 10/14] nvmet: mask pending AERs

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 12/14] nvme: mark nvme_queue_scan static

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 06/14] nvmet: add a new nvmet_zero_sgl helper

Don't we already have this? Or is it a re-send? It looks so awefully familiar to me... Anyways, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 68

Re: [PATCH 01/14] block: unexport check_disk_size_change

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 09/14] nvmet: Add AEN configuration support

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 14/14] nvme: limit warnings from nvme_identify_ns

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 11/14] nvme: submit AEN event configuration on startup

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 03/14] nvme.h: untangle AEN notice definitions

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 02/14] block: don't print a message when the device went away

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 07/14] scsi_transport_fc: complete requests from ->timeout

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 06/14] null_blk: complete requests from ->timeout

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 05/14] mtip32xx: complete requests from ->timeout

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 03/14] nvme: return BLK_EH_DONE from ->timeout

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 02/14] block: rename BLK_EH_NOT_HANDLED to BLK_EH_DONE

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH blktests] Documentation: document prerequisite scriptlets

github.com/osandov/osandov-linux#vm-setup Cool thanks for sharing. Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH blktests] blktests: use consistent helper returns

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH V6 11/11] nvme: pci: support nested EH

On Fri, May 18, 2018 at 10:28:04AM -0600, Keith Busch wrote: > On Thu, May 17, 2018 at 04:23:45PM +0200, Johannes Thumshirn wrote: > > > Agreed. Alternatively possibly call the driver's reset_preparei/done > > > callbacks. > > > > Exactly, but as long as we can i

Re: [PATCH blktests] Documentation: document prerequisite scriptlets

rker of mine started for this job. As minimal as possible. I try to get my rebuild - boot - test cycles short. With my current config I have a bootup time in qemu below half a second on a reasonable machine in my lab and just below one second on my laptop. [1] https://github.com/rapid

Re: [PATCH 08/10] block: Add warning for bi_next not NULL in bio_endio()

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 03/10] block: Add bioset_init()/bioset_exit()

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 02/10] block: Convert bio_set to mempool_init()

On Fri, May 18, 2018 at 03:49:01AM -0400, Kent Overstreet wrote: > Minor performance improvement by getting rid of pointer indirections > from allocation/freeing fastpaths. Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> Although I'd prefer numbers in the changelog w

Re: [PATCH V6 11/11] nvme: pci: support nested EH

attribute appears to have been added by Arjan for the > > Xorg driver. I think if we have a driver bound to the device we > > should not allow it. > > Agreed. Alternatively possibly call the driver's reset_preparei/done > callbacks. Exactly, but as

Re: [PATCH blktests] Documentation: document prerequisite scriptlets

Omar, ping? -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38

[PATCH blktests] Documentation: document prerequisite scriptlets

The config file is bash and it gets sourced, so all bash magic is doable in there as well. Document it so others don't have to re-discover this gem as well. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- Documentation/running-tests.md | 12 1 file changed, 12 inse

  1   2   3   4   >