Re: [PATCH 2/3] blktests: add python scripts for parsing fio json output
On 04/12/2018 18:47, Josef Bacik wrote:
> +For example
> +"write" : {
> +"io_bytes" : 313360384,
> +"bw" : 1016,
> +}
> +
> +Get's collapsed to
> +
> +"write_io_bytes" : 313360384,
> +"write_bw": 1016,
I'd definitively prefer to not pull in python as a dependency. The above
example can be done in shell (with the jq utility) as follows:
jthumshirn@linux-x5ow:~$ cat test.json |\
jq '. | {write_io_bytes: .write.io_bytes, write_bw: .write.bw}'
{
"write_io_bytes": 313360384,
"write_bw": 1016
}
And on a plus side jq is small as well:
jthumshirn@linux-x5ow:~$ zypper info jq
Loading repository data...
Reading installed packages...
Information for package jq:
---
Repository : openSUSE:Leap:15.0
Name : jq
Version: 1.5-lp150.1.10
Arch : x86_64
Vendor : openSUSE
Installed Size : 93.4 KiB
Installed : Yes
[...]
--
Johannes ThumshirnSUSE Labs Filesystems
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] block: update documentation
On 28/11/2018 02:25, Damien Le Moal wrote: > Jens Axboe , February 2009 I guess that address of Jens' doesn't work anymore either. -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 04/20] block: wire up block device iopoll method
Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 03/20] fs: add an iopoll method to struct file_operations
Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 02/20] aio: clear IOCB_HIPRI
Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 01/20] aio: fix failure to put the file pointer
Reivewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 5/7] aio: Fix fallback I/O priority value
Looks good, Reiewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 4/7] block: Introduce get_current_ioprio()
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 1/7] aio: Comment use of IOCB_FLAG_IOPRIO aio flag
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 2/7] block: Remove bio->bi_ioc
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 3/7] scsi: push blk_status_t up into scsi_setup_{fs,scsi}_cmnd
Look good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] block: Clear kernel memory before copying to user
On 08/11/2018 02:22, Keith Busch wrote:
> $ ./sg-test /dev/sda | grep -v 0
> 40733f4019db8001244019db4065244019db0094244019db
> c025244019dbc0e43a4019db40973a4019dbc0623a4019db
> 800c244019dbc0d61d4019dbc05f244019db80091e4019db
> 40913a4019db806f3f4019db40a83f4019dbc083244019db
> 80eb1e4019db00a93f4019dbc09a3a4019db40503f4019db
> 007f1b4019dbc0d91e4019db40551e4019db804a1b4019db
>
> --
>
Hi Keith,
Can you please add the above to blktests?
This would be very useful for downstream distributions.
Thanks a lot,
Johannes
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH v2] block: BFQ default for single queue devices
On 19/10/18 15:36, Bryan Gurney wrote: > I like this idea. I don't have enough experience to write this patch > myself, but I imagine something like adding "bool is_zoned_aware" to > "struct elevator_type", and setting that true only for the schedulers > that are currently zoned-device aware (which is currently deadline on > single queue, mq-deadline on blk-mq). I don't think this is needed currently as a) Jens is working on getting rid of the legacy path, which leaves us with mq-deadline only and Linus' patch has: + if (blk_queue_is_zoned(q)) + policy = "mq-deadline"; Which chooses mq-deadline on a zoned device. So nothing to worry about here now. All this only given Linus' patch actually gets merged. Byte, Johannes -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 2/2] loop/007: Add test for oops during backing file verification
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 1/2] loop/006: Add test for setting partscan flag
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 6/6] mtip32xx: fully switch to the generic DMA API
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 0/15 v2] loop: Fix oops and possible deadlocks
On 16/10/18 13:36, Jan Kara wrote: [...] > 2) For the oops (use-after-free) issue I was not able to reproduce that in > my test KVM in couple hours. The race window is rather narrow and syzbot > with KASAN and everything hit it only 11 times. So I'm not sure how useful > that test is. Any opinions? Personally I think a test that has varying outcomes depending on how often you run it (just to hit the race) isn't really suitable for a suite like blktests. But that's my personal opinion only, Omar what's your opinion here? -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] blk-mq: provider helper for setting up an SQ queue and tag set
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 17/17] null_blk: remove legacy IO path
On 12/10/18 08:56, Dongli Zhang wrote:
> Hi Jens,
>
> Will the legacy path be fully deprecated?
>
> In addition to performance measurement, null_blk is a very good tutorial for
> beginners to understand how to implement a legacy path based block driver from
> scratch. Unless legacy path is not used any longer, why not keep it in the
> code
> as a tutorial?
But when there is no tutorial on how to write drivers for the legacy
path no one will write drivers for the legacy path and will be upset
when we remove it.
Johannes
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 0/15 v2] loop: Fix oops and possible deadlocks
On Wed, Oct 10, 2018 at 02:28:09PM +0200, Jan Kara wrote: > On Wed 10-10-18 13:42:27, Johannes Thumshirn wrote: > > On Wed, Oct 10, 2018 at 07:19:00PM +0900, Tetsuo Handa wrote: > > > On 2018/10/10 19:04, Jan Kara wrote: > > > > Hi, > > > > > > > > this patch series fixes oops and possible deadlocks as reported by > > > > syzbot [1] > > > > [2]. The second patch in the series (from Tetsuo) fixes the oops, the > > > > remaining > > > > patches are cleaning up the locking in the loop driver so that we can > > > > in the > > > > end reasonably easily switch to rereading partitions without holding > > > > mutex > > > > protecting the loop device. > > > > > > > > I have lightly tested the patches by creating, deleting, and modifying > > > > loop > > > > devices but if there's some more comprehensive loopback device > > > > testsuite, I > > > > can try running it. Review is welcome! > > > > > > Testing on linux-next by syzbot will be the most comprehensive. ;-) > > > > Apart from that blktests has a loop category and I think it could also be > > worthwhile to add the C reproducer from syzkaller to blktests. > > Yeah, I did run loop tests now and they ran fine. I can try converting the > syzbot reproducers into something legible but it will take a while. There is one C repropducer which can be used (it just needs minor modifications to pass in the device instead of loop0). See for instance blktests/src/sg/syzkaller1.c -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 0/15 v2] loop: Fix oops and possible deadlocks
On Wed, Oct 10, 2018 at 07:19:00PM +0900, Tetsuo Handa wrote: > On 2018/10/10 19:04, Jan Kara wrote: > > Hi, > > > > this patch series fixes oops and possible deadlocks as reported by syzbot > > [1] > > [2]. The second patch in the series (from Tetsuo) fixes the oops, the > > remaining > > patches are cleaning up the locking in the loop driver so that we can in the > > end reasonably easily switch to rereading partitions without holding mutex > > protecting the loop device. > > > > I have lightly tested the patches by creating, deleting, and modifying loop > > devices but if there's some more comprehensive loopback device testsuite, I > > can try running it. Review is welcome! > > Testing on linux-next by syzbot will be the most comprehensive. ;-) Apart from that blktests has a loop category and I think it could also be worthwhile to add the C reproducer from syzkaller to blktests. Byte, Johannes -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] blk-mq-debugfs: Also show requests that have not yet been started
On Fri, Oct 05, 2018 at 07:13:32PM -0600, Jens Axboe wrote: > On 10/5/18 4:37 PM, Omar Sandoval wrote: > > On Fri, Oct 05, 2018 at 08:18:00AM -0600, Jens Axboe wrote: > >> On 10/4/18 11:35 AM, Bart Van Assche wrote: > >>> When debugging e.g. the SCSI timeout handler it is important that > >>> requests that have not yet been started or that already have > >>> completed are also reported through debugfs. > >> > >> Thanks, I like this better - applied. BTW, what's up with the > >> reverse ordering on this: > >> > >>> Signed-off-by: Bart Van Assche > >>> Cc: Christoph Hellwig > >>> Cc: Ming Lei > >>> Cc: Hannes Reinecke > >>> Cc: Johannes Thumshirn > >>> Cc: Martin K. Petersen > >> > >> For some reason that really annoys me, and I see it in various > >> patches these days. IMHO the SOB should be last, with whatever > >> acks, reviews, CC, before that. > > > > I could've sworn that this guideline was even documented somewhere, but > > I can't find it now ¯\_(ツ)_/¯ > > My guess is that it's some newer git thing - but if it is, it's really > annoying and should be reverted. I end up fixing these up by hand. Isn't it the way patchwork adds the tags? And yes I also thought this is the correct way of adding the Ccs, etc.. -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] blk-mq-debugfs: Also show requests that have not yet been started
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH v10 7/8] block: Make blk_get_request() block for non-PM requests while suspended
On Wed, Sep 26, 2018 at 11:24:55AM -0700, Bart Van Assche wrote: > On Wed, 2018-09-26 at 17:06 +0200, Johannes Thumshirn wrote: > > On Wed, Sep 26, 2018 at 04:57:32PM +0200, Christoph Hellwig wrote: > > > I don't think this actually works given that rpm_status only exists > > > if CONFIG_PM is set. > > > > I think it'll work as GCC does constant propagation. There are > > actually some places in the kernel that follow this pattern. > > This is what gcc on my development system thinks about that proposal: > > In file included from ./arch/x86/include/asm/bug.h:83:0, > from ./include/linux/bug.h:5, > from ./include/linux/thread_info.h:12, > from ./arch/x86/include/asm/preempt.h:7, > from ./include/linux/preempt.h:81, > from ./include/linux/spinlock.h:51, > from ./include/linux/seqlock.h:36, > from ./include/linux/time.h:6, > from ./include/linux/stat.h:19, > from ./include/linux/module.h:10, > from block/blk-core.c:15: > block/blk-core.c: In function ‘elv_next_request’: > block/blk-core.c:2795:44: error: ‘struct request_queue’ has no member named > ‘rpm_status’; did you mean ‘stats’? > WARN_ON_ONCE(q->rpm_status == RPM_SUSPENDED); > ^ > ./include/asm-generic/bug.h:69:25: note: in definition of macro ‘WARN_ON_ONCE’ > int __ret_warn_on = !!(condition); \ > ^ > scripts/Makefile.build:305: recipe for target 'block/blk-core.o' failed Aparently this only works for functions and not struct members, my bad. Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH v10 7/8] block: Make blk_get_request() block for non-PM requests while suspended
On Wed, Sep 26, 2018 at 04:57:32PM +0200, Christoph Hellwig wrote: > I don't think this actually works given that rpm_status only exists > if CONFIG_PM is set. I think it'll work as GCC does constant propagation. There are actually some places in the kernel that follow this pattern. Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH v10 7/8] block: Make blk_get_request() block for non-PM requests while suspended
On Wed, Sep 26, 2018 at 04:27:40PM +0200, Christoph Hellwig wrote:
> > list_for_each_entry(rq, >queue_head, queuelist) {
> > - if (blk_pm_allow_request(rq))
> > - return rq;
> > -
> > - if (rq->rq_flags & RQF_SOFTBARRIER)
> > - break;
> > +#ifdef CONFIG_PM
> > + /*
> > +* If a request gets queued in state RPM_SUSPENDED
> > +* then that's a kernel bug.
> > +*/
> > + WARN_ON_ONCE(q->rpm_status == RPM_SUSPENDED);
> > +#endif
>
> I hate this ifdef, but it probably isnt worth adding a helper for this
> assert, so I guess we'll have to live with it..
How about:
if (IS_ENABLED(CONFIG_PM))
WARN_ON_ONCE(q->rpm_status == RPM_SUSPENDED);
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] block: fix deadline elevator drain for zoned block devices
On Wed, Sep 26, 2018 at 04:23:16PM +0900, Damien Le Moal wrote: > When the deadline scheduler is used with a zoned block device, writes > to a zone will be dispatched one a a time. This causes the warning at a time? ^ Otherwise, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH v9 1/8] blk-mq: Document the functions that iterate over requests
On Wed, Sep 19, 2018 at 03:45:23PM -0700, Bart Van Assche wrote: > Make it easier to understand the purpose of the functions that iterate > over requests by documenting their purpose. Fix three minor spelling > mistakes in comments in these functions. [...] > > +/* > + * Call function @fn(@hctx, rq, @data, @reserved) for each request queued on > + * @hctx that has been assigned a driver tag. @reserved indicates whether @bt > + * is the breserved_tags member or the bitmap_tags member of struct > + * blk_mq_tags. > + */ > static void bt_for_each(struct blk_mq_hw_ctx *hctx, struct sbitmap_queue *bt, > busy_iter_fn *fn, void *data, bool reserved) One minor nit and only if you have to re-send the series, can you please also add the usual kernel-doc headers to the comments, i.e.: /** * bt_for_each() - run callback on each hctx with a driver tag * @hctx: the hardware context * @bt: the sbitmap_queue * @fn: the callback function to run * @data: the data for the callback function * @reserved: is reserved or not * * Call function @fn(@hctx, rq, @data, @reserved) for each request queued on * @hctx that has been assigned a driver tag. @reserved indicates whether @bt * is the breserved_tags member or the bitmap_tags member of struct * blk_mq_tags. */ static void bt_for_each(struct blk_mq_hw_ctx *hctx, struct sbitmap_queue *bt, busy_iter_fn *fn, void *data, bool reserved) Otherwise: Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH blktests 0/3] Add NVMeOF multipath tests
On Mon, Aug 20, 2018 at 03:46:45PM +, Bart Van Assche wrote: > Moving these tests into the nvme directory is possible but will make it > harder to run the NVMeOF multipath tests separately. Are you fine with this? Both way's have it's up and downsides, I agree. Having two distinct groups requires to run './check nvme nvmeof-mp' to run full coverage with nvme. Having it all in one group would require to run './check nvme 18 19 20 21 22 23 24 ...' to get only the dm-mpath ones. Honestly I hate both but your's (the two distinct groups) is probably easier to handle in the end, I have to admit. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH blktests 0/3] Add NVMeOF multipath tests
On Wed, Aug 15, 2018 at 01:37:25PM -0700, Bart Van Assche wrote:
> Hello Omar,
>
> The three patches in this series add several NVMeOF multipath tests. These
> tests are similar in nature to the SRP tests. Please consider these patches
> for the upstream blktests repository.
Hi Bart,
is there a special reason this isn't in the nvme category? I don't
really see a blocker here.
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] block: Remove two superfluous #include directives
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH v4 2/2] block: Ensure that a request queue is dissociated from the cgroup controller
>From my limited insight into this: Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH v4 1/2] block: Introduce blk_exit_queue()
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] block: copy ioprio in __bio_clone_fast()
Good catch, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH for v4.18] blk-mq: Rename BLK_EH_DONE into BLK_EH_DONT_RESET_TIMER
I'm OK with the rename in general but not sure about doing it this late in the cycle. Anyways, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: Silent data corruption in blkdev_direct_IO()
On Wed, Jul 18, 2018 at 03:54:46PM +0800, Ming Lei wrote: > Please go ahead and take care of it since you have the test cases. Speaking of which, do we already know how it is triggered and can we cook up a blktests testcase for it? This would be more than helpful for all parties. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 1/3] block: Fix a comment in a header file
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 2/2] blktests: add test for ANA state transition
On Tue, Jul 17, 2018 at 03:31:18PM +0200, Hannes Reinecke wrote:
> +requires() {
> + _have_program nvme && _have_module nvme-loop && _have_module loop && \
> + _have_configfs && _have_fio
> +}
this needs '_have_module_param nvme-core multipath' as well.
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH blktests v3 1/6] dir-locals.el: Add c-mode settings
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH blktests v2] dir-locals.el: fix indenation with Emacs
On Fri, Jul 06, 2018 at 02:17:44PM -0700, Omar Sandoval wrote: > On Fri, Jul 06, 2018 at 10:21:28AM +0200, Johannes Thumshirn wrote: > > A recent update of Emacs broke .dir-locals.el's shell indentation > > setting. > > > > Also set 'sh-indendation' not just 'sh-basic-offset' for this. > > Another typo ;) fixed and applied, thanks. *gah* Thanks :-) -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH blktests] dir-locals: fix indenation with Emacs
On Thu, Jul 05, 2018 at 11:13:48AM -0700, Bart Van Assche wrote: > On 07/04/18 04:59, Johannes Thumshirn wrote: > > A recent update of Emacs broke .dir-locals.el's shell indendation > > setting. > > Please fix the spelling of "indentation" in the subject and in the above > sentence. Additionally, the previous patch for this file had > "dir-locals.el:" as subject-prefix. Should this patch have the same subject > prefix? Yup, done. -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
[PATCH blktests v2] dir-locals.el: fix indenation with Emacs
A recent update of Emacs broke .dir-locals.el's shell indentation setting. Also set 'sh-indendation' not just 'sh-basic-offset' for this. Signed-off-by: Johannes Thumshirn Reviewed-by: Bart Van Assche --- Changes to v1: - Fix spelling and subject prefix - Add Bart's R-b --- .dir-locals.el | 1 + 1 file changed, 1 insertion(+) diff --git a/.dir-locals.el b/.dir-locals.el index f64c48202910..46961929fac9 100644 --- a/.dir-locals.el +++ b/.dir-locals.el @@ -1,3 +1,4 @@ ((sh-mode . ((sh-basic-offset . 8) +(sh-indentation . 8) (fill-column . 80) (indent-tabs-mode . t -- 2.16.4
[PATCH blktests] dir-locals: fix indenation with Emacs
A recent update of Emacs broke .dir-locals.el's shell indendation setting. Also set 'sh-indendation' not just 'sh-basic-offset' for this. Signed-off-by: Johannes Thumshirn --- .dir-locals.el | 1 + 1 file changed, 1 insertion(+) diff --git a/.dir-locals.el b/.dir-locals.el index f64c48202910..46961929fac9 100644 --- a/.dir-locals.el +++ b/.dir-locals.el @@ -1,3 +1,4 @@ ((sh-mode . ((sh-basic-offset . 8) +(sh-indentation . 8) (fill-column . 80) (indent-tabs-mode . t -- 2.16.4
Re: [PATCH V2] blk-mq: code clean-up by adding an API to clear set->mq_map
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] blk-mq: code clean-up by adding an API to clear set->mq_map
On Mon, Jul 02, 2018 at 10:34:19PM +0900, Minwoo Im wrote: > I was wondering you did mean 'inline' or not because the function in the > previous mail only with 'static' without 'inline' keyword :) > That's why I asked it one more time to figure out what you really mean. Ah sorry. I'm juggling too much things in parallel currently. Sorry for that. Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] blk-mq: code clean-up by adding an API to clear set->mq_map
On Mon, Jul 02, 2018 at 10:20:03PM +0900, Minwoo Im wrote:
[...]
> > You could still evaluate if it isn't worth to make it:
> > +static void blk_mq_clear_mq_map(struct blk_mq_tag_set *set)
> > +{
> > + int cpu;
> > +
> > + for_each_possible_cpu(cpu)
> > + set->mq_map[cpu] = 0;
> > +}
> >
> > and put it into 'include/linux/blk-mq.h'.
>
> Do you mean this whole bunch of function should be moved into blk-mq.h with
> 'inline' format?
yes
> I have already added this function prototype to blk-mq.h without 'static' to
> make blk-mq-pci.c to use it.
The function itself is pretty small and you use it in two different
files, so I'd make it an inline function in blk-mq.h, like this:
diff --git a/block/blk-mq-pci.c b/block/blk-mq-pci.c
index e233996bb76f..ccb9d7e9adbd 100644
--- a/block/blk-mq-pci.c
+++ b/block/blk-mq-pci.c
@@ -48,8 +48,7 @@ int blk_mq_pci_map_queues(struct blk_mq_tag_set *set, struct
pci_dev *pdev,
fallback:
WARN_ON_ONCE(set->nr_hw_queues > 1);
- for_each_possible_cpu(cpu)
- set->mq_map[cpu] = 0;
+ blk_mq_clear_mq_map(set);
return 0;
}
EXPORT_SYMBOL_GPL(blk_mq_pci_map_queues);
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 95919268564b..664c3817545b 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -2687,7 +2687,6 @@ static int blk_mq_alloc_rq_maps(struct blk_mq_tag_set
*set)
static int blk_mq_update_queue_map(struct blk_mq_tag_set *set)
{
if (set->ops->map_queues) {
- int cpu;
/*
* transport .map_queues is usually done in the following
* way:
@@ -2702,8 +2701,7 @@ static int blk_mq_update_queue_map(struct blk_mq_tag_set
*set)
* killing stale mapping since one CPU may not be mapped
* to any hw queue.
*/
- for_each_possible_cpu(cpu)
- set->mq_map[cpu] = 0;
+ blk_mq_clear_mq_map(set);
return set->ops->map_queues(set);
} else
diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
index e3147eb74222..a8ac78faa2fc 100644
--- a/include/linux/blk-mq.h
+++ b/include/linux/blk-mq.h
@@ -237,6 +237,14 @@ enum {
u32 blk_mq_unique_tag(struct request *rq);
+static inline void blk_mq_clear_mq_map(struct blk_mq_tag_set *set)
+{
+ int cpu;
+
+ for_each_possible_cpu(cpu)
+ set->mq_map[cpu] = 0;
+}
+
static inline u16 blk_mq_unique_tag_to_hwq(u32 unique_tag)
{
return unique_tag >> BLK_MQ_UNIQUE_TAG_BITS;
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] blk-mq: code clean-up by adding an API to clear set->mq_map
On Mon, Jul 02, 2018 at 09:55:57PM +0900, Minwoo Im wrote:
> No 2nd follow-up patch will be there. I thought these two parts are
> using a same unit-function to clear the set->mq-map. Also thought it
> would be great for the future use when it needs to be cleared.
> However, as you mentioned, I totally agree with your point. It seems
> just churns for churns' sake with no more usage for now.
I actually mis-read your patch, I'm sorry.
You're consolidating two callers of this so I guess this is not so
problematic. I somehow ignored the first hunk in the patch.
You could still evaluate if it isn't worth to make it:
+static void blk_mq_clear_mq_map(struct blk_mq_tag_set *set)
+{
+ int cpu;
+
+ for_each_possible_cpu(cpu)
+ set->mq_map[cpu] = 0;
+}
and put it into 'include/linux/blk-mq.h'.
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] blk-mq: code clean-up by adding an API to clear set->mq_map
On Sun, Jul 01, 2018 at 01:21:39AM +0900, Minwoo Im wrote: > set->mq_map is now currently cleared if something goes wrong when > establishing a queue map in blk-mq-pci.c. It's also cleared before > updating a queue map in blk_mq_update_queue_map(). > > This patch provides an API to clear set->mq_map to make it clear. Is there a follow up patch to this which justifies the change? With no 2nd consumer of the function I fear this will be disregarded as useless code churn. Byte, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 1/3] blk-mq: use list_splice_tail() to insert requests
Hi Ming,
On Thu, Jun 28, 2018 at 11:19:16AM +0800, Ming Lei wrote:
> + list_for_each_entry(rq, list, queuelist) {
> BUG_ON(rq->mq_ctx != ctx);
> - list_del_init(>queuelist);
> - __blk_mq_insert_req_list(hctx, rq, false);
> + trace_block_rq_insert(hctx->queue, rq);
> }
I wonder if we really need the above loop unconditionally. It does
some BUG_ON() sanity checking (which I hate but it was already there
so not your problem) and tracing of the request insertion.
So can we maybe only run this loop if tracing is enabled? Not sure if
this is possible though. Maybe Steven (Cced) can help here.
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH blktests v2 2/3] Add the discontiguous-io test program
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH blktests v2 1/3] src/Makefile: Rename $(TARGETS) into $(C_TARGETS)
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH blktests 00/15] Add SRP initiator driver tests
On Tue, Jun 26, 2018 at 08:24:51AM -0700, Bart Van Assche wrote: > As far as I know the requires() function is per test and there is no such > function at the group level. I prefer to define this test once at the group > level instead of copy/pasting the same test thirteen times in each test. No actually there is. There is a group_requires() in the test/XXX/group file (check for instance tests/group/nvme which has group_requires() calling _have_root and a group_device_requires() calling _test_dev_is_nvme). Byte, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH blktests 15/15] Add tests for the SRP initiator and target drivers
On Fri, Jun 22, 2018 at 03:19:46PM -0700, Bart Van Assche wrote: > tests/srp/functions | 1288 +++ Can you please move these into common/srp? Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH blktests 00/15] Add SRP initiator driver tests
On Tue, Jun 26, 2018 at 02:16:26AM +, Bart Van Assche wrote: > On Tue, 2018-06-26 at 09:37 +0800, Ming Lei wrote: > > I run SRP test on Fedora 27, and not run any LIO specific commands > > to load it, seems it is done automatically. > > > > So looks it might not a good idea to fail SRP test if LIO is loaded, > > just wondering why your SRP test can't make the two co-exist? > > The LIO configuration is system-wide. Only one configuration can be > loaded at any given time. I don't think that the SRP tests should wipe > any existing LIO configuration data if e.g. blktests is run accidentally > on a production server. I think that wiping LIO configuration data should > be a manual step. I think this should be handled in requires(). I.e. check if LIO is already configured and then skip the test if it is. Byte, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH blktests] check: add command line switch to test device drivers only
Thanks :-) -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH blktests] check: add command line switch to test device drivers only
Ping? -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 9/9] Makefile: Do not suppress useful shellcheck warnings
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 7/9] Avoid passing tests/block/002 arguments to _init_scsi_debug
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 8/9] check: Suppress a shellcheck warning about the DMESG_FILTER initialization
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 6/9] Multiple tests: remove unused and undefined variables
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 5/9] check: Avoid that shellcheck complains that $FULL appears unused
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 4/9] Suppress shellcheck complaints about global variables
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 3/9] check, tests/meta/012: Use array["index"] instead of array[index]
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 1/9] common/rc: Fix _have_tracepoint()
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 2/9] Annotate include statements in shell scripts where the source file is a variable
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
[PATCH blktests] check: add command line switch to test device drivers only
Sometimes it's useful to only run tests which exercise a device
special driver to verify a patch for the driver doesn't introduce a
regression.
Running the whole test-suite is just a waste of time in this case, so
provide a way to only run tests which have a test_device() function
set and not a test() function.
Signed-off-by: Johannes Thumshirn
---
check | 18 ++
1 file changed, 18 insertions(+)
diff --git a/check b/check
index 4baa8dde2436..639fcc43f09d 100755
--- a/check
+++ b/check
@@ -395,6 +395,12 @@ _run_test() {
. "tests/${TEST_NAME}"
if declare -fF test >/dev/null; then
+ if [[ -v DEVICE_ONLY ]]; then
+ SKIP_REASON="test excluded by user"
+ _output_notrun "$TEST_NAME"
+ return 0
+ fi
+
if declare -fF requires >/dev/null && ! requires; then
_output_notrun "$TEST_NAME"
return 0
@@ -546,6 +552,9 @@ Test runs:
-x, --exclude=TEST exclude a test (or test group) from the list of
tests to run
+ -d --device-only only run test which use a test device from the
+ TEST_DEV config setting
+
Miscellaneous:
-h, --help display this help message and exit"
@@ -570,6 +579,7 @@ unset TEMP
# Default configuration.
QUICK_RUN=0
+DEVICE_ONLY=0
EXCLUDE=()
TEST_DEVS=()
@@ -592,6 +602,10 @@ while true; do
EXCLUDE+=("$2")
shift 2
;;
+ '-d'|'--device-only')
+ DEVICE_ONLY=1
+ shift 2
+ ;;
'-h'|'--help')
usage out
;;
@@ -609,6 +623,10 @@ if [[ QUICK_RUN -ne 0 && ! -v TIMEOUT ]]; then
_error "QUICK_RUN specified without TIMEOUT"
fi
+if [[ DEVICE_ONLY -ne 0 && ${#TEST_DEVS[@]} -eq 0 ]]; then
+ _error "DEVICE_ONLY specified without TEST_DEVS"
+fi
+
# Convert the exclude list to an associative array.
TEMP_EXCLUDE=("${EXCLUDE[@]}")
unset EXCLUDE
--
2.16.4
Re: [PATCHv2] block: always set partition number to '0' in blk_partition_remap()
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH blktests 1/9] blktests: add hepler functions for new md tests
On Thu, Jun 07, 2018 at 10:45:02AM +0800, bingjingc wrote: > Hi Johannes & Jens, > > Thank you for your information and positive feedbacks on this patch. > > I'm also inspired by xfstests, too. Most conventional filesystems > have their test cases on it. I believe block layer can also have one. > > I felt sorry. It's first time I realized there is a test suite under > mdadm project. Now, I am trying to find documentation to get > it works. I can examine the efforts of migrating them or just > triggering them from blktests. > > Any ideas from linux-block and linux-raid channels are welcome. :) Migrating them over would be the best thing since sliced bread. Having to run only one test suite for the linux block device space is our long term goal. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH blktests 1/9] blktests: add hepler functions for new md tests
On Wed, Jun 06, 2018 at 08:29:25AM -0600, Jens Axboe wrote: > Hopefully this can be the start of migrating over those tests! Yes this would be great. I just wanted to connect the submitter and the md developers and make them aware of possibly duplicated efforts ;-). -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH blktests 1/9] blktests: add hepler functions for new md tests
On Wed, Jun 06, 2018 at 04:06:40PM +0800, bingjingc wrote: > We'd like to leverage this test framework for testing linux raid > software. There are several resync tasks in md/raid. For this commit, > we are trying to add creation resync and basic recovery tests for > every raid type. > > RAID is different from other block devices. It requires several > raid devices and hotspare devices for being assembled, disambled, > expended or recovered in the runtime. So we don't test devices > iteratively in TEST_DEVS list. We define RAID_DEVS and > RAID_SPARE_DEVS lists for providing block devices instead. > > We want to test the software not devices. We also provide a > LIMIT_DEV_SIZE option for limiting the tested array size by limiting > used space for each block device. > > [Getting Started] > > Additional dependencies are also minimal: > - mdadm > - cmp > > And please provide a file named config: > RAID_DEVS=(/dev/loop0 /dev/loop1 /dev/loop2 /dev/loop3 /dev/loop4) > RAID_SPARE_DEVS=(/dev/loop100 /dev/loop101) > LIMIT_DEV_SIZE=20480 # optional > > And as root, you can run the md set of tests by typing > ./check md > > For someone who don't want to run md tests, they just keep RAID_DEVS > and RAID_SPARE_DEVS not assigned, all md tests will be skipped. While I'm very much in support for the idea, please be aware that md has an own test suite by itself and please Cc the md mailing list as well. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 08/14] nvmet: implement the changed namespaces log
On Tue, May 29, 2018 at 10:17:12AM +0200, Christoph Hellwig wrote: > On Mon, May 28, 2018 at 08:53:42AM +0200, Johannes Thumshirn wrote: > > Reviewed-by: Johannes Thumshirn > > > > As a side note, what happens if more than 1024 Namespaces are changed > > (apart from setting the 1st element to 0x and zeroing out the > > rest)? > > > > The Spec is pretty silent in this regard. > > The spec is completly clear on this: > > From 5.14.1.4: > > "If more than 1024 namespaces have changed attributes since the last time the > log page was read, the first entry in the log page shall be set to h > and the remainder of the list shall be zero-filled." > > Once we don't know what changed we'll have to do a full rescan using > Identify. The "full rescan" part was what I couldn't read out of the spec. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 04/14] nvme.h: add the changed namespace list log
Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 07/14] nvmet: split log page implementation
Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 08/14] nvmet: implement the changed namespaces log
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> As a side note, what happens if more than 1024 Namespaces are changed (apart from setting the 1st element to 0x and zeroing out the rest)? The Spec is pretty silent in this regard. -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 13/14] nvme: use the changed namespaces list log to clear ns data changed AENs
Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 05/14] nvme.h: add AER configuration symbols
Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 10/14] nvmet: mask pending AERs
Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 12/14] nvme: mark nvme_queue_scan static
Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 06/14] nvmet: add a new nvmet_zero_sgl helper
Don't we already have this? Or is it a re-send? It looks so awefully familiar to me... Anyways, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 01/14] block: unexport check_disk_size_change
Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 09/14] nvmet: Add AEN configuration support
Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 14/14] nvme: limit warnings from nvme_identify_ns
Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 11/14] nvme: submit AEN event configuration on startup
Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 03/14] nvme.h: untangle AEN notice definitions
Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 02/14] block: don't print a message when the device went away
Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 07/14] scsi_transport_fc: complete requests from ->timeout
Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 06/14] null_blk: complete requests from ->timeout
Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 05/14] mtip32xx: complete requests from ->timeout
Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 03/14] nvme: return BLK_EH_DONE from ->timeout
Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 02/14] block: rename BLK_EH_NOT_HANDLED to BLK_EH_DONE
Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH blktests] Documentation: document prerequisite scriptlets
On Tue, May 22, 2018 at 05:15:30PM -0700, Omar Sandoval wrote: > Cool setup :) I have my own fanciness [1] which lets met boot straight > into a test kernel without packaging it up in any way. > > Anyways, I added some documentation based on yours. Thanks! > > 1: https://github.com/osandov/osandov-linux#vm-setup Cool thanks for sharing. Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH blktests] blktests: use consistent helper returns
Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH V6 11/11] nvme: pci: support nested EH
On Fri, May 18, 2018 at 10:28:04AM -0600, Keith Busch wrote: > On Thu, May 17, 2018 at 04:23:45PM +0200, Johannes Thumshirn wrote: > > > Agreed. Alternatively possibly call the driver's reset_preparei/done > > > callbacks. > > > > Exactly, but as long as we can issue the reset via sysfs the test-case > > is still valid. > > I disagree the test case is valid. The test writes '0' to the > pci-sysfs 'enable', but the driver also disables the pci device as part > of resetting, which is a perfectly reasonable thing for a driver to do. > > If the timing of the test's loop happens to write '0' right after the > driver disabled the device that it owns, a 'write error' on that sysfs > write occurs, and blktests then incorrectly claims the test failed. Hmm, ok that's a valid point. But seeing you have sent a patch for blktests anyways I think it's gone now. -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH blktests] Documentation: document prerequisite scriptlets
On Mon, May 21, 2018 at 11:29:04AM -0700, Omar Sandoval wrote: > But I'm curious about this specific example. Is this not mounted for you > automatically? I'm guessing systemd does it for me on my setup. No my setup is kind of special. I don't want to mess with all the user-space so all I do is: dracut --no-compress --kver `make kernelrelease` --kmoddir mods/ \ --no-hostonly --no-hostonly-cmdline --modules "bash base" \ --tmpdir `pwd`/myinitrd --force myinitrd/initrd \ --add-drivers "loop nvme nvme-loop nvmet" \ --install "lsblk find sort parted getopt fio tput column date \ dirname mktemp ps diff awk timeout time losetup \ truncate wc grep stat basename cut blktrace sg_inq \ realpath findmnt vi dd sed rm rmdir nvme" \ --include "$HOME/src/blktests" "/blktests qemu-kvm -m 4096 -smp 4 -nographic -serial mon:stdio -kernel \ arch/x86/boot/bzImage -initrd myinitrd/initrd \ -append "console=ttyS0 debug" I have the above in a shell wrapper as I simply can't remember it, or I just use rapido [1] which a co-worker of mine started for this job. As minimal as possible. I try to get my rebuild - boot - test cycles short. With my current config I have a bootup time in qemu below half a second on a reasonable machine in my lab and just below one second on my laptop. [1] https://github.com/rapido-linux/rapido Byte, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 08/10] block: Add warning for bi_next not NULL in bio_endio()
Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 03/10] block: Add bioset_init()/bioset_exit()
Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 02/10] block: Convert bio_set to mempool_init()
On Fri, May 18, 2018 at 03:49:01AM -0400, Kent Overstreet wrote: > Minor performance improvement by getting rid of pointer indirections > from allocation/freeing fastpaths. Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> Although I'd prefer numbers in the changelog when claiming a performance improvement. -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH V6 11/11] nvme: pci: support nested EH
On Thu, May 17, 2018 at 08:20:51AM -0600, Keith Busch wrote: > > Heh. But yes, this test and the PCI "enable" interface in sysfs look > > horribly wrong. pci_disable_device/pci_enable_device aren't something we > > can just do underneath the driver. Even if injecting the lowlevel > > config space manipulations done by it might be useful and a good test > > the Linux state ones are just killing the driver. > > Yes, I'm totally fine with injecting errors into the config space, but > for goodness sakes, don't fuck with the internal kernel structures out > from under drivers using them. > > My suggestion is to use 'setpci' to disable the device if you want to > inject this scenario. That way you get the desired broken device > scenario you want to test, but struct pci_dev hasn't been altered. > > > The enable attribute appears to have been added by Arjan for the > > Xorg driver. I think if we have a driver bound to the device we > > should not allow it. > > Agreed. Alternatively possibly call the driver's reset_preparei/done > callbacks. Exactly, but as long as we can issue the reset via sysfs the test-case is still valid. -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH blktests] Documentation: document prerequisite scriptlets
Omar, ping? -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
[PATCH blktests] Documentation: document prerequisite scriptlets
The config file is bash and it gets sourced, so all bash magic is doable in there as well. Document it so others don't have to re-discover this gem as well. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- Documentation/running-tests.md | 12 1 file changed, 12 insertions(+) diff --git a/Documentation/running-tests.md b/Documentation/running-tests.md index a479d5e94c5e..b477c0679683 100644 --- a/Documentation/running-tests.md +++ b/Documentation/running-tests.md @@ -66,3 +66,15 @@ command line option. QUICK_RUN=1 TIMEOUT=30 ``` + +### Pre-test setups + +Some tests, may need special prerequisites, like configfs being +mounted for NVMe over Fabrics tests. You can add your custom bash +scriptlets to `config` to get this done, e.g.: + +```sh +if ! test $(grep -q configfs /proc/mounts) ; then +mount -t configfs none /sys/kernel/config +fi +``` -- 2.16.3
