[LSF/MM TOPIC][LSF/MM ATTEND] IO completion polling for block drivers

Hi I'd like to discuss the ongoing work in the kernel to enable high priority IO via polling for completion in the blk-mq subsystem. Given that iopoll only really makes sense for low-latency, low queue depth environments (i.e. down below 10-20us) I'd like to discuss which drivers we think will

[PATCH 1/2] block: Rename blk_queue_zone_size and bdev_zone_size

All block device data fields and functions returning a number of 512B sectors are by convention named xxx_sectors while names in the form xxx_size are generally used for a number of bytes. The blk_queue_zone_size and bdev_zone_size functions were not following this convention so rename them. No

Re: [PATCH 0/2] Rename blk_queue_zone_size and bdev_zone_size

On 01/11/2017 09:36 PM, Damien Le Moal wrote: > Jens, > > On 1/12/17 12:52, Jens Axboe wrote: >> On Thu, Jan 12 2017, Damien Le Moal wrote: >>> All block device data fields and functions returning a number of 512B >>> sectors are by convention named xxx_sectors while names in the form >>> of

Re: [Lsf-pc] [LSF/MM ATTEND] OCSSDs - SMR, Hierarchical Interface, and Vector I/Os

On Thu, 2017-01-12 at 11:35 +0900, Damien Le Moal wrote: > > Just a note for the poor admin looking after the lists: to find all > > the ATTEND and TOPIC requests for the lists I fold up the threads > > to the top. If you frame your attend request as a reply, it's > > possible it won't get

Re: [PATCH 14/15] block/bsg: move queue creation into bsg_setup_queue

On Wed, Jan 11, 2017 at 05:01:22PM -0500, Mike Snitzer wrote: > But I've seen you reference the need to stop multipath from allocating > its own requests. Are you referring to old request_fn request-based > multipath's clone_old_rq:alloc_old_clone_request? Yes, that one is the issue. It

Re: [LSF/MM TOPIC][LSF/MM ATTEND] NAPI polling for block drivers

On 01/11/2017 09:36 PM, Stephen Bates wrote: >>> >>> I'd like to attend LSF/MM and would like to discuss polling for block >>> drivers. >>> >>> Currently there is blk-iopoll but it is neither as widely used as NAPI >>> in the networking field and accoring to Sagi's findings in [1] >>> performance

Re: [PATCH 0/2] Rename blk_queue_zone_size and bdev_zone_size

On 1/12/17 13:38, Jens Axboe wrote: > On 01/11/2017 09:36 PM, Damien Le Moal wrote: >> Jens, >> >> On 1/12/17 12:52, Jens Axboe wrote: >>> On Thu, Jan 12 2017, Damien Le Moal wrote: All block device data fields and functions returning a number of 512B sectors are by convention named

Re: [PATCH] MAINTAINERS: Update maintainer entry for NBD

On 01/11/2017 01:41 PM, Josef Bacik wrote: > The old maintainers email is bouncing and I've rewritten most of this > driver in the recent months. Also add linux-block to the mailinglist > and remove the old tree, I will send patches through the linux-block > tree. Thanks, Added, thanks Josef.

Re: [PATCH 0/2] Rename blk_queue_zone_size and bdev_zone_size

Jens, On 1/12/17 12:52, Jens Axboe wrote: > On Thu, Jan 12 2017, Damien Le Moal wrote: >> All block device data fields and functions returning a number of 512B >> sectors are by convention named xxx_sectors while names in the form >> of xxx_size are generally used for a number of bytes. The

Re: [Lsf-pc] [LSF/MM ATTEND] OCSSDs - SMR, Hierarchical Interface, and Vector I/Os

On Thu, 2017-01-12 at 10:33 +0900, Damien Le Moal wrote: > Hello, > > A long discussion on the list followed this initial topic proposal > from Matias. I think this is a worthy topic to discuss at LSF in > order to steer development of the zoned block device interface in the > right direction.

Re: [LSF/MM TOPIC][LSF/MM ATTEND] NAPI polling for block drivers

On Wed, Jan 11, 2017 at 04:08:31PM +, Bart Van Assche wrote: > A typical Ethernet network adapter delays the generation of an interrupt > after it has received a packet. A typical block device or HBA does not delay > the generation of an interrupt that reports an I/O completion. NVMe allows

Re: [LSF/MM TOPIC][LSF/MM ATTEND] NAPI polling for block drivers

On 01/11/2017 08:07 AM, Jens Axboe wrote: > On 01/11/2017 06:43 AM, Johannes Thumshirn wrote: >> Hi all, >> >> I'd like to attend LSF/MM and would like to discuss polling for block >> drivers. >> >> Currently there is blk-iopoll but it is neither as widely used as NAPI in the >> networking field

Re: [LSF/MM TOPIC][LSF/MM ATTEND] NAPI polling for block drivers

On 01/11/2017 04:07 PM, Jens Axboe wrote: > On 01/11/2017 06:43 AM, Johannes Thumshirn wrote: >> Hi all, >> >> I'd like to attend LSF/MM and would like to discuss polling for block >> drivers. >> >> Currently there is blk-iopoll but it is neither as widely used as NAPI in the >> networking field

Re: [LSF/MM TOPIC][LSF/MM ATTEND] NAPI polling for block drivers

On 01/11/2017 02:43 PM, Johannes Thumshirn wrote: > Hi all, > > I'd like to attend LSF/MM and would like to discuss polling for block drivers. > > Currently there is blk-iopoll but it is neither as widely used as NAPI in the > networking field and accoring to Sagi's findings in [1] performance

Re: [PATCH 14/15] block/bsg: move queue creation into bsg_setup_queue

On Wed, Jan 11 2017 at 3:45am -0500, Christoph Hellwig wrote: > On Wed, Jan 11, 2017 at 09:42:44AM +0100, Johannes Thumshirn wrote: > > On Tue, Jan 10, 2017 at 04:06:19PM +0100, Christoph Hellwig wrote: > > > Simply the boilerplate code needed for bsg nodes a bit. > > > > > >

[PATCH 09/10] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

This is basically identical to deadline-iosched, except it registers as a MQ capable scheduler. This is still a single queue design. Signed-off-by: Jens Axboe --- block/Kconfig.iosched | 6 + block/Makefile| 1 + block/mq-deadline.c | 569

[PATCH 10/10] blk-mq-sched: allow setting of default IO scheduler

Add Kconfig entries to manage what devices get assigned an MQ scheduler, and add a blk-mq flag for drivers to opt out of scheduling. The latter is useful for admin type queues that still allocate a blk-mq queue and tag set, but aren't use for normal IO. Signed-off-by: Jens Axboe

Re: [LSF/MM TOPIC][LSF/MM ATTEND] NAPI polling for block drivers

On Wed, 2017-01-11 at 17:22 +0100, Hannes Reinecke wrote: > On 01/11/2017 05:12 PM, h...@infradead.org wrote: > > On Wed, Jan 11, 2017 at 04:08:31PM +, Bart Van Assche wrote: > > > A typical Ethernet network adapter delays the generation of an > > > interrupt > > > after it has received a

Re: [LSF/MM TOPIC][LSF/MM ATTEND] NAPI polling for block drivers

On Wed, 2017-01-11 at 14:43 +0100, Johannes Thumshirn wrote: > I'd like to attend LSF/MM and would like to discuss polling for block > drivers. > > Currently there is blk-iopoll but it is neither as widely used as NAPI in > the networking field and accoring to Sagi's findings in [1] performance >

Re: [LSF/MM TOPIC][LSF/MM ATTEND] NAPI polling for block drivers

On 01/11/2017 05:12 PM, h...@infradead.org wrote: > On Wed, Jan 11, 2017 at 04:08:31PM +, Bart Van Assche wrote: >> A typical Ethernet network adapter delays the generation of an interrupt >> after it has received a packet. A typical block device or HBA does not delay >> the generation of an

Re: [LSF/MM TOPIC][LSF/MM ATTEND] NAPI polling for block drivers

On Wed, Jan 11, 2017 at 04:08:31PM +, Bart Van Assche wrote: [...] > A typical Ethernet network adapter delays the generation of an interrupt > after it has received a packet. A typical block device or HBA does not delay > the generation of an interrupt that reports an I/O completion. I

Re: [LSF/MM TOPIC][LSF/MM ATTEND] NAPI polling for block drivers

On 01/11/2017 09:12 AM, h...@infradead.org wrote: > On Wed, Jan 11, 2017 at 04:08:31PM +, Bart Van Assche wrote: >> A typical Ethernet network adapter delays the generation of an interrupt >> after it has received a packet. A typical block device or HBA does not delay >> the generation of an

[GIT PULL] NVMe fixes for 4.10-rc4

Hi Jens, below are two small NVMe fixes for this merge window. The following changes since commit 6bf6b0aa3da84a3d9126919a94c49c0fb7ee2fb3: virtio_blk: fix panic in initialization error path (2017-01-10 13:30:50 -0700) are available in the git repository at:

Re: [GIT PULL] NVMe fixes for 4.10-rc4

On 01/11/2017 11:42 AM, Christoph Hellwig wrote: > Hi Jens, > > below are two small NVMe fixes for this merge window. > > The following changes since commit 6bf6b0aa3da84a3d9126919a94c49c0fb7ee2fb3: > > virtio_blk: fix panic in initialization error path (2017-01-10 13:30:50 > -0700) > > are

Re: [PATCH 14/15] block/bsg: move queue creation into bsg_setup_queue

On 01/11/2017 10:01 AM, Christoph Hellwig wrote: > On Wed, Jan 11, 2017 at 09:59:17AM +0100, Hannes Reinecke wrote: >> I'd advocate to discuss this at LSF. >> Now that Mike moved the bio-based mpath stuff back in things got even >> more complex. > > Yeah. If we'd _only_ have bio based support it

Re: [LFS/MM TOPIC][LFS/MM ATTEND]: - Storage Stack and Driver Testing methodology.

On 01/11/2017 10:24 AM, Christoph Hellwig wrote: > On Wed, Jan 11, 2017 at 10:19:45AM +0100, Johannes Thumshirn wrote: >> Well, something I was thinking about but didn't find enough time to actually >> implement is making a xfstestes like test suite written using sg3_utils for >> SCSI. > >

[LSF/MM TOPIC][LSF/MM ATTEND] multipath redesign

Hi all, I'd like to attend LSF/MM this year, and would like to discuss a redesign of the multipath handling. With recent kernels we've got quite some functionality required for multipathing already implemented, making some design decisions of the original multipath-tools implementation quite

Re: [PATCH 14/15] block/bsg: move queue creation into bsg_setup_queue

On Tue, Jan 10, 2017 at 04:06:19PM +0100, Christoph Hellwig wrote: > Simply the boilerplate code needed for bsg nodes a bit. > > Signed-off-by: Christoph Hellwig > --- that reminds me of posting my SAS bsg-lib patch... Anyways looks good, Reviewed-by: Johannes Thumshirn

Re: [PATCH 01/15] virtio_blk: avoid DMA to stack for the sense buffer

On Wed, Jan 11, 2017 at 09:26:46AM +0100, Johannes Thumshirn wrote: > Isn't that one already queued in Jens' tree? Yes, it's now queued up. Patch 2 was submitted as well and should hopefully go into the next 4.10 RC. -- To unsubscribe from this list: send the line "unsubscribe linux-block" in

Re: [PATCH 14/15] block/bsg: move queue creation into bsg_setup_queue

On 01/11/2017 09:45 AM, Christoph Hellwig wrote: > On Wed, Jan 11, 2017 at 09:42:44AM +0100, Johannes Thumshirn wrote: >> On Tue, Jan 10, 2017 at 04:06:19PM +0100, Christoph Hellwig wrote: >>> Simply the boilerplate code needed for bsg nodes a bit. >>> >>> Signed-off-by: Christoph Hellwig

Re: [LFS/MM TOPIC][LFS/MM ATTEND]: - Storage Stack and Driver Testing methodology.

On Tue, Jan 10, 2017 at 10:40:53PM +, Chaitanya Kulkarni wrote: > Resending it at as a plain text. > > From: Chaitanya Kulkarni > Sent: Tuesday, January 10, 2017 2:37 PM > To: lsf...@lists.linux-foundation.org > Cc: linux-fsde...@vger.kernel.org; linux-block@vger.kernel.org; >

Re: [PATCH 14/15] block/bsg: move queue creation into bsg_setup_queue

On Wed, Jan 11, 2017 at 09:42:44AM +0100, Johannes Thumshirn wrote: > On Tue, Jan 10, 2017 at 04:06:19PM +0100, Christoph Hellwig wrote: > > Simply the boilerplate code needed for bsg nodes a bit. > > > > Signed-off-by: Christoph Hellwig > > --- > > that reminds me of posting my

Re: [PATCH 14/15] block/bsg: move queue creation into bsg_setup_queue

On Wed, Jan 11, 2017 at 09:59:17AM +0100, Hannes Reinecke wrote: > I'd advocate to discuss this at LSF. > Now that Mike moved the bio-based mpath stuff back in things got even > more complex. Yeah. If we'd _only_ have bio based support it would simplify things a lot, but as a third parallel path

Re: [Lsf-pc] [LSF/MM TOPIC] [LSF/MM ATTEND] FS Management Interfaces

Hi, On 10/01/17 10:14, Jan Kara wrote: Hi, On Tue 10-01-17 09:44:59, Steven Whitehouse wrote: I had originally thought about calling the proposal "kernel/userland interface", however that seemed a bit vague and management interfaces seems like a better title since it is I hope a bit clearer

Re: [PATCH] preview - block layer help to detect sequential IO

Hi Kashyap, [auto build test ERROR on v4.9-rc8] [cannot apply to block/for-next linus/master linux/master next-20170111] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Kashyap-Desai/preview

Re: [PATCH 05/15] dm: remove incomple BLOCK_PC support

On Tue, Jan 10 2017 at 10:06am -0500, Christoph Hellwig wrote: > DM tries to copy a few fields around for BLOCK_PC requests, but given > that no dm-target ever wires up scsi_cmd_ioctl BLOCK_PC can't actually > be sent to dm. > > Signed-off-by: Christoph Hellwig > ---

[PATCH] MAINTAINERS: Update maintainer entry for NBD

The old maintainers email is bouncing and I've rewritten most of this driver in the recent months. Also add linux-block to the mailinglist and remove the old tree, I will send patches through the linux-block tree. Thanks, Signed-off-by: Josef Bacik --- MAINTAINERS | 4 ++-- 1

[PATCH 01/10] block: move existing elevator ops to union

Prep patch for adding MQ ops as well, since doing anon unions with named initializers doesn't work on older compilers. Signed-off-by: Jens Axboe --- block/blk-ioc.c | 8 +++ block/blk-merge.c| 4 ++-- block/blk.h | 10

[PATCH 03/10] block: move rq_ioc() to blk.h

We want to use it outside of blk-core.c. Signed-off-by: Jens Axboe --- block/blk-core.c | 16 block/blk.h | 16 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/block/blk-core.c b/block/blk-core.c index

[LSF/MM ATTEND] OCSSDs - SMR, Hierarchical Interface, and Vector I/Os

Hello, A long discussion on the list followed this initial topic proposal from Matias. I think this is a worthy topic to discuss at LSF in order to steer development of the zoned block device interface in the right direction. Considering the relation and implication to ZBC/ZAC support, I would