Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

2018-03-06 Thread Martin K. Petersen
Ming, > Given both Don and Laurence have verified that patch 1 and patch 2 > does fix IO hang, could you consider to merge the two first? Oh, and I would still need a formal Acked-by: from Don and Tested-by: from Laurence. Also, for 4.16/scsi-fixes I would prefer verification to be done with

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

2018-03-06 Thread Martin K. Petersen
Hi Ming, > Given both Don and Laurence have verified that patch 1 and patch 2 > does fix IO hang, could you consider to merge the two first? I'm not going to merge the MR patch until Kashyap acks it. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

2018-03-06 Thread Ming Lei
On Tue, Mar 06, 2018 at 02:24:25PM -0500, Martin K. Petersen wrote: > > Ming, > > > Given both Don and Laurence have verified that patch 1 and patch 2 > > does fix IO hang, could you consider to merge the two first? > > Oh, and I would still need a formal Acked-by: from Don and Tested-by: >

Re: [PATCH][RESEND] block: sed-opal: fix u64 short atom length

2018-03-06 Thread Derrick, Jonathan
Hi Jonas, On Thu, 2018-03-01 at 14:27 +0100, Jonas Rabenstein wrote: > The length must be given as bytes and not as 4 bit tuples. > > Signed-off-by: Jonas Rabenstein n.de> > --- > block/sed-opal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH][RESEND] block: sed-opal: fix response string extraction

2018-03-06 Thread Derrick, Jonathan
This looks correct. Adding my Ack unless Scott has objections Acked-by: Jonathan Derrick On Thu, 2018-03-01 at 14:26 +0100, Jonas Rabenstein wrote: > Tokens are prefixed by a variable length of bytes. If a bytestring is > not stored in an tiny or short atom, we have

Re: [PATCH v2] bcache: move closure debug file into debug direcotry

2018-03-06 Thread Michael Lyle
Sorry- I had to pull/unapply this actually. On 03/04/2018 11:40 PM, Chengguang Xu wrote: > -static struct dentry *debug > +struct dentry *debug; This conflicts with other symbols called "debug" and doesn't compile. Please be sure that your patch set compiles before submitting. Mike > >

Re: [PATCH v2] bcache: move closure debug file into debug direcotry

2018-03-06 Thread Chengguang Xu
Hi Mike I'm really sorry for the inconvenient, in my test box it can compile with no error, so I didn't notice that before, I've sent modified v2 version for the problem. > Sent: Wednesday, March 07, 2018 at 10:54 AM > From: "Michael Lyle" > To: "Chengguang Xu"

[PATCH v2] bcache: move closure debug file into debug direcotry

2018-03-06 Thread Chengguang Xu
In current code closure debug file is outside of debug directory and when unloading module there is lack of removing operation for closure debug file, so it will cause creating error when trying to reload module. This patch move closure debug file into "bcache" debug direcory so that the file

Re: [PATCH V3 8/8] scsi: megaraid: improve scsi_mq performance via .host_tagset

2018-03-06 Thread Ming Lei
On Wed, Feb 28, 2018 at 08:28:48PM +0530, Kashyap Desai wrote: > Ming - > > Quick testing on my setup - Performance slightly degraded (4-5% drop)for > megaraid_sas driver with this patch. (From 1610K IOPS it goes to 1544K) > I confirm that after applying this patch, we have #queue = #numa node.

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

2018-03-06 Thread Martin K. Petersen
Ming, > Please consider 2/8 too since it is still a fix. I still need the driver maintainer to ack the change. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH V2] block: null_blk: fix 'Invalid parameters' when loading module

2018-03-06 Thread Jens Axboe
On 3/5/18 9:07 PM, Ming Lei wrote: > On ARM64, the default page size has been 64K on some distributions, and > we should allow ARM64 people to play null_blk. > > This patch fixes the issue by extend page bitmap size for supporting > other non-4KB PAGE_SIZE. Applied, thanks. -- Jens Axboe

Re: [PATCH v2 07/10] nvme-pci: Use PCI p2pmem subsystem to manage the CMB

2018-03-06 Thread Oliver
On Tue, Mar 6, 2018 at 12:14 PM, Logan Gunthorpe wrote: > > On 05/03/18 05:49 PM, Oliver wrote: >> >> It's in arch/powerpc/kernel/io.c as _memcpy_toio() and it has two full >> barriers! >> >> Awesome! >> >> Our io.h indicates that our iomem accessors are designed to provide

Re: Hangs in balance_dirty_pages with arm-32 LPAE + highmem

2018-03-06 Thread Tetsuo Handa
795514] Node 0 Normal free:16920kB min:17320kB low:21648kB high:25976kB active_anon:570132kB inactive_anon:13452kB active_file:14416kB inactive_file:14272kB unevictable:0kB writepending:42740kB present:1048576kB managed:951188kB mlocked:0kB kernel_stack:22128kB pagetables:37304kB bounce:0kB free_pcp:440kB local_pcp:48kB free_cma:0kB Complete log is http://I-love.SAKURA.ne.jp/tmp/serial-20180306.txt.xz . Config is http://I-love.SAKURA.ne.jp/tmp/config-4.16-rc4 .