On Fri, Aug 10, 2018 at 05:10:52PM +, Felipe Franciosi wrote:
>
> > On 10 Aug 2018, at 03:15, Greg Kroah-Hartman
> > wrote:
> >
> > On Fri, Aug 10, 2018 at 10:31:29AM +0800, Ming Lei wrote:
> >> On Fri, Aug 10, 2018 at 02:09:01AM +, Felipe Franciosi wrote:
> >>> Hi Ming (and all),
>
For legacy queues the only call of blkg_root_lookup() happens after
bypass mode has been enabled. Since blkg_lookup() returns NULL for
queues in bypass mode, modify the blkg_root_lookup() such that it
no longer depends on bypass mode. Rename the function into
blk_queue_root_blkg() as suggested by
On Fri, 2018-08-10 at 09:59 +0800, jianchao.wang wrote:
> On 08/10/2018 03:41 AM, Bart Van Assche wrote:
> > Instead of scheduling runtime resume of a request queue after a
> > request has been queued, schedule asynchronous resume during request
> > allocation. The new pm_request_resume() calls
> On 10 Aug 2018, at 03:15, Greg Kroah-Hartman
> wrote:
>
> On Fri, Aug 10, 2018 at 10:31:29AM +0800, Ming Lei wrote:
>> On Fri, Aug 10, 2018 at 02:09:01AM +, Felipe Franciosi wrote:
>>> Hi Ming (and all),
>>>
>>> Your series "scsi: virtio_scsi: fix IO hang caused by irq vector automatic
On Fri, Aug 10, 2018 at 10:59:37AM +0800, jianchao.wang wrote:
> Hi Omar
>
> On 08/10/2018 04:26 AM, Omar Sandoval wrote:
> > @@ -524,6 +524,9 @@ inline void __blk_mq_end_request(struct request *rq,
> > blk_status_t error)
> > blk_stat_add(rq, now);
> > }
> >
> > + if
> On 10 Aug 2018, at 11:32, Greg Kroah-Hartman
> wrote:
>
> On Fri, Aug 10, 2018 at 05:10:52PM +, Felipe Franciosi wrote:
>>
>>> On 10 Aug 2018, at 03:15, Greg Kroah-Hartman
>>> wrote:
>>>
>>> On Fri, Aug 10, 2018 at 10:31:29AM +0800, Ming Lei wrote:
On Fri, Aug 10, 2018 at
On Fri, 2018-08-10 at 09:20 +0800, Ming Lei wrote:
> On Thu, Aug 09, 2018 at 12:41:39PM -0700, Bart Van Assche wrote:
> > Process all requests in state SDEV_CREATED instead of only RQF_DV
> > requests. This does not change the behavior of the SCSI core because
> > the SCSI device state is modified
On Fri, 2018-08-10 at 09:51 +0800, jianchao.wang wrote:
> On 08/10/2018 03:41 AM, Bart Van Assche wrote:
> > +
> > + blk_set_pm_only(q);
> > + /*
> > +* This function only gets called if the most recent
> > +* pm_request_resume() call occurred at least autosuspend_delay_ms
> > +*
Checkpatch.pl warns there are 2 locations of smp_mb() and smp_wmb()
without code comment. This patch adds the missing code comments for
these memory barrier calls.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/closure.h | 4 +++-
drivers/md/bcache/super.c | 2 +-
2
This is not a preferred style to place open brace '{' at the end of
function definition, checkpatch.pl reports error for such coding
style. This patch moves them into the start of the next new line.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/super.c | 9 ++---
This patch declares char * array with const prefix in sysfs.c,
which is suggested by checkpatch.pl.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/bcache/sysfs.c
The SPDX header is missing fro closure.c, super.c and util.c, this
patch adds SPDX header for GPL-2.0 into these files.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/closure.c | 1 +
drivers/md/bcache/super.c | 1 +
drivers/md/bcache/util.c| 1 +
3 files
This is warned by checkpatch.pl, this patch removes the extra space.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/bcache.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/md/bcache/bcache.h b/drivers/md/bcache/bcache.h
index
On Fri, 2018-08-10 at 09:39 +0800, jianchao.wang wrote:
> On 08/10/2018 03:41 AM, Bart Van Assche wrote:
> > +/*
> > + * Whether or not blk_queue_enter() should proceed. RQF_PM requests are
> > always
> > + * allowed. RQF_DV requests are allowed if the PM_ONLY queue flag has not
> > been
> > + *
On Fri, 2018-08-10 at 15:27 +, Bart Van Assche wrote:
> On Fri, 2018-08-10 at 10:39 +0800, jianchao.wang wrote:
> > On 08/10/2018 03:41 AM, Bart Van Assche wrote:
> > > +void blk_pm_runtime_exit(struct request_queue *q)
> > > +{
> > > + if (!q->dev)
> > > + return;
> > > +
> > > +
Commit ea8c5356d390 ("bcache: set max writeback rate when I/O request
is idle") changes struct bch_ratelimit member rate from uint32_t to
atomic_long_t and uses atomic_long_set() in drivers/md/bcache/sysfs.c
to set new writeback rate, after the input is converted from memory
buf to long int by
There are many function definitions do not have identifier argument names,
scripts/checkpatch.pl complains warnings like this,
WARNING: function definition argument 'struct bcache_device *' should
also have an identifier name
#16735: FILE: writeback.h:120:
+void
This patch fixes warning reported by checkpatch.pl by replacing 'unsigned'
with 'unsigned int'.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/alloc.c | 36 ++-
drivers/md/bcache/bcache.h| 107 +++
drivers/md/bcache/bset.c
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/alloc.c | 3 +++
drivers/md/bcache/bcache.h| 1 +
drivers/md/bcache/bset.c | 5 -
drivers/md/bcache/btree.c | 7 +++
drivers/md/bcache/closure.c | 1 +
drivers/md/bcache/debug.c | 4 ++--
There are still many places in bcache use printk to display kernel
message, which are suggested to be preplaced by pr_*() routines like
pr_err(), pr_info(), or pr_notice().
This patch replaces all printk() with a proper pr_*() routine for
bcache code.
Signed-off-by: Coly Li
Reviewed-by:
Symbolic permission names are used in bcache, for now octal permission
numbers are encouraged to use for readability. This patch replaces
all symbolic permissions by octal permission numbers.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/bcache.h | 4 ++--
This patch fixes the lines over 80 characters into more lines, to minimize
warnings by checkpatch.pl. There are still some lines exceed 80 characters,
but it is better to be a single line and I don't change them.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/bcache.h
This patch fixes 3 style issues warned by checkpatch.pl,
- Comment lines are not aligned
- Comments use "/*" on subsequent lines
- Comment lines use a trailing "*/"
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/bset.c | 9 ++---
drivers/md/bcache/super.c
kmem_cache_destroy() is safe for NULL pointer as input, the NULL pointer
checking is unncessary. This patch just removes the NULL pointer checking
to make code simpler.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/request.c | 3 +--
1 file changed, 1 insertion(+), 2
bch_btree_insert_check_key() has unaligned indent, or indent by blank
characters. This patch makes the indent aligned and replace blank by
tabs.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/btree.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
'%pF' and '%pf' are deprecated vsprintf pointer extensions, this patch
replace them by '%pS', which is suggested by checkpatch.pl.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/closure.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
This patch fixes typo 'succesfully' to correct 'successfully', which is
suggested by checkpatch.pl.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/io.c | 2 +-
drivers/md/bcache/request.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
Current bcache Kconfig uses '---help---' as header of help information,
for now 'help' is prefered. This patch fixes this style by replacing
'---help---' by 'help' in bcache Kconfig file.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/Kconfig | 6 +++---
1 file
On Fri, 2018-08-10 at 10:39 +0800, jianchao.wang wrote:
> On 08/10/2018 03:41 AM, Bart Van Assche wrote:
> > +void blk_pm_runtime_exit(struct request_queue *q)
> > +{
> > + if (!q->dev)
> > + return;
> > +
> > + pm_runtime_get_sync(q->dev);
> > + q->dev = NULL;
> > +}
> >
This series contains several minor fixes and code cleanup reported by
scripts/checkpatch.pl. After this series, there are still a few warning
from checkpatch.pl, but I think they are necessary to be the way they
are and don't change them. For example, error message exceeds 80 chars
line limit.
On 8/10/18 9:45 AM, Coly Li wrote:
> Commit ea8c5356d390 ("bcache: set max writeback rate when I/O request
> is idle") changes struct bch_ratelimit member rate from uint32_t to
> atomic_long_t and uses atomic_long_set() in drivers/md/bcache/sysfs.c
> to set new writeback rate, after the input is
Thanks for cc. How is this exploitable? I mean only root can write to
sysfs? Or do you mean by allowing a user via sudo to write to that entry?
Stefan
Am 10.08.2018 um 17:45 schrieb Coly Li:
> Commit ea8c5356d390 ("bcache: set max writeback rate when I/O request
> is idle") changes struct
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/alloc.c | 3 +++
drivers/md/bcache/bcache.h| 1 +
drivers/md/bcache/bset.c | 5 -
drivers/md/bcache/btree.c | 7 +++
drivers/md/bcache/closure.c | 1 +
drivers/md/bcache/debug.c | 4 ++--
Hi Jens,
This series contains several minor fixes and code cleanup reported by
scripts/checkpatch.pl. After this series, there are still a few warning
from checkpatch.pl, but I think they are necessary to be the way they
are and don't change them. For example, error message exceeds 80 chars
line
There are still many places in bcache use printk to display kernel
message, which are suggested to be preplaced by pr_*() routines like
pr_err(), pr_info(), or pr_notice().
This patch replaces all printk() with a proper pr_*() routine for
bcache code.
Signed-off-by: Coly Li
Reviewed-by:
There are many function definitions do not have identifier argument names,
scripts/checkpatch.pl complains warnings like this,
WARNING: function definition argument 'struct bcache_device *' should
also have an identifier name
#16735: FILE: writeback.h:120:
+void
This patch fixes warning reported by checkpatch.pl by replacing 'unsigned'
with 'unsigned int'.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/alloc.c | 36 ++-
drivers/md/bcache/bcache.h| 107 +++
drivers/md/bcache/bset.c
Symbolic permission names are used in bcache, for now octal permission
numbers are encouraged to use for readability. This patch replaces
all symbolic permissions by octal permission numbers.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/bcache.h | 4 ++--
This patch fixes the lines over 80 characters into more lines, to minimize
warnings by checkpatch.pl. There are still some lines exceed 80 characters,
but it is better to be a single line and I don't change them.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/bcache.h
Checkpatch.pl warns there are 2 locations of smp_mb() and smp_wmb()
without code comment. This patch adds the missing code comments for
these memory barrier calls.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/closure.h | 4 +++-
drivers/md/bcache/super.c | 2 +-
2
This patch declares char * array with const prefix in sysfs.c,
which is suggested by checkpatch.pl.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/bcache/sysfs.c
'%pF' and '%pf' are deprecated vsprintf pointer extensions, this patch
replace them by '%pS', which is suggested by checkpatch.pl.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/closure.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
This patch fixes typo 'succesfully' to correct 'successfully', which is
suggested by checkpatch.pl.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/io.c | 2 +-
drivers/md/bcache/request.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
This patch fixes 3 style issues warned by checkpatch.pl,
- Comment lines are not aligned
- Comments use "/*" on subsequent lines
- Comment lines use a trailing "*/"
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/bset.c | 9 ++---
drivers/md/bcache/super.c
Current bcache Kconfig uses '---help---' as header of help information,
for now 'help' is prefered. This patch fixes this style by replacing
'---help---' by 'help' in bcache Kconfig file.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/Kconfig | 6 +++---
1 file
This is warned by checkpatch.pl, this patch removes the extra space.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/bcache.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/md/bcache/bcache.h b/drivers/md/bcache/bcache.h
index
This is not a preferred style to place open brace '{' at the end of
function definition, checkpatch.pl reports error for such coding
style. This patch moves them into the start of the next new line.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/super.c | 9 ++---
bch_btree_insert_check_key() has unaligned indent, or indent by blank
characters. This patch makes the indent aligned and replace blank by
tabs.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/btree.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
The SPDX header is missing fro closure.c, super.c and util.c, this
patch adds SPDX header for GPL-2.0 into these files.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/closure.c | 1 +
drivers/md/bcache/super.c | 1 +
drivers/md/bcache/util.c| 1 +
3 files
kmem_cache_destroy() is safe for NULL pointer as input, the NULL pointer
checking is unncessary. This patch just removes the NULL pointer checking
to make code simpler.
Signed-off-by: Coly Li
Reviewed-by: Shenghui Wang
---
drivers/md/bcache/request.c | 3 +--
1 file changed, 1 insertion(+), 2
On 2018/8/11 1:19 PM, Coly Li wrote:
> Hi Jens,
>
> This series contains several minor fixes and code cleanup reported by
> scripts/checkpatch.pl. After this series, there are still a few warning
> from checkpatch.pl, but I think they are necessary to be the way they
> are and don't change them.
On 2018/8/11 2:19 AM, Jens Axboe wrote:
> On 8/10/18 9:45 AM, Coly Li wrote:
>> Commit ea8c5356d390 ("bcache: set max writeback rate when I/O request
>> is idle") changes struct bch_ratelimit member rate from uint32_t to
>> atomic_long_t and uses atomic_long_set() in drivers/md/bcache/sysfs.c
>>
On 2018/8/11 2:13 AM, Stefan Priebe - Profihost AG wrote:
> Thanks for cc. How is this exploitable? I mean only root can write to
> sysfs? Or do you mean by allowing a user via sudo to write to that entry?
Hi Stefan,
This is not a security 0day bug, this is an error reported by Linux
kernel 0day
On 2018/8/10 4:26 PM, shenghui wrote:
>
>
> On 08/10/2018 03:23 PM, Coly Li wrote:
>> There are many function definitions do not have identifier argument names,
>> scripts/checkpatch.pl complains warnings like this,
>>
>> WARNING: function definition argument 'struct bcache_device *' should
>>
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
bch_btree_insert_check_key() has unaligned indent, or indent by blank
characters. This patch makes the indent aligned and replace blank by
tabs.
Signed-off-by: Coly Li
Cc: Shenghui Wang
---
drivers/md/bcache/btree.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
There are still many places in bcache use printk to display kernel
message, which are suggested to be preplaced by pr_*() routines like
pr_err(), pr_info(), or pr_notice().
This patch replaces all printk() with a proper pr_*() routine for
bcache code.
Signed-off-by: Coly Li
Cc: Shenghui Wang
kmem_cache_destroy() is safe for NULL pointer as input, the NULL pointer
checking is unncessary. This patch just removes the NULL pointer checking
to make code simpler.
Signed-off-by: Coly Li
Cc: Shenghui Wang
---
drivers/md/bcache/request.c | 3 +--
1 file changed, 1 insertion(+), 2
Current bcache Kconfig uses '---help---' as header of help information,
for now 'help' is prefered. This patch fixes this style by replacing
'---help---' by 'help' in bcache Kconfig file.
Signed-off-by: Coly Li
Cc: Shenghui Wang
---
drivers/md/bcache/Kconfig | 6 +++---
1 file changed, 3
'%pF' and '%pf' are deprecated vsprintf pointer extensions, this patch
replace them by '%pS', which is suggested by checkpatch.pl.
Signed-off-by: Coly Li
Cc: Shenghui Wang
---
drivers/md/bcache/closure.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Symbolic permission names are used in bcache, for now octal permission
numbers are encouraged to use for readability. This patch replaces
all symbolic permissions by octal permission numbers.
Signed-off-by: Coly Li
Cc: Shenghui Wang
---
drivers/md/bcache/bcache.h | 4 ++--
This patch fixes typo 'succesfully' to correct 'successfully', which is
suggested by checkpatch.pl.
Signed-off-by: Coly Li
Cc: Shenghui Wang
---
drivers/md/bcache/io.c | 2 +-
drivers/md/bcache/request.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
This patch declares char * array with const prefix in sysfs.c,
which is suggested by checkpatch.pl.
Signed-off-by: Coly Li
Cc: Shenghui Wang
---
drivers/md/bcache/sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c
This patch fixes 3 style issues warned by checkpatch.pl,
- Comment lines are not aligned
- Comments use "/*" on subsequent lines
- Comment lines use a trailing "*/"
Signed-off-by: Coly Li
Cc: Shenghui Wang
---
drivers/md/bcache/bset.c | 9 ++---
drivers/md/bcache/super.c | 22
This is warned by checkpatch.pl, this patch removes the extra space.
Signed-off-by: Coly Li
Cc: Shenghui Wang
---
drivers/md/bcache/bcache.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/md/bcache/bcache.h b/drivers/md/bcache/bcache.h
index
This is not a preferred style to place open brace '{' at the end of
function definition, checkpatch.pl reports error for such coding
style. This patch moves them into the start of the next new line.
Signed-off-by: Coly Li
Cc: Shenghui Wang
---
drivers/md/bcache/super.c | 9 ++---
1 file
The SPDX header is missing fro closure.c, super.c and util.c, this
patch adds SPDX header for GPL-2.0 into these files.
Signed-off-by: Coly Li
Cc: Shenghui Wang
---
drivers/md/bcache/closure.c | 1 +
drivers/md/bcache/super.c | 1 +
drivers/md/bcache/util.c| 1 +
3 files changed, 3
Checkpatch.pl warns there are 2 locations of smp_mb() and smp_wmb()
without code comment. This patch adds the missing code comments for
these memory barrier calls.
Signed-off-by: Coly Li
Cc: Shenghui Wang
---
drivers/md/bcache/closure.h | 4 +++-
drivers/md/bcache/super.c | 2 +-
2 files
Signed-off-by: Coly Li
Cc: Shenghui Wang
---
drivers/md/bcache/alloc.c | 3 +++
drivers/md/bcache/bcache.h| 1 +
drivers/md/bcache/bset.c | 5 -
drivers/md/bcache/btree.c | 7 +++
drivers/md/bcache/closure.c | 1 +
drivers/md/bcache/debug.c | 4 ++--
This patch fixes warning reported by checkpatch.pl by replacing 'unsigned'
with 'unsigned int'.
Signed-off-by: Coly Li
Cc: Shenghui Wang
---
drivers/md/bcache/alloc.c | 36 ++-
drivers/md/bcache/bcache.h| 107 +++
drivers/md/bcache/bset.c | 114
This series contains several minor fixes and code cleanup reported by
scripts/checkpatch.pl. After this series, there are still a few warning
from checkpatch.pl, but I think they are necessary to be the way they
are and don't change them. For example, error message exceeds 80 chars
line limit.
There are many function definitions do not have identifier argument names,
scripts/checkpatch.pl complains warnings like this,
WARNING: function definition argument 'struct bcache_device *' should
also have an identifier name
#16735: FILE: writeback.h:120:
+void
This patch fixes the lines over 80 characters into more lines, to minimize
warnings by checkpatch.pl. There are still some lines exceed 80 characters,
but it is better to be a single line and I don't change them.
Signed-off-by: Coly Li
Cc: Shenghui Wang
---
drivers/md/bcache/bcache.h| 4
On Fri, Aug 10, 2018 at 10:31:29AM +0800, Ming Lei wrote:
> On Fri, Aug 10, 2018 at 02:09:01AM +, Felipe Franciosi wrote:
> > Hi Ming (and all),
> >
> > Your series "scsi: virtio_scsi: fix IO hang caused by irq vector automatic
> > affinity" which forces virtio-scsi to use blk-mq fixes an
74 matches
Mail list logo
