Re: [EXT] Re: [PATCH] lightnvm: pblk: ignore the smeta oob area scan

2018-10-26 Thread Hans Holmberg
On Fri, Oct 26, 2018 at 1:12 AM Zhoujie Wu wrote: > > > > On 10/25/2018 04:16 AM, Hans Holmberg wrote: > > External Email > > > > -- > > On Thu, Oct 25, 2018 at 2:44 AM Zhoujie Wu wrote: > >> The smeta area l2p mapping is empty,

Re: [PATCH v2] lightnvm: pblk: ignore the smeta oob area scan

2018-10-26 Thread Hans Holmberg
Yes, please do. Reviewed-by: Hans Holmberg On Fri, Oct 26, 2018 at 10:08 AM Matias Bjørling wrote: > > On 10/26/2018 01:38 AM, Zhoujie Wu wrote: > > The smeta area l2p mapping is empty, and actually the > > recovery procedure only need to restore data sector's l2p > > mapping. So ignore the

[GIT PULL] Followup block changes for 4.20-rc1

2018-10-26 Thread Jens Axboe
fix for xen-blkfront (Vasilis Liaskovitis) - Fixing the get_rq trace point placement in blk-mq (Xiaoguang Wang) - Removal of a set-but-not-read variable in cdrom (zhong jiang) Please pull! git://git.kernel.dk/linux-block.git tags/for-linus-20181026

Re: [PATCH v2] lightnvm: pblk: ignore the smeta oob area scan

2018-10-26 Thread Matias Bjørling
On 10/26/2018 01:49 PM, Hans Holmberg wrote: Yes, please do. Reviewed-by: Hans Holmberg On Fri, Oct 26, 2018 at 10:08 AM Matias Bjørling wrote: On 10/26/2018 01:38 AM, Zhoujie Wu wrote: The smeta area l2p mapping is empty, and actually the recovery procedure only need to restore data

Re: [GIT PULL] Followup block changes for 4.20-rc1

2018-10-26 Thread Linus Torvalds
On Fri, Oct 26, 2018 at 9:00 AM Jens Axboe wrote: > > A followup pull request for this merge window. Pulled, Linus

Re: [PATCH 1/3] block: make sure discard bio is aligned with logical block size

2018-10-26 Thread Christoph Hellwig
> if (req_sects > UINT_MAX >> 9) > - req_sects = UINT_MAX >> 9; > + req_sects = (UINT_MAX >> 9) & ~bs_mask; Given that we have this same thing duplicated in write zeroes what about a documented helper?

Re: [PATCH v2] lightnvm: pblk: ignore the smeta oob area scan

2018-10-26 Thread Javier Gonzalez
> On 26 Oct 2018, at 01.35, Zhoujie Wu wrote: > > The smeta area l2p mapping is empty, and actually the > recovery procedure only need to restore data sector's l2p > mapping. So ignore the smeta oob scan. > > Signed-off-by: Zhoujie Wu > --- > v2: Modified based on suggestion from Hans. The

Re: [PATCH 2/3] block: cleanup __blkdev_issue_discard()

2018-10-26 Thread Christoph Hellwig
On Fri, Oct 26, 2018 at 02:24:34PM +0800, Ming Lei wrote: > Cleanup __blkdev_issue_discard(). It would help to explain what you clean up.. > + unsigned int req_sects = min(nr_sects, (UINT_MAX >> 9) & > ~bs_mask); This creates an overly long line.

Re: [PATCH v2] lightnvm: pblk: ignore the smeta oob area scan

2018-10-26 Thread Matias Bjørling
On 10/26/2018 01:38 AM, Zhoujie Wu wrote: The smeta area l2p mapping is empty, and actually the recovery procedure only need to restore data sector's l2p mapping. So ignore the smeta oob scan. Signed-off-by: Zhoujie Wu --- v2: Modified based on suggestion from Hans. The smeta may not start

[PATCH 0/3] block: make sure discard/writesame bio is aligned with logical block size

2018-10-26 Thread Ming Lei
Hi, The 1st & 3rd patch fixes bio size alignment issue. The 2nd patch cleans up __blkdev_issue_discard() a bit. Thanks, Ming Lei (3): block: make sure discard bio is aligned with logical block size block: cleanup __blkdev_issue_discard() block: make sure writesame bio is aligned with

[PATCH 3/3] block: make sure writesame bio is aligned with logical block size

2018-10-26 Thread Ming Lei
Obviously the created writesame bio has to be aligned with logical block size. Fixes: b49a0871be31a745b2ef ("block: remove split code in blkdev_issue_{discard,write_same}") Cc: Rui Salvaterra Cc: sta...@vger.kernel.org Cc: Mike Snitzer Cc: Christoph Hellwig Cc: Xiao Ni Cc: Mariusz Dabrowski

[PATCH 2/3] block: cleanup __blkdev_issue_discard()

2018-10-26 Thread Ming Lei
Cleanup __blkdev_issue_discard(). Cc: Rui Salvaterra Cc: Mike Snitzer Cc: Christoph Hellwig Cc: Xiao Ni Cc: Mariusz Dabrowski Signed-off-by: Ming Lei --- block/blk-lib.c | 23 +-- 1 file changed, 5 insertions(+), 18 deletions(-) diff --git a/block/blk-lib.c

[PATCH 1/3] block: make sure discard bio is aligned with logical block size

2018-10-26 Thread Ming Lei
Obviously the created discard bio has to be aligned with logical block size. Fixes: 744889b7cbb56a6 ("block: don't deal with discard limit in blkdev_issue_discard()") Reported-by: Rui Salvaterra Cc: Rui Salvaterra Cc: sta...@vger.kernel.org Cc: Mike Snitzer Cc: Christoph Hellwig Cc: Xiao Ni