Re: [PATCH] queue stall with blk-mq-sched

2017-01-27 Thread Hannes Reinecke
On 01/26/2017 05:42 PM, Jens Axboe wrote: > On 01/26/2017 09:35 AM, Hannes Reinecke wrote: >> On 01/25/2017 11:27 PM, Jens Axboe wrote: [ .. ] >>> And another variant, this one should be better in that it should result >>> in less queue runs and get better merging. Hope it works with your >>>

Re: [PATCH] queue stall with blk-mq-sched

2017-01-26 Thread Jens Axboe
On 01/26/2017 09:42 AM, Jens Axboe wrote: > On 01/26/2017 09:35 AM, Hannes Reinecke wrote: >> On 01/25/2017 11:27 PM, Jens Axboe wrote: >>> On 01/25/2017 10:42 AM, Jens Axboe wrote: On 01/25/2017 10:03 AM, Jens Axboe wrote: > On 01/25/2017 09:57 AM, Hannes Reinecke wrote: >> On

Re: [PATCH] queue stall with blk-mq-sched

2017-01-26 Thread Hannes Reinecke
On 01/25/2017 11:27 PM, Jens Axboe wrote: > On 01/25/2017 10:42 AM, Jens Axboe wrote: >> On 01/25/2017 10:03 AM, Jens Axboe wrote: >>> On 01/25/2017 09:57 AM, Hannes Reinecke wrote: On 01/25/2017 04:52 PM, Jens Axboe wrote: > On 01/25/2017 04:10 AM, Hannes Reinecke wrote: [ .. ]

Re: [PATCH] queue stall with blk-mq-sched

2017-01-26 Thread Jens Axboe
On 01/26/2017 09:35 AM, Hannes Reinecke wrote: > On 01/25/2017 11:27 PM, Jens Axboe wrote: >> On 01/25/2017 10:42 AM, Jens Axboe wrote: >>> On 01/25/2017 10:03 AM, Jens Axboe wrote: On 01/25/2017 09:57 AM, Hannes Reinecke wrote: > On 01/25/2017 04:52 PM, Jens Axboe wrote: >> On

Re: [PATCH] queue stall with blk-mq-sched

2017-01-25 Thread Jens Axboe
On 01/25/2017 10:42 AM, Jens Axboe wrote: > On 01/25/2017 10:03 AM, Jens Axboe wrote: >> On 01/25/2017 09:57 AM, Hannes Reinecke wrote: >>> On 01/25/2017 04:52 PM, Jens Axboe wrote: On 01/25/2017 04:10 AM, Hannes Reinecke wrote: >>> [ .. ] > Bah. > > Not quite. I'm still seeing

Re: [PATCH] queue stall with blk-mq-sched

2017-01-25 Thread Jens Axboe
On 01/25/2017 10:03 AM, Jens Axboe wrote: > On 01/25/2017 09:57 AM, Hannes Reinecke wrote: >> On 01/25/2017 04:52 PM, Jens Axboe wrote: >>> On 01/25/2017 04:10 AM, Hannes Reinecke wrote: >> [ .. ] Bah. Not quite. I'm still seeing some queues with state 'restart'. I've

Re: [PATCH] queue stall with blk-mq-sched

2017-01-25 Thread Jens Axboe
On 01/25/2017 04:10 AM, Hannes Reinecke wrote: > On 01/25/2017 09:07 AM, Hannes Reinecke wrote: >> On 01/25/2017 08:39 AM, Hannes Reinecke wrote: >>> On 01/24/2017 11:06 PM, Jens Axboe wrote: On 01/24/2017 12:55 PM, Jens Axboe wrote: > Try this patch. We only want to bump it for the

Re: [PATCH] queue stall with blk-mq-sched

2017-01-25 Thread Hannes Reinecke
On 01/25/2017 09:07 AM, Hannes Reinecke wrote: > On 01/25/2017 08:39 AM, Hannes Reinecke wrote: >> On 01/24/2017 11:06 PM, Jens Axboe wrote: >>> On 01/24/2017 12:55 PM, Jens Axboe wrote: Try this patch. We only want to bump it for the driver tags, not the scheduler side. >>> >>> More

Re: [PATCH] queue stall with blk-mq-sched

2017-01-25 Thread Hannes Reinecke
On 01/25/2017 08:39 AM, Hannes Reinecke wrote: > On 01/24/2017 11:06 PM, Jens Axboe wrote: >> On 01/24/2017 12:55 PM, Jens Axboe wrote: >>> Try this patch. We only want to bump it for the driver tags, not the >>> scheduler side. >> >> More complete version, this one actually tested. I think this

Re: [PATCH] queue stall with blk-mq-sched

2017-01-24 Thread Hannes Reinecke
On 01/24/2017 11:06 PM, Jens Axboe wrote: > On 01/24/2017 12:55 PM, Jens Axboe wrote: >> Try this patch. We only want to bump it for the driver tags, not the >> scheduler side. > > More complete version, this one actually tested. I think this should fix > your issue, let me know. > Nearly there.

Re: [PATCH] queue stall with blk-mq-sched

2017-01-24 Thread Jens Axboe
On 01/24/2017 12:55 PM, Jens Axboe wrote: > Try this patch. We only want to bump it for the driver tags, not the > scheduler side. More complete version, this one actually tested. I think this should fix your issue, let me know. diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c index

Re: [PATCH] queue stall with blk-mq-sched

2017-01-24 Thread Jens Axboe
On 01/24/2017 11:49 AM, Hannes Reinecke wrote: > On 01/24/2017 05:09 PM, Jens Axboe wrote: >> On 01/24/2017 08:54 AM, Hannes Reinecke wrote: >>> Hi Jens, >>> >>> I'm trying to debug a queue stall with your blk-mq-sched branch; with my >>> latest mpt3sas patches fio stops basically directly after

Re: [PATCH] queue stall with blk-mq-sched

2017-01-24 Thread Hannes Reinecke
On 01/24/2017 05:09 PM, Jens Axboe wrote: On 01/24/2017 08:54 AM, Hannes Reinecke wrote: Hi Jens, I'm trying to debug a queue stall with your blk-mq-sched branch; with my latest mpt3sas patches fio stops basically directly after starting a sequential read :-( I've debugged things and came up

Re: [PATCH] queue stall with blk-mq-sched

2017-01-24 Thread Hannes Reinecke
On 01/24/2017 05:03 PM, Jens Axboe wrote: On 01/24/2017 08:54 AM, Hannes Reinecke wrote: Hi Jens, I'm trying to debug a queue stall with your blk-mq-sched branch; with my latest mpt3sas patches fio stops basically directly after starting a sequential read :-( I've debugged things and came up

Re: [PATCH] queue stall with blk-mq-sched

2017-01-24 Thread Jens Axboe
On 01/24/2017 08:54 AM, Hannes Reinecke wrote: > Hi Jens, > > I'm trying to debug a queue stall with your blk-mq-sched branch; with my > latest mpt3sas patches fio stops basically directly after starting a > sequential read :-( > > I've debugged things and came up with the attached patch; we

Re: [PATCH] queue stall with blk-mq-sched

2017-01-24 Thread Jens Axboe
On 01/24/2017 08:54 AM, Hannes Reinecke wrote: > Hi Jens, > > I'm trying to debug a queue stall with your blk-mq-sched branch; with my > latest mpt3sas patches fio stops basically directly after starting a > sequential read :-( > > I've debugged things and came up with the attached patch; we