Re: btrfs csum failed on git .pack file

2009-09-09 Thread Oliver Mattos
What a strange coincidence that it affected git pack files in both cases. It's almost too improbable... Probably more than a coincidence I think, the question is what though... Some SSD drives (or rather the cheap wear levelling controllers in things like USB sticks) have firmware which tri

BUG? a possible bug for the absence of memory barrier

2009-09-09 Thread 홍신 shin hong
Hello. I am reporting possible bugs caused by the absence of memory barriers. Please examine this issue and let me know your opinion. In add_async_extent(), an async_extent object is allocated and initialized and then links to &cow->extents. However, since there is no memory barrier between the

[PATCH] Btrfs: proper -ENOSPC handling v2

2009-09-09 Thread Josef Bacik
This is vastly different from the original patch. Now instead of checking for enough space when starting each transaction, we simply do a btrfs_reserve_metadata_space() and specify how many items we plan on modifying. Then once we've done our modifications and such, just call btrfs_unreserve_metad

Re: btrfs failing fsx-linux

2009-09-09 Thread Chris Mason
On Wed, Sep 09, 2009 at 03:43:51PM +0200, Nick Piggin wrote: > On Wed, Sep 09, 2009 at 09:37:29AM -0400, Chris Mason wrote: > > On Wed, Sep 09, 2009 at 03:34:35PM +0200, Nick Piggin wrote: > > > Which cases do set_page_dirty happen without page_mkwrite? For fsx-linux > > > I hope there shouldn't be

Re: btrfs failing fsx-linux

2009-09-09 Thread Nick Piggin
On Wed, Sep 09, 2009 at 09:37:29AM -0400, Chris Mason wrote: > On Wed, Sep 09, 2009 at 03:34:35PM +0200, Nick Piggin wrote: > > Which cases do set_page_dirty happen without page_mkwrite? For fsx-linux > > I hope there shouldn't be any... > > I've been assuming its the zap_pte_range part, but now I

Re: btrfs failing fsx-linux

2009-09-09 Thread Chris Mason
On Wed, Sep 09, 2009 at 03:34:35PM +0200, Nick Piggin wrote: > On Wed, Sep 09, 2009 at 09:13:49AM -0400, Chris Mason wrote: > > On Tue, Aug 18, 2009 at 07:26:41PM +0200, Nick Piggin wrote: > > > Hi Chris, > > > > > > Don't know if this is a known issue, but I have btrfs (after my previous > > > in

Re: btrfs failing fsx-linux

2009-09-09 Thread Nick Piggin
On Wed, Sep 09, 2009 at 09:13:49AM -0400, Chris Mason wrote: > On Tue, Aug 18, 2009 at 07:26:41PM +0200, Nick Piggin wrote: > > Hi Chris, > > > > Don't know if this is a known issue, but I have btrfs (after my previous > > inode_tree fixup patch) failing fsx-linux in Linus's current git tree. > >

Re: btrfs failing fsx-linux

2009-09-09 Thread Chris Mason
On Tue, Aug 18, 2009 at 07:26:41PM +0200, Nick Piggin wrote: > Hi Chris, > > Don't know if this is a known issue, but I have btrfs (after my previous > inode_tree fixup patch) failing fsx-linux in Linus's current git tree. > > This makes it a bit hard for me to test my btrfs truncate conversion p

Re: btrfs csum failed on git .pack file

2009-09-09 Thread Chris Mason
On Wed, Sep 09, 2009 at 09:37:42AM +0100, Daniel J Blueman wrote: > >> > >> http://www.ocztechnologyforum.com/forum/showthread.php?t=57516 > > > > The issue is pretty much moot at this point, since OCZ support were not > > really interested in providing any sort of real technical support to > > fin

Re: btrfs csum failed on git .pack file

2009-09-09 Thread Daniel J Blueman
On Wed, Sep 9, 2009 at 9:26 AM, Jens Axboe wrote: > On Wed, Sep 09 2009, Daniel J Blueman wrote: >> On Wed, Sep 9, 2009 at 8:01 AM, Jens Axboe wrote: >> > On Wed, Sep 09 2009, Markus Trippelsdorf wrote: >> >> On Tue, Sep 08, 2009 at 10:32:14PM +0200, Jens Axboe wrote: >> >> > On Tue, Sep 08 2009, M

Re: btrfs csum failed on git .pack file

2009-09-09 Thread Jens Axboe
On Wed, Sep 09 2009, Daniel J Blueman wrote: > On Wed, Sep 9, 2009 at 8:01 AM, Jens Axboe wrote: > > On Wed, Sep 09 2009, Markus Trippelsdorf wrote: > >> On Tue, Sep 08, 2009 at 10:32:14PM +0200, Jens Axboe wrote: > >> > On Tue, Sep 08 2009, Markus Trippelsdorf wrote: > >> > > On Tue, Sep 08, 2009

Re: btrfs csum failed on git .pack file

2009-09-09 Thread Daniel J Blueman
On Wed, Sep 9, 2009 at 8:01 AM, Jens Axboe wrote: > On Wed, Sep 09 2009, Markus Trippelsdorf wrote: >> On Tue, Sep 08, 2009 at 10:32:14PM +0200, Jens Axboe wrote: >> > On Tue, Sep 08 2009, Markus Trippelsdorf wrote: >> > > On Tue, Sep 08, 2009 at 10:00:42PM +0200, Jens Axboe wrote: >> > > > On Mon,

Re: btrfs csum failed on git .pack file

2009-09-09 Thread Gregory Maxwell
On Tue, Sep 8, 2009 at 5:53 PM, Tracy Reed wrote: > On Tue, Sep 08, 2009 at 10:22:11PM +0200, Markus Trippelsdorf spake thusly: >> I've already deleted the file in question unfortunately. >> On IRC Chris decided that either bad RAM or a harddrive error was the >> most likely reason for this chechsu

Re: btrfs csum failed on git .pack file

2009-09-09 Thread Jens Axboe
On Wed, Sep 09 2009, Markus Trippelsdorf wrote: > On Wed, Sep 09, 2009 at 09:01:41AM +0200, Jens Axboe wrote: > > On Wed, Sep 09 2009, Markus Trippelsdorf wrote: > > > On Tue, Sep 08, 2009 at 10:32:14PM +0200, Jens Axboe wrote: > > > > On Tue, Sep 08 2009, Markus Trippelsdorf wrote: > > > > > On Tu

Re: btrfs csum failed on git .pack file

2009-09-09 Thread Markus Trippelsdorf
On Wed, Sep 09, 2009 at 09:01:41AM +0200, Jens Axboe wrote: > On Wed, Sep 09 2009, Markus Trippelsdorf wrote: > > On Tue, Sep 08, 2009 at 10:32:14PM +0200, Jens Axboe wrote: > > > On Tue, Sep 08 2009, Markus Trippelsdorf wrote: > > > > On Tue, Sep 08, 2009 at 10:00:42PM +0200, Jens Axboe wrote: > >

Re: btrfs csum failed on git .pack file

2009-09-09 Thread Jens Axboe
On Wed, Sep 09 2009, Markus Trippelsdorf wrote: > On Tue, Sep 08, 2009 at 10:32:14PM +0200, Jens Axboe wrote: > > On Tue, Sep 08 2009, Markus Trippelsdorf wrote: > > > On Tue, Sep 08, 2009 at 10:00:42PM +0200, Jens Axboe wrote: > > > > On Mon, Sep 07 2009, Markus Trippelsdorf wrote: > > > > > Just