Re: [PATCH] Btrfs: extended inode refs support for send mechanism

2012-10-15 Thread Jan Schmidt
Hi Alex, On Thu, October 11, 2012 at 13:11 (+0200), Alex Lyakas wrote: @@ -993,12 +1010,17 @@ static int get_inode_path(struct send_ctx *sctx, struct btrfs_root *root, if (ret 0) goto out; if (ret) { - ret = 1; - goto out; +

Re: [PATCH] Btrfs: extended inode refs support for send mechanism

2012-10-15 Thread Jan Schmidt
Hi Mark, On Thu, October 11, 2012 at 23:39 (+0200), Mark Fasheh wrote: On Wed, Oct 10, 2012 at 01:21:31PM +0200, Jan Schmidt wrote: @@ -1574,11 +1599,22 @@ static int get_first_ref(struct send_ctx *sctx, goto out; } -iref = btrfs_item_ptr(path-nodes[0],

Re: [RFC v3 13/13] vfs: add documentation

2012-10-15 Thread Zhi Yong Wu
On Mon, Oct 15, 2012 at 8:35 AM, Zheng Liu gnehzuil@gmail.com wrote: Hi Zhi Yong, [cut...] +3. The Design + +These include the following parts: + +* Hooks in existing vfs functions to track data access frequency + +* New rbtrees for tracking access frequency of inodes and

Re: [RFC v3 00/13] vfs: hot data tracking

2012-10-15 Thread Zhi Yong Wu
On Mon, Oct 15, 2012 at 8:39 AM, Zheng Liu gnehzuil@gmail.com wrote: On Wed, Oct 10, 2012 at 06:07:22PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com NOTE: The patchset is currently post out mainly to make sure it is going in the correct direction and

Re: [RFC v3 11/13] vfs: add 3 new ioctl interfaces

2012-10-15 Thread Dave Chinner
On Wed, Oct 10, 2012 at 06:07:33PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com FS_IOC_GET_HEAT_INFO: return a struct containing the various metrics collected in btrfs_freq_data structs, and also return a calculated data temperature based on those metrics.

Re: [RFC v3 12/13] vfs: add debugfs support

2012-10-15 Thread Dave Chinner
On Wed, Oct 10, 2012 at 06:07:34PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Add a /sys/kernel/debug/hot_track/device_name/ directory for each volume that contains two files. The first, `inode_data', contains the heat information for inodes that have

Re: [RFC v3 11/13] vfs: add 3 new ioctl interfaces

2012-10-15 Thread Zhi Yong Wu
On Mon, Oct 15, 2012 at 3:48 PM, Dave Chinner da...@fromorbit.com wrote: On Wed, Oct 10, 2012 at 06:07:33PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com FS_IOC_GET_HEAT_INFO: return a struct containing the various metrics collected in btrfs_freq_data

Re: [RFC v3 12/13] vfs: add debugfs support

2012-10-15 Thread Dave Chinner
On Wed, Oct 10, 2012 at 06:07:34PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Add a /sys/kernel/debug/hot_track/device_name/ directory for each volume that contains two files. The first, `inode_data', contains the heat information for inodes that have

Re: [RFC v3 12/13] vfs: add debugfs support

2012-10-15 Thread Zhi Yong Wu
On Mon, Oct 15, 2012 at 3:55 PM, Dave Chinner da...@fromorbit.com wrote: On Wed, Oct 10, 2012 at 06:07:34PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Add a /sys/kernel/debug/hot_track/device_name/ directory for each volume that contains two files. The

[PATCH v2] Btrfs: extended inode refs support for send mechanism

2012-10-15 Thread Jan Schmidt
This adds support for the new extended inode refs to btrfs send. Signed-off-by: Jan Schmidt list.bt...@jan-o-sch.net --- fs/btrfs/backref.c | 22 - fs/btrfs/backref.h |4 ++ fs/btrfs/send.c| 126 +--- 3 files changed, 94

Re: [RFC v3 12/13] vfs: add debugfs support

2012-10-15 Thread Zhi Yong Wu
On Mon, Oct 15, 2012 at 4:04 PM, Dave Chinner da...@fromorbit.com wrote: On Wed, Oct 10, 2012 at 06:07:34PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Add a /sys/kernel/debug/hot_track/device_name/ directory for each volume that contains two files. The

Re: [PATCH 0/4] Add show sub command to btrfs subvolume

2012-10-15 Thread Anand Jain
Thanks for working on that; do you think that is it feasible to merge the works on btrfs sub list and btrfs sub show ? To date the output of btrfs sub list is quite cryptic: a lot of information on only on row, which is difficult to read. However it has the capability to traverse the

Re: problems with btrfs send / restore

2012-10-15 Thread Miao Xie
On thu, 11 Oct 2012 21:54:48 +0200, Stefan Priebe wrote: Am 11.10.2012 21:43, schrieb David Sterba: On Thu, Oct 11, 2012 at 09:33:54PM +0200, Stefan Priebe wrote: [server: /btrfs/target]# btrfs send -i /btrfs/src/\@snapshot/1 /btrfs/src/\@snapshot/2 | btrfs receive

[PATCH] Btrfs: do not zero the page if it's in a hole

2012-10-15 Thread Li Dongyang
Don't bother zeroing the page if it's already a hole under there. We can save one allocation from this. Signed-off-by: Li Dongyang jerry87...@gmail.com --- fs/btrfs/inode.c | 17 + 1 file changed, 17 insertions(+) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index

[PATCH] Btrfs: try harder when we merge holes

2012-10-15 Thread Li Dongyang
We should look at path-slots[0] rather than path-slots[0]+1 while trying to merge with the hole behind us. Also this patch will delete the the latter one if we can merge with both front and back, leaving one hole covers all three. Signed-off-by: Li Dongyang jerry87...@gmail.com ---

[PATCH] Btrfs-progs: use atoll() for mkfs.btrfs size option

2012-10-15 Thread Stefan Behrens
On 32 bit systems, a numerical parameter of 2147483648 or above to the mkfs.btrfs -b option does not work. The parameter is stored in an u64 but is read using atol() and thus not read correctly. This patch changes it to use atoll(). Specifying a multiplier (k, m or g) like 100g in the mkfs.btrfs

Re: [PATCH 1/3] Add support for different unit.

2012-10-15 Thread Martin Steigerwald
Am Samstag, 13. Oktober 2012 schrieb Goffredo Baroncelli: From: Goffredo Baroncelli kreij...@inwind.it The function pretty_sizes() returns a string containing the passed number. It add a suffix depending by the number: eg KiB, MiB. This change replace the old SI suffix (KB, MB..) by the IEC

Re: [PATCH][BTRFS-PROGS][V6] btrfs filesystem df

2012-10-15 Thread Martin Steigerwald
Am Samstag, 13. Oktober 2012 schrieb Goffredo Baroncelli: Hi Chris, this serie of patches updated the command btrfs filesystem df. I update this command because it is not so easy to get the information about the disk usage from the command fi df and fi show. This patch was the result of

Re: [PATCH][V1][BTRFS-PROGS] Replace the units from KB to KiB..

2012-10-15 Thread Martin Steigerwald
Am Samstag, 13. Oktober 2012 schrieb Goffredo Baroncelli: Hi All, several people asked to update the units showed by the btrfs tool form the SI ones (KB, MB, GB...) to the IEC ones (KiB, MiB...). The aim of this patch is to allow the user to choice which units are showed. Depending by the

Re: [PATCH] Fits: tool to parse stream

2012-10-15 Thread Chris Mason
On Sat, Oct 13, 2012 at 09:41:28AM -0600, David Sterba wrote: On Sat, Oct 13, 2012 at 09:08:57AM +0100, Rory Campbell-Lange wrote: Perhaps BTRFS Incremental Stream or Backup Incremental Stream should be considered, with the file extension .bis. From the brainstorming we had about the name,

Re: [PATCH][V1][BTRFS-PROGS] Replace the units from KB to KiB..

2012-10-15 Thread Goffredo Baroncelli
Hi Martin, thanks for your testing. My patches are based on the Chris's master branch (git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-progs.git, commit 91d9eec1ff044394f2b98ee7fcb76713dd33b994). I was able to apply both without problem. disk_free cannot be the source of the

Systemcall for offline deduplication

2012-10-15 Thread Bob Marley
Hello all btrfs developers I would really appreciate a systemcall (or ioctl or the like) to allow deduplication of a block of a file against a block of another file. (ok if blocks need to be aligned to filesystem blocks) So that if I know that bytes 32768...65536 of FileA are identical to

[PATCH] Btrfs: send correct rdev and mode in btrfs-send

2012-10-15 Thread Arne Jansen
When sending a device file, the stream was missing the mode. Also the rdev was encoded wrongly. Signed-off-by: Arne Jansen sensi...@gmx.net --- fs/btrfs/send.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c index c7beb54..57933e8

Re: [PATCH] Btrfs-progs: use atoll() for mkfs.btrfs size option

2012-10-15 Thread Goffredo Baroncelli
Hi Stefan, when I checked your patch I found further problems to the function parse_size(): - this function is declared two time: both in mkfs.c and in cmd-filesystem.c; this is a good chance to move it in the utils.c file. - your suggestion was to use atoll, which is signed. strtoull (which is

[PATCH] Move parse_size() in utils.c

2012-10-15 Thread Goffredo Baroncelli
From: Goffredo Baroncelli kreij...@inwind.it Move parse_size() in utils.c, because it is used both from cmds-filesystem.c and mkfs.c. Moreover added check about overflow, support to further units ( t=tera, e=exa, z=zetta, y=yotta). Correct a bug which happens if a value like 123MB is passed:

Re: problems with btrfs send / restore

2012-10-15 Thread Stefan Priebe
Am 15.10.2012 12:16, schrieb Miao Xie: On thu, 11 Oct 2012 21:54:48 +0200, Stefan Priebe wrote: Am 11.10.2012 21:43, schrieb David Sterba: On Thu, Oct 11, 2012 at 09:33:54PM +0200, Stefan Priebe wrote: [server: /btrfs/target]# btrfs send -i /btrfs/src/\@snapshot/1 /btrfs/src/\@snapshot/2

Re: problems with btrfs send / restore

2012-10-15 Thread Alex Lyakas
Hi Stefan, Is /btrfs/target/\@snapshot/ a subvolume or a directory? can you pls try the patch that I posted here: http://www.spinics.net/lists/linux-btrfs/msg19583.html I feel that you're hitting a similar issue here. Before you apply the patch, please verify that you have /etc/mtab on your

Re: problems with btrfs send / restore

2012-10-15 Thread Stefan Priebe
Am 15.10.2012 21:42, schrieb Alex Lyakas: Is /btrfs/target/\@snapshot/ a subvolume or a directory? A simple directory. can you pls try the patch that I posted here: http://www.spinics.net/lists/linux-btrfs/msg19583.html I feel that you're hitting a similar issue here. Before you apply the

Re: [PATCH] Fits: tool to parse stream

2012-10-15 Thread Alex Lyakas
Thanks, Arne, it will definitely help to debug issues. Alex. On Mon, Oct 15, 2012 at 4:32 PM, Chris Mason chris.ma...@fusionio.com wrote: On Sat, Oct 13, 2012 at 09:41:28AM -0600, David Sterba wrote: On Sat, Oct 13, 2012 at 09:08:57AM +0100, Rory Campbell-Lange wrote: Perhaps BTRFS

Re: problems with btrfs send / restore

2012-10-15 Thread Alex Lyakas
Stefan, the second issue you're seeing was discussed here: http://www.spinics.net/lists/linux-btrfs/msg19672.html You can apply the patch I sent there meanwhile, but as Miao pointed out, I will need to make a better patch (hope will do it soon, together with this one). Thanks, Alex. On Mon,

Re: Systemcall for offline deduplication

2012-10-15 Thread David Sterba
On Mon, Oct 15, 2012 at 07:09:23PM +0200, Bob Marley wrote: I would really appreciate a systemcall (or ioctl or the like) to allow deduplication of a block of a file against a block of another file. (ok if blocks need to be aligned to filesystem blocks) It exists, is called

Re: Can not Mount btrfs No Space left

2012-10-15 Thread Hugo Mills
On Mon, Oct 15, 2012 at 03:52:15PM -0400, Shawn Dakin wrote: I have a btrfs volume that will not mount due to No space on device I would gladly free up some space if I could only mount the volume. Does anyone have a trick to getting this volume back up and running? Any help would be great!!

Re: Can not Mount btrfs No Space left

2012-10-15 Thread Shawn Dakin
Hugo, Thanks, I had not thought of that. It does mount fine ro so I can access the files. Any ideas on getting access to delete a few log files or snapshots so I can mount the volume rw? If not I will just copy it off onto another, but that will be time consuming. On Mon, Oct 15, 2012 at 4:17

Re: [PATCH] Move parse_size() in utils.c

2012-10-15 Thread Stefan Behrens
Hi Goffredo On 10/15/2012 21:15, Goffredo Baroncelli wrote: From: Goffredo Baroncelli kreij...@inwind.it Move parse_size() in utils.c, because it is used both from cmds-filesystem.c and mkfs.c. Makes sense. (Jan also sent such a patch on 1 Feb 2011

Re: [RFC v3 00/13] vfs: hot data tracking

2012-10-15 Thread Dave Chinner
On Wed, Oct 10, 2012 at 06:07:22PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com NOTE: The patchset is currently post out mainly to make sure it is going in the correct direction and hope to get some helpful comments from other guys. For more

Re: [PATCH] Move parse_size() in utils.c

2012-10-15 Thread Goffredo Baroncelli
Hi Stefan, On 2012-10-15 22:36, Stefan Behrens wrote: Hi Goffredo On 10/15/2012 21:15, Goffredo Baroncelli wrote: From: Goffredo Baroncelli kreij...@inwind.it Move parse_size() in utils.c, because it is used both from cmds-filesystem.c and mkfs.c. Makes sense. (Jan also sent such a patch

[PATCH] xfs: add hot tracking support.

2012-10-15 Thread Dave Chinner
From: Dave Chinner dchin...@redhat.com Connect up the VFS hot tracking support so XFS filesystems can make use of it. Signed-off-by: Dave Chinner dchin...@redhat.com --- fs/xfs/xfs_mount.h |1 + fs/xfs/xfs_super.c |9 + 2 files changed, 10 insertions(+) diff --git

Re: [RFC v3 00/13] vfs: hot data tracking

2012-10-15 Thread Dave Chinner
On Wed, Oct 10, 2012 at 06:07:22PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com NOTE: The patchset is currently post out mainly to make sure it is going in the correct direction and hope to get some helpful comments from other guys. For more

Re: [RFC v3 11/13] vfs: add 3 new ioctl interfaces

2012-10-15 Thread Dave Chinner
On Wed, Oct 10, 2012 at 06:07:33PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com FS_IOC_GET_HEAT_INFO: return a struct containing the various metrics collected in btrfs_freq_data structs, and also return a I think you mean hot_freq_data :P calculated data

Re: [RFC v3 11/13] vfs: add 3 new ioctl interfaces

2012-10-15 Thread Zhi Yong Wu
On Tue, Oct 16, 2012 at 11:17 AM, Dave Chinner da...@fromorbit.com wrote: On Wed, Oct 10, 2012 at 06:07:33PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com FS_IOC_GET_HEAT_INFO: return a struct containing the various metrics collected in btrfs_freq_data

[PATCH] Btrfs: fix memory leak in btrfs_quota_enable()

2012-10-15 Thread Tsutomu Itoh
We should free quota_root before returning from the error handling code. Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com --- fs/btrfs/qgroup.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c index 5039686..5776506