[PATCH v2] btrfs-progs: there is devid 0 when replace is running

2014-02-04 Thread Anand Jain
During disk replacement a new disk is temporarily added to the fs devlist with devid 0 and fs num_device is incremented by 1. However when progs reads the devlist it fail to obtain details of devid 0 because it doesn't query devid 0 at all. reproducer: btrfs rep start /dev/sdb /dev/sdf /btrfs

Re: btrfs raid5 unmountable

2014-02-04 Thread Tetja Rediske
Hello Duncan, Of course if you'd been following the list as btrfs testers really should still be doing at this point, you'd have seen all this covered before. And of course, if you had done pre-deployment testing before you stuck valuable data on that btrfs raid5, you'd have noted the

[cmds-scrub.c:539]: (style) Array index 'i' is used before limits check.

2014-02-04 Thread David Binderman
Hello there, Static analyser cppcheck says many things about btrfs-progs, including the subject line. Source code is     while (isspace(l[i]) i avail) { Suggest code rework. I checked the latest source code and the bug exists there too. Regards David Binderman

Re: [PATCH] Btrfs: disable snapshot aware defrag for now

2014-02-04 Thread Josef Bacik
On 02/03/2014 10:19 PM, Roger Binns wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/02/14 09:27, Josef Bacik wrote: It is so totally broken that I don't want it being turned on by anybody who can't edit this and change it themselves. The symptoms I saw are huge amounts of kernel

Re: [PATCH] Btrfs: throttle delayed refs better

2014-02-04 Thread Josef Bacik
On 02/03/2014 05:53 PM, Johannes Hirte wrote: On Mon, 3 Feb 2014 16:08:08 -0500 Josef Bacik jba...@fb.com wrote: On 02/03/2014 01:28 PM, Johannes Hirte wrote: On Thu, 23 Jan 2014 13:07:52 -0500 Josef Bacik jba...@fb.com wrote: On one of our gluster clusters we noticed some pretty big lag

Re: Booting with syslinux not possible

2014-02-04 Thread Blaz Balon
I also had some problems with syslinux. For me it only works if I put boot folder to root of btrfs. Didn't have a chance to do more test, but I copied /boot from default subvolume to subvolume 0 and it boots OK. -- regards Blaz Balon On 01/31/2014 11:00 PM, Alex wrote: Sorry KC:

btrfs crash with a corrupted(?) filesystem

2014-02-04 Thread Roman Mamedov
Hello, My server had a period of instability (PSU-related issues), some lockups, some strange crashes, and some files became corrupted, and perhaps parts of a filesystem too. One BTRFS partition now fails with the following errors. On an attempt to make a snapshot: [ 48.035664] btrfs: corrupt

Re: btrfs crash with a corrupted(?) filesystem

2014-02-04 Thread Hugo Mills
On Tue, Feb 04, 2014 at 10:23:10PM +0600, Roman Mamedov wrote: Hello, My server had a period of instability (PSU-related issues), some lockups, some strange crashes, and some files became corrupted, and perhaps parts of a filesystem too. One BTRFS partition now fails with the following

Re: btrfs crash with a corrupted(?) filesystem

2014-02-04 Thread Roman Mamedov
On Tue, 4 Feb 2014 16:32:35 + Hugo Mills h...@carfax.org.uk wrote: On Tue, Feb 04, 2014 at 10:23:10PM +0600, Roman Mamedov wrote: Hello, My server had a period of instability (PSU-related issues), some lockups, some strange crashes, and some files became corrupted, and perhaps parts

Re: btrfs crash with a corrupted(?) filesystem

2014-02-04 Thread Hugo Mills
On Tue, Feb 04, 2014 at 10:35:06PM +0600, Roman Mamedov wrote: On Tue, 4 Feb 2014 16:32:35 + Hugo Mills h...@carfax.org.uk wrote: On Tue, Feb 04, 2014 at 10:23:10PM +0600, Roman Mamedov wrote: Hello, My server had a period of instability (PSU-related issues), some lockups,

Re: Booting with syslinux not possible

2014-02-04 Thread Alex
Blaz Balon blaz.balon at laly.si writes: I also had some problems with syslinux. For me it only works if I put boot folder to root of btrfs. Didn't have a chance to do more test, but I copied /boot from default subvolume to subvolume 0 and it boots OK. Not sure I understand your /boot

[PATCH] Btrfs: introduce commit_root_sem to protect commit roots

2014-02-04 Thread Josef Bacik
Btrfs send uses the commit roots to avoid locking and such when sending snapshots. The problem with this it doesn't lock anything to make sure the commit roots don't get swapped out from underneath it. This can cause issues if you are trying to send a snapshot and then snapshot that snapshot

[GIT PULL] Btrfs

2014-02-04 Thread Chris Mason
Hi Linus, Please pull my for-linus: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus Filipe is fixing compile and boot problems with our crc32c rework, and Josef has disabled snapshot aware defrag for now. As the number of snapshots increases, we're hitting OOM.

Re: hitting BUG_ON on troublesome FS

2014-02-04 Thread Remco Hosman - Yerf-it.com
to reply to my own thread: i managed to empty the filesystem, but it still segfaults in the same way when i try to balance the last few blocks. a `btrfs bal start -dusage=0 /mountpoint` finishes, but leaves a few blocks allocated. when i skip the usage=0, it segfaults. What can i do to

Re: [GIT PULL] Btrfs

2014-02-04 Thread Greg KH
On Mon, Feb 03, 2014 at 01:18:40PM -0500, Chris Mason wrote: On Mon 03 Feb 2014 12:54:05 PM EST, David Sterba wrote: On Thu, Jan 30, 2014 at 04:52:54PM -0500, Chris Mason wrote: Chris Mason (3) commits (+64/-32): Btrfs: setup inode location during btrfs_init_inode_locked (+9/-9)

Re: [GIT PULL] Btrfs

2014-02-04 Thread Chris Mason
On 02/04/2014 02:50 PM, Greg KH wrote: On Mon, Feb 03, 2014 at 01:18:40PM -0500, Chris Mason wrote: On Mon 03 Feb 2014 12:54:05 PM EST, David Sterba wrote: On Thu, Jan 30, 2014 at 04:52:54PM -0500, Chris Mason wrote: Chris Mason (3) commits (+64/-32): Btrfs: setup inode location during

Re: Booting with syslinux not possible

2014-02-04 Thread Duncan
Alex posted on Tue, 04 Feb 2014 17:19:09 + as excerpted: I have quite an (overly) complicated setup. I had to chuckle at that one. Fits my setup to a T, altho they're different complications than yours. I'll have to remember it the next time I find a fitting context to use it! =:^) --

Re: hitting BUG_ON on troublesome FS

2014-02-04 Thread Josef Bacik
On 02/03/2014 03:51 PM, Remco Hosman - Yerf-it.com wrote: FIrst, a bit of history of the filesystem: used to be 6 disks, now 5. partially raid1 / raid10. been migrating back and forth a few times. As some point, a balance would not complete and would end with 164 ENOSPC’ses, while there was

Are nocow files snapshot-aware

2014-02-04 Thread Kai Krakow
Hi! I'm curious... The whole snapshot thing on btrfs is based on its COW design. But you can make individual files and directory contents nocow by applying the C attribute on it using chattr. This is usually recommended for database files and VM images. So far, so good... But what happens to

Re: Are nocow files snapshot-aware

2014-02-04 Thread Josef Bacik
On 02/04/2014 03:52 PM, Kai Krakow wrote: Hi! I'm curious... The whole snapshot thing on btrfs is based on its COW design. But you can make individual files and directory contents nocow by applying the C attribute on it using chattr. This is usually recommended for database files and VM images.

Re: Are nocow files snapshot-aware

2014-02-04 Thread David Sterba
On Tue, Feb 04, 2014 at 08:22:05PM -0500, Josef Bacik wrote: On 02/04/2014 03:52 PM, Kai Krakow wrote: Hi! I'm curious... The whole snapshot thing on btrfs is based on its COW design. But you can make individual files and directory contents nocow by applying the C attribute on it using

Re: hitting BUG_ON on troublesome FS

2014-02-04 Thread Remco Hosman - Yerf-it.com
How can i tell? Label: data uuid: a8626d67-4684-4b23-99b3-8d5fa8e7fd69 Total devices 5 FS bytes used 820.00KiB devid2 size 1.82TiB used 1.00GiB path /dev/sdb2 devid3 size 1.82TiB used 1.00GiB path /dev/sdf2 devid5 size 2.73TiB used 3.00GiB path

[PATCH] Btrfs: skip submitting barrier for missing device

2014-02-04 Thread Hidetoshi Seto
I got an error on v3.13: BTRFS error (device sdf1) in write_all_supers:3378: errno=-5 IO failure (errors while submitting device barriers.) how to reproduce: mkfs.btrfs -f -d raid1 /dev/sdf1 /dev/sdf2 wipefs -a /dev/sdf2 mount -o degraded /dev/sdf1 /mnt btrfs balance start -f