On 2/14/14, 4:24 PM, Dave Chinner wrote:
On Fri, Feb 14, 2014 at 10:41:16AM -0600, Eric Sandeen wrote:
On 2/14/14, 10:39 AM, David Sterba wrote:
On Thu, Feb 13, 2014 at 10:42:55AM -0600, Eric Sandeen wrote:
+cat /proc/mounts | grep $SCRATCH_MNT | grep relatime $seqres.full
+[ $? -ne 0
On 2/14/14, 7:39 PM, Dave Chinner wrote:
On Fri, Feb 14, 2014 at 05:48:59PM -0600, Eric Sandeen wrote:
On 2/14/14, 4:24 PM, Dave Chinner wrote:
On Fri, Feb 14, 2014 at 10:41:16AM -0600, Eric Sandeen wrote:
On 2/14/14, 10:39 AM, David Sterba wrote:
On Thu, Feb 13, 2014 at 10:42:55AM -0600
On 2/13/14, 9:23 AM, Koen De Wit wrote:
Tests the noatime, relatime, strictatime and nodiratime mount options.
There is an extra check for Btrfs to ensure that the access time is
never updated on read-only subvolumes. (Regression test for bug fixed
with commit
On 1/12/14, 7:21 PM, Qu Wenruo wrote:
On fri, 10 Jan 2014 10:15:37 -0600, Eric Sandeen wrote:
On 1/8/14, 12:30 AM, Qu Wenruo wrote:
Test remount btrfs with different pairing options like barrier and no
barrier.
It seems that while this tests that the remount succeeds, and that
the option
On 1/12/14, 10:00 PM, Qu Wenruo wrote:
Now I'm interested in how other filesystems like xfs makes sure that every
pairing
mount options are tested.
For starters, xfs actually doesn't handle very many options during remount.
Many of them are quite tricky to do, which made me wonder if they
: Add nodiscard mount option.
962cbee btrfs: Add noautodefrag mount option.
0b4fa2a btrfs: Add barrier option to support -o remount,barrier
Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com
Cc: Eric Sandeen sand...@redhat.com
---
tests/btrfs/025 | 125
On 1/7/14, 2:01 PM, Ben Myers wrote:
Hey Gents,
On Mon, Jan 06, 2014 at 03:46:58PM -0600, Eric Sandeen wrote:
On 1/6/14, 3:42 PM, Josef Bacik wrote:
On 01/06/2014 04:32 PM, Eric Sandeen wrote:
On 1/6/14, 1:58 PM, Josef Bacik wrote:
I was trying to reproduce something with fsx and I
On 1/7/14, 2:10 PM, Eric Sandeen wrote:
On 1/7/14, 2:01 PM, Ben Myers wrote:
Hey Gents,
On Mon, Jan 06, 2014 at 03:46:58PM -0600, Eric Sandeen wrote:
On 1/6/14, 3:42 PM, Josef Bacik wrote:
On 01/06/2014 04:32 PM, Eric Sandeen wrote:
On 1/6/14, 1:58 PM, Josef Bacik wrote:
I was trying
On 1/6/14, 1:58 PM, Josef Bacik wrote:
I was trying to reproduce something with fsx and I noticed that no matter what
seed I set I was getting the same file. Come to find out we are overloading
random() with our own custom horribleness for some unknown reason. So nuke
the
damn thing from
On 1/6/14, 3:42 PM, Josef Bacik wrote:
On 01/06/2014 04:32 PM, Eric Sandeen wrote:
On 1/6/14, 1:58 PM, Josef Bacik wrote:
I was trying to reproduce something with fsx and I noticed that no matter
what
seed I set I was getting the same file. Come to find out we are overloading
random
On 1/3/14, 12:10 AM, Qu Wenruo wrote:
Some options should be paired to support triggering different functions
when remounting.
This patchset add these missing pairing mount options.
I think this really would benefit from a regression test which
ensures that every remount transition works
On 11/25/13, 3:45 PM, Chris Mason wrote:
Hi everyone,
I've tagged the current btrfs-progs repo as v3.12. The new idea is that
instead of making the poor distros pull from git, I'll be creating
tagged releases at roughly the same pace as Linus cuts kernels.
Given the volume of btrfs-progs
On 11/19/13, 9:27 PM, Marc MERLIN wrote:
Here is another way in which btrfs-tools crashes if it sees things it
doesn't like.
Is anyone interested in those, or not really?
gandalfthegreat:/tmp# btrfs-find-root /dev/mapper/ssdcrypt
Check tree block failed, want=20971520,
On 11/18/13, 2:26 AM, Anand Jain wrote:
A test case to verify if the given raid option for the
metadata and data are actually created.
Signed-off-by: Anand Jain anand.j...@oracle.com
---
tests/btrfs/023 | 91
+++
tests/btrfs/023.out
On 11/18/13, 8:29 PM, Anand Jain wrote:
A test case to verify if the given raid option for the
metadata and data are actually created.
Signed-off-by: Anand Jain anand.j...@oracle.com
Reviewed-by: Eric Sandeen sand...@redhat.com
---
v2: a copied comment removed as Eric pointed out
If we goto again in cmd_subvol_delete(), and error out to out:
before re-allocating the dupdname and dupvname pointers, we'll
double-free them.
Set them to NULL after freeing to avoid this.
Resolves-Coverity-CID: 1125944
Resolves-Coverity-CID: 1125945
Signed-off-by: Eric Sandeen sand
Use strncpy(... ,PATH_MAX) to be sure we don't overflow
the path[PATH_MAX] array.
Resolves-Coverity-CID: 1125941
Signed-off-by: Eric Sandeen sand...@redhat.com
---
utils.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/utils.c b/utils.c
index a7441c1..c11a7c2 100644
These all apply to the integration branch in Chris's current git tree.
(Which saw the defects rise by from 55 to 65 in the last l6 commits :()
This beats back the defect count again. Compile tested only, FWIW.
Thanks,
-Eric
--
To unsubscribe from this list: send the line unsubscribe
set up.
Signed-off-by: Eric Sandeen sand...@redhat.com
---
cmds-filesystem.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/cmds-filesystem.c b/cmds-filesystem.c
index 0bfd710..e6642ef 100644
--- a/cmds-filesystem.c
+++ b/cmds-filesystem.c
@@ -106,11 +106,12 @@ static
The error return from open is -1, so test that, not 0,
for success/failure.
Resolves-Coverity-CID: 1125931
Signed-off-by: Eric Sandeen sand...@redhat.com
---
cmds-filesystem.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/cmds-filesystem.c b/cmds-filesystem.c
index
Even if it's definitely btrfs at this point,
btrfs_scan_one_device could fail for other reasons.
Check the return value, warn if it fails, and skip
the device register.
Resolves-Coverity-CID: 1125925
Signed-off-by: Eric Sandeen sand...@redhat.com
---
utils.c |9 -
1 files changed, 8
We intentionally fall through these case statements;
just annotate it to be clear.
Resolves-Coverity-CID: 1054887
Signed-off-by: Eric Sandeen sand...@redhat.com
---
utils.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/utils.c b/utils.c
index ecacc29..9aeb5f8
In the nothing to resume case we return directly and leak
several bits of memory; goto out to free them properly.
Resolves-Coverity-CID: 1125934
Resolves-Coverity-CID: 1125935
Resolves-Coverity-CID: 1125936
Signed-off-by: Eric Sandeen sand...@redhat.com
---
cmds-scrub.c |3 ++-
1 files
e0a04278 removed a bunch of dead code but left one little
bit; reinit is always 0, so btrfs_read_block_groups is
never called from here.
Resolves-Coverity-CID: 1125926
Signed-off-by: Eric Sandeen sand...@redhat.com
---
cmds-check.c |3 ---
1 files changed, 0 insertions(+), 3 deletions
get_df returns a negative error number, but then
we pass it to strerror, which wants a positive value...
Resolves-Coverity-CID: 1125929
Signed-off-by: Eric Sandeen sand...@redhat.com
---
cmds-filesystem.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/cmds-filesystem.c
We intentionally fall through these case statements;
just annotate it to be clear.
Resolves-Coverity-CID: 1054884
Signed-off-by: Eric Sandeen sand...@redhat.com
---
cmds-qgroup.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/cmds-qgroup.c b/cmds-qgroup.c
index
If any pwrite failed we leaked the allocated buf on
return from the function. goto out takes care of
those paths.
Resolves-Coverity-CID: 1125938
Signed-off-by: Eric Sandeen sand...@redhat.com
---
utils.c | 62 --
1 files changed, 32
Close fd before we return on error paths.
Resolves-Coverity-CID: 1125939
Signed-off-by: Eric Sandeen sand...@redhat.com
---
utils.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/utils.c b/utils.c
index c11a7c2..c784345 100644
--- a/utils.c
+++ b/utils.c
@@ -1905,10
Resolves-Coverity-CID: 1125924
Signed-off-by: Eric Sandeen sand...@redhat.com
---
cmds-filesystem.c |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/cmds-filesystem.c b/cmds-filesystem.c
index b1291d6..2cb067d 100644
--- a/cmds-filesystem.c
+++ b/cmds-filesystem.c
find_mount_root() tries to test for realpath() failure, but
tests the wrong value. Fix it.
Resolves-Coverity-CID: 1125940
Signed-off-by: Eric Sandeen sand...@redhat.com
---
cmds-send.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/cmds-send.c b/cmds-send.c
index
On 11/6/13, 7:50 PM, Wang Shilong wrote:
On 11/07/2013 09:48 AM, Wang Shilong wrote:
Hi Eric,
On 11/07/2013 07:15 AM, Eric Sandeen wrote:
In the nothing to resume case we return directly and leak
several bits of memory; goto out to free them properly.
Resolves-Coverity-CID: 1125934
On 10/23/13 6:24 AM, Eryu Guan wrote:
btrfs replace on readonly fs should not be allowed.
Regression test case for commit:
bbb651e Btrfs: don't allow the replace procedure on read only filesystems
Signed-off-by: Eryu Guan eg...@redhat.com
Could you speed this up by just truncating the
On 10/23/13 12:05 PM, Stefan Behrens wrote:
On Thu, 24 Oct 2013 00:44:43 +0800, Eryu Guan wrote:
btrfs replace on readonly fs should not be allowed.
Regression test case for commit:
bbb651e Btrfs: don't allow the replace procedure on read only filesystems
Signed-off-by: Eryu Guan
On 10/23/13 11:44 AM, Eryu Guan wrote:
btrfs replace on readonly fs should not be allowed.
Regression test case for commit:
bbb651e Btrfs: don't allow the replace procedure on read only filesystems
Signed-off-by: Eryu Guan eg...@redhat.com
Reviewed-by: Eric Sandeen sand...@redhat.com
On 10/18/13 1:26 PM, Josef Bacik wrote:
There was a problem with send trying to overwrite a file that wasn't actually
the same. This is a test to check this particular case where receive fails
when
it should succeed properly. I tested this to verify it fails without my fix
and
passes
On 10/18/13 1:26 PM, Josef Bacik wrote:
I've been periodically failing btrfs/003 because my box sometimes takes a
little
longer to unregister the device when we remove it and so the output from btrfs
dev show doesn't match what we are wanting since it still sees the device. To
fix this just
On 10/21/13 10:09 AM, Josef Bacik wrote:
On Mon, Oct 21, 2013 at 10:03:10AM -0500, Eric Sandeen wrote:
On 10/18/13 1:26 PM, Josef Bacik wrote:
There was a problem with send trying to overwrite a file that wasn't
actually
the same. This is a test to check this particular case where
On 10/21/13 10:14 AM, Eric Sandeen wrote:
On 10/21/13 10:09 AM, Josef Bacik wrote:
On Mon, Oct 21, 2013 at 10:03:10AM -0500, Eric Sandeen wrote:
On 10/18/13 1:26 PM, Josef Bacik wrote:
There was a problem with send trying to overwrite a file that wasn't
actually
the same. This is a test
. This test properly fails with my old patch and passes with my
good
patch. Thanks,
Signed-off-by: Josef Bacik jba...@fusionio.com
Reviewed-by: Eric Sandeen sand...@redhat.com
---
tests/btrfs/016 | 100
tests/btrfs/016.out | 2
jba...@fusionio.com
Doubles the test time on xfs, but from 16s to 30s on a single spindle sata
disk; I think we can handle it.
ext4 fails w/ or w/o the patch, so *shrug*
Reviewed-by: Eric Sandeen sand...@redhat.com
---
tests/generic/274 | 2 +-
1 file changed, 1 insertion(+), 1 deletion
On 10/18/13 1:26 PM, Josef Bacik wrote:
Btrfs had some issues with fsync()'ing directories and fsync()'ing after
renames. These three new tests cover the 3 different issues we were seeing.
Thanks,
Signed-off-by: Josef Bacik jba...@fusionio.com
I'd prefer that you copy 311 to a new test w/
with my fix. Thanks,
Signed-off-by: Josef Bacik jba...@fusionio.com
Reviewed-by: Eric Sandeen sand...@redhat.com
---
V1-V2: use the directory itself instead of cd'ing around
tests/btrfs/015 | 105
tests/btrfs/015.out | 2
On 10/21/13 11:05 AM, Josef Bacik wrote:
I noticed this test was hanging because mkfs.ext4 wanted to make sure it was
ok
to mkfs an entire device. We need -F so it doesn't ask this question.
Thanks,
Signed-off-by: Josef Bacik jba...@fusionio.com
Reviewed-by: Eric Sandeen sand
the device we're adding to make sure the device add will pass no matter which
version of btrfs-progs you have. Thanks,
Signed-off-by: Josef Bacik jba...@fusionio.com
Reviewed-by: Eric Sandeen sand...@redhat.com
---
common/config | 1 +
tests/btrfs/003 | 4
2 files changed, 5 insertions
On 10/16/13 11:11 AM, Filipe David Manana wrote:
On Wed, Oct 16, 2013 at 5:09 PM, Eric Sandeen sand...@sandeen.net wrote:
On 10/16/13 10:52 AM, Filipe David Borba Manana wrote:
This test is motivated by an issue found by a btrfs user, addressed
and described by the following GNU/Linux kernel
!
Reviewed-by: Eric Sandeen sand...@redhat.com
$ mkfs.btrfs -f /dev/loop0
$ mount /dev/loop0 /mnt
$ mkdir /mnt/acl
$ setfacl -d --set u::rwx,g::rwx,o::- /mnt/acl
$ getfacl /mnt/acl
user::rwx
group::rwx
other::r-x
default:user::rwx
default:group::rwx
default:other::---
$ mkdir /mnt/acl
On 10/10/13 6:39 AM, Duncan wrote:
Mike Audia posted on Thu, 10 Oct 2013 06:20:42 -0400 as excerpted:
I think I found a bug affecting btrfs filesystems and users invoking
fstrim to discard unused blocks: if I execute a `fstrim -v /` twice, the
amount trimmed does not change on the 2nd
On 10/11/13 10:14 AM, Emil Karlson wrote:
If the filesystem is clever enough to know that the range in question has
not been written to since the last discard, then it takes no action, and
reports zero bytes.
File system images can be rewritten on a new media so there is a
drawback to that.
that happened.
Reviewed-by: Eric Sandeen sand...@redhat.com
---
send-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/send-test.c b/send-test.c
index 3775f5f..a37b7fd 100644
--- a/send-test.c
+++ b/send-test.c
@@ -354,7 +354,7 @@ static void *process_thread(void
On 9/25/13 8:00 AM, vgrvelu wrote:
Hi
after doing mofprobe btrfs I could see btrfs entry in proc file
system. But still mount command is failing. It looks like super block
is corrupted
Seems doubtful if you *just* ran mkfs.btrfs.
Can you paste the exact commands you issued, from mkfs to
On 9/24/13 8:02 AM, Ross Kirk wrote:
Internally, btrfs_header_fsid() calculates an unsigned long, but casts
it to a pointer, while all callers cast it to unsigned long again.
Thanks for doing this; my only nitpick is to keep
the lines under 80 cols.
Committed to btrfs as
On 9/24/13 4:07 AM, Ross Kirk wrote:
Remove unused parameter, 'eb'. Unused since introduction in
5f39d397dfbe140a14edecd4e73c34ce23c4f9ee
Updated to be rebased against current upstream.
This doesn't apply...
- write_extent_buffer(cow, root-fs_info-fsid, btrfs_(cow),
+
-by: Eric Sandeen sand...@redhat.com
Signed-off-by: Ross Kirk ross.k...@gmail.com
---
fs/btrfs/ctree.c | 10 +-
fs/btrfs/ctree.h |2 +-
fs/btrfs/disk-io.c |6 +++---
fs/btrfs/ioctl.c |2 +-
4 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/fs/btrfs
On 9/24/13 6:39 PM, vgrvelu wrote:
hi
I created btrfs file system on one of sda partition. when I mount
with mount -t /dev/sda17 /btrfs,
# mount -t /dev/sda17 /btrfs?
That doesn't work. Maybe you meant :
# mount -t btrfs /dev/sda17 /btrfs ?
it is failing with wrong fs type bad
get this from blkid, but maybe not.
In the meantime it does do the right thing, so:
Reviewed-by: Eric Sandeen sand...@redhat.com
Signed-off-by: David Sterba dste...@suse.cz
---
utils.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/utils.c b/utils.c
On 9/23/13 10:44 AM, David Sterba wrote:
On Mon, Sep 23, 2013 at 10:08:08AM -0500, Eric Sandeen wrote:
On 9/20/13 11:42 AM, David Sterba wrote:
The message about trim was printed unconditionally, we should check if
trim is supported at all.
Good idea, but I wonder if there's any risk
() which does take a
struct extent_buffer as the first arg.
But on technical terms anyway,
Reviewed-by: Eric Sandeen sand...@redhat.com
Thanks,
-Eric
---
btrfs-calc-size.c |2 +-
btrfs-image.c |6 +++---
cmds-restore.c|2 +-
ctree.c | 30
On 9/20/13 8:27 AM, Ross Kirk wrote:
Remove unused parameter, 'eb'. Unused since introduction in
5f39d397dfbe140a14edecd4e73c34ce23c4f9ee
Signed-off-by: Ross Kirk ross.k...@gmail.com
A few points; was this against latest upstream?
Upstream, fba6aa75654394fccf2530041e9451414c28084f removed
and introduces a filter for the older style output.
[dchinner: modified to use a global filter in check rather than
per-test filters]
Signed-off-by: Tomas Racek tra...@redhat.com
Signed-off-by: Dave Chinner dchin...@redhat.com
Reviewed-by: Eric Sandeen sand...@redhat.com
---
(Resending as proper top
On 9/19/13 11:54 AM, Ilya Dryomov wrote:
...
diff --git a/check b/check
index 4085eae..ba7fd21 100755
--- a/check
+++ b/check
@@ -478,6 +478,10 @@ do
echo - no qualified output
err=true
else
+
+ # coreutils 2.16+ changed quote
On 9/17/13 8:11 PM, rongqing...@windriver.com wrote:
From: Roy Li rongqing...@windriver.com
The dependencies of all: version.h or other similar ones can not
fix the parallel build failure, only reduce the times; In fact,
many *.o files require version.h file.
#grep '#include
Change the suffix rule to ensure that version.h is
built before we try to create any .o file.
Reported-by: Roy Li rongqing...@windriver.com
Signed-off-by: Eric Sandeen sand...@redhat.com
---
I dunno, does this work? My gnu make is rusty.
diff --git a/Makefile b/Makefile
index 3d715d8..d25054f
On 9/17/13 8:56 PM, Eric Sandeen wrote:
Change the suffix rule to ensure that version.h is
built before we try to create any .o file.
Reported-by: Roy Li rongqing...@windriver.com
Signed-off-by: Eric Sandeen sand...@redhat.com
---
I dunno, does this work? My gnu make is rusty.
I'm
On 9/9/13 12:13 PM, Josef Bacik wrote:
On Mon, Sep 09, 2013 at 06:32:04PM +0200, David Sterba wrote:
On Fri, Sep 06, 2013 at 02:50:56PM -0400, Josef Bacik wrote:
We need to start adding some sanity tests to btrfs-progs to make sure we
aren't
breaking things with our patches. The most
On 9/5/13 9:43 AM, Тимофей Титовец wrote:
Hello guys, i try to convert ext4 volume, but btrfs-convert show me error:
No valid Btrfs found on file
unable to open ctree
conversion aborted.
Ubuntu 13.04
Kernel: 3.11
btrfs-progs git version 0.20-git20130822~194aa4a13
way to reproduce error:
.
-Eric
Thanks,
Wang
From:
Just whitespace fixes, and magical return value removal.
Signed-off-by: Eric Sandeen sand...@redhat.com
---
cmds-subvolume.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/cmds-subvolume.c b/cmds-subvolume.c
index 01b982c
On 9/2/13 9:45 AM, David Sterba wrote:
On Tue, Jun 11, 2013 at 07:38:03PM -0500, Eric Sandeen wrote:
Move btrfs cmd files to cmd/ subdir
Are you ok with naming the subdirectory 'cmds'?
david
yep! That's the _last_ bike shed I want to paint. ;)
I had picked cmd because
On 9/2/13 9:43 AM, David Sterba wrote:
On Tue, Jun 11, 2013 at 06:15:18PM -0500, Eric Sandeen wrote:
Move test tools to tests/
rename btrfs-corrupt-block.c = tests/btrfs-corrupt-block.c (100%)
IMO this is not a test by itself, so it should stay in the toplevel dir.
Hum, well, it has
MOn Sep 3, 2013, at 8:22 PM, Wang Shilong wangsl.f...@cn.fujitsu.com wrote:
On 09/03/2013 11:50 PM, Eric Sandeen wrote:
On 9/3/13 8:13 AM, Wang Shilong wrote:
Hello Eric,
Recently, i notice btrfs-progs's magic return value. For example, EACCESS
return 12.
Magic return value is confusing
On 8/29/13 3:19 PM, Chris Murphy wrote:
On Aug 29, 2013, at 1:53 PM, Hugo Mills h...@carfax.org.uk wrote:
On Thu, Aug 29, 2013 at 01:44:54PM -0600, Chris Murphy wrote:
Certainly, if known for sure it won't be more than 30 seconds?
Mmm... it'll depend on the setting of the commit
On 8/28/13 12:01 AM, Hidetoshi Seto wrote:
(2013/08/26 23:23), Eric Sandeen wrote:
Thanks for looking into this - how small of a device did you test?
I tried a 2MB device w/ these 2 patches and still got:
[btrfs-progs]# truncate --size=2m testfile
[btrfs-progs]# ./mkfs.btrfs testfile
On 8/29/13 8:21 AM, David Sterba wrote:
On Tue, Aug 13, 2013 at 02:38:05PM -0500, Eric Sandeen wrote:
+. ./common/rc
+. ./common/filter
+
+# real QA test starts here
+_supported_fs btrfs
+_supported_os Linux
+_require_scratch
+
+_scratch_mkfs /dev/null 21
+_scratch_mount
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 8/27/13 4:07 PM, Jeff Mahoney wrote:
On 8/27/13 4:56 PM, Josef Bacik wrote:
On Tue, Aug 27, 2013 at 03:28:24PM -0400, Jeff Mahoney wrote:
On 8/26/13 4:56 PM, Josef Bacik wrote:
One of the complaints we get a lot is how many BUG_ON()'s we have.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 8/27/13 4:25 PM, Jeff Mahoney wrote:
On 8/27/13 5:21 PM, Eric Sandeen wrote:
On 8/27/13 4:07 PM, Jeff Mahoney wrote:
On 8/27/13 4:56 PM, Josef Bacik wrote:
On Tue, Aug 27, 2013 at 03:28:24PM -0400, Jeff Mahoney wrote:
On 8/26/13 4:56 PM, Josef
On 8/26/13 12:38 AM, chandan wrote:
On Sunday, August 25, 2013 11:54:30 AM Eric Sandeen wrote:
Can you explain why this is necessary?
What failures do you see, on what filesystems?
generic/255 currently fails on Btrfs on a ppc64 machine with 64k page size and
hence 64k block size
things which are logic assertions vs. things which are just punts
in more common error-handling paths.
Acked-by: Eric Sandeen sand...@redhat.com
Thanks,
-Eric
---
fs/btrfs/Kconfig |9 +
fs/btrfs/ctree.h | 16
2 files changed, 25 insertions(+), 0 deletions
On 8/21/13 11:03 AM, Josef Bacik wrote:
I've been periodically failing btrfs/003 because my box sometimes takes a
little
longer to unregister the device when we remove it and so the output from btrfs
dev show doesn't match what we are wanting since it still sees the device. To
fix this just
On 8/20/13 4:14 AM, Stefan Behrens wrote:
On Mon, 19 Aug 2013 16:53:17 -0400, Josef Bacik wrote:
There was a problem with send trying to overwrite a file that wasn't actually
the same. This is a test to check this particular case where receive fails
when
it should succeed properly. I
On 8/20/13 6:20 AM, Geert Uytterhoeven wrote:
u64 is unsigned long long on all architectures now, so there's no need to
cast it when formatting it using the ll length modifier.
Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org
---
fs/btrfs/backref.c | 24 ++--
On 8/17/13 10:25 PM, Tom Gundersen wrote:
On Sat, Aug 17, 2013 at 7:59 PM, Chris Mason chris.ma...@fusionio.com wrote:
The problem with the progs release is I keep finding more things I want
to add. My local git tree has about a dozen commits that I feel are
important enough for v1.0. I just
On 8/16/13 9:51 AM, Stefan Behrens wrote:
This test failed for me with output from 'btrfs balance':
QA output created by 003
+Done, had to relocate 4 out of 4 chunks
+Done, had to relocate 5 out of 5 chunks
Silence is golden
Signed-off-by: Stefan Behrens
...@giantdisaster.de
---
V1 - V2:
Redirect errors to $seqres.full as proposed by Eric.
Thanks!
Reviewed-by: Eric Sandeen sand...@redhat.com
tests/btrfs/003 | 28 +++-
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/tests/btrfs/003 b/tests/btrfs/003
index
-by: Eric Sandeen sand...@redhat.com
# Convert string read from stdin like 128K to bytes and print it to stdout
diff --git a/common/filter.btrfs b/common/filter.btrfs
index e9a2bc2..1584596 100644
--- a/common/filter.btrfs
+++ b/common/filter.btrfs
@@ -33,6 +33,7
On 8/16/13 12:44 PM, Stefan Behrens wrote:
Signed-off-by: Stefan Behrens sbehr...@giantdisaster.de
Reviewed-by: Eric Sandeen sand...@redhat.com
---
tests/btrfs/009 | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/btrfs/009 b/tests/btrfs/009
index d46744c..08aa508 100755
and abstract out the subvolid logic as per Eric's
suggestions
V1-V2: address the comments made by Eric Sandeen.
Thank you, sir. :)
Reviewed-by: Eric Sandeen sand...@redhat.com
common/rc |8 ++
tests/btrfs/003 | 63
On 8/13/13 10:28 AM, Josef Bacik wrote:
On Sun, Aug 11, 2013 at 09:54:41PM -0500, Eric Sandeen wrote:
On Aug 11, 2013, at 8:15 PM, Dave Chinner da...@fromorbit.com wrote:
On Thu, Aug 08, 2013 at 12:40:55PM -0500, Eric Sandeen wrote:
On 8/8/13 3:17 AM, Jan Schmidt wrote:
SUBDIRS =
LLDLIBS
On 8/13/13 12:24 PM, Jan Schmidt wrote:
These two patches add the announced tests for btrfs send / receive. As
requested, the fssum tool is now included.
Thanks for the updates.
Both:
Reviewed-by: Eric Sandeen sand...@redhat.com
--
v1-v2:
- included fssum
- test number is now 316
the comments made by Eric Sandeen.
tests/btrfs/003 | 66
+++
tests/btrfs/003.out |2 +
tests/btrfs/group |1 +
3 files changed, 69 insertions(+), 0 deletions(-)
create mode 100755 tests/btrfs/003
create mode 100644 tests/btrfs/003
numbers are based off of a different counter. Thanks,
The problem itself isn't totally clear to me, but the test itself looks
fine. ;)
Signed-off-by: Josef Bacik jba...@fusionio.com
Reviewed-by: Eric Sandeen sand...@redhat.com
---
tests/btrfs/002 | 85
On 8/12/13 2:40 PM, Josef Bacik wrote:
We were allowing users to delete their default subvolume, which is
problematic.
This test is a regression test to make sure we don't let that happen in the
future. Thanks,
Signed-off-by: Josef Bacik jba...@fusionio.com
---
tests/btrfs/003 |
On Aug 11, 2013, at 8:15 PM, Dave Chinner da...@fromorbit.com wrote:
On Thu, Aug 08, 2013 at 12:40:55PM -0500, Eric Sandeen wrote:
On 8/8/13 3:17 AM, Jan Schmidt wrote:
SUBDIRS =
LLDLIBS = $(LIBATTR) $(LIBHANDLE) $(LIBACL)
+OPT_LDLIBS = -lssl -lcrypto
Hm, new deps. I guess it's
On 8/9/13 9:04 PM, anand jain wrote:
btrfs fi show
Label: none uuid: e7aae9f0-1aa8-41f5-8fb6-d4d8f80cdb2c
Total devices 1 FS bytes used 28.00KiB
devid2 size 2.00GiB used 0.00 path /dev/sdc -- WRONG
devid1 size 2.00GiB used 20.00MiB path /dev/sdb
Ok,
Mark many functions as static, and remove any resulting dead code.
Signed-off-by: Eric Sandeen sand...@redhat.com
---
V2: Keep the special subvol_uuid_search_add()-which-only-frees-pointers
because I'm picking my battles :)
btrfs-convert.c |8
btrfs-find-root.c |2
On 8/9/13 5:48 PM, David Sterba wrote:
On Fri, Aug 09, 2013 at 03:20:47PM -0500, Eric Sandeen wrote:
Mark many functions as static, and remove any resulting dead code.
Thanks.
-struct btrfs_root *link_subvol(struct btrfs_root *root, const char *base,
- u64
On 8/8/13 3:17 AM, Jan Schmidt wrote:
These two patches add the announced tests for btrfs send / receive. As
requested, the fssum tool is now included.
One drawback is that I'm unable to edit configure.ac or whatever needs
to be modified in an autotools preferred way. Any hints appreciated,
On 8/8/13 3:17 AM, Jan Schmidt wrote:
fssum is a tool to build a recursive checksum for a file system. The home
repository of fssum is
git://git.kernel.org/pub/scm/linux/kernel/git/arne/far-progs.git
It is added as an optional target, because it depends on glibc = 2.15 for
SEEK_HOLE /
On 8/8/13 3:17 AM, Jan Schmidt wrote:
Basic send / receive functionality test for btrfs. Requires current
version of fsstress built (-x support). Relies on fssum tool but can
skip the test if it failed to build.
Signed-off-by: Jan Schmidt list@jan-o-sch.net
Reviewed-by: Josef Bacik
On 8/7/13 2:54 AM, Stefan Behrens wrote:
On Tue, 06 Aug 2013 22:49:32 -0500, Eric Sandeen wrote:
On 8/6/13 8:05 PM, Eric Sandeen wrote:
Mark many functions as static, and remove any resulting dead code.
Signed-off-by: Eric Sandeen sand...@redhat.com
---
...
Actually, what the heck
On 8/7/13 4:43 PM, Sergei Trofimovich wrote:
...
Meet uselex.rb: one-file script to parse 'nm' output:
https://github.com/trofi/uselex/blob/master/uselex.rb
Nice to meet you! I think I've met your close relative,
ftp://ftp.samba.org/pub/unpacked/junkcode/findstatic.pl :)
On 8/6/13 1:27 PM, Filipe David Borba Manana wrote:
This change allows for most mount options to be persisted in
the filesystem, and be applied when the filesystem is mounted.
If the same options are specified at mount time, the persisted
values for those options are ignored.
The only
201 - 300 of 574 matches
Mail list logo
