Re: [PATCH] generic: test Btrfs delalloc accounting overflow

2017-06-06 Thread Omar Sandoval
On Wed, Jun 07, 2017 at 11:08:01AM +0800, Eryu Guan wrote: > On Tue, Jun 06, 2017 at 05:03:05PM -0700, Omar Sandoval wrote: > > On Sat, Jun 03, 2017 at 12:37:00AM -0700, Christoph Hellwig wrote: > > > This looks like a btrfs-specific test, and not like a generic one > > > to me. > > > > Nothing

Re: [PATCH] generic: test Btrfs delalloc accounting overflow

2017-06-06 Thread Eryu Guan
On Tue, Jun 06, 2017 at 05:03:05PM -0700, Omar Sandoval wrote: > On Sat, Jun 03, 2017 at 12:37:00AM -0700, Christoph Hellwig wrote: > > This looks like a btrfs-specific test, and not like a generic one > > to me. > > Nothing about the workload itself is btrfs-specific, we just have the > extra

Re: [PATCH] generic: test Btrfs delalloc accounting overflow

2017-06-06 Thread Omar Sandoval
On Sat, Jun 03, 2017 at 12:37:00AM -0700, Christoph Hellwig wrote: > This looks like a btrfs-specific test, and not like a generic one > to me. Nothing about the workload itself is btrfs-specific, we just have the extra check at the end. But I don't really care, I can make it a btrfs test unless

Re: [PATCH] generic: test Btrfs delalloc accounting overflow

2017-06-03 Thread Christoph Hellwig
This looks like a btrfs-specific test, and not like a generic one to me. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] generic: test Btrfs delalloc accounting overflow

2017-06-03 Thread Eryu Guan
On Fri, Jun 02, 2017 at 02:46:52PM +0200, David Sterba wrote: > On Fri, Jun 02, 2017 at 12:07:37PM +0300, Nikolay Borisov wrote: > > > +# Make sure that we didn't leak any metadata space. > > > +if [[ $FSTYP = btrfs ]]; then > > > + uuid="$(findmnt -n -o UUID "$TEST_DIR")" > > > > if we are on

Re: [PATCH] generic: test Btrfs delalloc accounting overflow

2017-06-02 Thread David Sterba
On Fri, Jun 02, 2017 at 12:07:37PM +0300, Nikolay Borisov wrote: > > +# Make sure that we didn't leak any metadata space. > > +if [[ $FSTYP = btrfs ]]; then > > + uuid="$(findmnt -n -o UUID "$TEST_DIR")" > > if we are on btrfs and we don't have findmnt this test will likely fail. > Perhaps

Re: [PATCH] generic: test Btrfs delalloc accounting overflow

2017-06-02 Thread Nikolay Borisov
On 2.06.2017 11:23, Omar Sandoval wrote: > From: Omar Sandoval > > This is a regression test for "[PATCH] Btrfs: fix delalloc accounting > leak caused by u32 overflow". It creates a bunch of delalloc extents and > merges them together to make sure the accounting is done right.

[PATCH] generic: test Btrfs delalloc accounting overflow

2017-06-02 Thread Omar Sandoval
From: Omar Sandoval This is a regression test for "[PATCH] Btrfs: fix delalloc accounting leak caused by u32 overflow". It creates a bunch of delalloc extents and merges them together to make sure the accounting is done right. Signed-off-by: Omar Sandoval ---