Re: [PATCH 1/7] BTRFS: Fix lseek return value for error

2011-09-19 Thread Chris Mason
Excerpts from Andi Kleen's message of 2011-09-19 15:59:52 -0400: > On Mon, Sep 19, 2011 at 03:30:02PM -0400, Chris Mason wrote: > > Excerpts from Andi Kleen's message of 2011-09-19 13:52:03 -0400: > > > > Thanks everyone, I've put Jeff's last version of this in my queue. > > > > > > Can you post t

Re: [PATCH 1/7] BTRFS: Fix lseek return value for error

2011-09-19 Thread Andi Kleen
On Mon, Sep 19, 2011 at 03:30:02PM -0400, Chris Mason wrote: > Excerpts from Andi Kleen's message of 2011-09-19 13:52:03 -0400: > > > Thanks everyone, I've put Jeff's last version of this in my queue. > > > > Can you post the version you merged? The previous ones all had issues. > > https://githu

Re: [PATCH 1/7] BTRFS: Fix lseek return value for error

2011-09-19 Thread Chris Mason
Excerpts from Andi Kleen's message of 2011-09-19 13:52:03 -0400: > > Thanks everyone, I've put Jeff's last version of this in my queue. > > Can you post the version you merged? The previous ones all had issues. https://github.com/chrismason/linux/commit/48802c8ae2a9d618ec734a61283d645ad527e06c T

Re: [PATCH 1/7] BTRFS: Fix lseek return value for error

2011-09-19 Thread Andi Kleen
> Thanks everyone, I've put Jeff's last version of this in my queue. Can you post the version you merged? The previous ones all had issues. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 1/7] BTRFS: Fix lseek return value for error

2011-09-18 Thread Chris Mason
Excerpts from Jeff liu's message of 2011-09-18 06:33:38 -0400: > > 在 2011-9-18,下午4:42, Marco Stornelli 写道: > > > Il 18/09/2011 09:29, Jeff Liu ha scritto: > >> Hi Andreas and Andi, > >> > >> Thanks for your comments. > >> > >> On 09/18/2011 09:46 AM, Andi Kleen wrote: > >> > > with an addi

Re: [PATCH 1/7] BTRFS: Fix lseek return value for error

2011-09-18 Thread Jeff liu
在 2011-9-18,下午4:42, Marco Stornelli 写道: > Il 18/09/2011 09:29, Jeff Liu ha scritto: >> Hi Andreas and Andi, >> >> Thanks for your comments. >> >> On 09/18/2011 09:46 AM, Andi Kleen wrote: >> > with an additional improvement if the offset is larger or equal to the > file size, return -E

Re: [PATCH 1/7] BTRFS: Fix lseek return value for error

2011-09-18 Thread Marco Stornelli
Il 18/09/2011 09:29, Jeff Liu ha scritto: Hi Andreas and Andi, Thanks for your comments. On 09/18/2011 09:46 AM, Andi Kleen wrote: with an additional improvement if the offset is larger or equal to the file size, return -ENXIO in directly: if (offset>= inode->i_size) {

Re: [PATCH 1/7] BTRFS: Fix lseek return value for error

2011-09-18 Thread Jeff Liu
Hi Andreas and Andi, Thanks for your comments. On 09/18/2011 09:46 AM, Andi Kleen wrote: >>> with an additional improvement if the offset is larger or equal to the >>> file size, return -ENXIO in directly: >>> >>>if (offset >= inode->i_size) { >>>mutex_unl

Re: [PATCH 1/7] BTRFS: Fix lseek return value for error

2011-09-17 Thread Andi Kleen
> > with an additional improvement if the offset is larger or equal to the > > file size, return -ENXIO in directly: > > > >if (offset >= inode->i_size) { > >mutex_unlock(&inode->i_mutex); > >return -ENXIO; > >} > > E

Re: [PATCH 1/7] BTRFS: Fix lseek return value for error

2011-09-17 Thread Andreas Dilger
On 2011-09-17, at 12:10 AM, Jeff Liu wrote: > I once posted a similar patch for this issue which can be found at: > http://www.spinics.net/lists/linux-btrfs/msg12169.html > > with an additional improvement if the offset is larger or equal to the > file size, return -ENXIO in directly: > >

Re: [PATCH 1/7] BTRFS: Fix lseek return value for error

2011-09-16 Thread Jeff Liu
I once posted a similar patch for this issue which can be found at: http://www.spinics.net/lists/linux-btrfs/msg12169.html with an additional improvement if the offset is larger or equal to the file size, return -ENXIO in directly: if (offset >= inode->i_size) { mutex_unlo

Re: [PATCH 1/7] BTRFS: Fix lseek return value for error

2011-09-16 Thread Andi Kleen
On Fri, Sep 16, 2011 at 11:48:15AM -0400, Christoph Hellwig wrote: > On Thu, Sep 15, 2011 at 04:06:47PM -0700, Andi Kleen wrote: > > From: Andi Kleen > > > > Introduced by 9a4327ca1f45f82edad7dc0a4e52ce9316e0950c > > I think this should go to Chris/Linus ASAP. But a slightly better > patch desc

Re: [PATCH 1/7] BTRFS: Fix lseek return value for error

2011-09-16 Thread Christoph Hellwig
On Thu, Sep 15, 2011 at 04:06:47PM -0700, Andi Kleen wrote: > From: Andi Kleen > > Introduced by 9a4327ca1f45f82edad7dc0a4e52ce9316e0950c I think this should go to Chris/Linus ASAP. But a slightly better patch description wouldn't hurt either. Also any reason you captialize BTRFS? > > Signed