RE: [PATCH] Btrfs: fix subvolume mount by name problem when default mount subvolume is set

2011-04-06 Thread Zhong, Xin
-Original Message- From: Chris Mason [mailto:chris.ma...@oracle.com] Sent: Tuesday, April 05, 2011 1:07 PM To: Zhong, Xin Cc: linux-btrfs Subject: Re: [PATCH] Btrfs: fix subvolume mount by name problem when default mount subvolume is set Excerpts from Zhong, Xin's message of

[PATCH V2] Btrfs: fix subvolume mount by name problem when default mount subvolume is set

2011-04-06 Thread Zhong, Xin
We create two subvolumes (meego_root and meego_home) in btrfs root directory. And set meego_root as default mount subvolume. After we remount btrfs, meego_root is mounted to top directory by default. Then when we try to mount meego_home (subvol=meego_home) to a subdirectory, it failed. The problem

Re: [PATCH V2] Btrfs: fix subvolume mount by name problem when default mount subvolume is set

2011-04-06 Thread Li Zefan
13:27, Zhong, Xin wrote: We create two subvolumes (meego_root and meego_home) in btrfs root directory. And set meego_root as default mount subvolume. After we remount btrfs, meego_root is mounted to top directory by default. Then when we try to mount meego_home (subvol=meego_home) to a

Re: cloning single-device btrfs file system onto multi-device one

2011-04-06 Thread Helmut Hullen
Hallo, Evert, Du meintest am 05.04.11: I then did a btrfs fi balance again and let it run through. However here is what I get: $ df -h /mnt Filesystem            Size  Used Avail Use% Mounted on /dev/sdb              8.2T  3.5T  3.2T  53% /mnt Only 3.2T left. How would I reclaim the

Re: cloning single-device btrfs file system onto multi-device one

2011-04-06 Thread Helmut Hullen
Hallo, Stephane, Du meintest am 28.03.11: I then did a btrfs fi balance again and let it run through. However here is what I get: $ df -h /mnt FilesystemSize Used Avail Use% Mounted on /dev/sdb 8.2T 3.5T 3.2T 53% /mnt Only 3.2T left. How would I reclaim the

Re: [PATCH] Btrfs: don't kzalloc the ordered extents

2011-04-06 Thread Arne Jansen
On 06.04.2011 01:20, Josef Bacik wrote: We initialize almost all of the fields when we allocate an ordered extent, so use kmalloc instead of kzalloc and just initialize the other fields that we don't already initialize yet. Thanks, Is it really worth it? we have seen a few bugs in the past

[PATCH V2] Btrfs: fix subvolume mount by name problem when default mount subvolume is set

2011-04-06 Thread Zhong, Xin
We create two subvolumes (meego_root and meego_home) in btrfs root directory. And set meego_root as default mount subvolume. After we remount btrfs, meego_root is mounted to top directory by default. Then when we try to mount meego_home (subvol=meego_home) to a subdirectory, it failed. The problem

RE: [PATCH V2] Btrfs: fix subvolume mount by name problem when default mount subvolume is set

2011-04-06 Thread Zhong, Xin
-Original Message- From: linux-btrfs-ow...@vger.kernel.org [mailto:linux-btrfs- ow...@vger.kernel.org] On Behalf Of Li Zefan Sent: Wednesday, April 06, 2011 2:34 PM To: Zhong, Xin Cc: linux-btrfs@vger.kernel.org Subject: Re: [PATCH V2] Btrfs: fix subvolume mount by name problem when

Re: cloning single-device btrfs file system onto multi-device one

2011-04-06 Thread Arne Jansen
On 28.03.2011 15:17, Stephane Chazelas wrote: I then did a btrfs fi balance again and let it run through. However here is what I get: $ df -h /mnt FilesystemSize Used Avail Use% Mounted on /dev/sdb 8.2T 3.5T 3.2T 53% /mnt Only 3.2T left. How would I reclaim

[PATCH V3] Btrfs: fix subvolume mount by name problem when default mount subvolume is set

2011-04-06 Thread Zhong, Xin
We create two subvolumes (meego_root and meego_home) in btrfs root directory. And set meego_root as default mount subvolume. After we remount btrfs, meego_root is mounted to top directory by default. Then when we try to mount meego_home (subvol=meego_home) to a subdirectory, it failed. The problem

Re: [PATCH V3] Btrfs: fix subvolume mount by name problem when default mount subvolume is set

2011-04-06 Thread Andreas Philipp
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Just a (probably) short question. This means, one now can mount any subvolume which lies directly in another subvolume by name, as long as one passes the correct subvolrootid=X mount option? Thanks, Andreas Philipp On 06.04.2011 09:33, Zhong, Xin

RE: [PATCH V3] Btrfs: fix subvolume mount by name problem when default mount subvolume is set

2011-04-06 Thread Zhong, Xin
-Original Message- From: Andreas Philipp [mailto:philipp.andr...@gmail.com] Sent: Wednesday, April 06, 2011 4:39 PM To: Zhong, Xin Cc: linux-btrfs@vger.kernel.org; Andreas Philipp Subject: Re: [PATCH V3] Btrfs: fix subvolume mount by name problem when default mount subvolume is set

[PATCH] Trace: add __print_symbolic_u64 to avoid warnings on 32bit machine

2011-04-06 Thread liubo
Btrfs has some ULL macros, and when these macros are passed to tracepoints' __print_symbolic(), there will be 64-32 truncate WARNINGS during compiling on 32bit box. Signed-off-by: Liu Bo liubo2...@cn.fujitsu.com --- include/linux/ftrace_event.h | 12 include/trace/events/btrfs.h

[RFC][PATCH] btrfs: using cached extent_state in set/unlock combinations

2011-04-06 Thread Arne Jansen
In several places the sequence (set_extent_uptodate, unlock_extent) is used. This leads to a duplicate lookup of the extent state. This patch lets set_extent_uptodate return a cached extent_state which can be passed to unlock_extent_cached. The occurences of the above sequences are updated to use

[PATCH] Btrfs: fix subvolume fake mount problem when default subvolume is set

2011-04-06 Thread Zhong, Xin
We create two subvolumes (meego_root and meego_home) in btrfs root directory. And set meego_root as default mount subvolume. After we remount btrfs, meego_root is mounted to top directory by default. Then if we create a directory with the same name as meego_home, we can mount meego_home subvolume

Re: [PATCH] Btrfs: don't kzalloc the ordered extents

2011-04-06 Thread Chris Mason
Excerpts from Arne Jansen's message of 2011-04-06 03:54:07 -0400: On 06.04.2011 01:20, Josef Bacik wrote: We initialize almost all of the fields when we allocate an ordered extent, so use kmalloc instead of kzalloc and just initialize the other fields that we don't already initialize

Re: BUG: unable to handle kernel NULL pointer dereference at (null)

2011-04-06 Thread Johannes Hirte
On Tuesday 05 April 2011 23:57:53 Josef Bacik wrote: Now it hit Man I cannot catch a break. I hope this is the last one. Thanks, Josef --- fs/btrfs/free-space-cache.c | 32 1 files changed, 32 insertions(+), 0 deletions(-) diff --git

Re: btrfs balancing start - and stop?

2011-04-06 Thread Stephane Chazelas
2011-04-04 20:07:54 +0100, Stephane Chazelas: [...] 4.7 more days to go. And I reckon it will have written about 9 TB to disk by that time (which is the total size of the volume, though only 3.8TB are occupied). Yes - that's the pessimistic estimation. As Hugo has explained it can

Re: cloning single-device btrfs file system onto multi-device one

2011-04-06 Thread Stephane Chazelas
2011-03-28 14:17:48 +0100, Stephane Chazelas: [...] So here is how I transferred a 6TB btrfs on one 6TB raid5 device (on host src) over the network onto a btrfs on 3 3TB hard drives [...] I then did a btrfs fi balance again and let it run through. However here is what I get: [...] Sorry, it

Re: cloning single-device btrfs file system onto multi-device one

2011-04-06 Thread Arne Jansen
On 06.04.2011 14:05, Stephane Chazelas wrote: 2011-04-06 10:25:00 +0200, Arne Jansen: On 28.03.2011 15:17, Stephane Chazelas wrote: I then did a btrfs fi balance again and let it run through. However here is what I get: $ df -h /mnt FilesystemSize Used Avail Use% Mounted on

Re: [PATCH] Btrfs: don't kzalloc the ordered extents

2011-04-06 Thread Josef Bacik
On 04/06/2011 07:06 AM, Chris Mason wrote: Excerpts from Arne Jansen's message of 2011-04-06 03:54:07 -0400: On 06.04.2011 01:20, Josef Bacik wrote: We initialize almost all of the fields when we allocate an ordered extent, so use kmalloc instead of kzalloc and just initialize the other fields

Re: BUG: unable to handle kernel NULL pointer dereference at (null)

2011-04-06 Thread Josef Bacik
On Wed, Apr 06, 2011 at 01:10:38PM +0200, Johannes Hirte wrote: On Tuesday 05 April 2011 23:57:53 Josef Bacik wrote: Now it hit Man I cannot catch a break. I hope this is the last one. Thanks, Ok I give up, I just cleaned it all up and don't mark the pages as dirty unless we're

[PATCH] Btrfs: do not use async submit for small DIO io's

2011-04-06 Thread Josef Bacik
When looking at our DIO performance Chris said that for small IO's doing the async submit stuff tends to be more overhead than it's worth. With this on top of my other fixes I get about a 17-20% speedup doing a sequential dd with 4k IO's. Basically if we don't have to split the bio for the map

[PATCH] Btrfs: reuse the extent_map we found when calling btrfs_get_extent

2011-04-06 Thread Josef Bacik
In btrfs_get_block_direct we call btrfs_get_extent to lookup the extent for the range that we are looking for. If we don't find an extent, btrfs_get_extent will insert a extent_map for that area and mark it as a hole. So it does the job of allocating a new extent map and inserting it into the io

Re: BUG: unable to handle kernel NULL pointer dereference at (null)

2011-04-06 Thread Jordan Patterson
Hi Josef: I tried your latest patch, since I had the same issue from the first email. With the patch applied, I am now hitting the BUG_ON(block_group-total_bitmaps = max_bitmaps); in add_new_bitmap in fs/btrfs/free-space-cache.c:1246 as soon as I mount the filesystem, with or without -o

Re: BUG: unable to handle kernel NULL pointer dereference at (null)

2011-04-06 Thread Johannes Hirte
On Wednesday 06 April 2011 22:47:28 Jordan Patterson wrote: Hi Josef: I tried your latest patch, since I had the same issue from the first email. With the patch applied, I am now hitting the BUG_ON(block_group-total_bitmaps = max_bitmaps); in add_new_bitmap in

2.6.39-rc2 filesystem balance lock ordering...

2011-04-06 Thread Daniel J Blueman
While trying to reproduce an earlier problem on 2.6.39-rc2, we see a possible deadlock from locks being taken in an inconsistent order: === [ INFO: possible circular locking dependency detected ] 2.6.39-rc2-350cd #2

Re: [PATCH] Btrfs: fix subvolume fake mount problem when default subvolume is set

2011-04-06 Thread Goffredo Baroncelli
Hi On 04/06/2011 11:34 AM, Zhong, Xin wrote: We create two subvolumes (meego_root and meego_home) in btrfs root directory. And set meego_root as default mount subvolume. After we remount btrfs, meego_root is mounted to top directory by default. Then if we create a directory with the same name