Re: [RFC] btrfs fi df output [Was Re: BTRF - Storage Usage]

2012-09-28 Thread Goffredo Baroncelli
On 09/28/2012 05:17 AM, Roman Mamedov wrote: On Thu, 27 Sep 2012 23:02:35 +0200 Goffredo Baroncelli wrote: Sorry for the space error: Below a more correct example $ btrfs filesystem disk-free / Summary: Total: 135.00GB Allocated: 10.51GB

[RFC] btrfs fi df output [Was Re: BTRF - Storage Usage]

2012-09-27 Thread Goffredo Baroncelli
On 09/27/2012 12:44 PM, Sébastien Maury wrote: Hi, I've installed a new server using btrfs for my root partition ("/"). It uses snapper for snapshots management and all seems to work pretty fine. My problem is to be able to know the remaining REAL free space in my partition. Using different c

Re: [PATCH v2 2/2] btrfs-progs: Fix up memory leakage

2012-09-26 Thread Goffredo Baroncelli
On 09/25/2012 07:14 PM, Goffredo Baroncelli wrote: I strongly disagree with this approach. The callee often don't know what happen after and before the call. The same is true for the programmer, because the code is quite often updated by several people. A clean exit() is the right thing to

Re: [PATCH v2 2/2] btrfs-progs: Fix up memory leakage

2012-09-25 Thread Goffredo Baroncelli
On 09/25/2012 12:14 PM, David Sterba wrote: On Tue, Sep 25, 2012 at 10:02:16AM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu Some code pathes forget to free memory on exit. Same as with the fd's, kernel will free all memory for us at exit(). I strongly disagree with this approach.

R: Re: [PATCH 2/2] Btrfs-progs: add mount-option command

2012-09-18 Thread Goffredo Baroncelli
>Da: r...@romanrm.ru >Data: 18/09/2012 6.19 >A: >Cc: "Hidetoshi Seto", >Ogg: Re: [PATCH 2/2] Btrfs-progs: add mount-option command > >On Tue, 18 Sep 2012 10:31:41 +0800 >Miao Xie wrote: > >> On tue, 18 Sep 2012 10:30:17 +0900, Hidetoshi Seto wrote: >> > This patch adds mount-option command. >>

R: [PATCH 2/2] Btrfs-progs: add mount-option command

2012-09-18 Thread Goffredo Baroncelli
Hi Seto, please could you update also the man page too ? Why it was not provided a way to clear a *single* flag ? To me it seems a bit too long to clear all the flag (btrfs mount-option clear) and then set the right one. As user interface I suggest something like chmod: btrfs mount-option

[RESPOST][BTRFS-PROGS][PATCH] btrfs_read_dev_super(): uninitialized variable

2012-09-11 Thread Goffredo Baroncelli
ed the special case when the magic fields is zeroed in the *first* superblock. In this case the device is skipped. Please apply, thank. You can pull from http://cassiopea.homelinux.net/git/btrfs-progs-unstable.git branch btrfs_read_dev_super-bug BR G.Baroncelli -- Signe

Re: [PATCH] btrfs: fix disk-io.c/btrfs_read_dev_super with BTRFS_SUPER_MIRROR_MAX to control the loops

2012-09-10 Thread Goffredo Baroncelli
Hi, On 09/10/2012 08:38 AM, Wang Sheng-Hui wrote: To check the duplicated super blocks, use BTRFS_SUPER_MIRROR_MAX as the loops limit. Signed-off-by: Wang Sheng-Hui --- fs/btrfs/disk-io.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/

Re: BTRFS thinks device is busy [kernel 3.5.3]

2012-09-05 Thread Goffredo Baroncelli
=S_IFREG|0444, st_size=0, ...}) = 0 mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f1cf0a7c000 read(3, "major minor #blocks name\n\n 8"..., 1024) = 700 read(3, "", 1024) = 0 close(3)= 0 munmap(0x7f1cf0a7

Re: BTRFS thinks device is busy [kernel 3.5.3]

2012-09-05 Thread Goffredo Baroncelli
Hi, On 09/05/2012 03:29 PM, Joeri Vanthienen wrote: Hi, I'm running OpenSuse 12.2 with kernel 3.5.3 HBA= LSI 1068e using the MPTSAS driver (patched) (https://patchwork.kernel.org/patch/1379181/) SANOS1:/media # uname -a Linux SANOS1 3.5.3 #3 SMP Sun Sep 2 18:44:37 CEST 2012 x86_64 x86_64 x86_64

Re: rfc: fuzz testing by direct writes to device

2012-09-04 Thread Goffredo Baroncelli
On 09/05/2012 03:59 AM, Shentino wrote: > I am not sure that doing "sed/dev/sdX ..." is the right thing to > do, because it rewrites the full disk. This means that: > - it takes a lot of time > - you don't have any control about which part of the disk you change: what > happens if sed write

Re: rfc: fuzz testing by direct writes to device

2012-09-04 Thread Goffredo Baroncelli
Hi, On 09/02/2012 03:03 AM, Shentino wrote: This whole subject was also about using sed to corrupt-o-magic a file's data on disk. Is this an acceptable method for testing? I am not sure that doing "sed /dev/sdX ..." is the right thing to do, because it rewrites the full disk. This means tha

[BTRFS-PROGS][BUG][PATCH] Incorrect detection of a removed device [was Re: “Bug”-report: inconsistency kernel <-> tools]

2012-08-31 Thread Goffredo Baroncelli
Hi all, Yan, On 08/31/2012 09:08 PM, Goffredo Baroncelli wrote: However making a test I found both the behaviours: sometime the removed disk disappears from the output of "btrfs fi show" and sometime not... May be that there is a bug somewhere... I became crazy looking at this bu

Re: “Bug”-report: inconsistency kernel <-> tools

2012-08-31 Thread Goffredo Baroncelli
On 08/30/2012 08:24 PM, Goffredo Baroncelli wrote: And magically the filesystem is now composed by three disks. However 4 physical devices are show. This because the disk /dev/vdi superblock says that the disk is still valid (after the "btrfs device del" the disk is not touched any

Re: [PATCH] Btrfs-progs: Add get/set label ioctl

2012-08-30 Thread Goffredo Baroncelli
Hi Anand, please updates the man page, because it says that it is impossible to change the label of a mounted filesystem [...] btrfs filesystem label [newlabel] Show or update the label of a filesystem. is used to iden‐ tify the filesystem. If a newlabel optional argumen

Re: “Bug”-report: inconsistency kernel <-> tools

2012-08-30 Thread Goffredo Baroncelli
On 08/28/2012 09:52 PM, M G Berberich wrote: Hello, We had set up a btrfs-fs over 6 hot-plugable SAS-disks for testing and got it into a state where kernel and btrfs-tools do not agree any more about the state of the filesystem. We do not remember exaclty what we did, but roughly it was somethi

Re: [PATCH v1 0/4] BTRFS sysfs support

2012-08-24 Thread Goffredo Baroncelli
You can pull the source from the following repo: http://cassiopea.homelinux.net/git/btrfs-unstable.git branch sysfs thanks. G.Baroncelli On 08/24/2012 03:58 PM, Goffredo Baroncelli wrote: > Hi all, > The following series restores the BTRFS sysfs support. My idea

[PATCH v1 4/4] Btrfs sysfs support documentation.

2012-08-24 Thread Goffredo Baroncelli
Update of the Documentation/filesystes/btrfs.txt file. Signed-off-by: Goffredo Baroncelli --- 0 files changed diff --git a/Documentation/filesystems/btrfs.txt b/Documentation/filesystems/btrfs.txt index 7671352..35840ab 100644 --- a/Documentation/filesystems/btrfs.txt +++ b/Documentation

[PATCH v1 3/4] Add a new Kconfig section to enable or disable the sysfs.

2012-08-24 Thread Goffredo Baroncelli
Add support for sysfs to BTRFS. This patch add the Kconfig part to enable or disable the exporting of teh BTRFS information via sysfs. Signed-off-by: Goffredo Baroncelli --- fs/btrfs/Kconfig |9 + 1 file changed, 9 insertions(+) diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig

[PATCH v1 2/4] Add hook for sysfs to btrfs.

2012-08-24 Thread Goffredo Baroncelli
Add the hook in the btrfs filesystem code to supporting sysfs. Signed-off-by: Goffredo Baroncelli --- fs/btrfs/super.c |4 fs/btrfs/volumes.c | 10 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c index e239915..8927674

[PATCH v1 1/4] Add support for sysfs to btrfs.

2012-08-24 Thread Goffredo Baroncelli
Export via sysfs some information about the btrfs devices and filesystem. Signed-off-by: Goffredo Baroncelli --- fs/btrfs/sysfs.c | 938 ++ fs/btrfs/sysfs.h | 31 ++ 2 files changed, 964 insertions(+), 5 deletions(-) create mode 100644 fs

[PATCH v1 0/4] BTRFS sysfs support

2012-08-24 Thread Goffredo Baroncelli
replacing of the printk with pr_info/pr_warn/ pr_crit --- Goffredo Baroncelli (4): Add support for sysfs to btrfs. Add hook for sysfs to btrfs. Add a new Kconfig section to enable or disable the sysfs. Btrfs sysfs support documentation. fs/btrfs/Kconfig |9

[PATCH v0 3/4] Add a new Kconfig section to enable or disable the sysfs.

2012-08-23 Thread Goffredo Baroncelli
Add support for sysfs to BTRFS. This patch add the Kconfig part to enable or disable the exporting of teh BTRFS information via sysfs. --- fs/btrfs/Kconfig |9 + 1 file changed, 9 insertions(+) diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig index d33f01c..187e057 100644 --- a/fs/btr

[PATCH v0 0/4] BTRFS sysfs support

2012-08-23 Thread Goffredo Baroncelli
we should export and which not or the sysfs structure. For now these information are read-only. In the future we could consider the idea to make some action: for example to change the label of a filesystem. Comments are welcome. BR G.Baroncelli --- Goffredo Baroncelli (4): Add support

[PATCH v0 4/4] Btrfs sysfs support documentation.

2012-08-23 Thread Goffredo Baroncelli
Update of the Documentation/filesystes/btrfs.txt file. --- 0 files changed diff --git a/Documentation/filesystems/btrfs.txt b/Documentation/filesystems/btrfs.txt index 7671352..35840ab 100644 --- a/Documentation/filesystems/btrfs.txt +++ b/Documentation/filesystems/btrfs.txt @@ -89,3 +89,78 @@ b

[PATCH v0 2/4] Add hook for sysfs to btrfs.

2012-08-23 Thread Goffredo Baroncelli
Add the hook in the btrfs filesystem code to supporting sysfs. --- fs/btrfs/volumes.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index ecaad40..e1075ab 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -36

[PATCH v0 1/4] Add support for sysfs to btrfs.

2012-08-23 Thread Goffredo Baroncelli
Export via sysfs some information about the btrfs devices and filesystem. --- fs/btrfs/super.c |4 fs/btrfs/sysfs.c | 933 ++ fs/btrfs/sysfs.h | 31 ++ 3 files changed, 963 insertions(+), 5 deletions(-) create mode 100644 fs/btrfs/sysfs.

Re: [PATCH] Btrfs-progs: enhance btrfs subvol list to show read-only snapshots

2012-08-05 Thread Goffredo Baroncelli
Hi Bo, On 08/02/2012 12:13 PM, zhoubo wrote: > From: Zhou Bo > > This patch enhances btrfs subvol list to show read-only snapshots. > You can use the -r option showing read-only snapshots, for example: > btrfs subvolume list -r Please elaborate this sentence: if I read correctly your code, the

Re: [PATCH 3/3] Btrfs-progs: list snapshots by generation

2012-07-31 Thread Goffredo Baroncelli
Hi Bo, On 07/31/2012 07:49 AM, Liu Bo wrote: > The idea is that we usually use snapshot to backup/restore our data, and the > common way can be a cron script which makes lots of snapshots, so we can end > up with spending some time to find the latest snapshot to restore. > > This adds a feature f

Re: [PATCH] Btrfs-progs: detect if the disk we are formatting is a ssd V2

2012-07-23 Thread Goffredo Baroncelli
On 07/23/2012 02:46 PM, Josef Bacik wrote: > On Fri, Jul 20, 2012 at 04:38:59PM -0600, Wendy Cheng wrote: >> However, this should have been a task for the admin (or whoever types >> this mkfs command). It is not a filesystem's job to assume how the >> firmware works and silently ignore the DUP req

Re: [PATCH] Btrfs-progs: detect if the disk we are formatting is a ssd V2

2012-07-20 Thread Goffredo Baroncelli
On 07/20/2012 09:15 PM, Josef Bacik wrote: > SSD's do not gain anything by having metadata DUP turned on. The underlying > file system that is a part of all SSD's could easily map duplicate metadat If I understood correctly you are stating that because an SSD *might* "eliminates the benefit of du

Re: [PATCH] Btrfs: add DEVICE_READY ioctl

2012-07-17 Thread Goffredo Baroncelli
On 07/17/2012 01:53 PM, David Sterba wrote: > On Fri, Jun 22, 2012 at 08:12:52PM +0200, Goffredo Baroncelli wrote: >> On 06/21/2012 10:10 PM, Josef Bacik wrote: >>> This will be used in conjunction with btrfs device ready . This is [] > >> Finally I am start

Re: 3.5.0-rc6: btrfs and LVM snapshots -> wrong devicename in /proc/mounts

2012-07-10 Thread Goffredo Baroncelli
Hi Arnd, I am trying to reproduce this bug. Which kernel version are you using ? BR G.Baroncelli On 07/10/2012 07:55 PM, Goffredo Baroncelli wrote: > On 07/10/2012 10:52 AM, Arnd Hannemann wrote: >> Hi, >> >> Am 10.07.2012 05:30, schrieb Christian Robert: >>> I

Re: 3.5.0-rc6: btrfs and LVM snapshots -> wrong devicename in /proc/mounts

2012-07-10 Thread Goffredo Baroncelli
On 07/10/2012 10:52 AM, Arnd Hannemann wrote: > Hi, > > Am 10.07.2012 05:30, schrieb Christian Robert: >> I agree with you, but you should never mount a snapshot of a btrfs >> filesystem at the same time the original is, >> because both the original and the snapshot had same "device fsid >> 5c3e

Re: [RFC] Btrfs "sendshots" and hidden snapshots

2012-07-09 Thread Goffredo Baroncelli
On 07/06/2012 02:45 PM, Alexander Block wrote: > On Fri, Jul 6, 2012 at 2:03 PM, Goffredo Baroncelli > wrote: >> On 07/06/2012 01:55 PM, Chris Mason wrote: >>> On Fri, Jul 06, 2012 at 02:51:43AM -0600, Alexander Block wrote: >>>> On Fri, Jul 6, 2012 at 12:34 AM,

Re: [RFC] Btrfs "sendshots" and hidden snapshots

2012-07-06 Thread Goffredo Baroncelli
On 07/06/2012 01:55 PM, Chris Mason wrote: > On Fri, Jul 06, 2012 at 02:51:43AM -0600, Alexander Block wrote: >> On Fri, Jul 6, 2012 at 12:34 AM, Goffredo Baroncelli >> wrote: >>> On 07/05/2012 06:51 PM, Alexander Block wrote: >>>> Hello all, >>>>

Re: [RFC] Btrfs "sendshots" and hidden snapshots

2012-07-06 Thread Goffredo Baroncelli
On 07/06/2012 10:51 AM, Alexander Block wrote: > On Fri, Jul 6, 2012 at 12:34 AM, Goffredo Baroncelli > wrote: >> On 07/05/2012 06:51 PM, Alexander Block wrote: >>> Hello all, >>> [] >>> When we later do an incremental send we can do this: >>&

Re: [RFC] Btrfs "sendshots" and hidden snapshots

2012-07-05 Thread Goffredo Baroncelli
On 07/05/2012 06:51 PM, Alexander Block wrote: > Hello all, > > in IRC we had a discussion on how we could solve sending live > subvolumes and how to send subvolumes without the need to > administrate/keep old snapshots for incremental sends. One of the > ideas was to introduce "sendshots", which

Re: [RFC PATCHv2 0/3] Btrfs-progs: introduce btrfs property subgroup

2012-06-27 Thread Goffredo Baroncelli
Hi Alexander, On 06/27/2012 03:16 PM, Alexander Block wrote: > This patchset introduces the btrfs property subgroup. It is the > result of a discussion we had on IRC. I tried to make the properties > interface as generic and extensible as possible. Comments are welcome. > > Currently the command

Re: [PATCH] Btrfs: add DEVICE_READY ioctl

2012-06-22 Thread Goffredo Baroncelli
On 06/21/2012 10:10 PM, Josef Bacik wrote: > This will be used in conjunction with btrfs device ready . This is > needed for initrd's to have a nice and lightweight way to tell if all of the > devices needed for a file system are in the cache currently. This keeps > them from having to do mount+s

Re: [PATCH] Btrfs-progs: add btrfs device ready command

2012-06-22 Thread Goffredo Baroncelli
On 06/21/2012 10:10 PM, Josef Bacik wrote: > This command will be used by things like dracut that wish to know very > simply if all of the devices have been added to the kernel cache yet for the > device to be fully mounted. This keeps initrd's from constantly having to > try to mount the file sys

Re: R: Re: Subvolumes and /proc/self/mountinfo

2012-06-21 Thread Goffredo Baroncelli
On 06/21/2012 03:38 PM, H. Peter Anvin wrote: >> But if /boot has to be in a separate filesystem, which is the point to >> > support btrfs at all ? Does make sense to support only a subset of btrfs >> > features ? >> > > Yes, and that's another good reason for /boot: btrfs supports that kind > of

Re: R: Re: Subvolumes and /proc/self/mountinfo

2012-06-21 Thread Goffredo Baroncelli
On 06/21/2012 01:46 PM, Martin Steigerwald wrote: > Am Donnerstag, 21. Juni 2012 schrieb Goffredo Baroncelli: >>> >>> >>>> Now we have the possibility to move the kernel near the modules, and >>>> this could lead some interesting possibility: think abou

Re: R: Re: Subvolumes and /proc/self/mountinfo

2012-06-20 Thread Goffredo Baroncelli
On 06/20/2012 11:49 PM, H. Peter Anvin wrote: > On 06/20/2012 11:06 AM, Goffredo Baroncelli wrote: >> >> Am not saying that we *should* move the kernel away from /boot. I am >> only saying that having the kernel near /lib/modules *has* some advantages. >> >> Few

Re: R: Re: Subvolumes and /proc/self/mountinfo

2012-06-20 Thread Goffredo Baroncelli
On 06/20/2012 09:15 PM, Helmut Hullen wrote: > Hallo, Goffredo, Hi Helmut, > > Du meintest am 20.06.12: > > [...] > >> Am not saying that we *should* move the kernel away from /boot. I am >> only saying that having the kernel near /lib/modules *has* some >> advantages. > >> Few year ago there

Re: [PATCH] Allow cross subvolume reflinks (2nd attempt)

2012-06-20 Thread Goffredo Baroncelli
On 06/20/2012 10:05 PM, Alexander Block wrote: > On Wed, Jun 20, 2012 at 8:11 PM, Goffredo Baroncelli > wrote: >> >> Yes please, could someone explain the reason behind this decision ? May >> be there are valid reasons, I am asking only to know which ones ? >> >

Re: [PATCH] Allow cross subvolume reflinks (2nd attempt)

2012-06-20 Thread Goffredo Baroncelli
On 06/20/2012 08:07 PM, Calvin Walton wrote: > On Wed, 2012-06-20 at 19:27 +0200, Alexander Block wrote: >> On Wed, Jun 20, 2012 at 7:18 PM, Goffredo Baroncelli >> wrote: >>> Hi Alexander, >>> >>> On 06/20/2012 12:35 PM, Alexander Block wrote: >>&g

Re: R: Re: Subvolumes and /proc/self/mountinfo

2012-06-20 Thread Goffredo Baroncelli
HI, On 06/20/2012 07:41 PM, H. Peter Anvin wrote: > On 06/20/2012 09:34 AM, Goffredo Baroncelli wrote: >> >> At the first I tough that having the /boot separate could be a good >> thing. Unfortunately /boot contains both the bootloader code and the >> kernel image. Th

Re: [PATCH] Allow cross subvolume reflinks (2nd attempt)

2012-06-20 Thread Goffredo Baroncelli
Hi Alexander, On 06/20/2012 12:35 PM, Alexander Block wrote: > The patch also does proper vfs mount checks, so cross mount > point reflinks are not possible with this patch. It only allows cross > reflinks between two subvolumes which are in the same mount point. Thanks for working on that. Wha

Re: Device names

2012-06-20 Thread Goffredo Baroncelli
On 06/20/2012 03:37 PM, Chris Mason wrote: > On Tue, Jun 19, 2012 at 06:00:11PM -0600, H. Peter Anvin wrote: >> On 06/19/2012 04:51 PM, Chris Mason wrote: >>> >>> At mount time, we go through and verify the path names still belong to >>> the filesystem you thought they belonged to. The bdev is loc

Re: R: Re: Subvolumes and /proc/self/mountinfo

2012-06-20 Thread Goffredo Baroncelli
On 06/20/2012 05:37 PM, H. Peter Anvin wrote: > On 06/20/2012 05:02 AM, Goffredo Baroncelli wrote: >> >> If I swap (via a rename) __active and __rollback, in the next boot my system >> uses a "good" copy of the root filesystem. This is a simple way to swap >&

R: Re: Subvolumes and /proc/self/mountinfo

2012-06-20 Thread Goffredo Baroncelli
Hi All, >Messaggio originale >Da: l...@fajar.net >Data: 20/06/2012 8.31 >A: "H. Peter Anvin" >Cc: >Ogg: Re: Subvolumes and /proc/self/mountinfo > >On Wed, Jun 20, 2012 at 10:22 AM, H. Peter Anvin wrote: >> a. Make a snapshot of the current root; >> b. Mount said snapshot; >> c. Install t

R: Re: Subvolumes and /proc/self/mountinfo

2012-06-20 Thread Goffredo Baroncelli
HI all, >Messaggio originale >Da: h...@zytor.com >Data: 20/06/2012 5.22 >A: "cwillu" >Cc: , >Ogg: Re: Subvolumes and /proc/self/mountinfo > > >The concept of what is the "root" and what is the "path" is >straightforward for lesser filesystems: the root of the filesystem is >defined by th

R: Re: Subvolumes and /proc/self/mountinfo

2012-06-20 Thread Goffredo Baroncelli
HI all, >Messaggio originale >Da: chris.ma...@fusionio.com >Data: 20/06/2012 1.49 >A: "H. Peter Anvin" >Cc: "linux-btrfs@vger.kernel.org" >Ogg: Re: Subvolumes and /proc/self/mountinfo > >> b. Are there better ways (walking the tree using BTRFS_IOC_TREE_SEARCH?) >> to accomplish this than

Re: cannot remove files: "rm" gives "no space left on device", 3.2.0-24, ubuntu

2012-06-18 Thread Goffredo Baroncelli
On 06/18/2012 08:40 AM, rupert THURNER wrote: > On Mon, Jun 18, 2012 at 7:53 AM, Goffredo Baroncelli > wrote: >> On 06/17/2012 09:54 PM, rupert THURNER wrote: >>> displays the additional free space. that it displays 30% of metadata >>> seems strange to me, or it

Re: cannot remove files: "rm" gives "no space left on device", 3.2.0-24, ubuntu

2012-06-17 Thread Goffredo Baroncelli
On 06/17/2012 09:54 PM, rupert THURNER wrote: > On Sun, Jun 17, 2012 at 3:32 PM, Mitch Harder > wrote: >> On Sun, Jun 17, 2012 at 3:04 AM, rupert THURNER >> wrote: >>> On Sun, Jun 17, 2012 at 7:19 AM, Andrei Popa wrote: On Sun, 2012-06-17 at 06:14 +0200, rupert THURNER wrote: >>> Will r

Re: [PATCH] Btrfs: add "nocompress" mount option

2012-06-15 Thread Goffredo Baroncelli
On 06/15/2012 12:50 PM, David Sterba wrote: > I prefer this over adding an extra option to disable. This > way there's no confusion if the compression is on or off. > > mount -o compress,nocompress /dev /mnt The confusion still exists if an user does: mount -o compress,compress=no /dev

Re: Moving top level to a subvolume

2012-06-13 Thread Goffredo Baroncelli
On 06/13/2012 09:21 AM, Arne Jansen wrote: > On 13.06.2012 09:04, C Anthony Risinger wrote: >> On Fri, Jun 8, 2012 at 2:40 PM, Arne Jansen wrote: >>> On 06/08/2012 09:24 PM, Matthew Hawn wrote: I just converted my root filesystem to btrfs with btrfs-convert. However, since I am running

Re: Btrfs and data nocow per inode basis

2012-06-12 Thread Goffredo Baroncelli
On 06/12/2012 10:44 PM, Chris Mason wrote: > On Tue, Jun 12, 2012 at 01:15:27PM -0600, Ted Ts'o wrote: >> It appears the NOCOW_FL flag is currently a no-op in the 3.2 kernel? > > It's not a noop, but it is only setting the NODATACOW flag. It needs to > set the nodatasum flag as well, just like th

Re: Btrfs and data nocow per inode basis

2012-06-12 Thread Goffredo Baroncelli
On 06/10/2012 08:47 AM, Goffredo Baroncelli wrote: > Hi all, > > which is the supposed corrected way to set the file flag FS_NOCOW_FL ? I > know that exists the associated ioctl FS_IOC_SETFLAGS; which I didn't > found is an user-space tool to use to set the flags. > &

Re: [PATCH] Removing btrfsctl, btrfs-vol, btrfs-show

2012-06-10 Thread Goffredo Baroncelli
On 06/10/2012 10:46 AM, Chris Samuel wrote: > On Saturday 09 June 2012 16:24:19 Goffredo Baroncelli wrote: > >> This commit removes all the related code. > > This doesn't seem to apply cleanly with patch Did you pass the "-p1" switch to the patch command ? >

[PATCH] Removing btrfsctl, btrfs-vol, btrfs-show

2012-06-08 Thread Goffredo Baroncelli
e. Signed-off-by: Goffredo Baroncelli --- INSTALL |5 - Makefile | 11 +- btrfs-show.c | 156 - btrfs-vol.c | 169 --- btrfsctl.c

[PATCH][btrfs-progs] Removing btrfsctl, btrfs-vol, btrfs-show

2012-06-08 Thread Goffredo Baroncelli
With the commit 002d021c (committed October 2011) btrfsctl, btrfs-vol, btrfs-show were declared deprecated. The last patches related to these commands are dated December 2010. These tools are replaced by the "btrfs" tool in all the functionality. Stefan Behrens yesterday issued a patch which remo

Re: [PATCH 3/3] Add btrfs filesystem info man page.

2012-06-08 Thread Goffredo Baroncelli
On 06/08/2012 09:21 PM, Jérôme Poulin wrote: > What kind of "info" does it give? This is really unhelpful in a man > page, it just tells the obvious. Definitely, this is one of the point of this patch to improve. > > On Fri, Jun 8, 2012 at 3:12 PM, Goffredo Baroncelli

Re: problem re-adding original mount block device on multi-device fs

2012-06-08 Thread Goffredo Baroncelli
On 06/08/2012 06:42 AM, Lennert Buytenhek wrote: > (please CC on replies, I'm not subscribed to the list) > > Hi! > > This fails: > > # mkfs.btrfs /dev/sd[bcde] > # mount /dev/sdb /mnt/x > # btrfs device delete /dev/sdb /mnt/x > # btrfs device add /dev/sdb /mnt/x >

[PATCH 1/3] Btrfs-progs: make two utility functions globally available

2012-06-08 Thread Goffredo Baroncelli
This patch is ispired by a Stefan Behrens one. --- Makefile |8 +++ cmds-scrub.c | 72 ++ utils.c | 68 ++ utils.h |4 4 files changed, 78 insertions(+), 7

[PATCH 3/3] Add btrfs filesystem info man page.

2012-06-08 Thread Goffredo Baroncelli
Update the man page to document the "btrfs filesystem info " command. --- man/btrfs.8.in |8 1 file changed, 8 insertions(+) diff --git a/man/btrfs.8.in b/man/btrfs.8.in index be478e0..6d96bf7 100644 --- a/man/btrfs.8.in +++ b/man/btrfs.8.in @@ -25,6 +25,8 @@ btrfs \- control a btrfs

[PATCH 2/3] Add btrfs filesystem info command.

2012-06-08 Thread Goffredo Baroncelli
Add btrfs filesystem info command, which is capable to show some btrfs filesystem information. --- cmds-filesystem.c | 59 + 1 file changed, 59 insertions(+) diff --git a/cmds-filesystem.c b/cmds-filesystem.c index 1f53d1c..9acc715 100644 ---

[RFC][btrfs-progs] add command btrfs filesystem info

2012-06-08 Thread Goffredo Baroncelli
Hi all the aim of this patch is to add the command "btrfs filesystem info" to show some filesystem information. Example: $ sudo btrfs-progs/btrfs filesystem info /mnt/test Path: /mnt/test Max ID: 4 UUID: 1c7e4ba6-aebc-4b39-90ef-c61315fb74d1 Num devices: 3 Dev ID: 2 UUID: cdbda186-735e-49cd-

Re: [PATCH v5 1/3] Btrfs-progs: move open_file_or_dir() to utils.c

2012-06-07 Thread Goffredo Baroncelli
Hi Stefan, On 05/25/2012 04:07 PM, Stefan Behrens wrote: > This is a preparation step to add support for device stats. The definition > of the function open_file_or_dir() is moved from common.c to utils.c in > order to be able to share some common code between scrub and the device > stats in the f

Re: [btrfs-progs] [bug][patch V2] Leaking file handle in scrub_fs_info()

2012-06-05 Thread Goffredo Baroncelli
Hi Hugo, On 06/05/2012 08:19 PM, Hugo Mills wrote: > On Tue, Jun 05, 2012 at 07:26:34PM +0200, Goffredo Baroncelli > wrote: >> Hi Hugo, >> >> I was not able to reproduce your error with my repository: I >> pulled it without problem. > > Well, I'd have n

Re: [btrfs-progs] [bug][patch V2] Leaking file handle in scrub_fs_info()

2012-06-05 Thread Goffredo Baroncelli
as inlined. Hoping that helps. commit b73abc9465d3a105b5f8f464f2867543a638e5e2 Author: Goffredo Baroncelli Date: Tue Jun 5 19:11:06 2012 +0200 scrub_fs_info( ) file handle leaking The function scrub_fs_info( ) closes and reopen a file handle passed as argument, when a

Re: It is not so interesting than I hoped

2012-05-31 Thread Goffredo Baroncelli
ffredo > > btrfs is fine, and so people of the list. > > thanks very much to Liu Bo, Arne Jansen, Goffredo Baroncelli > > > WeiFeng Liu > > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to

Re: [RFC PATCH] Decrease meta fragments by using a caterpillar band Method (Ver. 2)

2012-05-29 Thread Goffredo Baroncelli
Hi Liu, On 05/29/2012 06:24 PM, WeiFeng Liu wrote: > This is a several bugs fixed version since my first patch commit, and added > patch of btrfs-prog > > > Introduction and brief speculate of values and penalties: > > When a tree block need to be created, we offer, say, 2 or 3 blocks for

Re: [PATCH 2/2] Btrfs: resize all devices when we dont assign a specific device id

2012-05-24 Thread Goffredo Baroncelli
On 05/24/2012 04:15 AM, Liu Bo wrote: > On 05/23/2012 01:21 PM, Goffredo Baroncelli wrote: > >> Hi >> >> On 05/17/2012 02:08 PM, Liu Bo wrote: >>> This patch fixes two bugs: >>> >>> When we do not assigne a device id for the resizer, >>>

Re: Cant mount multi-subvolume via fstab

2012-05-23 Thread Goffredo Baroncelli
Hi Rogerio, On 05/23/2012 05:00 PM, Rogerio Bastos wrote: > Hi, > > I'm trying mount many subvolume during boot via fstab: > > UUID=xxx /usr btrfs subvol=usr,ro,nodev 0 0 > UUID=xxx /home btrfs subvol=home,nodev,nosuid 0 0 > UUID=xxx /var btrfs subvol=var,nodev 0 0 > UUID=xxx /var/tmp btrfs subv

Re: [PATCH 2/2] Btrfs: resize all devices when we dont assign a specific device id

2012-05-22 Thread Goffredo Baroncelli
Hi On 05/17/2012 02:08 PM, Liu Bo wrote: > This patch fixes two bugs: > > When we do not assigne a device id for the resizer, > - it will only take one device to resize, which is supposed to apply on > all available devices. > - it will take 'id 1' device as default, and this will cause a bug a

Re: Which is the maximum files size in BTRFS ? [was Re: btrfs: Probably the larger filesystem I will see for a long time]

2012-05-22 Thread Goffredo Baroncelli
On 05/22/2012 07:17 PM, Goffredo Baroncelli wrote: > Hi all, > >>From the specification [1] the btrfs maximum file size limit should be > 1<<64 bytes. However I was never able to create a file >= 1<<63 bytes. > > > ghigo@venice:/mnt/old-btrfs/home/ghigo/gi

Which is the maximum files size in BTRFS ? [was Re: btrfs: Probably the larger filesystem I will see for a long time]

2012-05-22 Thread Goffredo Baroncelli
Hi all, >From the specification [1] the btrfs maximum file size limit should be 1<<64 bytes. However I was never able to create a file >= 1<<63 bytes. ghigo@venice:/mnt/old-btrfs/home/ghigo/gianfile$ ls -l giantfile2 -rw-r--r-- 1 ghigo ghigo 9223372036854775807 May 22 18:55 giantfile2 ghigo@veni

Re: [btrfs-progs] [bug][patch] Leaking file handle in scrub_fs_info()

2012-04-25 Thread Goffredo Baroncelli
On 04/25/2012 11:39 AM, Jan Schmidt wrote: > Hi Goffredo, > > On 24.04.2012 20:43, Goffredo Baroncelli wrote: >> I was giving a look to the function scrub_fs_info( ), and to me it seems >> that could be a potential file handle leaking problem. > > It's only a s

[btrfs-progs] [bug][patch] Leaking file handle in scrub_fs_info()

2012-04-24 Thread Goffredo Baroncelli
Hi Jan, I was giving a look to the function scrub_fs_info( ), and to me it seems that could be a potential file handle leaking problem. In fact: static int scrub_fs_info(int fd, char *path, struct btrfs_ioctl_fs_info_args *fi_args, struct btrfs_ioctl_dev_

R: Re: Create subvolume from a directory?

2012-03-29 Thread Goffredo Baroncelli
Hi Liubo >Messaggio originale >Da: liubo2...@cn.fujitsu.com >Data: 29/03/2012 3.24 >> Could you elaborate which would be the issue ? >> "cp --reflink"-ing a file is not different than snapshotting a file. In >> any case I could mount a snapshot and not the source subvolume. >> > >We alre

Re: Create subvolume from a directory?

2012-03-28 Thread Goffredo Baroncelli
Hello Liu On 03/28/2012 04:18 AM, Liu Bo wrote: On 03/28/2012 06:24 AM, Matthias G. Eckermann wrote: # time cp -a --reflink /var/lib/lxc/installserver_tmp/rootfs /var/lib/lxc/installserver This is too much weird. AFAIK, clone between different subvolumes should be forbidden. So this wou

[PATCH][BTRFS-PROGS][Resubmit] Re: Btrfs filesystem resize syntax

2012-02-23 Thread Goffredo Baroncelli
Hi all, I am resubmitting an old patch, which has the aim to document the parameter of the btrfs filesystem resize command. The patch is against the Mason master repo. Hugo, Chris, please apply You can pull the source from http://cassiopea.homelinux.net/git/btrfs-progs-unstable.git

Re: subvolume info in /proc/mounts

2012-02-07 Thread Goffredo Baroncelli
Hi Christoph On Monday, 06 February, 2012 13:18:24 Christoph Hellwig wrote: > On Mon, Feb 06, 2012 at 12:53:21PM +0100, David Sterba wrote: > > On Sun, Feb 05, 2012 at 12:30:42PM +0200, Nikos Voutsinas wrote: > > > It's quite old, but what was this about; > > > > > > http://thread.gmane.org/gmane

Re: [PATCH 2/3] Btrfs-progs: implement new subcommand parser

2012-02-06 Thread Goffredo Baroncelli
On Saturday, 04 February, 2012 15:45:25 Ilya Dryomov wrote: > On Sat, Feb 04, 2012 at 01:54:23PM +0100, Goffredo Baroncelli wrote: > > Hi Ilya > > > > On Friday, 03 February, 2012 22:23:59 you wrote: > > > This completely replaces the existing subcommand infr

Re: [PATCH 0/3] Btrfs-progs: restriper interface

2012-02-06 Thread Goffredo Baroncelli
On Saturday, 04 February, 2012 15:47:17 Ilya Dryomov wrote: > On Sat, Feb 04, 2012 at 02:06:28PM +0100, Goffredo Baroncelli wrote: > > Hi Ilya, > > > > On Friday, 03 February, 2012 22:49:09 Ilya Dryomov wrote: > > > Hello, > > > > > > This is the u

Re: [PATCH 0/3] Btrfs-progs: restriper interface

2012-02-04 Thread Goffredo Baroncelli
Hi Ilya, On Friday, 03 February, 2012 22:49:09 Ilya Dryomov wrote: > Hello, > > This is the userspace part of restriper, rebased onto the new progs > infrastructure. Restriper commands are located under 'balance' prefix, > which is now the top level command group. However to not confuse > exist

Re: [PATCH 2/3] Btrfs-progs: implement new subcommand parser

2012-02-04 Thread Goffredo Baroncelli
ot;", *usagestr++); > + > + /* a long (possibly multi-line) description (optional) */ > + if (!*usagestr || ((flags & USAGE_LONG) == 0)) > + return 0; > + > + if (**usagestr) > + fputc('\n', outf); > + while (*usagestr &a

Re: btrfs-raid questions I couldn't find an answer to on the wiki

2012-01-29 Thread Goffredo Baroncelli
On Thursday, 26 January, 2012 16:41:32 Duncan wrote: > 1) My /boot partition and its backup (which I do want to keep separate > from root) are only 128 MB each. The wiki recommends 1 gig sizes > minimum, but there's some indication that's dated info due to mixed data/ > metadata mode in recent k

Re: BTRFS development

2012-01-08 Thread Goffredo Baroncelli
Thanks, > Debasish > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- gpg key@ keyserver.linux.it: Goffredo Baroncelli (

Re: [PATCH] Btrfs-progs: restriper interface

2012-01-07 Thread Goffredo Baroncelli
On Saturday, 07 January, 2012 17:49:01 Goffredo Baroncelli wrote: > On Saturday, 07 January, 2012 16:14:43 you wrote: [..] > > btrfs instead tries to be clever, and if ip was doing the same thing > > btrfs does you would get "ambiguous command 'r'" error in r

Re: [PATCH] Btrfs-progs: restriper interface

2012-01-07 Thread Goffredo Baroncelli
rfs s s -> is ambiguous command because it could means both 1) and 2) However if we try 1) we get an error. But this is not the intended behavior. I have to investigate why. BR G.Baroncelli > > Thanks, > > Ilya -- gpg key@ keyserver.linux.it: Goffredo Baroncelli (ghigo

Re: [PATCH] Btrfs-progs: restriper interface

2012-01-07 Thread Goffredo Baroncelli
riper' or whatsoever, then deprecating the 'balance' sub command. Finally, please could you update the man page too ? BR G.Baroncelli Disclaimer, I was the author of the sub-command matcher. -- gpg key@ keyserver.linux.it: Goffredo Baroncelli (ghigo) Key fingerprint = 4769 7E51 5293

Re: [PATCH V2] btrfs-progs: Add ioctl to read compressed size of a file

2011-12-20 Thread Goffredo Baroncelli
/* in */ > + __u64 size; /* out */ > + __u64 compressed_size; /* out */ > + __u64 reserved[2]; > +}; > + > + > /* BTRFS_IOC_SNAP_CREATE is no longer used by the btrfs command */ > #define BTRFS_IOC_SNAP_CREATE _IOW(B

Re: speeding up slow btrfs filesystem

2011-12-20 Thread Goffredo Baroncelli
Ciao Andrea, On Sunday, 18 December, 2011 19:41:49 you wrote: > 2011/12/16 Goffredo Baroncelli : > > I found a solution, but requires a bit of setup. > > Did you try: > echo force-unsafe-io >> /etc/dpkg/dpkg.cfg stracing an apt-get update, it seems that --force-unsafe-

Re: speeding up slow btrfs filesystem

2011-12-17 Thread Goffredo Baroncelli
unately today this is not available. [] > > Thanks, Regards -- gpg key@ keyserver.linux.it: Goffredo Baroncelli (ghigo) Key fingerprint = 4769 7E51 5293 D36C 814E C054 BF04 F161 3DC5 0512 -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: speeding up slow btrfs filesystem

2011-12-17 Thread Goffredo Baroncelli
ng goes wrong (like strange packages dependencies). Or you can have the previous configuration to go back in case of trouble. [*] Of course this is due to the fact that the most part of the filesystem is like ext4. Supporting BTRFS could be not the highest priority. -- gpg key@ keyserver.linux

Re: speeding up slow btrfs filesystem

2011-12-16 Thread Goffredo Baroncelli
(2011-10-19) BR G.Baroncelli -- gpg key@ keyserver.linux.it: Goffredo Baroncelli (ghigo) Key fingerprint = 4769 7E51 5293 D36C 814E C054 BF04 F161 3DC5 0512 -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org

Re: Cloning a Btrfs partition

2011-12-13 Thread Goffredo Baroncelli
linux-btrfs" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- gpg key@ keyserver.linux.it: Goffredo Baroncelli (ghigo) Key fingerprint = 4769 7E51 5293 D36C 814E C054 BF04 F161 3DC5 0512 -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

<    4   5   6   7   8   9   10   11   12   >