Re: [PATCH 1/2] btrfs: fix null pointer dereference in clone_fs_devices when name is null

2014-07-07 Thread Anand Jain
It's a pity that the patch has been merged into the upstream kernel. Let's correct our miss before the next merge. What I found were new-bugs, those are not related to this patch. BTW, I sent some patches to fix the problems about seed device(including the updated patch of this one),

Re: [PATCH 1/2] btrfs: fix null pointer dereference in clone_fs_devices when name is null

2014-07-07 Thread Anand Jain
It's a pity that the patch has been merged into the upstream kernel. Let's correct our miss before the next merge. What I found were new-bugs, those are not related to this patch. BTW, I sent some patches to fix the problems about seed device(including the updated patch of this one),

Re: [PATCH 1/2] btrfs: fix null pointer dereference in clone_fs_devices when name is null

2014-07-06 Thread Miao Xie
On Fri, 4 Jul 2014 19:24:44 +0800, Anand Jain wrote: (now used correct email id for Chris) On 04/07/2014 19:21, Anand Jain wrote: Miao, Chris, I appreciate your review comments, Miao. I am sorry for the delay, was stuck on this issue for a long time. more below. On 02/07/2014 10:38,

Re: [PATCH 1/2] btrfs: fix null pointer dereference in clone_fs_devices when name is null

2014-07-04 Thread Anand Jain
Miao, Chris, I appreciate your review comments, Miao. I am sorry for the delay, was stuck on this issue for a long time. more below. On 02/07/2014 10:38, Miao Xie wrote: On Mon, 30 Jun 2014 23:06:54 +0800, Anand Jain wrote: The primary reason of this problem is that we didn't scan the

Re: [PATCH 1/2] btrfs: fix null pointer dereference in clone_fs_devices when name is null

2014-07-04 Thread Anand Jain
(now used correct email id for Chris) On 04/07/2014 19:21, Anand Jain wrote: Miao, Chris, I appreciate your review comments, Miao. I am sorry for the delay, was stuck on this issue for a long time. more below. On 02/07/2014 10:38, Miao Xie wrote: On Mon, 30 Jun 2014 23:06:54 +0800, Anand

Re: [PATCH 1/2] btrfs: fix null pointer dereference in clone_fs_devices when name is null

2014-07-01 Thread Miao Xie
On Mon, 30 Jun 2014 23:06:54 +0800, Anand Jain wrote: The primary reason of this problem is that we didn't scan the system and find all the devices in the filesystem, if we scan the system, we can mount the filesystem successfully, needn't mount it with degraded option. so I think the right

[PATCH 1/2] btrfs: fix null pointer dereference in clone_fs_devices when name is null

2014-06-30 Thread Anand Jain
when one of the device path is missing btrfs_device name is null. So this patch will check for that. stack: BUG: unable to handle kernel NULL pointer dereference at 0010 IP: [812e18c0] strlen+0x0/0x30 [a01cd92a] ? clone_fs_devices+0xaa/0x160 [btrfs] [a01cdcf7]

Re: [PATCH 1/2] btrfs: fix null pointer dereference in clone_fs_devices when name is null

2014-06-30 Thread Miao Xie
On Mon, 30 Jun 2014 17:12:47 +0800, Anand Jain wrote: when one of the device path is missing btrfs_device name is null. So this patch will check for that. stack: BUG: unable to handle kernel NULL pointer dereference at 0010 IP: [812e18c0] strlen+0x0/0x30

Re: [PATCH 1/2] btrfs: fix null pointer dereference in clone_fs_devices when name is null

2014-06-30 Thread Anand Jain
The primary reason of this problem is that we didn't scan the system and find all the devices in the filesystem, if we scan the system, we can mount the filesystem successfully, needn't mount it with degraded option. so I think the right way to fix is to scan the system and find the device that