Re: [PATCH 2/2] btrfs: drop optimal argument from find_live_mirror()

2018-02-23 Thread David Sterba
On Tue, Jan 30, 2018 at 02:28:31PM +0800, Anand Jain wrote: > Drop optimal argument from the function find_live_mirror() > as we can deduce it in the function itself. Yeah the argument is not necessary. It's another misleading variable name, as it's not 'optimal' but a fallback. Please rename it.

Re: [PATCH 2/2] btrfs: drop optimal argument from find_live_mirror()

2018-01-30 Thread Anand Jain
On 01/30/2018 05:12 PM, Nikolay Borisov wrote: On 30.01.2018 08:28, Anand Jain wrote: Drop optimal argument from the function find_live_mirror() as we can deduce it in the function itself. Signed-off-by: Anand Jain --- fs/btrfs/volumes.c | 8 1 file

Re: [PATCH 2/2] btrfs: drop optimal argument from find_live_mirror()

2018-01-30 Thread Nikolay Borisov
On 30.01.2018 08:28, Anand Jain wrote: > Drop optimal argument from the function find_live_mirror() > as we can deduce it in the function itself. > > Signed-off-by: Anand Jain > --- > fs/btrfs/volumes.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) >

[PATCH 2/2] btrfs: drop optimal argument from find_live_mirror()

2018-01-29 Thread Anand Jain
Drop optimal argument from the function find_live_mirror() as we can deduce it in the function itself. Signed-off-by: Anand Jain --- fs/btrfs/volumes.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c