[PATCH] explain filesystem resize devid option

2011-02-09 Thread Hubert Kario
Adds explanation to help message and man page how to use `filesystem resize' to resize only a single device not all devices of a file system. Signed-off-by: Hubert Kario --- patch to apply cleanly requires my previous patches adding advanced help functionality btrfs.c| 10 +++---

Re: bug#8001: cp (8.10) sparse handling fails on compressed btrfs (cp/fiemap-2)

2011-02-09 Thread Pádraig Brady
On 08/02/11 03:53, Mike Frysinger wrote: > after upgrading from coreutils 8.9 to 8.10, the sparse handling in cp is > silently breaking on btrfs filesystems with the compressed option enabled. > using --sparse=never works fine, but "auto" or "always" tend to fail. the > cp/fiemap-2 test catche

kernel panic (was: no space left on device)

2011-02-09 Thread Helmut Hullen
Hallo, Erik, Du meintest am 08.02.11: >> Maybe that doesn't help now. I'm working with kernel 2.6.37 and >> kernel 2.6.38-rc2, and I've got big problems. > I had to install at least 2.6.37 to have a kernel with an advanced > enough balance feature to actually reclaim the free space and report >

[PATCH] Btrfs - use %pU to print fsid

2011-02-09 Thread Ilya Dryomov
Get rid of FIXME comment. Uuids from dmesg are now the same as uuids given by btrfs-progs. Signed-off-by: Ilya Dryomov --- fs/btrfs/volumes.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 2636a05..83b789c 100644 ---

[PATCH] btrfs: prevent heap corruption in btrfs_ioctl_space_info()

2011-02-09 Thread Dan Rosenberg
Commit bf5fc093c5b625e4259203f1cee7ca73488a5620 refactored btrfs_ioctl_space_info() and introduced several security issues. space_args.space_slots is an unsigned 64-bit type controlled by a possibly unprivileged caller. The comparison as a signed int type allows providing values that are treated

Re: [PATCH] btrfs: prevent heap corruption in btrfs_ioctl_space_info()

2011-02-09 Thread Josef Bacik
On Wed, Feb 09, 2011 at 09:12:46AM -0500, Dan Rosenberg wrote: > Commit bf5fc093c5b625e4259203f1cee7ca73488a5620 refactored > btrfs_ioctl_space_info() and introduced several security issues. > > space_args.space_slots is an unsigned 64-bit type controlled by a > possibly unprivileged caller. The

Re: [PATCH] btrfs: prevent heap corruption in btrfs_ioctl_space_info()

2011-02-09 Thread Josef Bacik
On Wed, Feb 09, 2011 at 10:51:33AM -0500, Josef Bacik wrote: > On Wed, Feb 09, 2011 at 09:12:46AM -0500, Dan Rosenberg wrote: > > Commit bf5fc093c5b625e4259203f1cee7ca73488a5620 refactored > > btrfs_ioctl_space_info() and introduced several security issues. > > > > space_args.space_slots is an uns

Re: [PATCH] btrfs: prevent heap corruption in btrfs_ioctl_space_info()

2011-02-09 Thread Dan Rosenberg
> > Argh sorry I take it back, this is wrong, we can have multiple raid types per > space info, so you need to put the slot_count-- in the inner loop farther down > to count the actual slots we're adding. Thanks, > Good catch, thanks. Reviewed-by: Dan Rosenberg -Dan -- To unsubscribe from

warning in btrfs_free_block_groups

2011-02-09 Thread Neil Schemenauer
I suspect this might be related to previous btrfs errors I've had on the same filesystem. See: http://python.ca/nas/linux/btrfs_bug.txt The most recent kernel message is: WARNING: at fs/btrfs/extent-tree.c:8239 btrfs_free_block_groups+0x218/0x275() Hardware name: MS-7388 Module

Re: warning in btrfs_free_block_groups

2011-02-09 Thread cwillu
Posted for posterity (pastebins aren't forever) 2.6.36-rc8 Oct 27 05:13:01 klonk kernel: device fsid a040b1bd002364c8-548ed98bdbee91b4 devid 1 transid 1450 /dev/sdb2 Oct 27 05:13:08 klonk kernel: btrfs allocation failed flags 1, wanted 4096 Oct 27 05:13:08 klonk kernel: space_info has 0 free, is

Re: mkfs.btrfs - error checking /dev/sda5 mount status

2011-02-09 Thread Goffredo Baroncelli
On 02/08/2011 10:26 PM, Lubos Kolouch wrote: > Goffredo Baroncelli, Tue, 08 Feb 2011 21:00:25 +0100: > >> On 02/08/2011 07:57 AM, Lubos Kolouch wrote: >>> Hi, >>> >>> I'm hitting this issue - sda5 is a normal device, nothing to do with >>> loop, encryption etc. >>> >>> # mkfs.btrfs /dev/sda5 >>> >

btrfs: issues with SUBVOL_SETFLAGS

2011-02-09 Thread Dan Rosenberg
Commit 0caa102da82799efaba88e234484786a9591c797 introduced the SUBVOL_SETFLAGS ioctl, which contains the following check: if (flags & ~BTRFS_SUBVOL_CREATE_ASYNC) return -EINVAL; if (flags & ~BTRFS_SUBVOL_RDONLY) return -EOPNOTSUPP; Is it intentiona

Re: mkfs.btrfs - error checking /dev/sda5 mount status

2011-02-09 Thread Lubos Kolouch
Goffredo Baroncelli, Wed, 09 Feb 2011 19:25:34 +0100: > On 02/08/2011 10:26 PM, Lubos Kolouch wrote: >> Goffredo Baroncelli, Tue, 08 Feb 2011 21:00:25 +0100: >> >>> On 02/08/2011 07:57 AM, Lubos Kolouch wrote: Hi, I'm hitting this issue - sda5 is a normal device, nothing to do with

Re: btrfs: issues with SUBVOL_SETFLAGS

2011-02-09 Thread Li Zefan
Dan Rosenberg wrote: > Commit 0caa102da82799efaba88e234484786a9591c797 introduced the > SUBVOL_SETFLAGS ioctl, which contains the following check: > > if (flags & ~BTRFS_SUBVOL_CREATE_ASYNC) Oops, should be: if (flags & BTRFS_SUBVOL_CREATE_ASYNC) > return -EINVAL; > >

Recovering data from disk with loose cable

2011-02-09 Thread Ben Gamari
We have a disk array behind two external SATA port multipliers (four disks on each multiplier) which has been running btrfs (RAID 1 for both data and metadata). Unfortunately, earlier today it seems one of the SATA cables came loose, resulting in the kernel (2.6.37) eventually OOPSing although appa

New btrfsck status

2011-02-09 Thread Ben Gamari
Hey all, Over the last several months there have been many claims regarding the release of the rewritten btrfsck. Unfortunately, despite numerous claims that it will be released Real Soon Now(c), I have yet to see even a repository with preliminary code. Did I miss an announcement? There is someth

Re: New btrfsck status

2011-02-09 Thread cwillu
On Wed, Feb 9, 2011 at 8:52 PM, Ben Gamari wrote: > Hey all, > > Over the last several months there have been many claims regarding the > release of the rewritten btrfsck. Unfortunately, despite numerous > claims that it will be released Real Soon Now(c), I have yet to see > even a repository with

Re: mkfs.btrfs - error checking /dev/sda5 mount status

2011-02-09 Thread Chris Samuel
On 10/02/11 07:12, Lubos Kolouch wrote: > /dev/root / btrfs rw,noatime,compress,ssd 0 0 My memory of the strace showed that there was no /dev/root when it tried to open it - can you confirm whether or not that's the case please ? cheers! Chris -- Chris Samuel : http://www.csamuel.org/ : Me

Re: mkfs.btrfs - error checking /dev/sda5 mount status

2011-02-09 Thread Lubos Kolouch
Chris Samuel, Thu, 10 Feb 2011 14:09:17 +1100: > On 10/02/11 07:12, Lubos Kolouch wrote: > >> /dev/root / btrfs rw,noatime,compress,ssd 0 0 > > My memory of the strace showed that there was no /dev/root when it tried > to open it - can you confirm whether or not that's the case please ? > > che

Re: mkfs.btrfs - error checking /dev/sda5 mount status

2011-02-09 Thread Helmut Hullen
Hallo, Lubos, Du meintest am 09.02.11: > # cat /proc/mounts > rootfs / rootfs rw 0 0 > /dev/root / btrfs rw,noatime,compress,ssd 0 0 "/dev/root" is a symlink (which I don't like). rdev shows which real device is meant. Viele Gruesse! Helmut -- To unsubscribe from this list: send the

Re: mkfs.btrfs - error checking /dev/sda5 mount status

2011-02-09 Thread Helmut Hullen
Hallo, Lubos, Du meintest am 10.02.11: >>> /dev/root / btrfs rw,noatime,compress,ssd 0 0 > # ls -la /dev/root > ls: cannot access /dev/root: No such file or directory ls -la $(rdev) (but that's no simple way ...) Viele Gruesse! Helmut -- To unsubscribe from this list: send the line "