* Herbert Xu | 2007-11-16 10:08:51 [+0800]:
On Thu, Nov 15, 2007 at 10:10:05PM +0100, Sebastian Siewior wrote:
In this case, the s390 has the same bug (they copy the IV back after
blkcipher_walk_done()). Howevere it will probably never get triggered
because they have an aligment of 0 (what
On Mon, Nov 19, 2007 at 07:56:55PM +0800, Herbert Xu ([EMAIL PROTECTED]) wrote:
I'm not sure what user will do, when it request chaining, but driver
will set CRYPTO_ALG_CIPHER_NOCHAIN itself and return wrong/old in
req-info?
For IPsec it is not an issue though, but I can not say that for
On Sun, Nov 18, 2007 at 02:52:37PM +0800, Herbert Xu ([EMAIL PROTECTED]) wrote:
On Fri, Nov 16, 2007 at 02:11:10PM +0300, Evgeniy Polyakov wrote:
That's a question - should it copy IV back or not?
Currently it is not required by crypto users.
OK I've changed my mind :)
The reason is
On Sun, Nov 18, 2007 at 02:52:37PM +0800, Herbert Xu wrote:
So my plan is to add a new flag, CRYPTO_ALG_CIPHER_NOCHAIN that
you would set on algorithms that cannot be chained. The semantics
is that everything else remains the same except that on encrypt
calls, the req-info after completion
* Herbert Xu | 2007-11-16 10:08:51 [+0800]:
You must copy it back to allow chaining. Even when we go async
someone may wish to chain. So in that sense you've just found a
bug in the hifn driver :)
Not only in hfin. My SPU-AES has the same bug. Do you know someone who
wants to chain? I can
On Fri, Nov 16, 2007 at 02:11:10PM +0300, Evgeniy Polyakov wrote:
That's a question - should it copy IV back or not?
Currently it is not required by crypto users.
Well currently we have exactly one crypto user of ablkcipher
in the tree, and that's tcrypt :)
However, looking at the sync crypto
On Fri, Nov 16, 2007 at 07:25:30PM +0800, Herbert Xu ([EMAIL PROTECTED]) wrote:
On Fri, Nov 16, 2007 at 02:11:10PM +0300, Evgeniy Polyakov wrote:
That's a question - should it copy IV back or not?
Currently it is not required by crypto users.
Well currently we have exactly one crypto
* Herbert Xu | 2007-11-14 22:22:53 [+0800]:
Indeed the last call to blkcipher_walk_done will free the IV if
we had to copy it due to an alignment mismatch. Since geode has
an alignment of 16 bytes, that's almost a given.
Ach
You could copy from/to desc-info instead which would solve the
On Thu, Nov 15, 2007 at 10:10:05PM +0100, Sebastian Siewior wrote:
In this case, the s390 has the same bug (they copy the IV back after
blkcipher_walk_done()). Howevere it will probably never get triggered
because they have an aligment of 0 (what gets pushed to 3 by the crypto
API if I
On Wed, Nov 14, 2007 at 12:11:32AM +0100, Sebastian Siewior wrote:
and everything goes back to normal. I checked walk.iv and it doesn't
change, it is still the same pointer. Do you free the walk.iv in the
meantime or is there another BUG I don't see? The IV length is 16 bytes.
Currently I'm
10 matches
Mail list logo
