RE: [PATCH 1/6] virtio: wrap find_vqs

> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Thursday, March 30, 2017 4:49 AM > Subject: [PATCH 1/6] virtio: wrap find_vqs > > We are going to add more parameters to find_vqs, let's wrap the call so > we don't need to tweak all drivers every time. > >

RE: [PATCH] virtio-crypto: adjust priority of algorithm

> > From: Christian Borntraeger [mailto:borntrae...@de.ibm.com] > Sent: Friday, January 13, 2017 4:28 PM > To: Gonglei (Arei); virtualizat...@lists.linux-foundation.org; > linux-crypto@vger.kernel.org; linux-ker...@vger.kernel.org > Cc: m...@redhat.com; herb...@gondor.apana.or

RE: [PATCH v8 1/1] crypto: add virtio-crypto driver

> > On Thu, Jan 12, 2017 at 03:10:25PM +0100, Christian Borntraeger wrote: > > On 01/10/2017 01:56 PM, Christian Borntraeger wrote: > > > On 01/10/2017 01:36 PM, Gonglei (Arei) wrote: > > >> Hi, > > >> > >

RE: [PATCH v8 1/1] crypto: add virtio-crypto driver

Hi, > > On 12/15/2016 03:03 AM, Gonglei wrote: > [...] > > + > > +static struct crypto_alg virtio_crypto_algs[] = { { > > + .cra_name = "cbc(aes)", > > + .cra_driver_name = "virtio_crypto_aes_cbc", > > + .cra_priority = 501, > > > This is still higher than the hardware-accelerators (like

RE: [virtio-dev] Re: [Qemu-devel] [PATCH v7 1/1] crypto: add virtio-crypto driver

Hi Michael, > > > > > > > > Subject: RE: [Qemu-devel] [PATCH v7 1/1] crypto: add virtio-crypto driver > > > > > > On Thursday, December 15, 2016 8:45 AM, Gonglei (Arei) Wrote: > > > < > > diff --git a/drivers/crypto/v

RE: [Qemu-devel] [PATCH v7 1/1] crypto: add virtio-crypto driver

Regards, -Gonglei > -Original Message- > From: Zeng, Xin [mailto:xin.z...@intel.com] > Sent: Thursday, December 15, 2016 8:59 AM > To: Gonglei (Arei); Halil Pasic; linux-ker...@vger.kernel.org; > qemu-de...@nongnu.org; virtio-...@lists.oasis-open.org; > virtuali

RE: [Qemu-devel] [PATCH v7 1/1] crypto: add virtio-crypto driver

> > > On 12/14/2016 12:50 PM, Gonglei wrote: > > diff --git a/drivers/crypto/virtio/virtio_crypto_core.c > b/drivers/crypto/virtio/virtio_crypto_core.c > > new file mode 100644 > > index 000..c0854a1 > > --- /dev/null > > +++ b/drivers/crypto/virtio/virtio_crypto_core.c > > @@ -0,0 +1,474

RE: [PATCH v6 2/2] crypto: add virtio-crypto driver

Hi, > > Subject: Re: [PATCH v6 2/2] crypto: add virtio-crypto driver > > > > On 12/12/2016 11:05 PM, Michael S. Tsirkin wrote: > > On Mon, Dec 12, 2016 at 06:54:07PM +0800, Herbert Xu wrote: > >> On Mon, Dec 12, 2016 at 06:25:12AM +, Gonglei (Arei) w

RE: [PATCH v6 2/2] crypto: add virtio-crypto driver

> > Subject: Re: [PATCH v6 2/2] crypto: add virtio-crypto driver > > On Mon, Dec 12, 2016 at 06:54:07PM +0800, Herbert Xu wrote: > > On Mon, Dec 12, 2016 at 06:25:12AM +0000, Gonglei (Arei) wrote: > > > Hi, Michael & Herbert > > > > > > Because th

RE: [PATCH v6 2/2] crypto: add virtio-crypto driver

4.10 merge window timing from Linus https://lkml.org/lkml/2016/12/7/506 Dec 23rd is the deadline for 4.10 merge window. Regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Thursday, December 08, 2016 12:37 PM > Subject: [PATCH v6 2/2] crypto: add virt

RE: [PATCH v6 1/2] sparc: fix a building error reported by kbuild

Regards, -Gonglei > -Original Message- > From: linux-crypto-ow...@vger.kernel.org > [mailto:linux-crypto-ow...@vger.kernel.org] On Behalf Of Sam Ravnborg > Sent: Saturday, December 10, 2016 5:59 AM > To: Gonglei (Arei) > Cc: linux-ker...@vger.kernel.org; qem

RE: [PATCH v5 1/1] crypto: add virtio-crypto driver

Hi Sam, > > Subject: Re: [PATCH v5 1/1] crypto: add virtio-crypto driver > > On Mon, Dec 05, 2016 at 03:12:52AM +0000, Gonglei (Arei) wrote: > > I don't think the root cause of those warnings are introduced by > > virtio-crypto > driver. > > > > What's

RE: [PATCH v5 1/1] crypto: add virtio-crypto driver

Hi Herbert, Would you please review and/or ack the virtio_crypto_algs.c? It is the realization of specified algs based on Linux Crypto Framework. Thanks! Regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Thursday, December 01, 2016 8:39 PM > T

RE: [PATCH v5 1/1] crypto: add virtio-crypto driver

I don't think the root cause of those warnings are introduced by virtio-crypto driver. What's your opinion? Sam and David? Thanks, -Gonglei > -Original Message- > From: kbuild test robot [mailto:l...@intel.com] > Sent: Sunday, December 04, 2016 10:40 AM > Subject: Re: [PATCH v5 1/1]

RE: [PATCH v4 1/1] crypto: add virtio-crypto driver

> > On Thu, Dec 01, 2016 at 02:27:19AM +, Gonglei (Arei) wrote: > > > On Tue, Nov 29, 2016 at 08:48:14PM +0800, Gonglei wrote: > > > > diff --git a/drivers/crypto/virtio/virtio_crypto_algs.c > > > b/drivers/crypto/virtio/virtio_crypto_algs.c > > >

RE: [PATCH v4 1/1] crypto: add virtio-crypto driver

> > Subject: Re: [PATCH v4 1/1] crypto: add virtio-crypto driver > > On Thu, Dec 01, 2016 at 02:27:19AM +0000, Gonglei (Arei) wrote: > > > On Tue, Nov 29, 2016 at 08:48:14PM +0800, Gonglei wrote: > > > > +static int virtio_crypto_alg_ablkcipher_init_sessio

RE: [PATCH v4 1/1] crypto: add virtio-crypto driver

Hi Stefan, > > On Tue, Nov 29, 2016 at 08:48:14PM +0800, Gonglei wrote: > > diff --git a/drivers/crypto/virtio/virtio_crypto_algs.c > b/drivers/crypto/virtio/virtio_crypto_algs.c > > new file mode 100644 > > index 000..08b077f > > --- /dev/null > > +++

RE: [virtio-dev] Re: [PATCH v3] crypto: add virtio-crypto driver

> > Subject: Re: [virtio-dev] Re: [PATCH v3] crypto: add virtio-crypto driver > > On Tue, 29 Nov 2016 01:37:44 +0000 > "Gonglei (Arei)" <arei.gong...@huawei.com> wrote: > > > > On Mon, 28 Nov 2016 20:08:23 +0800 > > > Gonglei <ar

RE: [PATCH v3] crypto: add virtio-crypto driver

> > > On Tue, Nov 29, 2016 at 08:22:58AM +, Gonglei (Arei) wrote: > > > Hi, > > > > > > > > > > +source "drivers/crypto/virtio/Kconfig" > > > > > > > + > > > > > > > endif # CRYPTO_HW >

RE: [PATCH v3] crypto: add virtio-crypto driver

> > On Tue, Nov 29, 2016 at 08:22:58AM +, Gonglei (Arei) wrote: > > Hi, > > > > > > > > +source "drivers/crypto/virtio/Kconfig" > > > > > > + > > > > > > endif # CRYPTO_HW > > > > > > diff

RE: [PATCH v3] crypto: add virtio-crypto driver

Hi, > > > > +source "drivers/crypto/virtio/Kconfig" > > > > + > > > > endif # CRYPTO_HW > > > > diff --git a/drivers/crypto/Makefile b/drivers/crypto/Makefile > > > > index ad7250f..bc53cb8 100644 > > > > --- a/drivers/crypto/Makefile > > > > +++ b/drivers/crypto/Makefile > > > > @@ -32,3 +32,4

RE: [PATCH v3] crypto: add virtio-crypto driver

> > > > > + > > > > +/* Note: kernel crypto API realization */ > > > > +static int virtio_crypto_ablkcipher_setkey(struct crypto_ablkcipher > > > > *tfm, > > > > +const uint8_t *key, > > > > +unsigned int keylen) > >

RE: [PATCH v3] crypto: add virtio-crypto driver

Hi Halil, > > On 11/28/2016 06:19 PM, Michael S. Tsirkin wrote: > >>> +static int virtio_crypto_alg_ablkcipher_init_session( > >>> > > + struct virtio_crypto_ablkcipher_ctx *ctx, > >>> > > + uint32_t alg, const uint8_t *key, > >>> > > + unsigned int keylen, >

RE: [PATCH v3] crypto: add virtio-crypto driver

Hi Michael and Stefan, > > Subject: Re: [PATCH v3] crypto: add virtio-crypto driver > > On Mon, Nov 28, 2016 at 04:20:55PM +, Stefan Hajnoczi wrote: > > On Mon, Nov 28, 2016 at 08:08:23PM +0800, Gonglei wrote: > > > This patch introduces virtio-crypto driver for Linux Kernel. > > > > > > The

RE: [virtio-dev] Re: [PATCH v3] crypto: add virtio-crypto driver

> > Subject: [virtio-dev] Re: [PATCH v3] crypto: add virtio-crypto driver > > On Mon, 28 Nov 2016 20:08:23 +0800 > Gonglei wrote: > > > +static int virtcrypto_update_status(struct virtio_crypto *vcrypto) > > +{ > > + u32 status; > > + int err; > > + > > +

RE: [virtio-dev] Re: [PATCH v2 2/2] crypto: add virtio-crypto driver

> > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Monday, November 28, 2016 1:09 PM > To: Gonglei (Arei) > Subject: Re: [virtio-dev] Re: [PATCH v2 2/2] crypto: add virtio-crypto driver > > On Mon, Nov 28, 2016 at 04:47:21AM +, Gonglei (Arei) wrote: > &g

RE: [virtio-dev] Re: [PATCH v2 2/2] crypto: add virtio-crypto driver

Hi Michael, > > Subject: [virtio-dev] Re: [PATCH v2 2/2] crypto: add virtio-crypto driver > > On Tue, Nov 22, 2016 at 04:10:23PM +0800, Gonglei wrote: > > This patch introduces virtio-crypto driver for Linux Kernel. > > > > The virtio crypto device is a virtual cryptography device > > as well as

RE: [virtio-dev] Re: [PATCH v2 1/2] virtio: introduce little edian functions for virtio_cread/write# family

> > Subject: Re: [virtio-dev] Re: [PATCH v2 1/2] virtio: introduce little edian > functions for virtio_cread/write# family > > On Mon, Nov 28, 2016 at 04:34:56AM +0200, Michael S. Tsirkin wrote: > > On Mon, Nov 28, 2016 at 01:56:04AM +, Gonglei (Arei) wr

RE: [virtio-dev] Re: [PATCH v2 1/2] virtio: introduce little edian functions for virtio_cread/write# family

> > Subject: Re: [virtio-dev] Re: [PATCH v2 1/2] virtio: introduce little edian > functions for virtio_cread/write# family > > On Mon, Nov 28, 2016 at 01:56:04AM +, Gonglei (Arei) wrote: > > Hi Michael, > > > > Thanks for your feedback firstly! > > >

RE: [virtio-dev] Re: [PATCH v2 1/2] virtio: introduce little edian functions for virtio_cread/write# family

Hi Michael, Thanks for your feedback firstly! > -Original Message- > From: virtio-...@lists.oasis-open.org [mailto:virtio-...@lists.oasis-open.org] > On Behalf Of Michael S. Tsirkin > Sent: Sunday, November 27, 2016 11:33 AM > To: Gonglei (Arei) > Subject: [virtio-dev]

RE: [PATCH v2 0/2] virtio-crypto: add Linux driver

Hi, > -Original Message- > From: Gonglei (Arei) > Sent: Tuesday, November 22, 2016 4:10 PM > To: linux-ker...@vger.kernel.org; qemu-de...@nongnu.org; > virtio-...@lists.oasis-open.org; virtualizat...@lists.linux-foundation.org; > linux-crypto@vger.kernel.org > S

RE: [PATCH] crypto: add virtio-crypto driver

Hi Michael, May I should convert all __virtio32/64 to le32/64 in virtio_crypto.h ? > +#define VIRTIO_CRYPTO_OPCODE(service, op) (((service) << 8) | (op)) > + > +struct virtio_crypto_ctrl_header { > +#define VIRTIO_CRYPTO_CIPHER_CREATE_SESSION \ > +