Re: [PATCH] mac80211: aead api to reduce redundancy

2017-09-24 11:05 GMT-04:00 Johannes Berg : > On Sun, 2017-09-24 at 01:40 -0400, Xiang Gao wrote: >> Currently, the aes_ccm.c and aes_gcm.c are almost line by line >> copy of each other. This patch reduce code redundancy by moving >> the code in these two files to

Re: [PATCH] mac80211: aead api to reduce redundancy

On Sun, 2017-09-24 at 13:21 -0400, Xiang Gao wrote: > > Do you mean to put more characters each line in the description > Huh, sorry, no - my bad. I was thinking of the code, not the description at all. For example here: > -int ieee80211_aes_gcm_encrypt(struct crypto_aead *tfm, u8 *j_0, u8

Re: [PATCH] mac80211: aead api to reduce redundancy

2017-09-24 13:42 GMT-04:00 Johannes Berg : > On Sun, 2017-09-24 at 13:21 -0400, Xiang Gao wrote: >> >> Do you mean to put more characters each line in the description >> > Huh, sorry, no - my bad. I was thinking of the code, not the > description at all. Oh yes, these

[PATCH 4.9 27/77] [PATCH - RESEND] crypto: AF_ALG - remove SGL terminator indicator when chaining

4.9-stable review patch. If anyone has any objections, please let me know. -- From: Stephan Mueller Fixed differently upstream as commit 2d97591ef43d ("crypto: af_alg - consolidation of duplicate code") The SGL is MAX_SGL_ENTS + 1 in size. The last SG

[PATCH 4.13 034/109] [PATCH - RESEND] crypto: AF_ALG - remove SGL terminator indicator when chaining

4.13-stable review patch. If anyone has any objections, please let me know. -- From: Stephan Mueller Fixed differently upstream as commit 2d97591ef43d ("crypto: af_alg - consolidation of duplicate code") The SGL is MAX_SGL_ENTS + 1 in size. The last SG

Re: [RFC PATCH 0/2] let the crypto subsystem generate the ecc privkey

Hi Tudor, > That Bluetooth SMP knows about the private key is pointless, since the > detection of debug key usage is actually via the public key portion. > With this patch set, the Bluetooth SMP will stop keeping a copy of the > ecdh private key, except when using debug keys. This way we let the

[PATCH 3.18 11/42] [PATCH - RESEND] crypto: AF_ALG - remove SGL terminator indicator when chaining

3.18-stable review patch. If anyone has any objections, please let me know. -- From: Stephan Mueller Fixed differently upstream as commit 2d97591ef43d ("crypto: af_alg - consolidation of duplicate code") The SGL is MAX_SGL_ENTS + 1 in size. The last SG

[PATCH 4.4 27/66] [PATCH - RESEND] crypto: AF_ALG - remove SGL terminator indicator when chaining

4.4-stable review patch. If anyone has any objections, please let me know. -- From: Stephan Mueller Fixed differently upstream as commit 2d97591ef43d ("crypto: af_alg - consolidation of duplicate code") The SGL is MAX_SGL_ENTS + 1 in size. The last SG

Re: [PATCH 0/2] fix authenc() kernel crash

Am Sonntag, 24. September 2017, 08:22:54 CEST schrieb Stephan Müller: Hi Herbert, (private) > Hi Herbert, > > The two patches together fix a kernel crash that can be triggered via > AF_ALG when using authenc() with zero plaintext. > > The changes are also tested to verify that the hashing on

Re: [PATCH] staging:ccree Fix avoid externs in .c files

On Thu, Sep 21, 2017 at 9:43 AM, Janani Sankara Babu wrote: > This patch solves the warning shown by the checkpatch script > WARNING: externs should be avoided in .c files I'm afraid here too the feedback is the same - you are working on the Linus master tree, therefore you

[PATCH 2/2] crypto: shash - no kmap of zero SG

In case the caller provides an SG with zero data, prevent a kmap of the page pointed to by the SG. In this case, it is possible that the page does not exist. This fixes a crash in authenc() when the plaintext is zero and thus the encryption operation is a noop. In this case, no input data exists

[PATCH 0/2] fix authenc() kernel crash

Hi Herbert, The two patches together fix a kernel crash that can be triggered via AF_ALG when using authenc() with zero plaintext. The changes are also tested to verify that the hashing on null data is still supported. I suspect that the vulnerability fixed with patch 1 is present in abklcipher

Re: [PATCH] mac80211: aead api to reduce redundancy

On Sun, 2017-09-24 at 01:40 -0400, Xiang Gao wrote: > Currently, the aes_ccm.c and aes_gcm.c are almost line by line > copy of each other. This patch reduce code redundancy by moving > the code in these two files to crypto/aead_api.c to make it a > higher level aead api. The aes_ccm.c and

Re: [PATCH] staging:ccree Fix use BIT macro

Hi Janani, On Thu, Sep 21, 2017 at 9:39 AM, Janani Sankara Babu wrote: > This patch is created to solve the following warning shown by the checkpatch > script Warning: Replace all occurences of (1< > Signed-off-by: Janani Sankara Babu

Re: [PATCH] mac80211: aead api to reduce redundancy

On Mon, 2017-09-25 at 12:56 +0800, Herbert Xu wrote: > On Sun, Sep 24, 2017 at 07:42:46PM +0200, Johannes Berg wrote: > > > > Unrelated to this, I'm not sure whose tree this should go through - > > probably Herbert's (or DaveM's with his ACK? not sure if there's a > > crypto tree?) or so? > >

Re: [PATCH] mac80211: aead api to reduce redundancy

On Sun, Sep 24, 2017 at 07:42:46PM +0200, Johannes Berg wrote: > > Unrelated to this, I'm not sure whose tree this should go through - > probably Herbert's (or DaveM's with his ACK? not sure if there's a > crypto tree?) or so? Since you're just rearranging code invoking the crypto API, rather