Re: [PATCH v2] crypto: caam - fix sg dump

2016-09-22 Thread Horia Geanta Neag
On 9/22/2016 1:55 PM, Herbert Xu wrote: > Horia Geanta Neag wrote: >> >>> + >>> +static void dbg_dump_sg(const char *level, const char *prefix_str, >>> + int prefix_type, int rowsize, int groupsize, >>> +st

Re: [PATCH] crypto: caam - fix dbg_dump_sg() style issues

2016-09-22 Thread Horia Geanta Neag
On 9/22/2016 1:58 PM, Catalin Vasile wrote: > Signed-off-by: Catalin Vasile Reviewed-by: Horia Geantă -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.htm

Re: [PATCH] crypto: caam - fix dbg_dump_sg() style issues

2016-09-22 Thread Horia Geanta Neag
On 9/22/2016 2:42 PM, Horia Geanta Neag wrote: > On 9/22/2016 1:58 PM, Catalin Vasile wrote: >> Signed-off-by: Catalin Vasile > Reviewed-by: Horia Geantă Actually please fix also the warning reported by kbuild test robot in dbg_dump_sg: s/min(x, y)/min_t(size_t, x, y) Horia -- To

Re: [PATCH] crypto: caam: add support for iMX6UL

2016-10-06 Thread Horia Geanta Neag
On 10/4/2016 10:33 AM, Marcus Folkesson wrote: > i.MX6UL does only require three clocks to enable CAAM module. > > Signed-off-by: Marcus Folkesson Reviewed-by: Horia Geantă Thanks, Horia -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majo

Re: [PATCH] crypto: caam: fix type mismatch warning

2016-10-25 Thread Horia Geanta Neag
On 10/26/2016 12:29 AM, Arnd Bergmann wrote: > Building the caam driver on arm64 produces a harmless warning: > > drivers/crypto/caam/caamalg.c:140:139: warning: comparison of distinct > pointer types lacks a cast > > We can use min_t to tell the compiler which type we want it to use > here. >

Re: ahash and crc32c

2016-10-28 Thread Horia Geanta Neag
On 2/26/2013 7:11 PM, Zeev Zilberman wrote: > Hi, > > I'm working on an ahash driver that supports CRC32C. > I saw that all existing CRC32C implementations (except blackfin) are > implementing shash interface, but ahash seems to be the correct choice > in our case. > On the other hand I saw that C

Re: [PATCH v2] crypto: mxs-dcp - Remove hash support

2016-10-28 Thread Horia Geanta Neag
On 10/25/2016 12:33 AM, Fabio Estevam wrote: > On Mon, Oct 24, 2016 at 6:39 PM, Marek Vasut wrote: > >> Can't you rather fix it? > > I would love to have this fixed, but I don't know how. Looking on the i.MX6 Solo Lite security manual, the fix seems to consist in enabling context switching - i.

Re: [PATCH] crypto: caam: do not register AES-XTS mode on LP units

2016-11-07 Thread Horia Geanta Neag
On 11/5/2016 1:17 AM, Sven Ebenfeld wrote: > When using AES-XTS on a Wandboard, we receive a Mode error: > caam_jr 2102000.jr1: 20001311: CCB: desc idx 19: AES: Mode error. > > Due to the Security Reference Manual, the Low Power AES units s/Due to/According to > of the i.MX6 do not support the XT

Re: [PATCH 1/6] crypto-caamhash: Use kmalloc_array() in ahash_setkey()

2016-09-15 Thread Horia Geanta Neag
On 9/15/2016 5:43 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 15 Sep 2016 11:20:09 +0200 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_a

Re: crypto-caamhash: Fine-tuning for several function implementations

2016-09-15 Thread Horia Geanta Neag
On 9/15/2016 5:37 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 15 Sep 2016 16:27:23 +0200 > > Some update suggestions were taken into account > from static source code analysis. > > Markus Elfring (6): > Use kmalloc_array() in ahash_setkey() > Rename jump labels in ahash_

Re: [PATCH] crypto: caam - fix sg dump

2016-09-16 Thread Horia Geanta Neag
On 9/16/2016 12:06 PM, Catalin Vasile wrote: > Ensure scatterlists have a virtual memory mapping before dumping. > > Signed-off-by: Catalin Vasile > --- > drivers/crypto/caam/caamalg.c | 65 > +-- > 1 file changed, 50 insertions(+), 15 deletions(-) > > d

Re: [PATCH v2] crypto: caam - fix sg dump

2016-09-22 Thread Horia Geanta Neag
On 9/22/2016 11:58 AM, Catalin Vasile wrote: > Ensure scatterlists have a virtual memory mapping before dumping. > > Signed-off-by: Catalin Vasile > --- > Changes: > V2: > * resolved issue of sleeping in atomic contexts > --- > --- > drivers/crypto/caam/caamalg.c | 79 >