Re: [PATCH V3 2/6] hwmon: Add support for RPi voltage sensor

odifications to the downstream firmware driver. In case of > an undervoltage condition only an entry is written to the kernel log. > > CC: "Noralf Trønnes" <nor...@tronnes.org> > Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> Acked-by: Guenter Roeck <li...

Re: [PATCH RFC V2 2/6] hwmon: Add support for RPi voltage sensor

On Wed, May 23, 2018 at 01:12:10PM +0100, Robin Murphy wrote: > On 22/05/18 20:31, Stefan Wahren wrote: > [...] > >+static int rpi_hwmon_probe(struct platform_device *pdev) > >+{ > >+struct device *dev = >dev; > >+struct rpi_hwmon_data *data; > >+int

Re: [PATCH RFC V2 2/6] hwmon: Add support for RPi voltage sensor

On 05/22/2018 06:51 AM, Stefan Wahren wrote: Hi Guenter, Guenter Roeck <li...@roeck-us.net> hat am 22. Mai 2018 um 15:41 geschrieben: On 05/22/2018 04:21 AM, Stefan Wahren wrote: Currently there is no easy way to detect undervoltage conditions on a remote Raspberry Pi. This hwmon

Re: [PATCH RFC V2 2/6] hwmon: Add support for RPi voltage sensor

On 05/22/2018 04:21 AM, Stefan Wahren wrote: Currently there is no easy way to detect undervoltage conditions on a remote Raspberry Pi. This hwmon driver retrieves the state of the undervoltage sensor via mailbox interface. The handling based on Noralf's modifications to the downstream firmware

Re: [PATCH v3 09/10] drivers/hwmon: Add PECI hwmon client drivers

On Thu, Apr 12, 2018 at 10:09:51AM -0700, Jae Hyun Yoo wrote: [ ... ] > >>+static int find_core_index(struct peci_cputemp *priv, int channel) > >>+{ > >>+    int core_channel = channel - DEFAULT_CHANNEL_NUMS; > >>+    int idx, found = 0; > >>+ > >>+    for (idx = 0; idx <

Re: [PATCH v3 09/10] drivers/hwmon: Add PECI hwmon client drivers

On 04/11/2018 07:51 PM, Jae Hyun Yoo wrote: On 4/11/2018 5:34 PM, Guenter Roeck wrote: On 04/11/2018 02:59 PM, Jae Hyun Yoo wrote: Hi Guenter, Thanks a lot for sharing your time. Please see my inline answers. On 4/10/2018 3:28 PM, Guenter Roeck wrote: On Tue, Apr 10, 2018 at 11:32:11AM

Re: [PATCH v3 09/10] drivers/hwmon: Add PECI hwmon client drivers

On 04/11/2018 02:59 PM, Jae Hyun Yoo wrote: Hi Guenter, Thanks a lot for sharing your time. Please see my inline answers. On 4/10/2018 3:28 PM, Guenter Roeck wrote: On Tue, Apr 10, 2018 at 11:32:11AM -0700, Jae Hyun Yoo wrote: This commit adds PECI cputemp and dimmtemp hwmon drivers. Signed

Re: [PATCH v3 09/10] drivers/hwmon: Add PECI hwmon client drivers

el.com> > Cc: Arnd Bergmann <a...@arndb.de> > Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org> > Cc: Fengguang Wu <fengguang...@intel.com> > Cc: Greg KH <gre...@linuxfoundation.org> > Cc: Guenter Roeck <li...@roeck-us.net> > Cc: Jason M Biils <

Re: [PATCH V2 3/9] dt-bindings: Tegra186 tachometer device tree bindings

On 04/10/2018 06:30 AM, Rob Herring wrote: On Mon, Apr 9, 2018 at 9:37 AM, Mikko Perttunen wrote: On 04/09/2018 04:21 PM, Rob Herring wrote: On Mon, Apr 9, 2018 at 12:38 AM, Mikko Perttunen wrote: Rob, Please don't top post to lists. this binding

Re: [PATCH V2 7/9] hwmon: pwm-fan: add sysfs node to read rpm of fan

On 03/20/2018 09:40 PM, Rajkumar Rampelli wrote: Add fan device attribute fan1_input in pwm-fan driver to read speed of fan in rotations per minute. Signed-off-by: Rajkumar Rampelli --- V2: Removed generic-pwm-tachometer driver and using pwm-fan driver as per suggestions

Re: [PATCH 31/47] watchdog: remove bfin_wdt driver

On Wed, Mar 14, 2018 at 04:35:44PM +0100, Arnd Bergmann wrote: > The blackfin architecture is getting removed, so this driver has > become obsolete. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Guenter Roeck <li...@roeck-us.net> > --- > D

Re: [PATCH 05/10] hwmon: generic-pwm-tachometer: Add generic PWM based tachometer

On 03/07/2018 11:57 PM, Mikko Perttunen wrote: On 07.03.2018 16:20, Guenter Roeck wrote: On 03/07/2018 01:47 AM, Rajkumar Rampelli wrote: On Wednesday 28 February 2018 07:59 PM, Guenter Roeck wrote: On 02/27/2018 11:03 PM, Mikko Perttunen wrote: On 02/28/2018 08:12 AM, Rajkumar Rampelli

Re: [PATCH 05/10] hwmon: generic-pwm-tachometer: Add generic PWM based tachometer

On 03/07/2018 10:06 PM, Laxman Dewangan wrote: On Wednesday 07 March 2018 07:50 PM, Guenter Roeck wrote: On 03/07/2018 01:47 AM, Rajkumar Rampelli wrote: While I am not opposed to ABI changes, the merits of those would need to be discussed on the mailing list. But replacing "fan1_

Re: [PATCH 05/10] hwmon: generic-pwm-tachometer: Add generic PWM based tachometer

On 03/07/2018 01:47 AM, Rajkumar Rampelli wrote: On Wednesday 28 February 2018 07:59 PM, Guenter Roeck wrote: On 02/27/2018 11:03 PM, Mikko Perttunen wrote: On 02/28/2018 08:12 AM, Rajkumar Rampelli wrote: On Wednesday 28 February 2018 11:28 AM, Guenter Roeck wrote: On 02/27/2018 09:38 PM

Re: [PATCH 05/10] hwmon: generic-pwm-tachometer: Add generic PWM based tachometer

On 02/27/2018 11:03 PM, Mikko Perttunen wrote: On 02/28/2018 08:12 AM, Rajkumar Rampelli wrote: On Wednesday 28 February 2018 11:28 AM, Guenter Roeck wrote: On 02/27/2018 09:38 PM, Rajkumar Rampelli wrote: On Wednesday 21 February 2018 08:20 PM, Guenter Roeck wrote: On 02/20/2018 10:58 PM

Re: [PATCH 05/10] hwmon: generic-pwm-tachometer: Add generic PWM based tachometer

On 02/27/2018 09:38 PM, Rajkumar Rampelli wrote: On Wednesday 21 February 2018 08:20 PM, Guenter Roeck wrote: On 02/20/2018 10:58 PM, Rajkumar Rampelli wrote: Add generic PWM based tachometer driver via HWMON interface to report the RPM of motor. This drivers get the period/duty cycle from

Re: [v2, 7/7] tty: serial: msm_geni_serial: Add serial driver support for GENI based QUP

On Fri, Jan 12, 2018 at 06:05:47PM -0700, Karthikeyan Ramasubramanian wrote: > This driver supports GENI based UART Controller in the Qualcomm SOCs. The > Qualcomm Generic Interface (GENI) is a programmable module supporting a > wide range of serial interfaces including UART. This driver support

Re: [PATCH v2 7/8] [PATCH 7/8] drivers/hwmon: Add a generic PECI hwmon client driver

On Wed, Feb 21, 2018 at 08:16:05AM -0800, Jae Hyun Yoo wrote: > This commit adds a generic PECI hwmon client driver implementation. > > Signed-off-by: Jae Hyun Yoo > --- > drivers/hwmon/Kconfig | 10 + > drivers/hwmon/Makefile | 1 + >

Re: [PATCH v2 7/8] [PATCH 7/8] drivers/hwmon: Add a generic PECI hwmon client driver

On Wed, Feb 21, 2018 at 01:24:48PM -0800, Jae Hyun Yoo wrote: > Hi Guenter, > > Thanks for sharing your time to review this code. Please check my answers > inline. > > On 2/21/2018 10:26 AM, Guenter Roeck wrote: > >On Wed, Feb 21, 2018 at 08:16:05AM -0800, Jae Hyun Yo

Re: [PATCH 05/10] hwmon: generic-pwm-tachometer: Add generic PWM based tachometer

On Wed, Feb 21, 2018 at 05:20:29PM +0200, Mikko Perttunen wrote: > On 21.02.2018 16:46, Guenter Roeck wrote: > >On 02/20/2018 11:15 PM, Mikko Perttunen wrote: > >>AIUI, the PWM framework already exposes a sysfs node with period > >>information. We should just use t

Re: [PATCH 05/10] hwmon: generic-pwm-tachometer: Add generic PWM based tachometer

On 02/20/2018 10:58 PM, Rajkumar Rampelli wrote: Add generic PWM based tachometer driver via HWMON interface to report the RPM of motor. This drivers get the period/duty cycle from PWM IP which captures the motor PWM output. This driver implements a simple interface for monitoring the speed of

Re: [PATCH 05/10] hwmon: generic-pwm-tachometer: Add generic PWM based tachometer

On 02/20/2018 11:15 PM, Mikko Perttunen wrote: AIUI, the PWM framework already exposes a sysfs node with period information. We should just use that instead of adding a new driver for this. I am kind of lost. Please explain. Are you saying that we should drop the pwm-fan driver as well

Re: [PATCH 2/3] documentation: watchdog: remove documentation for ixp2000

;cla...@baylibre.com> Reviewed-by: Guenter Roeck <li...@roeck-us.net> > --- > Documentation/watchdog/watchdog-parameters.txt | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/Documentation/watchdog/watchdog-parameters.txt > b/Documentation/watchdog/watchdo

Re: [PATCH 1/3] documentation: watchdog: remove documentation of at32ap700x_wdt

On Thu, Feb 01, 2018 at 08:44:10PM +, Corentin Labbe wrote: > Since at32ap700x_wdt is gone, no need to keep its documentation > > Signed-off-by: Corentin Labbe <cla...@baylibre.com> Reviewed-by: Guenter Roeck <li...@roeck-us.net> > --- > Documentation/watchdog/

Re: [linux, dev-4.10, 6/6] drivers/hwmon: Add a driver for a generic PECI hwmon

On Thu, Jan 11, 2018 at 11:47:01AM -0800, Jae Hyun Yoo wrote: > On 1/10/2018 1:47 PM, Guenter Roeck wrote: > >On Tue, Jan 09, 2018 at 02:31:26PM -0800, Jae Hyun Yoo wrote: > >>This commit adds driver implementation for a generic PECI hwmon. > >> > >>S

Re: [linux, dev-4.10, 6/6] drivers/hwmon: Add a driver for a generic PECI hwmon

On Tue, Jan 09, 2018 at 02:31:26PM -0800, Jae Hyun Yoo wrote: > This commit adds driver implementation for a generic PECI hwmon. > > Signed-off-by: Jae Hyun Yoo > --- > drivers/hwmon/Kconfig | 6 + > drivers/hwmon/Makefile | 1 + >

Re: [v6,4/4] pmbus (max31785): Add dual tachometer support

On Mon, Nov 20, 2017 at 03:12:06PM +1030, Andrew Jeffery wrote: > The dual tachometer feature is implemented in hardware with a TACHSEL > input to indicate the rotor under measurement, and exposed on the device > by extending the READ_FAN_SPEED_1 word with two extra bytes*. The need > to read the

Re: [v6,3/4] pmbus (core): Add virtual page config bit

On Mon, Nov 20, 2017 at 03:12:05PM +1030, Andrew Jeffery wrote: > Some circumstances call for virtual pages, to expose multiple values > packed into an extended PMBus register in a manner non-compliant with > the PMBus standard. An example of this is the Maxim MAX31785 controller, > which extends

Re: [v6,2/4] pmbus (max31785): Add fan control

On Mon, Nov 20, 2017 at 03:12:04PM +1030, Andrew Jeffery wrote: > The implementation makes use of the new fan control virtual registers > exposed by the pmbus core. It mixes use of the default implementations > with some overrides via the read/write handlers to handle FAN_COMMAND_1 > on the

Re: [v6,1/4] pmbus (core): Add fan control support

On Mon, Nov 20, 2017 at 03:12:03PM +1030, Andrew Jeffery wrote: > Expose fanX_target, pwmX and pwmX_enable hwmon sysfs attributes. > > Fans in a PMBus device are driven by the configuration of two registers, > FAN_CONFIG_x_y and FAN_COMMAND_x: FAN_CONFIG_x_y dictates how the fan > and the tacho

Re: [PATCH 1/2] watchdog: introduce watchdog.open_timeout commandline parameter

On Wed, Nov 29, 2017 at 11:56:57AM +0100, Rasmus Villemoes wrote: > On 2017-11-28 23:14, Guenter Roeck wrote: > > On Tue, Nov 28, 2017 at 11:35:49AM +0100, Rasmus Villemoes wrote: > >> > >> The unit is milliseconds rather than seconds because that covers more > >

Re: [PATCH 1/2] watchdog: introduce watchdog.open_timeout commandline parameter

On Tue, Nov 28, 2017 at 11:35:49AM +0100, Rasmus Villemoes wrote: > The watchdog framework takes care of feeding a hardware watchdog until > userspace opens /dev/watchdogN. If that never happens for some reason > (buggy init script, corrupt root filesystem or whatnot) but the kernel > itself is

Re: [v3,10/12] hwmon (occ): Add non-hwmon attributes

On Mon, Nov 20, 2017 at 05:53:39PM -0600, eaja...@linux.vnet.ibm.com wrote: > From: "Edward A. James" > > Create device attributes for additional OCC properties that do not > belong as hwmon sensors. These provide additional information as to the > state of the processor and

Re: [v3, 09/12] hwmon (occ): Add sensor attributes and register hwmon device

On Mon, Nov 20, 2017 at 05:53:38PM -0600, eaja...@linux.vnet.ibm.com wrote: > From: "Edward A. James" > > Setup the sensor attributes for every OCC sensor found by the first poll > response. Register the attributes with hwmon. Add hwmon documentation > for the driver. > >

Re: [v3, 02/12] Documentation: ABI: Add occ-hwmon driver sysfs documentation

On Mon, Nov 20, 2017 at 05:53:31PM -0600, eaja...@linux.vnet.ibm.com wrote: > From: "Edward A. James" > > Detail the sysfs attributes provided by the occ-hwmon driver. > This describes my problem with this driver: All the sysfs attributes described here are not really

Re: [PATCH v5 3/4] pmbus (core): Add virtual page config bit

On 11/17/2017 07:26 PM, Andrew Jeffery wrote: Some circumstances call for virtual pages, to expose multiple values packed into an extended PMBus register in a manner non-compliant with the PMBus standard. An example of this is the Maxim MAX31785 controller, which extends the READ_FAN_SPEED_1

Re: [v4,3/6] pmbus: core: Add fan control support

On 11/09/2017 07:03 PM, Andrew Jeffery wrote: On Sun, 2017-11-05 at 06:39 -0800, Guenter Roeck wrote: On Fri, Nov 03, 2017 at 03:53:03PM +1100, Andrew Jeffery wrote: Expose fanX_target, pwmX and pwmX_enable hwmon sysfs attributes. Fans in a PMBus device are driven by the configuration of two

Re: [v4,4/6] pmbus: max31785: Add fan control

On 11/09/2017 07:10 PM, Andrew Jeffery wrote: On Sun, 2017-11-05 at 07:04 -0800, Guenter Roeck wrote: On Fri, Nov 03, 2017 at 03:53:04PM +1100, Andrew Jeffery wrote: The implementation makes use of the new fan control virtual registers exposed by the pmbus core. It mixes use of the default

Re: [v4,1/6] dt-bindings: pmbus: Add Maxim MAX31785 documentation

On Fri, Nov 03, 2017 at 03:53:01PM +1100, Andrew Jeffery wrote: > Signed-off-by: Andrew Jeffery > Acked-by: Rob Herring Applied to hwmon-next. Thanks, Guenter > --- > .../devicetree/bindings/hwmon/max31785.txt | 22 > ++ > 1 file

Re: [v4,6/6] pmbus: max31785: Add dual tachometer support

On Fri, Nov 03, 2017 at 03:53:06PM +1100, Andrew Jeffery wrote: > The dual tachometer feature is implemented in hardware with a TACHSEL > input to indicate the rotor under measurement, and exposed on the device > by extending the READ_FAN_SPEED_1 word with two extra bytes*. The need > to read the

Re: [v4,3/6] pmbus: core: Add fan control support

On Fri, Nov 03, 2017 at 03:53:03PM +1100, Andrew Jeffery wrote: > Expose fanX_target, pwmX and pwmX_enable hwmon sysfs attributes. > > Fans in a PMBus device are driven by the configuration of two registers: > FAN_CONFIG_x_y and FAN_COMMAND_x: FAN_CONFIG_x_y dictates how the fan > and the tacho

Re: [v4, 2/6] pmbus: Add driver for Maxim MAX31785 Intelligent Fan Controller

On Fri, Nov 03, 2017 at 03:53:02PM +1100, Andrew Jeffery wrote: > The Maxim MAX31785 is a PMBus device providing closed-loop, multi-channel fan > management with temperature and remote voltage sensing. Various fan control > features are provided, including PWM frequency control, temperature >

Re: [7/8] Documentation: fix selftests related file refs

at should have been a Reviewed-by: for the hpwdt code. Otherwise Reviewed-by: Guenter Roeck <li...@roeck-us.net> > --- > Documentation/filesystems/dnotify.txt| 2 +- > Documentation/watchdog/hpwdt.txt | 2 +- > Documentation/watchdog/pcwd-watchdog.txt | 2 +-

Re: [PATCH v2 3/4] dt-bindings: hwmon: Add ti-max-expected-current-microamp property to ina2xx

On Tue, Oct 17, 2017 at 03:36:31PM -0500, Rob Herring wrote: > On Thu, Oct 12, 2017 at 02:36:04PM +0200, Maciej Purski wrote: > > Add optional max expected current property which allows calibrating > > the ina sensor in order to achieve requested measure scale. Document > > the changes in

Re: [PATCH v2 3/4] dt-bindings: hwmon: Add ti-max-expected-current-microamp property to ina2xx

On 10/12/2017 06:00 AM, Maciej Purski wrote: On 10/12/2017 02:39 PM, Krzysztof Kozlowski wrote: On Thu, Oct 12, 2017 at 2:36 PM, Maciej Purski wrote: Add optional max expected current property which allows calibrating the ina sensor in order to achieve requested

Re: [PATCH v2 0/2] kbuild: Cache exploratory calls to the compiler

ra testing. I've tested it on a very > limited build environment and it seems to be working fine, but I > could believe that with some weird compiler options or on certain > architectures you might need some extra escaping here and there. > Not being a makefile expert, I can't s

Re: [PATCH 2/4] hwmon: (ina2xx) Make max expected current configurable

On 09/28/2017 05:50 AM, Maciej Purski wrote: Max expected current is used for calculating calibration register value, Current LSB and Power LSB according to equations found in ina datasheet. Max expected current is now implicitly set to default value, which is 2^15, thanks to which Current LSB

Re: [PATCH] hwmon: pmbus: Make reg check and clear faults functions return errors

On 09/07/2017 08:40 PM, Andrew Jeffery wrote: On Fri, 2017-09-08 at 12:51 +1000, Andrew Jeffery wrote: I can't test with devicetree. x86 system. 2,100+ iterations with your driver, no failures. Great. I really appreciate your testing here, so thanks for your efforts. I owe you a few drinks

Re: [PATCH] hwmon: pmbus: Make reg check and clear faults functions return errors

On 09/07/2017 08:40 PM, Andrew Jeffery wrote: On Fri, 2017-09-08 at 12:51 +1000, Andrew Jeffery wrote: I can't test with devicetree. x86 system. 2,100+ iterations with your driver, no failures. Great. I really appreciate your testing here, so thanks for your efforts. I owe you a few drinks

Re: [PATCH] hwmon: pmbus: Make reg check and clear faults functions return errors

On 09/07/2017 07:06 PM, Andrew Jeffery wrote: On Thu, 2017-09-07 at 18:26 -0700, Guenter Roeck wrote: On 09/07/2017 06:02 PM, Andrew Jeffery wrote: On Thu, 2017-09-07 at 17:27 -0700, Guenter Roeck wrote: On 09/07/2017 08:22 AM, Andrew Jeffery wrote: On Thu, 2017-09-07 at 06:40 -0700, Guenter

Re: [PATCH] hwmon: pmbus: Make reg check and clear faults functions return errors

On 09/07/2017 06:02 PM, Andrew Jeffery wrote: On Thu, 2017-09-07 at 17:27 -0700, Guenter Roeck wrote: On 09/07/2017 08:22 AM, Andrew Jeffery wrote: On Thu, 2017-09-07 at 06:40 -0700, Guenter Roeck wrote: On 09/06/2017 04:32 PM, Andrew Jeffery wrote: Guess I need to dig up my eval board

Re: [PATCH] hwmon: pmbus: Make reg check and clear faults functions return errors

On 09/07/2017 08:22 AM, Andrew Jeffery wrote: On Thu, 2017-09-07 at 06:40 -0700, Guenter Roeck wrote: On 09/06/2017 04:32 PM, Andrew Jeffery wrote: Guess I need to dig up my eval board and see if I can reproduce the problem. Seems you are saying that the problem is always seen when

Re: [PATCH] hwmon: pmbus: Make reg check and clear faults functions return errors

On 09/06/2017 04:32 PM, Andrew Jeffery wrote: Guess I need to dig up my eval board and see if I can reproduce the problem. Seems you are saying that the problem is always seen when issuing a sequence of "clear faults" commands on multiple pages ? Yeah. We're also seeing bad behaviour under

Re: [PATCH] hwmon: pmbus: Make reg check and clear faults functions return errors

On 09/06/2017 04:32 PM, Andrew Jeffery wrote: On Wed, 2017-09-06 at 15:51 -0700, Guenter Roeck wrote: On Wed, Sep 06, 2017 at 10:23:37AM +1000, Andrew Jeffery wrote: On Tue, 2017-09-05 at 10:00 -0700, Guenter Roeck wrote: On Tue, Sep 05, 2017 at 05:01:32PM +1000, Andrew Jeffery wrote: Some

Re: [PATCH] hwmon: pmbus: Make reg check and clear faults functions return errors

On Wed, Sep 06, 2017 at 10:23:37AM +1000, Andrew Jeffery wrote: > On Tue, 2017-09-05 at 10:00 -0700, Guenter Roeck wrote: > > On Tue, Sep 05, 2017 at 05:01:32PM +1000, Andrew Jeffery wrote: > > > Some functions exposed by pmbus core conflated errors that occurred when >

Re: [PATCH] hwmon: pmbus: Make reg check and clear faults functions return errors

On Tue, Sep 05, 2017 at 05:01:32PM +1000, Andrew Jeffery wrote: > Some functions exposed by pmbus core conflated errors that occurred when > setting the page to access with errors that occurred when accessing > registers in a page. In some cases, this caused legitimate errors to be > hidden under

Re: [PATCH 2/2] hwmon: (ucd9000) Add sysfs attribute to clear logged faults

On Wed, Aug 30, 2017 at 01:55:36PM -0500, Christopher Bostic wrote: > Add ability to clear logged faults via sysfs. > I am not in favor of such chip specific commands, in this case for several reasons (besides it being a non-standard attribute). The logged faults are not read or used by the

Re: [2/2] hwmon: (pmbus/lm25066) Add support for TI LM5066I

Datasheet: > http://www.national.com/pf/LM/LM5066.html > + * Texas Instruments LM5066I > +Prefix: 'lm5066i' > +Addresses scanned: - > + Datasheet: > +http://www.ti.com/product/LM5066I > > Author: Guenter Roeck <li...@roeck-us.net> > > @@ -37,8

Re: [1/2] hwmon: (pmbus/lm25066) Offset coefficient depends on CL

On Tue, Aug 29, 2017 at 02:21:16PM -0700, Xo Wang wrote: > When converting the DIRECT format CURRENT_IN and POWER commands, make > the offset coefficient ("b") predicate on the value of the current limit > setting. > > Signed-off-by: Xo Wang Applied to hwmon-next. Thanks,

Re: [PATCH v3 3/3] Documentation: hwmon: Document the IBM CFF power supply

On Mon, Aug 14, 2017 at 02:26:20PM -0500, Eddie James wrote: > > > On 08/14/2017 01:53 PM, Guenter Roeck wrote: > >On Mon, Aug 14, 2017 at 10:26:30AM -0500, Eddie James wrote: > >>From: "Edward A. James" <eaja...@us.ibm.com> > >> >

Re: [PATCH v3 3/3] Documentation: hwmon: Document the IBM CFF power supply

On Mon, Aug 14, 2017 at 10:26:30AM -0500, Eddie James wrote: > From: "Edward A. James" > > Signed-off-by: Edward A. James > --- > Documentation/hwmon/ibm-cffps | 54 > +++ > 1 file changed, 54 insertions(+) >

Re: [PATCH v2 2/3] hwmon: (pmbus): Add POWER system power supply driver

On Fri, Aug 11, 2017 at 09:30:59AM -0500, Eddie James wrote: > > > On 08/10/2017 08:18 PM, Guenter Roeck wrote: > >On Thu, Aug 10, 2017 at 05:19:45PM -0500, Eddie James wrote: > >>From: "Edward A. James" <eaja...@us.ibm.com> > >> > >

Re: [PATCH v2 3/3] Documentation: hwmon: Add POWER system power supply documentation

On Thu, Aug 10, 2017 at 05:19:46PM -0500, Eddie James wrote: > From: "Edward A. James" > > Signed-off-by: Edward A. James > --- > Documentation/hwmon/powerps | 54 > + > 1 file changed, 54 insertions(+) >

Re: [PATCH v2 2/3] hwmon: (pmbus): Add POWER system power supply driver

On Thu, Aug 10, 2017 at 05:19:45PM -0500, Eddie James wrote: > From: "Edward A. James" > > Add the driver to monitor POWER system power supplies with hwmon over > pmbus. > > Signed-off-by: Edward A. James > --- > drivers/hwmon/pmbus/Kconfig | 10 +++

Re: [v6,3/3] watchdog: introduce CONFIG_WATCHDOG_OPEN_TIMEOUT

On Tue, May 30, 2017 at 10:56:47AM +0200, Rasmus Villemoes wrote: > This allows setting a default value for the watchdog.open_timeout > commandline parameter via Kconfig. > > Some BSPs allow remote updating of the kernel image and root file > system, but updating the bootloader requires physical

Re: [v6, 2/3] watchdog: introduce watchdog.open_timeout commandline parameter

On Tue, May 30, 2017 at 10:56:46AM +0200, Rasmus Villemoes wrote: > The watchdog framework takes care of feeding a hardware watchdog until > userspace opens /dev/watchdogN. If that never happens for some reason > (buggy init script, corrupt root filesystem or whatnot) but the kernel > itself is

Re: [PATCH v3] hwmon: Add support for MAX31785 intelligent fan controller

On 06/08/2017 12:53 AM, Andrew Jeffery wrote: On Wed, 2017-06-07 at 08:55 -0700, Guenter Roeck wrote: On Tue, Jun 06, 2017 at 04:32:30PM +0930, Andrew Jeffery wrote: Add a basic driver for the MAX31785, focusing on the fan control features but ignoring the temperature and voltage monitoring

Re: [PATCH v3] hwmon: Add support for MAX31785 intelligent fan controller

On Wed, Jun 07, 2017 at 04:15:06PM +0930, Andrew Jeffery wrote: > On Wed, 2017-06-07 at 12:18 +0930, Joel Stanley wrote: > > On Wed, Jun 7, 2017 at 1:50 AM, Matthew Barth > > > <msba...@linux.vnet.ibm.com> wrote: > > > > > > On 06/06/17 8:33 AM, Guenter R

Re: [PATCH v3] hwmon: Add support for MAX31785 intelligent fan controller

On Tue, Jun 06, 2017 at 04:32:30PM +0930, Andrew Jeffery wrote: > Add a basic driver for the MAX31785, focusing on the fan control > features but ignoring the temperature and voltage monitoring > features of the device. > > This driver supports all fan control modes and tachometer / PWM >

Re: [PATCH v6 0/3] watchdog: allow setting deadline for opening /dev/watchdogN

On 06/06/2017 01:08 AM, Rasmus Villemoes wrote: On 2017-05-30 10:56, Rasmus Villemoes wrote: v6 tweaks the wording in watchdog-parameters.txt to avoid having to update it if and when the watchdog core grows new parameters. It also adds a little more rationale to the commit messages for 2/3 and

Re: [PATCH v3] hwmon: Add support for MAX31785 intelligent fan controller

On 06/06/2017 12:02 AM, Andrew Jeffery wrote: Add a basic driver for the MAX31785, focusing on the fan control features but ignoring the temperature and voltage monitoring features of the device. This driver supports all fan control modes and tachometer / PWM readback where applicable.

Re: [PATCH v5 2/3] watchdog: introduce watchdog.open_timeout commandline parameter

On 05/22/2017 07:06 AM, Rasmus Villemoes wrote: The watchdog framework takes care of feeding a hardware watchdog until userspace opens /dev/watchdogN. If that never happens for some reason (buggy init script, corrupt root filesystem or whatnot) but the kernel itself is fine, the machine stays up

Re: [PATCH v5 0/3] watchdog: allow setting deadline for opening /dev/watchdogN

On Mon, May 22, 2017 at 07:07:51PM +0100, Alan Cox wrote: > On Mon, 22 May 2017 16:06:36 +0200 > Rasmus Villemoes wrote: > > > If a watchdog driver tells the framework that the device is running, > > the framework takes care of feeding the watchdog until userspace

Re: [PATCH 0/5] hwmon: move include files out of include/linux/i2c

On 05/21/2017 01:34 PM, Wolfram Sang wrote: It doesn't make sense to use include/linux/i2c for client drivers which may in fact rather be hwmon or input or whatever devices. As a result, I want to deprecate include/linux/i2c for good. This series moves the include files to a better location,

Re: [PATCH v4 2/3] hwmon: (adt7475) temperature smoothing

On Tue, May 16, 2017 at 08:30:52PM +, Chris Packham wrote: > On 16/05/17 20:23, kbuild test robot wrote: > > Hi Chris, > > > > [auto build test ERROR on hwmon/hwmon-next] > > [also build test ERROR on v4.12-rc1 next-20170516] > > [if your patch is applied to the wrong git tree, please drop us

Re: [PATCH v4 2/3] hwmon: (adt7475) temperature smoothing

On 05/14/2017 06:30 PM, Chris Packham wrote: When enabled temperature smoothing allows ramping the fan speed over a configurable period of time instead of jumping to the new speed instantaneously. Signed-off-by: Chris Packham Applied to -next. --- Changes

Re: [PATCH v4 1/3] hwmon: (adt7475) fan stall prevention

On 05/14/2017 06:30 PM, Chris Packham wrote: By default adt7475 will stop the fans (pwm duty cycle 0%) when the temperature drops past Tmin - hysteresis. Some systems want to keep the fans moving even when the temperature drops so add new sysfs attributes that configure the enhanced acoustics

Re: [PATCH v3 3/4] hwmon: (adt7475) temperature smoothing

On 05/14/2017 02:23 PM, Chris Packham wrote: On 15/05/17 03:40, Guenter Roeck wrote: On 05/10/2017 08:45 PM, Chris Packham wrote: When enabled temperature smoothing allows ramping the fan speed over a configurable period of time instead of jumping to the new speed instantaneously. Signed-off

Re: [PATCH v3 2/4] hwmon: (adt7475) fan stall prevention

On 05/10/2017 08:45 PM, Chris Packham wrote: By default adt7475 will stop the fans (pwm duty cycle 0%) when the temperature drops past Tmin - hysteresis. Some systems want to keep the fans moving even when the temperature drops so add new sysfs attributes that configure the enhanced acoustics

Re: [RFC PATCH v2 3/3] hwmon: (adt7475) temperature smoothing

On Wed, May 03, 2017 at 12:40:09PM +1200, Chris Packham wrote: > When enabled temperature smoothing allows ramping the fan speed over a > configurable period of time instead of jumping to the new speed > instantaneously. > > Signed-off-by: Chris Packham > --- >

Re: [RFC PATCH v2 2/3] hwmon: (adt7475) fan stall prevention

On Wed, May 03, 2017 at 12:40:08PM +1200, Chris Packham wrote: > By default adt7475 will stop the fans (pwm duty cycle 0%) when the > temperature drops past Tmin - hysteresis. Some systems want to keep the > fans moving even when the temperature drops so add new sysfs attributes > that configure

Re: [RFC PATCH 3/3] hwmon: (adt7475) temperature smoothing

On Tue, May 02, 2017 at 05:45:36PM +1200, Chris Packham wrote: > When enabled temperature smoothing allows ramping the fan speed over a > configurable period of time instead of jumping to the new speed > instantaneously. > > Signed-off-by: Chris Packham > --- >

Re: [PATCH 2/3] hwmon: (adt7475) fan stall prevention

On Tue, May 02, 2017 at 05:45:35PM +1200, Chris Packham wrote: > By default adt7475 will stop the fans (pwm duty cycle 0%) when the > temperature drops past Tmin - hysteresis. Some systems want to keep the > fans moving even when the temperature drops so add new sysfs attributes > that configure

Re: [PATCH 2/2] devicetree: Document the max31760 device binding.

On Tue, Apr 11, 2017 at 06:47:28AM -0700, John Muir wrote: > > On Apr 10, 2017, at 8:42 AM, Rob Herring wrote: > > > > On Tue, Apr 04, 2017 at 12:20:34PM -0700, John Muir wrote: > >> +MAX31760 fan controller > >> +--- > >> + > >> +This device supports I2C

Re: [PATCH linux v6 2/2] drivers: hwmon: Support for ASPEED PWM/Fan tach

On 04/04/2017 05:55 AM, Guenter Roeck wrote: On 04/03/2017 04:30 PM, Jaghathiswari Rankappagounder Natarajan wrote: The ASPEED AST2400/2500 PWM controller supports 8 PWM output ports. The ASPEED AST2400/2500 Fan tach controller supports 16 tachometer inputs. The device driver matches

Re: [PATCH linux v6 2/2] drivers: hwmon: Support for ASPEED PWM/Fan tach

On 04/03/2017 04:30 PM, Jaghathiswari Rankappagounder Natarajan wrote: The ASPEED AST2400/2500 PWM controller supports 8 PWM output ports. The ASPEED AST2400/2500 Fan tach controller supports 16 tachometer inputs. The device driver matches on the device tree node. The configuration values are

Re: [PATCH linux v6 1/2] Documentation: dt-bindings: Document bindings for ASPEED AST2400/AST2500 PWM and Fan tach controller device driver

On 04/03/2017 04:30 PM, Jaghathiswari Rankappagounder Natarajan wrote: This binding provides interface for adding values related to ASPEED AST2400/2500 PWM and Fan tach controller support. The PWM controller can support upto 8 PWM output ports. The Fan tach controller can support upto 16

Re: [PATCH linux v9 2/5] hwmon: occ: Add sysfs interface

On 03/14/2017 01:55 PM, Eddie James wrote: From: "Edward A. James" Add a generic mechanism to expose the sensors provided by the OCC in sysfs. Signed-off-by: Edward A. James Signed-off-by: Andrew Jeffery --- Documentation/hwmon/occ

Re: [PATCH linux v5 2/2] drivers: hwmon: Support for ASPEED PWM/Fan tach

On 03/24/2017 11:17 AM, Jaghathiswari Rankappagounder Natarajan wrote: The ASPEED AST2400/2500 PWM controller supports 8 PWM output ports. The ASPEED AST2400/2500 Fan tach controller supports 16 tachometer inputs. The device driver matches on the device tree node. The configuration values are

Re: [RFC 2/2] hwmon: powernv: Hwmon driver for OCC inband power and temperature sensors

On 03/09/2017 05:30 AM, Shilpasri G Bhat wrote: Hi Guenter, On 03/09/2017 05:40 PM, Guenter Roeck wrote: On Thu, Mar 09, 2017 at 05:19:15PM +0530, Shilpasri G Bhat wrote: Add support to read power and temperature sensors from OCC inband sensors which are copied to main memory by OCC

Re: [PATCH linux v8 2/6] hwmon: occ: Add sysfs interface

On 02/14/2017 12:34 PM, Eddie James wrote: From: "Edward A. James" Add a generic mechanism to expose the sensors provided by the OCC in sysfs. Signed-off-by: Edward A. James Signed-off-by: Andrew Jeffery --- Documentation/hwmon/occ

Re: [RFC 2/2] hwmon: powernv: Hwmon driver for OCC inband power and temperature sensors

a reason to consider such an alternative ? Thanks, Guenter > Signed-off-by: Shilpasri G Bhat <shilpa.b...@linux.vnet.ibm.com> > CC: Rob Herring <robh...@kernel.org> > CC: Mark Rutland <mark.rutl...@arm.com> > CC: Jean Delvare <jdelv...@suse.com> > CC: Guenter Roeck

Re: [PATCH linux v8 0/6] drivers: hwmon: Add On-Chip Controller driver

On Thu, Feb 23, 2017 at 04:43:20PM -0600, Edward James wrote: > Hi Guenter, > > Any thoughts on this patch set? Others welcome to chime in too. > Sorry, I have been busy. Weekend or next week, hopefully. Guenter > Thanks, > Eddie > > Eddie James wrote on

Re: [PATCH] docs: hwmon: Fix typo "Microship" should be "Microchip"

On Tue, Feb 21, 2017 at 10:30:47PM +1300, Chris Packham wrote: > Signed-off-by: Chris Packham Applied to -next. Thanks, Guenter > --- > Documentation/hwmon/tc654 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH linux v7 4/6] hwmon: occ: Add callbacks for parsing P8 OCC datastructures

On Mon, Feb 13, 2017 at 11:47:22AM +1030, Andrew Jeffery wrote: > On Fri, 2017-02-10 at 16:01 +1030, Joel Stanley wrote: > > > On Wed, Feb 8, 2017 at 9:40 AM,   wrote: > > > > > From: "Edward A. James" > > > > > > Add functions to parse the data

Re: [PATCH linux v4 2/6] hwmon: occ: Add sysfs interface

On 01/26/2017 03:19 PM, eajames@gmail.com wrote: From: "Edward A. James" Add a generic mechanism to expose the sensors provided by the OCC in sysfs. Signed-off-by: Edward A. James Signed-off-by: Andrew Jeffery ---

Re: [PATCH linux v4 1/6] hwmon: Add core On-Chip Controller support for POWER CPUs

On 01/26/2017 03:19 PM, eajames@gmail.com wrote: From: "Edward A. James" Add core support for polling the OCC for it's sensor data and parsing that data into sensor-specific information. Signed-off-by: Edward A. James Signed-off-by: Andrew Jeffery

[PATCH] watchdog: Introduce watchdog_stop_on_unregister helper

reducing driver code size while retaining functionality. Signed-off-by: Guenter Roeck <li...@roeck-us.net> --- Documentation/watchdog/watchdog-kernel-api.txt | 6 ++ drivers/watchdog/watchdog_dev.c| 5 + include/linux/watchdog.h | 10 +++

Re: [PATCH linux v3 2/6] hwmon: occ: Add sysfs interface

On Mon, Jan 23, 2017 at 04:01:25PM -0600, Edward James wrote: > > > On Sat, Jan 21, 2017 at 12:08 PM, Guenter Roeck <li...@roeck-us.net> wrote: > > On 01/16/2017 01:13 PM, eajames@gmail.com wrote: > >> > >> From: "Edward A. James" <e

Re: [PATCH linux v3 1/6] hwmon: Add core On-Chip Controller support for POWER CPUs

On Mon, Jan 23, 2017 at 01:28:52PM -0600, Edward James wrote: > I still just can't get gmail to reply to this. Thanks for the review. > > On Sat, Jan 21, 2017 at 11:49 AM, Guenter Roeck <li...@roeck-us.net> wrote: > > On 01/16/2017 01:13 PM, eajames@gmail.com wrote: &g

  1   2   >