Re: [PATCH v2 3/3] tools: move pcmcia crc32hash tool from Documentation
On Wed, Sep 21, 2016 at 06:51:13PM -0600, Shuah Khan wrote: > Move pcmcia crc32hash tool from Documentation to tools/pcmcia and > remove it from Documentation Makefile. Update location information > for this tool. Create a new Makefile to build pcmcia. It can be built > from top level directory or from pcmcia directory: > > Run make -C tools/pcmcia or cd tools/pcmcia; make > > Signed-off-by: Shuah Khan> --- > Documentation/Makefile | 3 +-- > Documentation/pcmcia/.gitignore | 1 - > Documentation/pcmcia/Makefile| 7 --- > Documentation/pcmcia/crc32hash.c | 32 > Documentation/pcmcia/devicetable.txt | 4 ++-- > MAINTAINERS | 1 + > tools/pcmcia/.gitignore | 1 + > tools/pcmcia/Makefile| 9 + > tools/pcmcia/crc32hash.c | 32 > 9 files changed, 46 insertions(+), 44 deletions(-) > delete mode 100644 Documentation/pcmcia/.gitignore > delete mode 100644 Documentation/pcmcia/Makefile > delete mode 100644 Documentation/pcmcia/crc32hash.c > create mode 100644 tools/pcmcia/.gitignore > create mode 100644 tools/pcmcia/Makefile > create mode 100644 tools/pcmcia/crc32hash.c Acked-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2 1/3] tools: move accounting tool from Documentation
Move accounting tool to tools and remove it from Documentation Makefile. Update location information for this tool. Create a new Makefile to build accounting. It can be built from top level directory or from accounting directory: Run make -C tools/accounting or cd tools/accounting; make Signed-off-by: Shuah Khan--- Documentation/Makefile| 2 +- Documentation/accounting/.gitignore | 1 - Documentation/accounting/Makefile | 7 - Documentation/accounting/delay-accounting.txt | 6 +- Documentation/accounting/getdelays.c | 550 -- tools/accounting/.gitignore | 1 + tools/accounting/Makefile | 9 + tools/accounting/getdelays.c | 550 ++ 8 files changed, 564 insertions(+), 562 deletions(-) delete mode 100644 Documentation/accounting/.gitignore delete mode 100644 Documentation/accounting/Makefile delete mode 100644 Documentation/accounting/getdelays.c create mode 100644 tools/accounting/.gitignore create mode 100644 tools/accounting/Makefile create mode 100644 tools/accounting/getdelays.c diff --git a/Documentation/Makefile b/Documentation/Makefile index 0b8cd50..e4dd5e4 100644 --- a/Documentation/Makefile +++ b/Documentation/Makefile @@ -1,2 +1,2 @@ -subdir-y := accounting blackfin \ +subdir-y := blackfin \ laptops pcmcia diff --git a/Documentation/accounting/.gitignore b/Documentation/accounting/.gitignore deleted file mode 100644 index 8648520..000 --- a/Documentation/accounting/.gitignore +++ /dev/null @@ -1 +0,0 @@ -getdelays diff --git a/Documentation/accounting/Makefile b/Documentation/accounting/Makefile deleted file mode 100644 index 7e232cb..000 --- a/Documentation/accounting/Makefile +++ /dev/null @@ -1,7 +0,0 @@ -# List of programs to build -hostprogs-y := getdelays - -# Tell kbuild to always build the programs -always := $(hostprogs-y) - -HOSTCFLAGS_getdelays.o += -I$(objtree)/usr/include diff --git a/Documentation/accounting/delay-accounting.txt b/Documentation/accounting/delay-accounting.txt index 8a12f07..042ea59 100644 --- a/Documentation/accounting/delay-accounting.txt +++ b/Documentation/accounting/delay-accounting.txt @@ -54,9 +54,9 @@ are sent to userspace without requiring a command. If it is the last exiting task of a thread group, the per-tgid statistics are also sent. More details are given in the taskstats interface description. -The getdelays.c userspace utility in this directory allows simple commands to -be run and the corresponding delay statistics to be displayed. It also serves -as an example of using the taskstats interface. +The getdelays.c userspace utility in tools/accounting directory allows simple +commands to be run and the corresponding delay statistics to be displayed. It +also serves as an example of using the taskstats interface. Usage - diff --git a/Documentation/accounting/getdelays.c b/Documentation/accounting/getdelays.c deleted file mode 100644 index b5ca536..000 --- a/Documentation/accounting/getdelays.c +++ /dev/null @@ -1,550 +0,0 @@ -/* getdelays.c - * - * Utility to get per-pid and per-tgid delay accounting statistics - * Also illustrates usage of the taskstats interface - * - * Copyright (C) Shailabh Nagar, IBM Corp. 2005 - * Copyright (C) Balbir Singh, IBM Corp. 2006 - * Copyright (c) Jay Lan, SGI. 2006 - * - * Compile with - * gcc -I/usr/src/linux/include getdelays.c -o getdelays - */ - -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include - -#include -#include -#include - -/* - * Generic macros for dealing with netlink sockets. Might be duplicated - * elsewhere. It is recommended that commercial grade applications use - * libnl or libnetlink and use the interfaces provided by the library - */ -#define GENLMSG_DATA(glh) ((void *)(NLMSG_DATA(glh) + GENL_HDRLEN)) -#define GENLMSG_PAYLOAD(glh) (NLMSG_PAYLOAD(glh, 0) - GENL_HDRLEN) -#define NLA_DATA(na) ((void *)((char*)(na) + NLA_HDRLEN)) -#define NLA_PAYLOAD(len) (len - NLA_HDRLEN) - -#define err(code, fmt, arg...) \ - do {\ - fprintf(stderr, fmt, ##arg);\ - exit(code); \ - } while (0) - -int done; -int rcvbufsz; -char name[100]; -int dbg; -int print_delays; -int print_io_accounting; -int print_task_context_switch_counts; - -#define PRINTF(fmt, arg...) { \ - if (dbg) { \ - printf(fmt, ##arg); \ - } \ - } - -/* Maximum size of response requested or message sent */ -#define MAX_MSG_SIZE 1024 -/* Maximum number of cpus expected to be specified in a cpumask */ -#define MAX_CPUS 32 - -struct msgtemplate { - struct
[PATCH v2 2/3] tools: move laptops dslm tool from Documentation
Move laptops dslm tool to tools/laptop/dslm and remove it from Documentation Makefile. Update location information for this tool. Create a new Makefile to build dslm. It can be built from top level directory or from laptops directory: Run make -C tools/laptop/dslm or cd tools/laptop/dslm; make Signed-off-by: Shuah Khan--- Documentation/Makefile| 2 +- Documentation/laptops/.gitignore | 1 - Documentation/laptops/00-INDEX| 4 - Documentation/laptops/Makefile| 5 - Documentation/laptops/dslm.c | 166 -- Documentation/laptops/laptop-mode.txt | 2 +- tools/laptop/dslm/.gitignore | 1 + tools/laptop/dslm/Makefile| 9 ++ tools/laptop/dslm/dslm.c | 166 ++ 9 files changed, 178 insertions(+), 178 deletions(-) delete mode 100644 Documentation/laptops/.gitignore delete mode 100644 Documentation/laptops/Makefile delete mode 100644 Documentation/laptops/dslm.c create mode 100644 tools/laptop/dslm/.gitignore create mode 100644 tools/laptop/dslm/Makefile create mode 100644 tools/laptop/dslm/dslm.c diff --git a/Documentation/Makefile b/Documentation/Makefile index e4dd5e4..0ddb50c 100644 --- a/Documentation/Makefile +++ b/Documentation/Makefile @@ -1,2 +1,2 @@ subdir-y := blackfin \ - laptops pcmcia + pcmcia diff --git a/Documentation/laptops/.gitignore b/Documentation/laptops/.gitignore deleted file mode 100644 index 9fc984e..000 --- a/Documentation/laptops/.gitignore +++ /dev/null @@ -1 +0,0 @@ -dslm diff --git a/Documentation/laptops/00-INDEX b/Documentation/laptops/00-INDEX index 7c0ac2a..86169dc 100644 --- a/Documentation/laptops/00-INDEX +++ b/Documentation/laptops/00-INDEX @@ -1,13 +1,9 @@ 00-INDEX - This file -Makefile - - Makefile for building dslm example program. asus-laptop.txt - information on the Asus Laptop Extras driver. disk-shock-protection.txt - information on hard disk shock protection. -dslm.c - - Simple Disk Sleep Monitor program laptop-mode.txt - how to conserve battery power using laptop-mode. sony-laptop.txt diff --git a/Documentation/laptops/Makefile b/Documentation/laptops/Makefile deleted file mode 100644 index 0abe44f..000 --- a/Documentation/laptops/Makefile +++ /dev/null @@ -1,5 +0,0 @@ -# List of programs to build -hostprogs-y := dslm - -# Tell kbuild to always build the programs -always := $(hostprogs-y) diff --git a/Documentation/laptops/dslm.c b/Documentation/laptops/dslm.c deleted file mode 100644 index d5dd2d4..000 --- a/Documentation/laptops/dslm.c +++ /dev/null @@ -1,166 +0,0 @@ -/* - * dslm.c - * Simple Disk Sleep Monitor - * by Bartek Kania - * Licensed under the GPL - */ -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include - -#ifdef DEBUG -#define D(x) x -#else -#define D(x) -#endif - -int endit = 0; - -/* Check if the disk is in powersave-mode - * Most of the code is stolen from hdparm. - * 1 = active, 0 = standby/sleep, -1 = unknown */ -static int check_powermode(int fd) -{ -unsigned char args[4] = {WIN_CHECKPOWERMODE1,0,0,0}; -int state; - -if (ioctl(fd, HDIO_DRIVE_CMD, ) - && (args[0] = WIN_CHECKPOWERMODE2) /* try again with 0x98 */ - && ioctl(fd, HDIO_DRIVE_CMD, )) { - if (errno != EIO || args[0] != 0 || args[1] != 0) { - state = -1; /* "unknown"; */ - } else - state = 0; /* "sleeping"; */ -} else { - state = (args[2] == 255) ? 1 : 0; -} -D(printf(" drive state is: %d\n", state)); - -return state; -} - -static char *state_name(int i) -{ -if (i == -1) return "unknown"; -if (i == 0) return "sleeping"; -if (i == 1) return "active"; - -return "internal error"; -} - -static char *myctime(time_t time) -{ -char *ts = ctime(); -ts[strlen(ts) - 1] = 0; - -return ts; -} - -static void measure(int fd) -{ -time_t start_time; -int last_state; -time_t last_time; -int curr_state; -time_t curr_time = 0; -time_t time_diff; -time_t active_time = 0; -time_t sleep_time = 0; -time_t unknown_time = 0; -time_t total_time = 0; -int changes = 0; -float tmp; - -printf("Starting measurements\n"); - -last_state = check_powermode(fd); -start_time = last_time = time(0); -printf(" System is in state %s\n\n", state_name(last_state)); - -while(!endit) { - sleep(1); - curr_state = check_powermode(fd); - - if (curr_state != last_state || endit) { - changes++; - curr_time = time(0); - time_diff = curr_time - last_time; - - if (last_state == 1) active_time += time_diff; - else if (last_state == 0) sleep_time += time_diff; - else unknown_time += time_diff; - - last_state = curr_state; - last_time = curr_time; - -
[PATCH v2 0/3] Move runnable tools from Documentation to tools
Move runnable tools from Documentation to tools. I moved just the tools code, and left documentation files as is. Based on the v1 series feedback, This v2 series moves accounting, laptops/dslm, and pcmcia to tools. If v2 patches look good, and if I get an okay, I will try to get these into 4.9-rc1 Changes since v1: -- Move to tools instead of samples based on feedback -- Update location information and MAINTIANERS file as needed. Shuah Khan (3): tools: move accounting example code from Documentation tools: move laptops dslm tool from Documentation tools: move pcmcia crc32hash tool from Documentation Documentation/Makefile| 3 +- Documentation/accounting/.gitignore | 1 - Documentation/accounting/Makefile | 7 - Documentation/accounting/delay-accounting.txt | 6 +- Documentation/accounting/getdelays.c | 550 -- Documentation/laptops/.gitignore | 1 - Documentation/laptops/00-INDEX| 4 - Documentation/laptops/Makefile| 5 - Documentation/laptops/dslm.c | 166 Documentation/laptops/laptop-mode.txt | 2 +- Documentation/pcmcia/.gitignore | 1 - Documentation/pcmcia/Makefile | 7 - Documentation/pcmcia/crc32hash.c | 32 -- Documentation/pcmcia/devicetable.txt | 4 +- MAINTAINERS | 1 + tools/accounting/.gitignore | 1 + tools/accounting/Makefile | 9 + tools/accounting/getdelays.c | 550 ++ tools/laptop/dslm/.gitignore | 1 + tools/laptop/dslm/Makefile| 9 + tools/laptop/dslm/dslm.c | 166 tools/pcmcia/.gitignore | 1 + tools/pcmcia/Makefile | 9 + tools/pcmcia/crc32hash.c | 32 ++ 24 files changed, 786 insertions(+), 782 deletions(-) delete mode 100644 Documentation/accounting/.gitignore delete mode 100644 Documentation/accounting/Makefile delete mode 100644 Documentation/accounting/getdelays.c delete mode 100644 Documentation/laptops/.gitignore delete mode 100644 Documentation/laptops/Makefile delete mode 100644 Documentation/laptops/dslm.c delete mode 100644 Documentation/pcmcia/.gitignore delete mode 100644 Documentation/pcmcia/Makefile delete mode 100644 Documentation/pcmcia/crc32hash.c create mode 100644 tools/accounting/.gitignore create mode 100644 tools/accounting/Makefile create mode 100644 tools/accounting/getdelays.c create mode 100644 tools/laptop/dslm/.gitignore create mode 100644 tools/laptop/dslm/Makefile create mode 100644 tools/laptop/dslm/dslm.c create mode 100644 tools/pcmcia/.gitignore create mode 100644 tools/pcmcia/Makefile create mode 100644 tools/pcmcia/crc32hash.c -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH v2 3/5] futex: Throughput-optimized (TO) futexes
On 09/21/2016 02:59 AM, Mike Galbraith wrote: On Tue, 2016-09-20 at 09:42 -0400, Waiman Long wrote: This patch introduces a new futex implementation called throughput-optimized (TO) futexes. nit: 'TO' sounds way too much like timeout... TP? You even use 'to' as shorthand for timeout in the next patch. I agree. I am not that satisfied with the TO name. So I will change it to TP in my next revision of the patch. Thanks for the suggestion. Cheers, Longman -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: XDP (eXpress Data Path) documentation
On Tue, Sep 20, 2016 at 2:08 AM, Jesper Dangaard Brouerwrote: > Hi all, > > As promised, I've started documenting the XDP eXpress Data Path): > > [1] > https://prototype-kernel.readthedocs.io/en/latest/networking/XDP/index.html > > IMHO the documentation have reached a stage where it is useful for the > XDP project, BUT I request collaboration on improving the documentation > from all. (Native English speakers are encouraged to send grammar fixes ;-)) > Hi Jesper, Thanks for taking the initiative on the this, The document reads more like a design doc than description right now, that's probably okay since we could use a design doc. Under "Important to understand" there are some disclaimers that XDP does not implement qdiscs or BQL and fairness otherwise. This is true for it's own traffic, but it does not (or at least should not) affect these mechanisms or normal stack traffic running simultaneously. I think we've made assumptions about fairness between XDP and non-XDP queues, we probably want to clarify fairness (and also validate whatever assumptions we've made with testing). Thanks, Tom > You wouldn't believe it: But this pretty looking documentation actually > follows the new Kernel documentation format. It is actually just > ".rst" text files stored in my github repository under kernel/Documentation > [2] > > [2] > https://github.com/netoptimizer/prototype-kernel/tree/master/kernel/Documentation > > Thus, just git clone my repository and started editing and send me > patches (or github pull requests). Like: > > $ git clone https://github.com/netoptimizer/prototype-kernel > $ cd prototype-kernel/kernel/Documentation/ > $ make html > $ firefox _build/html/index.html & > > This new documentation format combines the best of two worlds, pretty > online browser documentation with almost plain text files, and changes > being tracked via git commits [3] (and auto git hooks to generate the > readthedocs.org page). You got to love it! :-) > > -- > Best regards, > Jesper Dangaard Brouer > MSc.CS, Principal Kernel Engineer at Red Hat > Author of http://www.iptv-analyzer.org > LinkedIn: http://www.linkedin.com/in/brouer > > [3] https://github.com/netoptimizer/prototype-kernel/commits/master -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] docs: Remove space-before-label guidance from CodingStyle
On Wed, 2016-09-21 at 15:54 -0600, Jonathan Corbet wrote: > Recent discussion has made it clear that there is no community consensus > on this particular rule. Remove it now, lest it inspire yet another set > of unwanted "cleanup" patches. Thanks. I believe it's better to remove this one too. -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 3/3] mm: enable CONFIG_MOVABLE_NODE on powerpc
On Wed, Sep 21, 2016 at 08:13:37PM +0530, Aneesh Kumar K.V wrote: So we are looking at two step online process here. The above explained the details nicely. Can you capture these details in the commit message. ie, to say that when using 'echo online-movable > state' we allow the move from normal to movable only if movable node is set. Also you may want to mention that we still don't support the auto-online to movable. Sure, no problem. I'll use a more verbose commit message in v3. -- Reza Arbab -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 2/4] samples: move timers example code from Documentation
Shuah Khan wrote: > Move timers examples to samples and remove it from Documentation > Makefile. Create a new Makefile to build timers. It can be built > from top level directory or from timers directory: > > Run make -C samples/timers or cd samples/timers; make > > Acked-by: Jonathan Corbet> Signed-off-by: Shuah Khan Acked-by: Clemens Ladisch -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] docs-rst: add inter-document cross references
On Wed, 21 Sep 2016 08:51:05 -0300 Mauro Carvalho Chehabwrote: > Add cross references for the development process documents > that were converted to ReST: > Documentation/SubmitChecklist > Documentation/SubmittingDrivers > Documentation/SubmittingPatches > Documentation/development-process/development-process.rst > Documentation/stable_kernel_rules.txt Applied, thanks. ...and now I'm thinking that's maybe about enough in docs for 4.9...:) jon -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Documentation/email-clients.txt: convert it to ReST markup
On Wed, 21 Sep 2016 07:49:18 -0300 Mauro Carvalho Chehabwrote: > As this file is mentioned at the development-process/ book, > let's convert it to ReST markup. Applied, thanks. jon -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v2 1/4] samples: move misc-devices/mei example code from Documentation
> > Move misc-devices/mei examples to samples/mei and remove it from > Documentation Makefile. Delete misc-devices/Makefile. > > Create a new Makefile to build samples/mei. It can be built from top level > directory or from mei directory: > > Run make -C samples/mei or cd samples/mei; make > > Acked-by: Jonathan Corbet> Signed-off-by: Shuah Khan Acked-by: Tomas Winkler > --- > Documentation/Makefile | 2 +- > Documentation/misc-devices/Makefile | 1 - > Documentation/misc-devices/mei/.gitignore| 1 - > Documentation/misc-devices/mei/Makefile | 5 - > Documentation/misc-devices/mei/TODO | 2 - > Documentation/misc-devices/mei/mei-amt-version.c | 479 > --- > MAINTAINERS | 1 + > samples/mei/.gitignore | 1 + > samples/mei/Makefile | 9 + > samples/mei/TODO | 2 + > samples/mei/mei-amt-version.c| 479 > +++ > 11 files changed, 493 insertions(+), 489 deletions(-) delete mode 100644 > Documentation/misc-devices/Makefile > delete mode 100644 Documentation/misc-devices/mei/.gitignore > delete mode 100644 Documentation/misc-devices/mei/Makefile > delete mode 100644 Documentation/misc-devices/mei/TODO > delete mode 100644 Documentation/misc-devices/mei/mei-amt-version.c > create mode 100644 samples/mei/.gitignore create mode 100644 > samples/mei/Makefile create mode 100644 samples/mei/TODO create > mode 100644 samples/mei/mei-amt-version.c > > diff --git a/Documentation/Makefile b/Documentation/Makefile index > 80b5bdc..3c2a207 100644 > --- a/Documentation/Makefile > +++ b/Documentation/Makefile > @@ -1,2 +1,2 @@ > subdir-y := accounting auxdisplay blackfin \ > - laptops misc-devices pcmcia timers watchdog > + laptops pcmcia timers watchdog > diff --git a/Documentation/misc-devices/Makefile b/Documentation/misc- > devices/Makefile > deleted file mode 100644 > index e2b7aa4..000 > --- a/Documentation/misc-devices/Makefile > +++ /dev/null > @@ -1 +0,0 @@ > -subdir-y := mei > diff --git a/Documentation/misc-devices/mei/.gitignore > b/Documentation/misc-devices/mei/.gitignore > deleted file mode 100644 > index f356b81..000 > --- a/Documentation/misc-devices/mei/.gitignore > +++ /dev/null > @@ -1 +0,0 @@ > -mei-amt-version > diff --git a/Documentation/misc-devices/mei/Makefile > b/Documentation/misc-devices/mei/Makefile > deleted file mode 100644 > index d758047..000 > --- a/Documentation/misc-devices/mei/Makefile > +++ /dev/null > @@ -1,5 +0,0 @@ > -# List of programs to build > -hostprogs-y := mei-amt-version > -HOSTCFLAGS_mei-amt-version.o += -I$(objtree)/usr/include -# Tell kbuild > to always build the programs -always := $(hostprogs-y) diff --git > a/Documentation/misc-devices/mei/TODO b/Documentation/misc- > devices/mei/TODO > deleted file mode 100644 > index 6b3625d..000 > --- a/Documentation/misc-devices/mei/TODO > +++ /dev/null > @@ -1,2 +0,0 @@ > -TODO: > - - Cleanup and split the timer function > diff --git a/Documentation/misc-devices/mei/mei-amt-version.c > b/Documentation/misc-devices/mei/mei-amt-version.c > deleted file mode 100644 > index 57d0d87..000 > --- a/Documentation/misc-devices/mei/mei-amt-version.c > +++ /dev/null > @@ -1,479 +0,0 @@ > - > /** > > - * Intel Management Engine Interface (Intel MEI) Linux driver > - * Intel MEI Interface Header > - * > - * This file is provided under a dual BSD/GPLv2 license. When using or > - * redistributing this file, you may do so under either license. > - * > - * GPL LICENSE SUMMARY > - * > - * Copyright(c) 2012 Intel Corporation. All rights reserved. > - * > - * This program is free software; you can redistribute it and/or modify > - * it under the terms of version 2 of the GNU General Public License as > - * published by the Free Software Foundation. > - * > - * This program is distributed in the hope that it will be useful, but > - * WITHOUT ANY WARRANTY; without even the implied warranty of > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > GNU > - * General Public License for more details. > - * > - * You should have received a copy of the GNU General Public License > - * along with this program; if not, write to the Free Software > - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110, > - * USA > - * > - * The full GNU General Public License is included in this distribution > - * in the file called LICENSE.GPL. > - * > - * Contact Information: > - * Intel Corporation. > - * linux-...@linux.intel.com > - * http://www.intel.com > - * > - * BSD LICENSE > - * > - * Copyright(c) 2003 - 2012 Intel Corporation. All rights reserved. > - * All rights
Re: [PATCH v2 0/4] Move runnable examples code from Documentation to samples
On Wed, 21 Sep 2016 13:47:29 -0600 Shuah Khanwrote: > Move runnable examples code from Documentation to samples. I moved > just the example code, and left documentation files as is. > > I dropped accounting, laptops, and pcmcia from this v2 series as per > the v1 feedback on these being a better fit under tools. I will send > a separate v2 for them. > > If v2 patches look good, and if I get an okay, I will try to get these > into 4.9-rc1 > > Changes since v1: > - Updated location information in .txt for timers, watchdog, and > auxdisplay > - Updated MAINTAINERS file for misc-devices/mei based on feedback > from Tomas Winkler > - Added Acked-by from Jon Corbet for timers, and misc-devices/mei Looks good, feel free to add my ack to the rest. jon -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 1/4] samples: move misc-devices/mei example code from Documentation
On Wed, Sep 21, 2016 at 01:47:30PM -0600, Shuah Khan wrote: > Move misc-devices/mei examples to samples/mei and remove it from > Documentation Makefile. Delete misc-devices/Makefile. > > Create a new Makefile to build samples/mei. It can be built from top > level directory or from mei directory: > > Run make -C samples/mei or cd samples/mei; make > > Acked-by: Jonathan Corbet> Signed-off-by: Shuah Khan > --- Acked-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2 3/4] samples: move watchdog example code from Documentation
Move watchdog examples to samples and remove it from Documentation Makefile. Create a new Makefile to build watchdog. It can be built from top level directory or from watchdog directory: Run make -C samples/watchdog or cd samples/watchdog; make Signed-off-by: Shuah Khan--- Documentation/Makefile | 2 +- Documentation/watchdog/Makefile | 1 - Documentation/watchdog/src/.gitignore| 1 - Documentation/watchdog/src/Makefile | 5 - Documentation/watchdog/src/watchdog-simple.c | 24 Documentation/watchdog/watchdog-api.txt | 2 +- Documentation/watchdog/wdt.txt | 2 +- samples/watchdog/.gitignore | 1 + samples/watchdog/Makefile| 8 samples/watchdog/watchdog-simple.c | 24 10 files changed, 36 insertions(+), 34 deletions(-) delete mode 100644 Documentation/watchdog/Makefile delete mode 100644 Documentation/watchdog/src/.gitignore delete mode 100644 Documentation/watchdog/src/Makefile delete mode 100644 Documentation/watchdog/src/watchdog-simple.c create mode 100644 samples/watchdog/.gitignore create mode 100644 samples/watchdog/Makefile create mode 100644 samples/watchdog/watchdog-simple.c diff --git a/Documentation/Makefile b/Documentation/Makefile index fc386b7..b2210b7 100644 --- a/Documentation/Makefile +++ b/Documentation/Makefile @@ -1,2 +1,2 @@ subdir-y := accounting auxdisplay blackfin \ - laptops pcmcia watchdog + laptops pcmcia diff --git a/Documentation/watchdog/Makefile b/Documentation/watchdog/Makefile deleted file mode 100644 index 6018f45..000 --- a/Documentation/watchdog/Makefile +++ /dev/null @@ -1 +0,0 @@ -subdir-y := src diff --git a/Documentation/watchdog/src/.gitignore b/Documentation/watchdog/src/.gitignore deleted file mode 100644 index ff0ebb5..000 --- a/Documentation/watchdog/src/.gitignore +++ /dev/null @@ -1 +0,0 @@ -watchdog-simple diff --git a/Documentation/watchdog/src/Makefile b/Documentation/watchdog/src/Makefile deleted file mode 100644 index 47be791..000 --- a/Documentation/watchdog/src/Makefile +++ /dev/null @@ -1,5 +0,0 @@ -# List of programs to build -hostprogs-y := watchdog-simple - -# Tell kbuild to always build the programs -always := $(hostprogs-y) diff --git a/Documentation/watchdog/src/watchdog-simple.c b/Documentation/watchdog/src/watchdog-simple.c deleted file mode 100644 index ba45803..000 --- a/Documentation/watchdog/src/watchdog-simple.c +++ /dev/null @@ -1,24 +0,0 @@ -#include -#include -#include -#include - -int main(void) -{ - int fd = open("/dev/watchdog", O_WRONLY); - int ret = 0; - if (fd == -1) { - perror("watchdog"); - exit(EXIT_FAILURE); - } - while (1) { - ret = write(fd, "\0", 1); - if (ret != 1) { - ret = -1; - break; - } - sleep(10); - } - close(fd); - return ret; -} diff --git a/Documentation/watchdog/watchdog-api.txt b/Documentation/watchdog/watchdog-api.txt index b3a701f..0e62ba3 100644 --- a/Documentation/watchdog/watchdog-api.txt +++ b/Documentation/watchdog/watchdog-api.txt @@ -37,7 +37,7 @@ activates as soon as /dev/watchdog is opened and will reboot unless the watchdog is pinged within a certain time, this time is called the timeout or margin. The simplest way to ping the watchdog is to write some data to the device. So a very simple watchdog daemon would look -like this source file: see Documentation/watchdog/src/watchdog-simple.c +like this source file: see samples/watchdog/watchdog-simple.c A more advanced driver could for example check that a HTTP server is still responding before doing the write call to ping the watchdog. diff --git a/Documentation/watchdog/wdt.txt b/Documentation/watchdog/wdt.txt index 061c2e3..ed2f0b8 100644 --- a/Documentation/watchdog/wdt.txt +++ b/Documentation/watchdog/wdt.txt @@ -47,4 +47,4 @@ The external event interfaces on the WDT boards are not currently supported. Minor numbers are however allocated for it. -Example Watchdog Driver: see Documentation/watchdog/src/watchdog-simple.c +Example Watchdog Driver: see samples/watchdog/watchdog-simple.c diff --git a/samples/watchdog/.gitignore b/samples/watchdog/.gitignore new file mode 100644 index 000..ff0ebb5 --- /dev/null +++ b/samples/watchdog/.gitignore @@ -0,0 +1 @@ +watchdog-simple diff --git a/samples/watchdog/Makefile b/samples/watchdog/Makefile new file mode 100644 index 000..9b53d89 --- /dev/null +++ b/samples/watchdog/Makefile @@ -0,0 +1,8 @@ +CC := $(CROSS_COMPILE)gcc +PROGS := watchdog-simple + +all: $(PROGS) + +clean: + rm -fr $(PROGS) + diff --git a/samples/watchdog/watchdog-simple.c b/samples/watchdog/watchdog-simple.c new file mode 100644 index 000..ba45803 --- /dev/null +++
[PATCH v2 0/4] Move runnable examples code from Documentation to samples
Move runnable examples code from Documentation to samples. I moved just the example code, and left documentation files as is. I dropped accounting, laptops, and pcmcia from this v2 series as per the v1 feedback on these being a better fit under tools. I will send a separate v2 for them. If v2 patches look good, and if I get an okay, I will try to get these into 4.9-rc1 Changes since v1: - Updated location information in .txt for timers, watchdog, and auxdisplay - Updated MAINTAINERS file for misc-devices/mei based on feedback from Tomas Winkler - Added Acked-by from Jon Corbet for timers, and misc-devices/mei Shuah Khan (4): samples: move misc-devices/mei example code from Documentation samples: move timers example code from Documentation samples: move watchdog example code from Documentation samples: move auxdisplay example code from Documentation Documentation/Makefile | 4 +- Documentation/auxdisplay/.gitignore | 1 - Documentation/auxdisplay/Makefile| 7 - Documentation/auxdisplay/cfag12864b | 2 +- Documentation/auxdisplay/cfag12864b-example.c| 281 - Documentation/misc-devices/Makefile | 1 - Documentation/misc-devices/mei/.gitignore| 1 - Documentation/misc-devices/mei/Makefile | 5 - Documentation/misc-devices/mei/TODO | 2 - Documentation/misc-devices/mei/mei-amt-version.c | 479 --- Documentation/timers/.gitignore | 1 - Documentation/timers/Makefile| 5 - Documentation/timers/hpet.txt| 2 +- Documentation/timers/hpet_example.c | 294 -- Documentation/watchdog/Makefile | 1 - Documentation/watchdog/src/.gitignore| 1 - Documentation/watchdog/src/Makefile | 5 - Documentation/watchdog/src/watchdog-simple.c | 24 -- Documentation/watchdog/watchdog-api.txt | 2 +- Documentation/watchdog/wdt.txt | 2 +- MAINTAINERS | 1 + samples/auxdisplay/.gitignore| 1 + samples/auxdisplay/Makefile | 9 + samples/auxdisplay/cfag12864b-example.c | 281 + samples/mei/.gitignore | 1 + samples/mei/Makefile | 9 + samples/mei/TODO | 2 + samples/mei/mei-amt-version.c| 479 +++ samples/timers/.gitignore| 1 + samples/timers/Makefile | 15 + samples/timers/hpet_example.c| 294 ++ samples/watchdog/.gitignore | 1 + samples/watchdog/Makefile| 8 + samples/watchdog/watchdog-simple.c | 24 ++ 34 files changed, 1132 insertions(+), 1114 deletions(-) delete mode 100644 Documentation/auxdisplay/.gitignore delete mode 100644 Documentation/auxdisplay/Makefile delete mode 100644 Documentation/auxdisplay/cfag12864b-example.c delete mode 100644 Documentation/misc-devices/Makefile delete mode 100644 Documentation/misc-devices/mei/.gitignore delete mode 100644 Documentation/misc-devices/mei/Makefile delete mode 100644 Documentation/misc-devices/mei/TODO delete mode 100644 Documentation/misc-devices/mei/mei-amt-version.c delete mode 100644 Documentation/timers/.gitignore delete mode 100644 Documentation/timers/Makefile delete mode 100644 Documentation/timers/hpet_example.c delete mode 100644 Documentation/watchdog/Makefile delete mode 100644 Documentation/watchdog/src/.gitignore delete mode 100644 Documentation/watchdog/src/Makefile delete mode 100644 Documentation/watchdog/src/watchdog-simple.c create mode 100644 samples/auxdisplay/.gitignore create mode 100644 samples/auxdisplay/Makefile create mode 100644 samples/auxdisplay/cfag12864b-example.c create mode 100644 samples/mei/.gitignore create mode 100644 samples/mei/Makefile create mode 100644 samples/mei/TODO create mode 100644 samples/mei/mei-amt-version.c create mode 100644 samples/timers/.gitignore create mode 100644 samples/timers/Makefile create mode 100644 samples/timers/hpet_example.c create mode 100644 samples/watchdog/.gitignore create mode 100644 samples/watchdog/Makefile create mode 100644 samples/watchdog/watchdog-simple.c -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller
Hi Tejun, On Wed, Sep 21, 2016 at 7:56 PM, Tejun Heowrote: > Hello, Parav. > > On Wed, Sep 21, 2016 at 10:13:38AM +0530, Parav Pandit wrote: >> We have completed review from Tejun, Christoph. >> HFI driver folks also provided feedback for Intel drivers. >> Matan's also doesn't have any more comments. >> >> If possible, if you can also review, it will be helpful. >> >> I have some more changes unrelated to cgroup in same files in both the git >> tree. >> Pushing them now either results into merge conflict later on for >> Doug/Tejun, or requires rebase and resending patch. >> If you can review, we can avoid such rework. > > My impression of the thread was that there doesn't seem to be enough > of consensus around how rdma resources should be defined. Is that > part agreed upon now? > We ended up discussing few points on different thread [1]. There was confusion on how some non-rdma/non-IB drivers would work with rdma cgroup from Matan. Christoph explained how they don't fit in the rdma subsystem and therefore its not prime target to addess. Intel driver maintainer Denny also acknowledged same on [2]. IB compliant drivers of Intel support rdma cgroup as explained in [2]. With that usnic and Intel psm drivers falls out of rdma cgroup support as they don't fit very well in the verbs definition. [1] https://www.spinics.net/lists/linux-rdma/msg40340.html [2] http://www.spinics.net/lists/linux-rdma/msg40717.html I will wait for Leon's review comments if he has different view on architecture. Back in April when I met face-to-face to Leon and Haggai, Leon was in support to have kernel defined the rdma resources as suggested by Christoph and Tejun instead of IB/RDMA subsystem. I will wait for his comments if his views have changed with new uAPI taking shape. -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 3/3] mm: enable CONFIG_MOVABLE_NODE on powerpc
Reza Arbabwrites: > On Wed, Sep 21, 2016 at 12:39:51PM +0530, Aneesh Kumar K.V wrote: >>What I was checking was how will one mark a node movable in ppc64 ? I >>don't see ppc64 code doing the equivalent of memblock_mark_hotplug(). > > Post boot, the marking mechanism is not necessary. You can create a > movable node by putting all of the node's memory into ZONE_MOVABLE > during the hotplug. > >>So when you say "Onlining memory into ZONE_MOVABLE requires >>CONFIG_MOVABLE_NODE" where is that restriction ?. IIUC, >>should_add_memory_movable() will only return ZONE_MOVABLE only if it is >>non empty and MOVABLE_NODE will create a ZONE_MOVABLE zone by default >>only if it finds a memblock marked hotpluggable. So wondering if we >>are not calling memblock_mark_hotplug() how is it working. Or am I >>missing something ? > > You are looking at the addition step of hotplug. You're correct there, > the memory is added to the default zone, not ZONE_MOVABLE. The > transition to ZONE_MOVABLE takes place during the onlining step. In > online_pages(): > > zone = move_pfn_range(zone_shift, pfn, pfn + nr_pages); > > The reason we need CONFIG_MOVABLE_NODE is right before that: > > if ((zone_idx(zone) > ZONE_NORMAL || > online_type == MMOP_ONLINE_MOVABLE) && > !can_online_high_movable(zone)) > return -EINVAL; > So we are looking at two step online process here. The above explained the details nicely. Can you capture these details in the commit message. ie, to say that when using 'echo online-movable > state' we allow the move from normal to movable only if movable node is set. Also you may want to mention that we still don't support the auto-online to movable. > where can_online_high_movable() is defined like this: > > #ifdef CONFIG_MOVABLE_NODE > /* >* When CONFIG_MOVABLE_NODE, we permit onlining of a node which doesn't > have >* normal memory. >*/ > static bool can_online_high_movable(struct zone *zone) > { > return true; > } > #else /* CONFIG_MOVABLE_NODE */ > /* ensure every online node has NORMAL memory */ > static bool can_online_high_movable(struct zone *zone) > { > return node_state(zone_to_nid(zone), N_NORMAL_MEMORY); > } > #endif /* CONFIG_MOVABLE_NODE */ > > To be more clear, I can change the commit log to say "Onlining all of a > node's memory into ZONE_MOVABLE requires CONFIG_MOVABLE_NODE". > > -- > Reza Arbab -aneesh -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] docs-rst: add inter-document cross references
On Wed, Sep 21, 2016 at 08:51:05AM -0300, Mauro Carvalho Chehab wrote: > Add cross references for the development process documents > that were converted to ReST: > Documentation/SubmitChecklist > Documentation/SubmittingDrivers > Documentation/SubmittingPatches > Documentation/development-process/development-process.rst > Documentation/stable_kernel_rules.txt > > Signed-off-by: Mauro Carvalho Chehab> --- > > The changes here were at patch 29/29, that did the rename. I opted to > split this change to just add the cross-references without the rename, as > it makes easier if we decide to use symlinks instead of renames. > > As I rebased the rename patch as well, on the top of this one, we can > also use the rename, if people find it better. For the stable_kernel_rules.txt portion: Acked-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 3/3] mm: enable CONFIG_MOVABLE_NODE on powerpc
On Wed, Sep 21, 2016 at 12:39:51PM +0530, Aneesh Kumar K.V wrote: What I was checking was how will one mark a node movable in ppc64 ? I don't see ppc64 code doing the equivalent of memblock_mark_hotplug(). Post boot, the marking mechanism is not necessary. You can create a movable node by putting all of the node's memory into ZONE_MOVABLE during the hotplug. So when you say "Onlining memory into ZONE_MOVABLE requires CONFIG_MOVABLE_NODE" where is that restriction ?. IIUC, should_add_memory_movable() will only return ZONE_MOVABLE only if it is non empty and MOVABLE_NODE will create a ZONE_MOVABLE zone by default only if it finds a memblock marked hotpluggable. So wondering if we are not calling memblock_mark_hotplug() how is it working. Or am I missing something ? You are looking at the addition step of hotplug. You're correct there, the memory is added to the default zone, not ZONE_MOVABLE. The transition to ZONE_MOVABLE takes place during the onlining step. In online_pages(): zone = move_pfn_range(zone_shift, pfn, pfn + nr_pages); The reason we need CONFIG_MOVABLE_NODE is right before that: if ((zone_idx(zone) > ZONE_NORMAL || online_type == MMOP_ONLINE_MOVABLE) && !can_online_high_movable(zone)) return -EINVAL; where can_online_high_movable() is defined like this: #ifdef CONFIG_MOVABLE_NODE /* * When CONFIG_MOVABLE_NODE, we permit onlining of a node which doesn't have * normal memory. */ static bool can_online_high_movable(struct zone *zone) { return true; } #else /* CONFIG_MOVABLE_NODE */ /* ensure every online node has NORMAL memory */ static bool can_online_high_movable(struct zone *zone) { return node_state(zone_to_nid(zone), N_NORMAL_MEMORY); } #endif /* CONFIG_MOVABLE_NODE */ To be more clear, I can change the commit log to say "Onlining all of a node's memory into ZONE_MOVABLE requires CONFIG_MOVABLE_NODE". -- Reza Arbab -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: GPU-DRM-nouveau: Delete unnecessary braces
> The original style was correct, the new style is wrong. I find your feedback interesting for further clarifications. > Multi-line indents get curly braces for readability. How do you think about to transform such an information into an official specification for the the document "CodingStyle"? Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] docs-rst: add inter-document cross references
Add cross references for the development process documents that were converted to ReST: Documentation/SubmitChecklist Documentation/SubmittingDrivers Documentation/SubmittingPatches Documentation/development-process/development-process.rst Documentation/stable_kernel_rules.txt Signed-off-by: Mauro Carvalho Chehab--- The changes here were at patch 29/29, that did the rename. I opted to split this change to just add the cross-references without the rename, as it makes easier if we decide to use symlinks instead of renames. As I rebased the rename patch as well, on the top of this one, we can also use the rename, if people find it better. Documentation/SubmitChecklist | 10 + Documentation/SubmittingDrivers| 7 --- Documentation/SubmittingPatches| 24 ++ .../development-process/development-process.rst| 2 ++ Documentation/stable_kernel_rules.txt | 7 +-- 5 files changed, 32 insertions(+), 18 deletions(-) diff --git a/Documentation/SubmitChecklist b/Documentation/SubmitChecklist index 22a370ff34e5..894289b22b15 100644 --- a/Documentation/SubmitChecklist +++ b/Documentation/SubmitChecklist @@ -1,3 +1,5 @@ +.. _submitchecklist: + Linux Kernel patch submission checklist ~~~ @@ -5,7 +7,7 @@ Here are some basic things that developers should do if they want to see their kernel patch submissions accepted more quickly. These are all above and beyond the documentation that is provided in -Documentation/SubmittingPatches +:ref:`Documentation/SubmittingPatches ` and elsewhere regarding submitting Linux kernel patches. @@ -28,8 +30,8 @@ and elsewhere regarding submitting Linux kernel patches. 4) ppc64 is a good architecture for cross-compilation checking because it tends to use ``unsigned long`` for 64-bit quantities. -5: Check your patch for general style as detailed in - Documentation/CodingStyle. +5) Check your patch for general style as detailed in + :ref:`Documentation/CodingStyle `. Check for trivial violations with the patch style checker prior to submission (``scripts/checkpatch.pl``). You should be able to justify all violations that remain in @@ -54,7 +56,7 @@ and elsewhere regarding submitting Linux kernel patches. but any one function that uses more than 512 bytes on the stack is a candidate for change. -11: Include :ref:`kernel-doc ` to document global kernel APIs. +11) Include :ref:`kernel-doc ` to document global kernel APIs. (Not required for static functions, but OK there also.) Use ``make htmldocs`` or ``make pdfdocs`` to check the :ref:`kernel-doc ` and fix any issues. diff --git a/Documentation/SubmittingDrivers b/Documentation/SubmittingDrivers index 2ac931645e53..252b77a23fad 100644 --- a/Documentation/SubmittingDrivers +++ b/Documentation/SubmittingDrivers @@ -40,9 +40,9 @@ Linux 2.4: maintainer does not respond or you cannot find the appropriate maintainer then please contact Willy Tarreau . -Linux 2.6: +Linux 2.6 and upper: The same rules apply as 2.4 except that you should follow linux-kernel - to track changes in API's. The final contact point for Linux 2.6 + to track changes in API's. The final contact point for Linux 2.6+ submissions is Andrew Morton. What Criteria Determine Acceptance @@ -73,7 +73,8 @@ Interfaces: Code: Please use the Linux style of code formatting as documented - in Documentation/CodingStyle. If you have sections of code + in :ref:`Documentation/CodingStyle `. + If you have sections of code that need to be in other formats, for example because they are shared with a windows driver kit and you want to maintain them just once separate them out nicely and note diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 9c3dfa7babf3..36f1dedc944c 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -10,10 +10,12 @@ can greatly increase the chances of your change being accepted. This document contains a large number of suggestions in a relatively terse format. For detailed information on how the kernel development process -works, see Documentation/development-process. Also, read -Documentation/SubmitChecklist for a list of items to check before +works, see :ref:`Documentation/development-process `. +Also, read :ref:`Documentation/SubmitChecklist ` +for a list of items to check before submitting code. If you are submitting a driver, also read -Documentation/SubmittingDrivers; for device tree binding patches, read +:ref:`Documentation/SubmittingDrivers `; +for device tree binding patches, read Documentation/devicetree/bindings/submitting-patches.txt.
[PATCH] Documentation/email-clients.txt: convert it to ReST markup
As this file is mentioned at the development-process/ book, let's convert it to ReST markup. Signed-off-by: Mauro Carvalho Chehab--- This one corresponds to patch 27/29 of the last patch series. Changes: - Removed all the rename stuff from it - Clean up bare :: lines Documentation/email-clients.txt | 208 ++-- 1 file changed, 114 insertions(+), 94 deletions(-) diff --git a/Documentation/email-clients.txt b/Documentation/email-clients.txt index 2d485dea8cec..ac892b30815e 100644 --- a/Documentation/email-clients.txt +++ b/Documentation/email-clients.txt @@ -1,23 +1,27 @@ +.. _email_clients: + Email clients info for Linux -== + Git --- -These days most developers use `git send-email` instead of regular +--- + +These days most developers use ``git send-email`` instead of regular email clients. The man page for this is quite good. On the receiving -end, maintainers use `git am` to apply the patches. +end, maintainers use ``git am`` to apply the patches. -If you are new to git then send your first patch to yourself. Save it -as raw text including all the headers. Run `git am raw_email.txt` and -then review the changelog with `git log`. When that works then send +If you are new to ``git`` then send your first patch to yourself. Save it +as raw text including all the headers. Run ``git am raw_email.txt`` and +then review the changelog with ``git log``. When that works then send the patch to the appropriate mailing list(s). General Preferences --- +--- + Patches for the Linux kernel are submitted via email, preferably as inline text in the body of the email. Some maintainers accept attachments, but then the attachments should have content-type -"text/plain". However, attachments are generally frowned upon because +``text/plain``. However, attachments are generally frowned upon because it makes quoting portions of the patch more difficult in the patch review process. @@ -25,7 +29,7 @@ Email clients that are used for Linux kernel patches should send the patch text untouched. For example, they should not modify or delete tabs or spaces, even at the beginning or end of lines. -Don't send patches with "format=flowed". This can cause unexpected +Don't send patches with ``format=flowed``. This can cause unexpected and unwanted line breaks. Don't let your email client do automatic word wrapping for you. @@ -54,57 +58,63 @@ mailing lists. Some email client (MUA) hints --- +- + Here are some specific MUA configuration hints for editing and sending patches for the Linux kernel. These are not meant to be complete software package configuration summaries. + Legend: -TUI = text-based user interface -GUI = graphical user interface -~~ +- TUI = text-based user interface +- GUI = graphical user interface + Alpine (TUI) + Config options: -In the "Sending Preferences" section: -- "Do Not Send Flowed Text" must be enabled -- "Strip Whitespace Before Sending" must be disabled +In the :menuselection:`Sending Preferences` section: + +- :menuselection:`Do Not Send Flowed Text` must be ``enabled`` +- :menuselection:`Strip Whitespace Before Sending` must be ``disabled`` When composing the message, the cursor should be placed where the patch -should appear, and then pressing CTRL-R let you specify the patch file +should appear, and then pressing :kbd:`CTRL-R` let you specify the patch file to insert into the message. -~~ Claws Mail (GUI) + Works. Some people use this successfully for patches. -To insert a patch use Message->Insert File (CTRL+i) or an external editor. +To insert a patch use :menuselection:`Message-->Insert` File (:kbd:`CTRL-I`) +or an external editor. If the inserted patch has to be edited in the Claws composition window -"Auto wrapping" in Configuration->Preferences->Compose->Wrapping should be +"Auto wrapping" in +:menuselection:`Configuration-->Preferences-->Compose-->Wrapping` should be disabled. -~~ Evolution (GUI) +*** Some people use this successfully for patches. When composing mail select: Preformat - from Format->Paragraph Style->Preformatted (Ctrl-7) + from :menuselection:`Format-->Paragraph Style-->Preformatted` (:kbd:`CTRL-7`) or the toolbar Then use: - Insert->Text File... (Alt-n x) +:menuselection:`Insert-->Text File...` (:kbd:`ALT-N x`) to insert the patch. -You can also "diff -Nru old.c new.c | xclip", select Preformat, then
Re: [PATCH 00/14] Update kernel-docs.txt
Em Tue, 20 Sep 2016 18:56:45 -0600 Jonathan Corbetescreveu: > On Tue, 20 Sep 2016 08:36:29 -0300 > Mauro Carvalho Chehab wrote: > > > This patch series update the kernel-docs.txt file, removing broken links, > > adding > > newer ones and ordering documents in published date. > > OK, I'm still unconvinced about the value of this file, but, if people > want to keep it up to date, I'll play along. I've applied the whole set > (except #1, which was already applied with the other set). Thanks! > > Note that parts 2, 4, 5, 8, 13, and 14 all had the weird "charset=true" > problem, so I had to fix them up manually before I could apply them. I > wouldn't be all that terribly put out if that could be fixed before the > next megaseries shows up...:) :) Fixed. The problem was on this setting: $ git config --get-all sendemail.assume8bitencoding true It should be, instead, "UTF-8". The funny thing is that I was carrying this wrong setting for *several* years... Thanks for noticing! It is fixed now. Thanks, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [iovisor-dev] XDP (eXpress Data Path) documentation
On Tue, 20 Sep 2016 19:47:07 -0700 Alexei Starovoitovwrote: > On Tue, Sep 20, 2016 at 11:08:44AM +0200, Jesper Dangaard Brouer via > iovisor-dev wrote: > > Hi all, > > > > As promised, I've started documenting the XDP eXpress Data Path): > > > > [1] > > https://prototype-kernel.readthedocs.io/en/latest/networking/XDP/index.html > > > > IMHO the documentation have reached a stage where it is useful for the > > XDP project, BUT I request collaboration on improving the documentation > > from all. (Native English speakers are encouraged to send grammar fixes ;-)) > > > > You wouldn't believe it: But this pretty looking documentation actually > > follows the new Kernel documentation format. It is actually just > > ".rst" text files stored in my github repository under kernel/Documentation > > [2] > > > > [2] > > https://github.com/netoptimizer/prototype-kernel/tree/master/kernel/Documentation > > > > Thanks so much for doing it. This is great start! > Some minor editing is needed here and there. > To make it into official doc do you mind preparing a patch for Jon's doc tree > ? > If you think the doc is too volatile and not suitable for kernel.org, > another alternative is to host it on https://github.com/iovisor > since it's LF collaborative project it won't disappear suddenly. > You can be a maintainer of that repo if you like. I do see this as kernel documentation that eventually should end-up in Jon's doc tree. Right now it is too volatile. Once XDP have "stabilized" some more, I plan to push/submit the *relevant* pieces into the kernel. E.g. I plan to have a "proposals" section, which is not meant upstream doc as it is an intermediate specification step before implementing, after which it should move to another doc section. Likewise some of the use-case documents might be "rejected" before reaching upstream doc. The reason I've not created a separate repository for XDP doc only, is because I also plan to document other parts of the kernel in this repo[3], not just XDP. Like my page_pool work. The documentation is not really official documentation before it reach a kernel git tree, together with the code it documents. I hope this approach can help us document while developing, and turn email discussions into specifications. Like I forgot the XDP_ABORTED not warning argument, which you had to re-iterate, but now it is documented[4][5]. -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat Author of http://www.iptv-analyzer.org LinkedIn: http://www.linkedin.com/in/brouer [3] https://github.com/netoptimizer/prototype-kernel/ [4] https://github.com/netoptimizer/prototype-kernel/commit/a4e60e2d7a894 [5] https://prototype-kernel.readthedocs.io/en/latest/networking/XDP/implementation/userspace_api.html#troubleshooting-and-monitoring -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH v2 3/5] futex: Throughput-optimized (TO) futexes
On Tue, 2016-09-20 at 09:42 -0400, Waiman Long wrote: > This patch introduces a new futex implementation called > throughput-optimized (TO) futexes. nit: 'TO' sounds way too much like timeout... TP? You even use 'to' as shorthand for timeout in the next patch. > /* > ->> > * Wake robust non-PI futexes here. The wakeup of > ->> > * PI futexes happens in exit_pi_state(): > +>> > * Wake robust non-PI/TO futexes here. The wakeup of > +>> > * PI/TO futexes happens in exit_pi_state(): > >> > */ nit: comment attracted my eye during high speed scroll-by. -Mike -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html