Re: [RFC v1 3/4] x86, boot: Implement ASLR for kernel memory sections (x86_64)

2016-06-17 Thread Ingo Molnar
* Ingo Molnar <mi...@kernel.org> wrote: > > * Thomas Garnier <thgar...@google.com> wrote: > > > arch/x86/include/asm/kaslr.h| 12 +++ > > Hm, what tree is this patch against? asm/kaslr.h does not exist upstream or > in the > x86 tree.

Re: [RFC v1 3/4] x86, boot: Implement ASLR for kernel memory sections (x86_64)

2016-06-17 Thread Ingo Molnar
* Thomas Garnier wrote: > arch/x86/include/asm/kaslr.h| 12 +++ Hm, what tree is this patch against? asm/kaslr.h does not exist upstream or in the x86 tree. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the

Re: [RFC v1 3/4] x86, boot: Implement ASLR for kernel memory sections (x86_64)

2016-06-17 Thread Ingo Molnar
* Ingo Molnar <mi...@kernel.org> wrote: > > * Thomas Garnier <thgar...@google.com> wrote: > > > arch/x86/include/asm/kaslr.h| 12 +++ > > Hm, what tree is this patch against? asm/kaslr.h does not exist upstream or > in the > x86 tree.

Re: [PATCH Documentation/memory-barriers.txt] Clarify limited control-dependency scope

2016-06-17 Thread Ingo Molnar
* Paul E. McKenney wrote: > Nothing in the control-dependencies section of memory-barriers.txt > says that control dependencies don't extend beyond the end of the > if-statement containing the control dependency. Worse yet, in many > situations, they do extend

Re: [PATCH] Prefer kASLR over Hibernation

2016-04-06 Thread Ingo Molnar
* Kees Cook wrote: > On Wed, Apr 6, 2016 at 1:56 PM, Linus Torvalds > wrote: > > On Wed, Apr 6, 2016 at 1:17 PM, Pavel Machek wrote: > >> > >> Why is kASLR incompatible with hibernation? We can hibernate have > >> 4.3 kernel

Re: [PATCH] Prefer kASLR over Hibernation

2016-04-06 Thread Ingo Molnar
* Ingo Molnar <mi...@kernel.org> wrote: > > * Kees Cook <keesc...@chromium.org> wrote: > > > On Wed, Apr 6, 2016 at 1:56 PM, Linus Torvalds > > <torva...@linux-foundation.org> wrote: > > > On Wed, Apr 6, 2016 at 1:17 PM, Pavel Machek &

Re: [PATCH] Prefer kASLR over Hibernation

2016-04-06 Thread Ingo Molnar
* Rafael J. Wysocki wrote: > On Wed, Apr 6, 2016 at 9:44 PM, Kees Cook wrote: > > When building with both CONFIG_HIBERNATION and CONFIG_RANDOMIZE_BASE, > > one or the other must be chosen at boot-time. Until now, hibernation > > was selected when no

Re: [PATCH] Prefer kASLR over Hibernation

2016-04-06 Thread Ingo Molnar
* Rafael J. Wysocki wrote: > [...] > > One of the weak points is the final jump, because it has to be done to the > physical location of the image kernel's entry point even though the virtual > addresses of it may differ between the boot and the image kernels. The seed >

Re: [PATCH] Prefer kASLR over Hibernation

2016-04-06 Thread Ingo Molnar
* Kees Cook wrote: > >> I don't think this is a good idea, as it turns off emergency hibernation > >> of > >> laptops - many desktop distros support it by default. > > > > Right, I forgot about this one. > > When I last checked Ubuntu doesn't enable hibernation by

Re: [PATCH 0/6] Intel Secure Guard Extensions

2016-04-27 Thread Ingo Molnar
* Andy Lutomirski wrote: > > What new syscalls would be needed for ssh to get all this support? > > This patchset or similar, plus some user code and an enclave to use. > > Sadly, on current CPUs, you also need Intel to bless the enclave. It looks > like > new CPUs

Re: [kernel-hardening] Re: [PATCH 1/2] security, perf: allow further restriction of perf_event_open

2016-08-03 Thread Ingo Molnar
* Kees Cook wrote: > > I see 0 up-sides of this approach and, as per the above, a whole bunch of > > very > > serious downsides. > > > > A global (esp. default inhibited) knob is too coarse and limiting. > > I haven't suggested it be default inhibit in the upstream

Re: [PATCH v5 2/2] Doc/memory-barriers: Add Korean translation

2016-07-21 Thread Ingo Molnar
wells <dhowe...@redhat.com> > > Signed-off-by: Paul E. McKenney <paul...@linux.vnet.ibm.com> > > Acked-by: Minchan Kim <minc...@kernel.org> > > Signed-off-by: SeongJae Park <sj38.p...@gmail.com> > > If Minchan is OK with this version, if Ingo and

Re: [PATCH v4 3/3] Doc/memory-barriers: Add Korean translation

2016-07-08 Thread Ingo Molnar
* Byungchul Park wrote: > On Fri, Jul 08, 2016 at 07:50:39AM +0900, SeongJae Park wrote: > > > I will add my opinion in korean. > > > > Thank you for kind and faithful review. I agree with most of your opinions > > and > > suggestions. Most of your suggestions looks

Re: [PATCH] [linux-next] Doc: x86: Fix typo in x86

2016-07-01 Thread Ingo Molnar
* Masanari Iida wrote: > This patch fix some spelling typo found in > Documentation/x86. > > Signed-off-by: Masanari Iida > --- > Documentation/x86/intel_mpx.txt | 6 +++--- > Documentation/x86/tlb.txt | 4 ++-- >

Re: [PATCHv3 1/2] arch: Move CONFIG_DEBUG_RODATA and CONFIG_SET_MODULE_RONX to be common

2017-02-06 Thread Ingo Molnar
| 11 -- > arch/s390/Kconfig | 5 ++--- > arch/s390/Kconfig.debug| 3 --- > arch/x86/Kconfig | 5 ++--- > arch/x86/Kconfig.debug | 11 -- > 13 files changed, 51

Re: [PATCHv3 2/2] arch: Rename CONFIG_DEBUG_RODATA and CONFIG_DEBUG_MODULE_RONX

2017-02-19 Thread Ingo Molnar
* Kees Cook wrote: > On Thu, Feb 16, 2017 at 2:25 PM, Pavel Machek wrote: > > Hi! > > > >> > >> -config DEBUG_RODATA > >> +config STRICT_KERNEL_RWX > >> bool "Make kernel text and rodata read-only" if > >> ARCH_OPTIONAL_KERNEL_RWX > >> depends

Re: [PATCH v5 4/4] usb: doc: add document for USB3 debug port usage

2017-01-19 Thread Ingo Molnar
* Lu Baolu wrote: > Add Documentation/usb/usb3-debug-port.rst. This document includes > the user guide for USB3 debug port. > > Cc: linux-doc@vger.kernel.org > Signed-off-by: Lu Baolu > --- > Documentation/usb/usb3-debug-port.rst | 95 >

Re: [RFC PATCH tip/master 2/3] kprobes: Allocate kretprobe instance if its free list is empty

2017-03-30 Thread Ingo Molnar
* Masami Hiramatsu wrote: > > So this is something I missed while the original code was merged, but the > > concept > > looks a bit weird: why do we do any "allocation" while a handler is > > executing? > > > > That's fundamentally fragile. What's the maximum number of

Re: [RFC PATCH tip/master 2/3] kprobes: Allocate kretprobe instance if its free list is empty

2017-03-29 Thread Ingo Molnar
* Masami Hiramatsu wrote: > @@ -1824,6 +1823,30 @@ void unregister_jprobes(struct jprobe **jps, int num) > EXPORT_SYMBOL_GPL(unregister_jprobes); > > #ifdef CONFIG_KRETPROBES > + > +/* Try to use free instance first, if failed, try to allocate new instance */ > +struct

Re: [PATCH v7 1/3] x86/mm: Adapt MODULES_END based on Fixmap section size

2017-03-16 Thread Ingo Molnar
* Thomas Garnier wrote: > This patch aligns MODULES_END to the beginning of the Fixmap section. > It optimizes the space available for both sections. The address is > pre-computed based on the number of pages required by the Fixmap > section. > > It will allow GDT

Re: [PATCH v9 00/38] x86: Secure Memory Encryption (AMD)

2017-07-08 Thread Ingo Molnar
* Tom Lendacky wrote: > This patch series provides support for AMD's new Secure Memory Encryption > (SME) > feature. I'm wondering, what's the typical performance hit to DRAM access latency when SME is enabled? On that same note, if the performance hit is

Re: [PATCH v10 37/38] compiler-gcc.h: Introduce __nostackp function attribute

2017-07-18 Thread Ingo Molnar
* Tom Lendacky wrote: > Create a new function attribute, __nostackp, that can used to turn off > stack protection on a per function basis. > > Signed-off-by: Tom Lendacky > --- > include/linux/compiler-gcc.h | 2 ++ > include/linux/compiler.h

Re: [PATCH] kbuild: deprecate cc-option-align

2017-06-22 Thread Ingo Molnar
in principle, although I haven't tested it: Acked-by: Ingo Molnar <mi...@kernel.org> Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 0/2] kbuild: Cache exploratory calls to the compiler

2017-10-05 Thread Ingo Molnar
--null --pre "sync" --repeat 10 make kernel/sched/ >/dev/null Performance counter stats for 'make kernel/sched/' (10 runs): 0.148483807 seconds time elapsed ( +- 0.57% ) A 300% speedup on my system! So I wholeheartedly endorse

Re: [PATCH RFC v3 4/6] Documentation: Add three sysctls for smart idle poll

2017-11-13 Thread Ingo Molnar
* Quan Xu <quan@gmail.com> wrote: > > > On 2017/11/13 23:08, Ingo Molnar wrote: > > * Quan Xu <quan.x...@gmail.com> wrote: > > > > > From: Quan Xu <quan@gmail.com> > > > > > > To reduce the cost of poll, we

Re: [PATCH RFC v3 4/6] Documentation: Add three sysctls for smart idle poll

2017-11-13 Thread Ingo Molnar
* Quan Xu wrote: > From: Quan Xu > > To reduce the cost of poll, we introduce three sysctl to control the > poll time when running as a virtual machine with paravirt. > > Signed-off-by: Yang Zhang > Signed-off-by: Quan Xu

Re: [PATCH v2] sched/deadline: fix runtime accounting in documentation

2017-11-16 Thread Ingo Molnar
Bristot de Oliveira <bris...@redhat.com> > > CC: Jonathan Corbet <cor...@lwn.net> > > CC: "Peter Zijlstra (Intel)" <pet...@infradead.org> > > CC: Ingo Molnar <mi...@redhat.com> > > CC: linux-doc@vger.kernel.org > > Cc: Tommaso Cucinot

Re: [PATCH 0/2] acpi, x86: Add SPCR table support

2017-12-07 Thread Ingo Molnar
* Prarit Bhargava wrote: > The SPCR (Serial Port Console Redirection) Table provides information > about the configuration of serial port. This information can be used > to configure the early console. s/about the configuration of serial port /about the configuration of

Re: [PATCH 0/2] acpi, x86: Add SPCR table support

2017-12-11 Thread Ingo Molnar
* Prarit Bhargava wrote: > If I disable "Serial Port Console Debug" in my BIOS I still see the SPCR > configured: > > [root@prarit-lab ~]# dmesg | grep SPCR > [0.00] ACPI: SPCR 0x69031000 50 (v01 > ) > > AFAICT the SPCR is always

Re: [PATCH v2 2/2] acpi, x86: Use SPCR table for earlycon on x86

2017-12-12 Thread Ingo Molnar
.kernel.org > Cc: linux-ser...@vger.kernel.org > Cc: Bhupesh Sharma <bhsha...@redhat.com> > Cc: Lv Zheng <lv.zh...@intel.com> > Cc: Thomas Gleixner <t...@linutronix.de> > Cc: Ingo Molnar <mi...@redhat.com> > Cc: "H. Peter Anvin" <h...@zytor.com> >

Re: [RFC PATCH v3 0/6] Documentation/features: Provide and apply 'features-refresh.sh'

2018-05-14 Thread Ingo Molnar
it applies this script to refresh the > > status files in place; previous discussions about this series are at [1]. > > Looks good, I've applied the set, thanks. A belated: Reviewed-by: Ingo Molnar <mi...@kernel.org> Thanks guys! Ingo -- To unsubscribe from this list

Re: [PATCH] acpi, spcr: Make SPCR available to x86

2018-01-20 Thread Ingo Molnar
d-off-by: Prarit Bhargava <pra...@redhat.com> > Cc: linux-a...@vger.kernel.org > Cc: linux-doc@vger.kernel.org > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux...@vger.kernel.org > Cc: linux-ser...@vger.kernel.org > Cc: Bhupesh Sharma <bhsha...@redhat.com> > Cc

Re: [PATCH v12 01/22] selftests/x86: Move protecton key selftest to arch neutral directory

2018-02-21 Thread Ingo Molnar
sts/x86/pkey-helpers.h > delete mode 100644 tools/testing/selftests/x86/protection_keys.c Acked-by: Ingo Molnar <mi...@kernel.org> Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] x86: Add topology_hw_smt_threads() and remove smp_num_siblings

2018-02-24 Thread Ingo Molnar
* Prarit Bhargava wrote: > Commit bbb65d2d365e ("x86: use cpuid vector 0xb when available for > detecting cpu topology") changed the value of smp_num_siblings from the > active number of threads in a core to the maximum number threads in a > core. e.g.) On Intel Haswell and

Re: [RFC PATCH 0/3] Documentation/features: Provide and apply "features-refresh.sh"

2018-04-05 Thread Ingo Molnar
* Andrea Parri <andrea.pa...@amarulasolutions.com> wrote: > On Wed, Apr 04, 2018 at 06:56:32AM +0200, Ingo Molnar wrote: > > > > * Andrea Parri <andrea.pa...@amarulasolutions.com> wrote: > > > > > In Ingo's words [1]: > > > > > >

Re: [Question] Documentation/features: More automation/scripting help?

2018-03-30 Thread Ingo Molnar
* Andrea Parri wrote: > Hi all, > > The directory (not yet three years old although, I freely admit, I've > only recently become aware of it) provides arch. support matrices for > more than 40 generic kernel features that need per-arch. support: > > This is

Re: [RFC PATCH 0/3] Documentation/features: Provide and apply "features-refresh.sh"

2018-04-03 Thread Ingo Molnar
* Andrea Parri wrote: > In Ingo's words [1]: > > "[...] what should be done instead is to write a script that refreshes >all the arch-support.txt files in-place. [...] > >It's OK for the script to have various quirks for weirdly implemented >